)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"cf9f159f9f8123e0205d2a8677cffed691eee153","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Venkata Mahesh Jonnalagadda \u003cVenkata.Jonnalagadda@intl.att.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-06 09:13:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"service_name \u0026 auth_name need to be used properly"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In puppet-mistral module, auth_name is used as service title instead of"},{"line_number":10,"context_line":"service name and auth_name overriding code is missing."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"With this fix, service_name \u0026 auth_name used properly"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I94d5429a21acea5d9fe8812f85fb65cfeb3094a3"},{"line_number":15,"context_line":"Closes-Bug: #1588275"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_602b6183","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":53},"updated":"2016-06-06 15:07:27.000000000","message":"That\u0027s not valid commit message and title.\n\n1)\n\n\u003e auth_name is used as service title instead of\nservice name\n\nAnd so what? Why do we need to set as resource title service name?\n\n2)\n\n\u003e auth_name overriding code is missing\n\nBecause we have auth_name as title and auth_name in keystone be default is title name. And for now it works as expected without errors, because we have only one endpoint per-project. Nova was exception, because till Newton we had 3 endpoints and for some situations we need to use one user for all of them. That\u0027s why nova has right now auth_name passed.\n\nWhat\u0027s purpose for this change?\n\nYour current commit message doesn\u0027t explain why you do this, it looks like - oh, we have such approach in other modules, let\u0027s have it here. But why?","commit_id":"dba5763128c8b0618270f35158f992c2d1c92254"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a2d724d2d9f2c31e6ad417fc2a4fec0a85ea66c2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"With this fix, service_name \u0026 auth_name used properly"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I94d5429a21acea5d9fe8812f85fb65cfeb3094a3"},{"line_number":15,"context_line":"Closes-Bug: #1588275"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7aa08908_b839b9d9","line":15,"range":{"start_line":15,"start_character":12,"end_line":15,"end_character":20},"updated":"2016-06-07 16:06:50.000000000","message":"Also the bug for tracking all this work across the various modules is #1590040","commit_id":"dba5763128c8b0618270f35158f992c2d1c92254"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"33cc36d55728e0d8318c394f36a6a3590f175539","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":91,"context_line":"    service_name        \u003d\u003e $real_service_name,"},{"line_number":92,"context_line":"    region              \u003d\u003e $region,"},{"line_number":93,"context_line":"    auth_name           \u003d\u003e $auth_name,"},{"line_number":94,"context_line":"    password            \u003d\u003e $password,"},{"line_number":95,"context_line":"    email               \u003d\u003e $email,"},{"line_number":96,"context_line":"    tenant              \u003d\u003e $tenant,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_0e0bde7e","line":93,"updated":"2016-06-02 10:38:50.000000000","message":"that\u0027s strange, that you have not user, because:\n\nhttps://github.com/openstack/puppet-keystone/blob/master/manifests/resource/service_identity.pp#L112\n\nauth_name will be taken from resource $name, which is $auth_name\n\nIs here any logs or steps to reproduce this problem?","commit_id":"a9ee3686e111fa66adc7c4e8ff53e01cb2ba4ff2"},{"author":{"_account_id":18324,"name":"Venkata Mahesh Jonnalagadda","email":"Venkata.Jonnalagadda@intl.att.com","username":"vj884x"},"change_message_id":"f763380df8dfd19bcaea5f1a7a299642dddc9453","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":91,"context_line":"    service_name        \u003d\u003e $real_service_name,"},{"line_number":92,"context_line":"    region              \u003d\u003e $region,"},{"line_number":93,"context_line":"    auth_name           \u003d\u003e $auth_name,"},{"line_number":94,"context_line":"    password            \u003d\u003e $password,"},{"line_number":95,"context_line":"    email               \u003d\u003e $email,"},{"line_number":96,"context_line":"    tenant              \u003d\u003e $tenant,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9abb7d3a_6c6712eb","line":93,"in_reply_to":"9abb7d3a_0e0bde7e","updated":"2016-06-03 09:45:43.000000000","message":"As you mentioned, in keystone service_identity $auth_name is assigned with $name, which will create service name \u0027mistral\u0027 becoz $auth_name is passed in 85 line no.\n\nLets suppose, if you are developing a fuel plugin and want different service user (eg: m1245) to be created as auth_name in keystone for mistral then if you assign $auth_name with m1245 in plugin code then service user \u0027mistral\u0027 will be created in keystone instead of \u0027m1245\u0027.\n\nHence, we need to add this fix so that if users want to have different service user for mistral in respective deployment environment then it will work.\n\nExample snapshot:\n\nwithout fix -\nroot@node-29:~# keystone user-list\n| ca8696616af6480a9abea7992163249e |      mistral     |   True  | mistral@localhost |\n\nwith fix -\nroot@node-29:~# keystone user-list\n| ca8696616af6480a9abea7992163249e |      m1245     |   True  | mistral@localhost |\n\nYou can also try it out to test this scenario.","commit_id":"a9ee3686e111fa66adc7c4e8ff53e01cb2ba4ff2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d87d996c577f2d85a2ae90171f17399ad13bd089","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    service_description \u003d\u003e $service_description,"},{"line_number":91,"context_line":"    service_name        \u003d\u003e $real_service_name,"},{"line_number":92,"context_line":"    region              \u003d\u003e $region,"},{"line_number":93,"context_line":"    auth_name           \u003d\u003e $auth_name,"},{"line_number":94,"context_line":"    password            \u003d\u003e $password,"},{"line_number":95,"context_line":"    email               \u003d\u003e $email,"},{"line_number":96,"context_line":"    tenant              \u003d\u003e $tenant,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_601ecc64","line":93,"in_reply_to":"9abb7d3a_6c6712eb","updated":"2016-06-06 12:41:19.000000000","message":"so IIUC you want auth_name different from service_name (ex: mistral for service_name and m1245 for auth_name).\n\nWhat you need to do is to give service_name \u003d \u0027mistral\u0027 to this class and auth_name\u003d \u003d \u0027m1245\u0027 to this class too.\n\nCan you let us know if it works for you?","commit_id":"a9ee3686e111fa66adc7c4e8ff53e01cb2ba4ff2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1677febb429315dfb59ec0b74021534485b306c7","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    $real_service_name \u003d $service_name"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  keystone::resource::service_identity { $real_service_name:"},{"line_number":86,"context_line":"    configure_user      \u003d\u003e $configure_user,"},{"line_number":87,"context_line":"    configure_user_role \u003d\u003e $configure_user_role,"},{"line_number":88,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_1b9da759","line":85,"range":{"start_line":85,"start_character":42,"end_line":85,"end_character":59},"updated":"2016-06-06 18:31:00.000000000","message":"It looks like we have some inconsistencies between the various other openstack classes as to how we handle this. Other classes have v2/v3 hard codes, etc. So we probably need a single bug to capture this work so we can get them all aligned correctly. \n\nTechnically I don\u0027t think there\u0027s anything wrong with how it\u0027s currently implemented.  In keystone you have \u0027username\u0027 and \u0027name\u0027 and I think what you\u0027re trying to convey is that the \u0027name\u0027 should be the purpose such as \u0027mistral\u0027 or \u0027nova v2\u0027 and the username can be whatever.","commit_id":"dba5763128c8b0618270f35158f992c2d1c92254"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0db63e40bf6bf28b82fd9292ba655c809c22b877","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    $real_service_name \u003d $service_name"},{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  keystone::resource::service_identity { $real_service_name:"},{"line_number":86,"context_line":"    configure_user      \u003d\u003e $configure_user,"},{"line_number":87,"context_line":"    configure_user_role \u003d\u003e $configure_user_role,"},{"line_number":88,"context_line":"    configure_endpoint  \u003d\u003e $configure_endpoint,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7aa08908_6d15d147","line":85,"range":{"start_line":85,"start_character":42,"end_line":85,"end_character":59},"in_reply_to":"7aa08908_1b9da759","updated":"2016-06-07 16:05:42.000000000","message":"So we talked about this in our meeting today, the title should be set to \u0027mistral\u0027.  If you update this and the tests then we can merge it.","commit_id":"dba5763128c8b0618270f35158f992c2d1c92254"}],"spec/classes/mistral_keystone_auth_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b5bbca87c51207b2d2adccc67a5e596045dda35c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  describe \u0027when overriding auth name\u0027 do"},{"line_number":43,"context_line":"    let :params do"},{"line_number":44,"context_line":"      { :password \u003d\u003e \u0027foo\u0027,"},{"line_number":45,"context_line":"        :auth_name \u003d\u003e \u0027mistral\u0027 }"},{"line_number":46,"context_line":"    end"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    it { is_expected.to contain_keystone_user(\u0027mistral\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7aa08908_55637edd","line":45,"updated":"2016-06-10 10:28:38.000000000","message":"do not change overrided values to defaults","commit_id":"64af0048be3d31ef74fed03f4df824862ba74a8b"}]}