)]}'
{"manifests/checks/libvirt.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0ed1b02c238212bfe6646b277e6e6cde99ed10cb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to 300 seconds."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"class monasca::checks::libvirt("},{"line_number":94,"context_line":"  $admin_password                 \u003d undef,"},{"line_number":95,"context_line":"  $admin_tenant_name              \u003d undef,"},{"line_number":96,"context_line":"  $admin_user                     \u003d undef,"},{"line_number":97,"context_line":"  $alive_only                     \u003d false,"},{"line_number":98,"context_line":"  $cache_dir                      \u003d \u0027/dev/shm\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_2493fd50","line":95,"range":{"start_line":94,"start_character":35,"end_line":95,"end_character":42},"updated":"2016-07-19 22:53:49.000000000","message":"I\u0027m fine with the patch, but i have a question.\n\nWhy required parameters are set to undef and you don\u0027t raise warning or fail when they are undef?","commit_id":"4b36f0a080eaef518b5ca764723368d464a49abf"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"9effb9800c2c388d67f05a2b87f4e8da0178ef2f","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to 300 seconds."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"class monasca::checks::libvirt("},{"line_number":94,"context_line":"  $admin_password                 \u003d undef,"},{"line_number":95,"context_line":"  $admin_tenant_name              \u003d undef,"},{"line_number":96,"context_line":"  $admin_user                     \u003d undef,"},{"line_number":97,"context_line":"  $alive_only                     \u003d false,"},{"line_number":98,"context_line":"  $cache_dir                      \u003d \u0027/dev/shm\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_84362950","line":95,"range":{"start_line":94,"start_character":35,"end_line":95,"end_character":42},"in_reply_to":"dada55a8_2493fd50","updated":"2016-07-19 22:58:35.000000000","message":"good point, we should probably be doing that all over the place in this module.  will start including that in subsequent patches along with doc changes.  thx for the review!!!","commit_id":"4b36f0a080eaef518b5ca764723368d464a49abf"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"040cad083d69d1633ef6743c43d634289b09e2dc","unresolved":false,"context_lines":[{"line_number":91,"context_line":"#   Defaults to 300 seconds."},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"class monasca::checks::libvirt("},{"line_number":94,"context_line":"  $admin_password                 \u003d undef,"},{"line_number":95,"context_line":"  $admin_tenant_name              \u003d undef,"},{"line_number":96,"context_line":"  $admin_user                     \u003d undef,"},{"line_number":97,"context_line":"  $alive_only                     \u003d false,"},{"line_number":98,"context_line":"  $cache_dir                      \u003d \u0027/dev/shm\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_4461d138","line":95,"range":{"start_line":94,"start_character":35,"end_line":95,"end_character":42},"in_reply_to":"dada55a8_84362950","updated":"2016-07-19 23:01:22.000000000","message":"Tks :D","commit_id":"4b36f0a080eaef518b5ca764723368d464a49abf"}]}