)]}'
{"manifests/checks/vertica.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ae4df8eefc2b957b86a7530360949df8dcc4c0d7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class monasca::checks::vertica("},{"line_number":25,"context_line":"  $node_name \u003d undef,"},{"line_number":26,"context_line":"  $password  \u003d undef,"},{"line_number":27,"context_line":"  $service   \u003d \u0027vertica\u0027,"},{"line_number":28,"context_line":"  $timeout   \u003d 3,"},{"line_number":29,"context_line":"  $user      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a89bdaa_56ecb229","line":26,"updated":"2016-09-07 22:22:42.000000000","message":"I\u0027m assuming user/password should probably be required? or is user: undef acceptable?","commit_id":"0109a9e8c8e96d1e51105a07af2cb8b05ccbb087"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"a27fe9bd2585ca6296d43be08ef758016887d016","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class monasca::checks::vertica("},{"line_number":25,"context_line":"  $node_name \u003d undef,"},{"line_number":26,"context_line":"  $password  \u003d undef,"},{"line_number":27,"context_line":"  $service   \u003d \u0027vertica\u0027,"},{"line_number":28,"context_line":"  $timeout   \u003d 3,"},{"line_number":29,"context_line":"  $user      \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a89bdaa_b21793a1","line":26,"in_reply_to":"9a89bdaa_56ecb229","updated":"2016-09-08 18:48:51.000000000","message":"They really are required -- i\u0027ll add an undef check in the next PS.  Thx!","commit_id":"0109a9e8c8e96d1e51105a07af2cb8b05ccbb087"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"781e1f88fb6a3f321e66eea47c9342a34824f244","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (Required) Name of the vertica user."},{"line_number":23,"context_line":"#"},{"line_number":24,"context_line":"class monasca::checks::vertica("},{"line_number":25,"context_line":"  $node_name \u003d undef,"},{"line_number":26,"context_line":"  $password  \u003d undef,"},{"line_number":27,"context_line":"  $service   \u003d \u0027vertica\u0027,"},{"line_number":28,"context_line":"  $timeout   \u003d 3,"},{"line_number":29,"context_line":"  $user      \u003d undef,"},{"line_number":30,"context_line":"){"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  if $node_name \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_0dcd8265","line":29,"range":{"start_line":25,"start_character":0,"end_line":29,"end_character":21},"updated":"2016-09-08 19:08:07.000000000","message":"This would be better:\n\n $node_name,\n $user,\n $password,\n $service \u003d \u0027vertica\u0027,\n $timeout \u003d 3,","commit_id":"f08b4fa3002a42a8615fe6204dd69f28dda61b82"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"781e1f88fb6a3f321e66eea47c9342a34824f244","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  $user      \u003d undef,"},{"line_number":30,"context_line":"){"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  if $node_name \u003d\u003d undef {"},{"line_number":33,"context_line":"    fail(\u0027node_name parameter is required\u0027)"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  if $password \u003d\u003d undef {"},{"line_number":37,"context_line":"    fail(\u0027password parameter is required\u0027)"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $user \u003d\u003d undef {"},{"line_number":41,"context_line":"    fail(\u0027user parameter is required\u0027)"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  $conf_dir \u003d $::monasca::agent::conf_dir"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a89bdaa_ed9a1e61","line":42,"range":{"start_line":32,"start_character":0,"end_line":42,"end_character":3},"updated":"2016-09-08 19:08:07.000000000","message":"You could just not set them to undef, it\u0027ll have the same effect this making them required","commit_id":"f08b4fa3002a42a8615fe6204dd69f28dda61b82"}]}