)]}'
{"manifests/checks/ovs.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"9e200407c1206c2058d587dc26abea40532fc860","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   with service data.  For example, \u0027tenant_name\u0027 in the list will"},{"line_number":33,"context_line":"#   add the tenant name dimension to router metrics posted to the"},{"line_number":34,"context_line":"#   infrastructure project."},{"line_number":35,"context_line":"#   Defaults to not set in the config file."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*neutron_refresh*]"},{"line_number":38,"context_line":"#   (Optional) Interval to force data refresh from neutron."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_69a46307","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":43},"updated":"2016-10-14 20:44:40.000000000","message":"Empty list no?","commit_id":"fdfeab590f4cf6e1871f94f88f1d994aba77200d"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"683dc66c0e00e80eca19f38c28ffac87de07ae20","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#   with service data.  For example, \u0027tenant_name\u0027 in the list will"},{"line_number":33,"context_line":"#   add the tenant name dimension to router metrics posted to the"},{"line_number":34,"context_line":"#   infrastructure project."},{"line_number":35,"context_line":"#   Defaults to not set in the config file."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"# [*neutron_refresh*]"},{"line_number":38,"context_line":"#   (Optional) Interval to force data refresh from neutron."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa6399be_e9579323","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":43},"in_reply_to":"fa6399be_69a46307","updated":"2016-10-14 21:14:57.000000000","message":"aah -- good catch.  correct -- will fix.","commit_id":"fdfeab590f4cf6e1871f94f88f1d994aba77200d"}],"spec/classes/ovs_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"14c9cb6d2796f934d229bbb36551fdc75c8c254c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"require \u0027spec_helper\u0027"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027monasca::checks::ovs\u0027 do"},{"line_number":4,"context_line":"  describe \u0027on debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa6399be_68a2619c","line":1,"updated":"2016-10-17 19:31:31.000000000","message":"By the way this file should be named monasca_checks_ovs_spec.rb","commit_id":"c3a0a116b9df7d66e116a767b07bd9bfc1501416"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9b6e3f6e33923b61bb223b0f4fddf139d62f3b58","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    end"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    let :pre_condition do"},{"line_number":12,"context_line":"      \"service { \u0027monasca-agent\u0027: }\""},{"line_number":13,"context_line":"    end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    let(:params) { {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa6399be_fa4f5331","line":12,"updated":"2016-10-14 22:42:40.000000000","message":"Techincally this works, but it would be better to actually do something like include ::monasca::agent since that would have also setup the path correctly for the ovs.yaml file in the below contain_file(...) checks.  \n\nThis probably should be something like the following to be more representative on how this would be consumed (and tested here):\n\nlet :pre_condition do\n  \u003c\u003c-EOF\nclass { \u0027::monasca::agent\u0027:\n  url          \u003d\u003e \u0027http://127.0.0.1\u0027,\n  username     \u003d\u003e \u0027user\u0027,\n  password     \u003d\u003e \u0027password\u0027,\n  keystone_url \u003d\u003e \u0027http://127.0.0.1:5000\u0027\n}\n  EOF\nend","commit_id":"c3a0a116b9df7d66e116a767b07bd9bfc1501416"},{"author":{"_account_id":8126,"name":"Bradley Klein","email":"bradley.klein@charter.com","username":"bklei"},"change_message_id":"b8d22089a99535a3e466662786148c10bb9cf9c3","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    end"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    let :pre_condition do"},{"line_number":12,"context_line":"      \"service { \u0027monasca-agent\u0027: }\""},{"line_number":13,"context_line":"    end"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    let(:params) { {"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa6399be_40cae26f","line":12,"in_reply_to":"fa6399be_fa4f5331","updated":"2016-10-17 14:41:58.000000000","message":"thanks for the review alex -- i\u0027m a spec testing newbie, will roll a patch with the agent as a pre condition...","commit_id":"c3a0a116b9df7d66e116a767b07bd9bfc1501416"}]}