)]}'
{".fixtures.yml":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":8,"context_line":"    \u0027sysctl\u0027: \u0027git://github.com/duritong/puppet-sysctl.git\u0027"},{"line_number":9,"context_line":"    \u0027keystone\u0027: \u0027git://github.com/openstack/puppet-keystone.git\u0027"},{"line_number":10,"context_line":"    \u0027openstacklib\u0027: \u0027git://github.com/openstack/puppet-openstacklib.git\u0027"},{"line_number":11,"context_line":"  symlinks:"},{"line_number":12,"context_line":"    \u0027murano\u0027: \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a50d1a3_9feddab9","line":10,"updated":"2015-07-30 13:08:09.000000000","message":"You should add rabbitmq here","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":8,"context_line":"    \u0027sysctl\u0027: \u0027git://github.com/duritong/puppet-sysctl.git\u0027"},{"line_number":9,"context_line":"    \u0027keystone\u0027: \u0027git://github.com/openstack/puppet-keystone.git\u0027"},{"line_number":10,"context_line":"    \u0027openstacklib\u0027: \u0027git://github.com/openstack/puppet-openstacklib.git\u0027"},{"line_number":11,"context_line":"  symlinks:"},{"line_number":12,"context_line":"    \u0027murano\u0027: \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1a4dcd0f_1dc69867","line":10,"in_reply_to":"3a50d1a3_9feddab9","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7face027fd6e651ee26477b5a3e1f500b4c929b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":8,"context_line":"    \u0027sysctl\u0027: \u0027git://github.com/duritong/puppet-sysctl.git\u0027"},{"line_number":9,"context_line":"    \u0027keystone\u0027: \u0027git://github.com/openstack/puppet-keystone.git\u0027"},{"line_number":10,"context_line":"    \u0027openstacklib\u0027: \u0027git://github.com/openstack/puppet-openstacklib.git\u0027"},{"line_number":11,"context_line":"  symlinks:"},{"line_number":12,"context_line":"    \u0027murano\u0027: \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a4dcd0f_df06e01f","line":10,"updated":"2015-08-04 13:50:54.000000000","message":"Where is rabbitmq? :) See my comment in 13 patch","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"c99220edd2d692f58eb41e265a654244846d47b9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    \u0027stdlib\u0027: \u0027git://github.com/puppetlabs/puppetlabs-stdlib.git\u0027"},{"line_number":8,"context_line":"    \u0027sysctl\u0027: \u0027git://github.com/duritong/puppet-sysctl.git\u0027"},{"line_number":9,"context_line":"    \u0027keystone\u0027: \u0027git://github.com/openstack/puppet-keystone.git\u0027"},{"line_number":10,"context_line":"    \u0027openstacklib\u0027: \u0027git://github.com/openstack/puppet-openstacklib.git\u0027"},{"line_number":11,"context_line":"  symlinks:"},{"line_number":12,"context_line":"    \u0027murano\u0027: \"#{source_dir}\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1a4dcd0f_b63d3ebd","line":10,"in_reply_to":"1a4dcd0f_df06e01f","updated":"2015-08-04 14:55:56.000000000","message":"Done","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"}],"examples/basic.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class { \u0027::murano::db::mysql\u0027:"},{"line_number":2,"context_line":"  user     \u003d\u003e \u0027murano\u0027,"},{"line_number":3,"context_line":"  password \u003d\u003e \u0027secrete\u0027,"},{"line_number":4,"context_line":"  dbname   \u003d\u003e \u0027murano\u0027,"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"class { \u0027::murano\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_4b247cb1","line":4,"updated":"2015-07-30 13:08:09.000000000","message":"You shouldn\u0027t override default values with default values. Just skip them here.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"class { \u0027::murano::db::mysql\u0027:"},{"line_number":2,"context_line":"  user     \u003d\u003e \u0027murano\u0027,"},{"line_number":3,"context_line":"  password \u003d\u003e \u0027secrete\u0027,"},{"line_number":4,"context_line":"  dbname   \u003d\u003e \u0027murano\u0027,"},{"line_number":5,"context_line":"}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"class { \u0027::murano\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_66e5d207","line":4,"in_reply_to":"3a50d1a3_4b247cb1","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  rabbit_own_password \u003d\u003e \u0027secrete\u0027,"},{"line_number":28,"context_line":"  service_host        \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":29,"context_line":"  service_port        \u003d\u003e 8082,"},{"line_number":30,"context_line":"  external_network    \u003d\u003e \u0027public\u0027,"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class { \u0027::murano::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_0b6c34cf","line":30,"updated":"2015-07-30 13:08:09.000000000","message":"ditto","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  rabbit_own_password \u003d\u003e \u0027secrete\u0027,"},{"line_number":28,"context_line":"  service_host        \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":29,"context_line":"  service_port        \u003d\u003e 8082,"},{"line_number":30,"context_line":"  external_network    \u003d\u003e \u0027public\u0027,"},{"line_number":31,"context_line":"}"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class { \u0027::murano::api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_26efcae9","line":30,"in_reply_to":"3a50d1a3_0b6c34cf","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class { \u0027::murano::api\u0027:"},{"line_number":34,"context_line":"  host \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":35,"context_line":"  port \u003d\u003e 8082,"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class { \u0027::murano::engine\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_2b71f0a8","line":35,"updated":"2015-07-30 13:08:09.000000000","message":"ditto","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class { \u0027::murano::api\u0027:"},{"line_number":34,"context_line":"  host \u003d\u003e \u0027127.0.0.1\u0027,"},{"line_number":35,"context_line":"  port \u003d\u003e 8082,"},{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class { \u0027::murano::engine\u0027: }"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_e6bfa2ce","line":35,"in_reply_to":"3a50d1a3_2b71f0a8","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class { \u0027::murano::client\u0027: }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class { \u0027::murano::dashboard\u0027:"},{"line_number":43,"context_line":"  api_url  \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class { \u0027::murano::rabbitmq\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_cbadeceb","line":43,"updated":"2015-07-30 13:08:09.000000000","message":"ditto","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class { \u0027::murano::client\u0027: }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class { \u0027::murano::dashboard\u0027:"},{"line_number":43,"context_line":"  api_url  \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":44,"context_line":"}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class { \u0027::murano::rabbitmq\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_86b49ef2","line":43,"in_reply_to":"3a50d1a3_cbadeceb","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class { \u0027::murano::rabbitmq\u0027:"},{"line_number":47,"context_line":"  rabbit_user     \u003d\u003e \u0027murano\u0027,"},{"line_number":48,"context_line":"  rabbit_password \u003d\u003e \u0027secrete\u0027,"},{"line_number":49,"context_line":"  rabbit_port     \u003d\u003e \u002755572\u0027,"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class { \u0027::murano::keystone::auth\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_0b5674ce","line":49,"updated":"2015-07-30 13:08:09.000000000","message":"same here","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"class { \u0027::murano::rabbitmq\u0027:"},{"line_number":47,"context_line":"  rabbit_user     \u003d\u003e \u0027murano\u0027,"},{"line_number":48,"context_line":"  rabbit_password \u003d\u003e \u0027secrete\u0027,"},{"line_number":49,"context_line":"  rabbit_port     \u003d\u003e \u002755572\u0027,"},{"line_number":50,"context_line":"}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class { \u0027::murano::keystone::auth\u0027:"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_a6b99aeb","line":49,"in_reply_to":"3a50d1a3_0b5674ce","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  tenant       \u003d\u003e \u0027services\u0027,"},{"line_number":57,"context_line":"  public_url   \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":58,"context_line":"  admin_url    \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":59,"context_line":"  internal_url \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"murano::application { \u0027io.murano\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_6b0858da","line":59,"updated":"2015-07-30 13:08:09.000000000","message":"and here","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  tenant       \u003d\u003e \u0027services\u0027,"},{"line_number":57,"context_line":"  public_url   \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":58,"context_line":"  admin_url    \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":59,"context_line":"  internal_url \u003d\u003e \u0027http://127.0.0.1:8082\u0027,"},{"line_number":60,"context_line":"}"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"murano::application { \u0027io.murano\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_46cf767f","line":59,"in_reply_to":"3a50d1a3_6b0858da","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  os_password    \u003d\u003e \u0027secrete\u0027,"},{"line_number":66,"context_line":"  os_auth_url    \u003d\u003e \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":67,"context_line":"  os_region      \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":68,"context_line":"  mandatory      \u003d\u003e true,"},{"line_number":69,"context_line":"}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Service[\u0027murano-api\u0027] -\u003e Murano::Application\u003c| mandatory \u003d\u003d true |\u003e"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_eb1b081b","line":68,"updated":"2015-07-30 13:08:09.000000000","message":"and here","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  os_password    \u003d\u003e \u0027secrete\u0027,"},{"line_number":66,"context_line":"  os_auth_url    \u003d\u003e \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":67,"context_line":"  os_region      \u003d\u003e \u0027RegionOne\u0027,"},{"line_number":68,"context_line":"  mandatory      \u003d\u003e true,"},{"line_number":69,"context_line":"}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Service[\u0027murano-api\u0027] -\u003e Murano::Application\u003c| mandatory \u003d\u003d true |\u003e"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_06c96e78","line":68,"in_reply_to":"3a50d1a3_eb1b081b","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"}],"manifests/api.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"0a5510f3b513144c93eba89144892c589e5a2d8d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    subscribe  \u003d\u003e Exec[\u0027murano-dbmanage\u0027],"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  exec { \u0027murano-dbmanage\u0027:"},{"line_number":49,"context_line":"    command     \u003d\u003e $::murano::params::dbmanage_command,"},{"line_number":50,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":51,"context_line":"    user        \u003d\u003e \u0027murano\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a50d1a3_09a5e7b3","line":48,"updated":"2015-07-21 07:30:42.000000000","message":"Would it be possible to use the if $sync_db { include ::murano::db::sync } pattern here.\n\nThis pattern is being brought up on every module[1], would be nice it this module could implement it directly\n\n[1] https://review.openstack.org/#/q/status:open+branch:master+topic:db_sync,n,z","commit_id":"682292313c9866a7a8320ed157a400893d3803d2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7face027fd6e651ee26477b5a3e1f500b4c929b8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $sync_db {"},{"line_number":76,"context_line":"    require ::murano::db::sync"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Package[\u0027murano-api\u0027] ~\u003e Service[\u0027murano-api\u0027]"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_5335ecd7","line":76,"updated":"2015-08-04 13:50:54.000000000","message":"No, it should be include","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"c99220edd2d692f58eb41e265a654244846d47b9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $sync_db {"},{"line_number":76,"context_line":"    require ::murano::db::sync"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  Package[\u0027murano-api\u0027] ~\u003e Service[\u0027murano-api\u0027]"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_59bf4bfb","line":76,"in_reply_to":"1a4dcd0f_5335ecd7","updated":"2015-08-04 14:55:56.000000000","message":"Done","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"}],"manifests/application.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $os_password      \u003d \u0027ChangeMe\u0027,"},{"line_number":55,"context_line":"  $os_region        \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":57,"context_line":"  $mandatory        \u003d false,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_49db2422","line":57,"updated":"2015-07-30 13:08:09.000000000","message":"What is goal for this parameter? It doesn\u0027t use anywhere.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $os_password      \u003d \u0027ChangeMe\u0027,"},{"line_number":55,"context_line":"  $os_region        \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":57,"context_line":"  $mandatory        \u003d false,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_a603da72","line":57,"in_reply_to":"3a50d1a3_49db2422","updated":"2015-08-04 13:24:41.000000000","message":"Removed","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"}],"manifests/dashboard.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_694dc098","line":43,"updated":"2015-07-30 13:08:09.000000000","message":"May be will be better use for default \u0027/etc/openstack-dashboard/local_settings.py\u0027 ?","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"66dcc9f348f7180700129f514da959c0b0e8e9d8","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_5aec4029","line":43,"in_reply_to":"3a50d1a3_694dc098","updated":"2015-07-30 13:30:40.000000000","message":"see  exec { \u0027clean_horizon_config, so this path is correct, clean up legacy things","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":47,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_a94988b9","line":44,"updated":"2015-07-30 13:08:09.000000000","message":"Does this script installed by package? And if yes, which one?","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"66dcc9f348f7180700129f514da959c0b0e8e9d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":47,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_7abc9c06","line":44,"in_reply_to":"3a50d1a3_a94988b9","updated":"2015-07-30 13:30:40.000000000","message":"This script comes from package, and very soon will be useless. Legacy","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"}],"manifests/engine.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"0a5510f3b513144c93eba89144892c589e5a2d8d","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    subscribe  \u003d\u003e Exec[\u0027murano-dbmanage\u0027],"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  exec { \u0027murano-dbmanage\u0027:"},{"line_number":49,"context_line":"    command     \u003d\u003e $::murano::params::dbmanage_command,"},{"line_number":50,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":51,"context_line":"    user        \u003d\u003e \u0027murano\u0027,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"3a50d1a3_6996eb4d","line":48,"updated":"2015-07-21 07:30:42.000000000","message":"ditto","commit_id":"682292313c9866a7a8320ed157a400893d3803d2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_4416a959","line":60,"updated":"2015-07-30 13:08:09.000000000","message":"Duplication include from init.pp\n\nYou can use require","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_c67946fe","line":60,"in_reply_to":"3a50d1a3_4416a959","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7face027fd6e651ee26477b5a3e1f500b4c929b8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    require ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_d3f33c09","line":60,"updated":"2015-08-04 13:50:54.000000000","message":"`Duplication include from init.pp\nYou can use require` \u003c- i mean require as parameter in service actually.","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"c99220edd2d692f58eb41e265a654244846d47b9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    require ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_79ba470c","line":60,"in_reply_to":"1a4dcd0f_d3f33c09","updated":"2015-08-04 14:55:56.000000000","message":"Done","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*murano_package_name*]"},{"line_number":8,"context_line":"#   List of packages which should be instolled."},{"line_number":9,"context_line":"#   Defaults: \u0027murano\u0027"},{"line_number":10,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_1e83e557","line":7,"updated":"2015-06-30 09:47:23.000000000","message":"this parameter should be moved to params.pp file.\n\nAlso i should not name paratemeter like \u0027murano_someparameter\u0027,\nyou should name it just \u0027someparameter\u0027, i guess","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":297,"context_line":"  class { \u0027::murano::python_muranoclient\u0027:"},{"line_number":298,"context_line":"  }"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"  class { \u0027::murano::api\u0027 :"},{"line_number":301,"context_line":"    use_syslog             \u003d\u003e $use_syslog,"},{"line_number":302,"context_line":"    debug                  \u003d\u003e $debug,"},{"line_number":303,"context_line":"    verbose                \u003d\u003e $verbose,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_1e38c59f","line":300,"updated":"2015-06-30 09:47:23.000000000","message":"this class shouldn\u0027t be called here, i think. It should be run from one big manifest like site.pp. Please, see another projects like nova, heat and etc. In this case, it can be placed into examples/bacis.pp file.","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    external_network       \u003d\u003e $external_network,"},{"line_number":342,"context_line":"  }"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"  class { \u0027::murano::dashboard\u0027 :"},{"line_number":345,"context_line":"    settings_py     \u003d\u003e \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":346,"context_line":"    repo_url_string \u003d\u003e $murano_repo_url_string,"},{"line_number":347,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_3e3b499e","line":344,"updated":"2015-06-30 09:47:23.000000000","message":"ditto","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    repo_url_string \u003d\u003e $murano_repo_url_string,"},{"line_number":347,"context_line":"  }"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"  class { \u0027::murano::murano_rabbitmq\u0027 :"},{"line_number":350,"context_line":"    rabbit_user        \u003d\u003e $murano_own_rabbit_userid,"},{"line_number":351,"context_line":"    rabbit_password    \u003d\u003e $murano_own_rabbit_passwd,"},{"line_number":352,"context_line":"    rabbit_vhost       \u003d\u003e $murano_rabbit_virtual_host,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_de41fd0c","line":349,"updated":"2015-06-30 09:47:23.000000000","message":"ditto","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":354,"context_line":"  }"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"  class { \u0027::murano::keystone\u0027:"},{"line_number":358,"context_line":"    tenant           \u003d\u003e $murano_keystone_tenant,"},{"line_number":359,"context_line":"    user             \u003d\u003e $murano_keystone_user,"},{"line_number":360,"context_line":"    password         \u003d\u003e $murano_keystone_password,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_fe44011c","line":357,"updated":"2015-06-30 09:47:23.000000000","message":"ditto","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"# \u003d\u003d keystone authentication options"},{"line_number":88,"context_line":"#"},{"line_number":89,"context_line":"# [*keystone_username*]"},{"line_number":90,"context_line":"#  (Optional) Username for murano credentials"},{"line_number":91,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":92,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_e4901551","line":89,"updated":"2015-07-30 13:08:09.000000000","message":"Use correct name: admin_user","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"#"},{"line_number":87,"context_line":"# \u003d\u003d keystone authentication options"},{"line_number":88,"context_line":"#"},{"line_number":89,"context_line":"# [*keystone_username*]"},{"line_number":90,"context_line":"#  (Optional) Username for murano credentials"},{"line_number":91,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":92,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_da87d65f","line":89,"in_reply_to":"3a50d1a3_e4901551","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#  (Optional) Username for murano credentials"},{"line_number":91,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# [*keystone_password*]"},{"line_number":94,"context_line":"#  (Required) Password for murano credentials"},{"line_number":95,"context_line":"#  Defaults to false"},{"line_number":96,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_e477b539","line":93,"updated":"2015-07-30 13:08:09.000000000","message":"admin_password","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"#  (Optional) Username for murano credentials"},{"line_number":91,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":92,"context_line":"#"},{"line_number":93,"context_line":"# [*keystone_password*]"},{"line_number":94,"context_line":"#  (Required) Password for murano credentials"},{"line_number":95,"context_line":"#  Defaults to false"},{"line_number":96,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_fab9722f","line":93,"in_reply_to":"3a50d1a3_e477b539","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#  (Required) Password for murano credentials"},{"line_number":95,"context_line":"#  Defaults to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*keystone_tenant*]"},{"line_number":98,"context_line":"#  (Optional) Tenant for keystone_username"},{"line_number":99,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":100,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_448d4929","line":97,"updated":"2015-07-30 13:08:09.000000000","message":"admin_tenant_name","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"#  (Required) Password for murano credentials"},{"line_number":95,"context_line":"#  Defaults to false"},{"line_number":96,"context_line":"#"},{"line_number":97,"context_line":"# [*keystone_tenant*]"},{"line_number":98,"context_line":"#  (Optional) Tenant for keystone_username"},{"line_number":99,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":100,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_3ab03a43","line":97,"in_reply_to":"3a50d1a3_448d4929","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#  (Optional) Tenant for keystone_username"},{"line_number":99,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*keystone_region*]"},{"line_number":102,"context_line":"#  (Optional) Region for keystone"},{"line_number":103,"context_line":"#  Defaults to \u0027RegionOne\u0027"},{"line_number":104,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_24b35deb","line":101,"updated":"2015-07-30 13:08:09.000000000","message":"Just \u0027region\u0027\n\nAnd this parameter is not set anywhere.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"#  (Optional) Tenant for keystone_username"},{"line_number":99,"context_line":"#  Defaults to \u0027admin\u0027"},{"line_number":100,"context_line":"#"},{"line_number":101,"context_line":"# [*keystone_region*]"},{"line_number":102,"context_line":"#  (Optional) Region for keystone"},{"line_number":103,"context_line":"#  Defaults to \u0027RegionOne\u0027"},{"line_number":104,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_7aa56202","line":101,"in_reply_to":"3a50d1a3_24b35deb","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#  (Optional) Region for keystone"},{"line_number":103,"context_line":"#  Defaults to \u0027RegionOne\u0027"},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*keystone_uri*]"},{"line_number":106,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":107,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027"},{"line_number":108,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_e4e25501","line":105,"updated":"2015-07-30 13:08:09.000000000","message":"I think, we should name this parameter as auth_uri","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#  (Optional) Region for keystone"},{"line_number":103,"context_line":"#  Defaults to \u0027RegionOne\u0027"},{"line_number":104,"context_line":"#"},{"line_number":105,"context_line":"# [*keystone_uri*]"},{"line_number":106,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":107,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027"},{"line_number":108,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_ba9beac8","line":105,"in_reply_to":"3a50d1a3_e4e25501","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":107,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027"},{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"# [*keystone_signing_dir*]"},{"line_number":110,"context_line":"#  (Optional) Directory used to cache files related to PKI tokens"},{"line_number":111,"context_line":"#  Defaults to \u0027/tmp/keystone-signing-muranoapi\u0027"},{"line_number":112,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_a4ec4df4","line":109,"updated":"2015-07-30 13:08:09.000000000","message":"Ditto: signing_dir","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":107,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027"},{"line_number":108,"context_line":"#"},{"line_number":109,"context_line":"# [*keystone_signing_dir*]"},{"line_number":110,"context_line":"#  (Optional) Directory used to cache files related to PKI tokens"},{"line_number":111,"context_line":"#  Defaults to \u0027/tmp/keystone-signing-muranoapi\u0027"},{"line_number":112,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_1a60decd","line":109,"in_reply_to":"3a50d1a3_a4ec4df4","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"#  (Optional) Admin identity endpoint"},{"line_number":115,"context_line":"#  Defaults to \u0027http://127.0.0.1:35357/\u0027#"},{"line_number":116,"context_line":"#"},{"line_number":117,"context_line":"# [*use_neutron*]"},{"line_number":118,"context_line":"#  (Optional) Whether to use neutron"},{"line_number":119,"context_line":"#  Defaults to false"},{"line_number":120,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_845351e2","line":117,"updated":"2015-07-30 13:08:09.000000000","message":"I believe, that those parameters should be moved under main parameters section.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"#  (Optional) Admin identity endpoint"},{"line_number":115,"context_line":"#  Defaults to \u0027http://127.0.0.1:35357/\u0027#"},{"line_number":116,"context_line":"#"},{"line_number":117,"context_line":"# [*use_neutron*]"},{"line_number":118,"context_line":"#  (Optional) Whether to use neutron"},{"line_number":119,"context_line":"#  Defaults to false"},{"line_number":120,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_3a691abf","line":117,"in_reply_to":"3a50d1a3_845351e2","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    /^postgresql:\\/\\//: {"},{"line_number":187,"context_line":"      require postgresql::lib::python"},{"line_number":188,"context_line":"    }"},{"line_number":189,"context_line":"    /^sqlite:\\/\\//: {"},{"line_number":190,"context_line":"      fail(\u0027murano does not support sqlite!\u0027)"},{"line_number":191,"context_line":"    }"},{"line_number":192,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_045661ce","line":189,"updated":"2015-07-30 13:08:09.000000000","message":"If Murano doesn\u0027t support Sqlite, you can remove this case.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":186,"context_line":"    /^postgresql:\\/\\//: {"},{"line_number":187,"context_line":"      require postgresql::lib::python"},{"line_number":188,"context_line":"    }"},{"line_number":189,"context_line":"    /^sqlite:\\/\\//: {"},{"line_number":190,"context_line":"      fail(\u0027murano does not support sqlite!\u0027)"},{"line_number":191,"context_line":"    }"},{"line_number":192,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_7a6ec2ca","line":189,"in_reply_to":"3a50d1a3_045661ce","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    if $external_network {"},{"line_number":207,"context_line":"      $neutron_external_network \u003d $external_network"},{"line_number":208,"context_line":"    } else {"},{"line_number":209,"context_line":"      $neutron_external_network \u003d $::murano::params::default_external_network"},{"line_number":210,"context_line":"    }"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    murano_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_a4fe8dac","line":209,"updated":"2015-07-30 13:08:09.000000000","message":"You can set this value as default","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d12cd943ae7225c4cae26fb2f90b445a93a257e8","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    if $external_network {"},{"line_number":207,"context_line":"      $neutron_external_network \u003d $external_network"},{"line_number":208,"context_line":"    } else {"},{"line_number":209,"context_line":"      $neutron_external_network \u003d $::murano::params::default_external_network"},{"line_number":210,"context_line":"    }"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    murano_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_c0c62268","line":209,"in_reply_to":"3a50d1a3_7ac6dc69","updated":"2015-07-30 14:01:22.000000000","message":"I don\u0027t see here any calling function, which will extracted ext net name. Is it missed?","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"66dcc9f348f7180700129f514da959c0b0e8e9d8","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    if $external_network {"},{"line_number":207,"context_line":"      $neutron_external_network \u003d $external_network"},{"line_number":208,"context_line":"    } else {"},{"line_number":209,"context_line":"      $neutron_external_network \u003d $::murano::params::default_external_network"},{"line_number":210,"context_line":"    }"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    murano_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_7ac6dc69","line":209,"in_reply_to":"3a50d1a3_a4fe8dac","updated":"2015-07-30 13:30:40.000000000","message":"not sure because ext net name extracted from env settings and may not equals default name","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    if $external_network {"},{"line_number":207,"context_line":"      $neutron_external_network \u003d $external_network"},{"line_number":208,"context_line":"    } else {"},{"line_number":209,"context_line":"      $neutron_external_network \u003d $::murano::params::default_external_network"},{"line_number":210,"context_line":"    }"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"    murano_config {"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_1a49be5f","line":209,"in_reply_to":"3a50d1a3_c0c62268","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7face027fd6e651ee26477b5a3e1f500b4c929b8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":"    } else {"},{"line_number":203,"context_line":"      murano_config {"},{"line_number":204,"context_line":"        \u0027networking/external_network\u0027 : ensure \u003d\u003e absent;"},{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_53a08c9f","line":204,"updated":"2015-08-04 13:50:54.000000000","message":"Is situation, when neutron is used and external_network is not defined, correct?","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"c99220edd2d692f58eb41e265a654244846d47b9","unresolved":false,"context_lines":[{"line_number":201,"context_line":"      }"},{"line_number":202,"context_line":"    } else {"},{"line_number":203,"context_line":"      murano_config {"},{"line_number":204,"context_line":"        \u0027networking/external_network\u0027 : ensure \u003d\u003e absent;"},{"line_number":205,"context_line":"      }"},{"line_number":206,"context_line":"    }"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"1a4dcd0f_596d0b97","line":204,"in_reply_to":"1a4dcd0f_53a08c9f","updated":"2015-08-04 14:55:56.000000000","message":"Done","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"}],"manifests/keystone/auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":124,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":125,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":126,"context_line":"  $version             \u003d undef,"},{"line_number":127,"context_line":"  $port                \u003d undef,"},{"line_number":128,"context_line":"  $public_port         \u003d undef,"},{"line_number":129,"context_line":"  $public_protocol     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_bfad36ec","line":126,"updated":"2015-07-30 13:08:09.000000000","message":"I think, you can remove deprecated parameters, because we don\u0027t have puppet-murano now actually :-) Other reviewers, what do you think? Do we need keep deprecated parameters in this case?","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":124,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":125,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":126,"context_line":"  $version             \u003d undef,"},{"line_number":127,"context_line":"  $port                \u003d undef,"},{"line_number":128,"context_line":"  $public_port         \u003d undef,"},{"line_number":129,"context_line":"  $public_protocol     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_dd2b5081","line":126,"in_reply_to":"3a50d1a3_9aa88879","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"66dcc9f348f7180700129f514da959c0b0e8e9d8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"  $admin_url           \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":124,"context_line":"  $internal_url        \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":125,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":126,"context_line":"  $version             \u003d undef,"},{"line_number":127,"context_line":"  $port                \u003d undef,"},{"line_number":128,"context_line":"  $public_port         \u003d undef,"},{"line_number":129,"context_line":"  $public_protocol     \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_9aa88879","line":126,"in_reply_to":"3a50d1a3_bfad36ec","updated":"2015-07-30 13:30:40.000000000","message":"If it wouldn\u0027t provide any negative impact - agree","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"}],"manifests/params.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  $murano_api_service_name          \u003d \u0027openstack-murano-api\u0027"},{"line_number":12,"context_line":"  $murano_engine_service_name       \u003d \u0027openstack-murano-engine\u0027"},{"line_number":13,"context_line":"  $default_repo_url_string          \u003d \u0027MURANO_REPO_URL \u003d http://catalog.openstack.org\u0027"},{"line_number":14,"context_line":"  $default_url_string               \u003d \u0027MURANO_API_URL \u003d http://127.0.0.1:8082\u0027"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  case $::osfamily {"},{"line_number":17,"context_line":"    \u0027RedHat\u0027: {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_5e040dbf","line":14,"updated":"2015-06-30 09:47:23.000000000","message":"may this parameter should be formed from murano host and port?","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"}],"manifests/rabbitmq.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*rabbit_user*]"},{"line_number":8,"context_line":"#  (Optional)"},{"line_number":9,"context_line":"#  Defaults to \u0027murano\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*rabbit_password*]"},{"line_number":12,"context_line":"#  (Optional)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_dfc9227b","line":9,"updated":"2015-07-30 13:08:09.000000000","message":"Description is missed for all parameters","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    enable \u003d\u003e true,"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  firewall { $firewall_rule_name :"},{"line_number":79,"context_line":"    dport  \u003d\u003e [ $rabbit_port ],"},{"line_number":80,"context_line":"    proto  \u003d\u003e \u0027tcp\u0027,"},{"line_number":81,"context_line":"    action \u003d\u003e \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_9f9aba6d","line":78,"updated":"2015-07-30 13:08:09.000000000","message":"We shouldn\u0027t use such rules here. It should be moved out of this class i think.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    enable \u003d\u003e true,"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  firewall { $firewall_rule_name :"},{"line_number":79,"context_line":"    dport  \u003d\u003e [ $rabbit_port ],"},{"line_number":80,"context_line":"    proto  \u003d\u003e \u0027tcp\u0027,"},{"line_number":81,"context_line":"    action \u003d\u003e \u0027accept\u0027,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_ddeef021","line":78,"in_reply_to":"3a50d1a3_9f9aba6d","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  exec { \u0027create_murano_user\u0027 :"},{"line_number":100,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 add_user \u0027${rabbit_user}\u0027 \u0027${rabbit_password}\u0027\","},{"line_number":101,"context_line":"    unless  \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 list_users | grep -qE \u0027^${rabbit_user}\\\\s*\\\\[\u0027\","},{"line_number":102,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_3f1046ab","line":99,"updated":"2015-07-30 13:08:09.000000000","message":"Actually you can use rabbitmq resources","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7613,"name":"Igor Yozhikov","email":"medput@gmail.com","username":"iyozhikov"},"change_message_id":"66dcc9f348f7180700129f514da959c0b0e8e9d8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  exec { \u0027create_murano_user\u0027 :"},{"line_number":100,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 add_user \u0027${rabbit_user}\u0027 \u0027${rabbit_password}\u0027\","},{"line_number":101,"context_line":"    unless  \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 list_users | grep -qE \u0027^${rabbit_user}\\\\s*\\\\[\u0027\","},{"line_number":102,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_ba24640e","line":99,"in_reply_to":"3a50d1a3_3f1046ab","updated":"2015-07-30 13:30:40.000000000","message":"Not pretty sure here, murano use additional instance of rMQ service with different parameters as for user access as for networking","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  exec { \u0027create_murano_user\u0027 :"},{"line_number":100,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 add_user \u0027${rabbit_user}\u0027 \u0027${rabbit_password}\u0027\","},{"line_number":101,"context_line":"    unless  \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 list_users | grep -qE \u0027^${rabbit_user}\\\\s*\\\\[\u0027\","},{"line_number":102,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a4dcd0f_f090b397","line":99,"in_reply_to":"3a50d1a3_6344f81a","updated":"2015-08-04 13:24:41.000000000","message":"There is no possibility to use rabbitmq resources in case of inability to choose non-default node during resource usage","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d12cd943ae7225c4cae26fb2f90b445a93a257e8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":97,"context_line":"  }"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  exec { \u0027create_murano_user\u0027 :"},{"line_number":100,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 add_user \u0027${rabbit_user}\u0027 \u0027${rabbit_password}\u0027\","},{"line_number":101,"context_line":"    unless  \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 list_users | grep -qE \u0027^${rabbit_user}\\\\s*\\\\[\u0027\","},{"line_number":102,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_6344f81a","line":99,"in_reply_to":"3a50d1a3_ba24640e","updated":"2015-07-30 14:01:22.000000000","message":"We can use provider rabbit_vhost to create new node: https://github.com/puppetlabs/puppetlabs-rabbitmq/blob/master/lib/puppet/provider/rabbitmq_vhost/rabbitmqctl.rb\n\nBut we really should test it, that upstream rabbitmq resources are support specifying some node.","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":103,"context_line":"  }"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"  exec { \u0027create_murano_vhost\u0027 :"},{"line_number":106,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 add_vhost \u0027${rabbit_vhost}\u0027\","},{"line_number":107,"context_line":"    unless  \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 list_vhosts | grep -qE \u0027^${rabbit_vhost}$\u0027\","},{"line_number":108,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_1f0f8a89","line":105,"updated":"2015-07-30 13:08:09.000000000","message":"ditto","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  exec { \u0027set_murano_user_permissions\u0027 :"},{"line_number":112,"context_line":"    command \u003d\u003e \"rabbitmqctl -n \u0027${rabbit_node_name}\u0027 set_permissions -p \u0027${rabbit_vhost}\u0027 \u0027${rabbit_user}\u0027 \u0027.*\u0027 \u0027.*\u0027 \u0027.*\u0027\","},{"line_number":113,"context_line":"    path    \u003d\u003e [ \u0027/bin\u0027, \u0027/sbin\u0027, \u0027/usr/bin\u0027, \u0027/usr/sbin\u0027 ],"},{"line_number":114,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"3a50d1a3_7f1ecebc","line":111,"updated":"2015-07-30 13:08:09.000000000","message":"ditto","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"}],"metadata.json":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e12c6894862dbb1729865319395761bd1778834b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" }"},{"line_number":34,"context_line":"  ]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"3a50d1a3_ff573e58","line":33,"updated":"2015-07-30 13:08:09.000000000","message":"Rabbitmq please","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"afcf9a4638bba06d55e79a7c826a31e23f1b623d","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" }"},{"line_number":34,"context_line":"  ]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"1a4dcd0f_9db068f6","line":33,"in_reply_to":"3a50d1a3_ff573e58","updated":"2015-08-04 13:24:41.000000000","message":"Done","commit_id":"2e439afaa9f4f2fe46de707791effdda12fa6ce4"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7face027fd6e651ee26477b5a3e1f500b4c929b8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" }"},{"line_number":34,"context_line":"  ]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a4dcd0f_53c5ec39","line":33,"updated":"2015-08-04 13:50:54.000000000","message":"Again, where is rabbitmq? :)","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"c99220edd2d692f58eb41e265a654244846d47b9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    { \"name\": \"puppetlabs/inifile\", \"version_requirement\": \"\u003e\u003d1.0.0 \u003c2.0.0\" },"},{"line_number":31,"context_line":"    { \"name\": \"openstack/keystone\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" },"},{"line_number":32,"context_line":"    { \"name\": \"puppetlabs/stdlib\", \"version_requirement\": \"\u003e\u003d4.0.0 \u003c5.0.0\" },"},{"line_number":33,"context_line":"    { \"name\": \"openstack/openstacklib\", \"version_requirement\": \"\u003e\u003d6.0.0 \u003c7.0.0\" }"},{"line_number":34,"context_line":"  ]"},{"line_number":35,"context_line":"}"}],"source_content_type":"application/json","patch_set":14,"id":"1a4dcd0f_192d4346","line":33,"in_reply_to":"1a4dcd0f_53c5ec39","updated":"2015-08-04 14:55:56.000000000","message":"Not required in this file","commit_id":"bdd087a482f381f5f4b669423f9bea3c71f783c7"}],"templates/rabbitmq-init-centos.erb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# rabbitmq-server Murano RabbitMQ broker"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# chkconfig: - 80 05"},{"line_number":6,"context_line":"# description: Enable AMQP service provided by RabbitMQ"}],"source_content_type":"application/x-erb","patch_set":6,"id":"ba3cc151_5e1bad1b","line":3,"updated":"2015-06-30 09:47:23.000000000","message":"i think it\u0027s not ok to place init file here, it should be placed in package","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"}],"templates/rabbitmq-init-ubuntu.erb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e03a057c5ee77e6b26ef817e9e43c16be6f1a527","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# rabbitmq-server Murano RabbitMQ broker"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# chkconfig: - 80 05"},{"line_number":6,"context_line":"# description: Enable AMQP service provided by RabbitMQ"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":""}],"source_content_type":"application/x-erb","patch_set":6,"id":"ba3cc151_3ed7c924","line":5,"updated":"2015-06-30 09:47:23.000000000","message":"the same here","commit_id":"04b12931648603f8e20f642aae478a2f0bbd4933"}]}
