)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8640fc93fcf4dde1925d91eeee7a4687f9bb6512","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  Package \u003c| title \u003d\u003d \u0027murano-common\u0027 |\u003e ~\u003e Exec[\u0027murano-dbmanage\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027murano-dbmanage\u0027] ~\u003e Service \u003c| tag \u003d\u003d \u0027murano-service\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Murano_config \u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027murano-dbmanage\u0027]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  exec { \u0027murano-dbmanage\u0027:"},{"line_number":14,"context_line":"    command     \u003d\u003e $::murano::params::dbmanage_command,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"da20952f_71c2f786","line":11,"updated":"2015-09-04 16:08:10.000000000","message":"Is only the \u0027database/connection\u0027 option affects db-manage?","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"79a58a142ebc8ba935f946ba4762327d4f41f46c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  Package \u003c| title \u003d\u003d \u0027murano-common\u0027 |\u003e ~\u003e Exec[\u0027murano-dbmanage\u0027]"},{"line_number":9,"context_line":"  Exec[\u0027murano-dbmanage\u0027] ~\u003e Service \u003c| tag \u003d\u003d \u0027murano-service\u0027 |\u003e"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  Murano_config \u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027murano-dbmanage\u0027]"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  exec { \u0027murano-dbmanage\u0027:"},{"line_number":14,"context_line":"    command     \u003d\u003e $::murano::params::dbmanage_command,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"ba15a1d1_3b737cb3","line":11,"in_reply_to":"da20952f_71c2f786","updated":"2015-09-14 16:50:51.000000000","message":"Yes, there is no another option affecting DB","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e29d31a36ab4ede14982475402172e06afd8f394","unresolved":false,"context_lines":[{"line_number":180,"context_line":"    }"},{"line_number":181,"context_line":"    /^postgresql:\\/\\//: {"},{"line_number":182,"context_line":"      require postgresql::lib::python"},{"line_number":183,"context_line":"    }"},{"line_number":184,"context_line":"    default: {"},{"line_number":185,"context_line":"      fail(\u0027Unsupported db backend configured\u0027)"},{"line_number":186,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a4dcd0f_3d93c75c","line":183,"updated":"2015-08-12 16:22:26.000000000","message":"What about sqlite? You\u0027re verifying it in the connection string but it\u0027s not supported?","commit_id":"692a93efef7d49e6c95befe1830b76c1c6e7819e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e29d31a36ab4ede14982475402172e06afd8f394","unresolved":false,"context_lines":[{"line_number":212,"context_line":"    \u0027DEFAULT/log_dir\u0027                       : value \u003d\u003e $log_dir;"},{"line_number":213,"context_line":"    \u0027DEFAULT/notification_driver\u0027           : value \u003d\u003e $notification_driver;"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    \u0027murano/url\u0027                            : value \u003d\u003e \"http://${service_host}:${service_port}\";"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    \u0027database/connection\u0027                   : value \u003d\u003e $database_connection;"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a4dcd0f_3d7ae724","line":215,"updated":"2015-08-12 16:22:26.000000000","message":"Could this ever be https?  Would it be better to have these parameters just be a full url rather than host/port?","commit_id":"692a93efef7d49e6c95befe1830b76c1c6e7819e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8640fc93fcf4dde1925d91eeee7a4687f9bb6512","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  $sync_db              \u003d true,"},{"line_number":175,"context_line":"  $admin_user           \u003d \u0027admin\u0027,"},{"line_number":176,"context_line":"  $admin_tenant_name    \u003d \u0027admin\u0027,"},{"line_number":177,"context_line":"  $admin_password       \u003d false,"},{"line_number":178,"context_line":"  $auth_uri             \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":179,"context_line":"  $identity_uri         \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":180,"context_line":"  $signing_dir          \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"da20952f_3199df79","line":177,"updated":"2015-09-04 16:08:10.000000000","message":"is situation, when \u0027admin_password\u0027 is not set, acceptably? Or without this parameter it will not work?","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"79a58a142ebc8ba935f946ba4762327d4f41f46c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"  $sync_db              \u003d true,"},{"line_number":175,"context_line":"  $admin_user           \u003d \u0027admin\u0027,"},{"line_number":176,"context_line":"  $admin_tenant_name    \u003d \u0027admin\u0027,"},{"line_number":177,"context_line":"  $admin_password       \u003d false,"},{"line_number":178,"context_line":"  $auth_uri             \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":179,"context_line":"  $identity_uri         \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":180,"context_line":"  $signing_dir          \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"ba15a1d1_ef41be3a","line":177,"in_reply_to":"da20952f_3199df79","updated":"2015-09-14 16:50:51.000000000","message":"I\u0027ve added a workaround to avoid situation","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8640fc93fcf4dde1925d91eeee7a4687f9bb6512","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    \u0027keystone_authtoken/admin_user\u0027         : value \u003d\u003e $admin_user;"},{"line_number":287,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027  : value \u003d\u003e $admin_tenant_name;"},{"line_number":288,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027        : value \u003d\u003e $signing_dir;"},{"line_number":289,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027       : value \u003d\u003e $identity_uri;"},{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  if $admin_password {"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"da20952f_b1272f62","line":289,"updated":"2015-09-04 16:08:10.000000000","message":"nit: align should be by \u0027value\u0027 instead of \u0027:\u0027, i think","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"79a58a142ebc8ba935f946ba4762327d4f41f46c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"    \u0027keystone_authtoken/admin_user\u0027         : value \u003d\u003e $admin_user;"},{"line_number":287,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027  : value \u003d\u003e $admin_tenant_name;"},{"line_number":288,"context_line":"    \u0027keystone_authtoken/signing_dir\u0027        : value \u003d\u003e $signing_dir;"},{"line_number":289,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027       : value \u003d\u003e $identity_uri;"},{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"  if $admin_password {"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"ba15a1d1_4f81ca49","line":289,"in_reply_to":"da20952f_b1272f62","updated":"2015-09-14 16:50:51.000000000","message":"Done","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"}],"manifests/params.pp":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"cf92aa99f1238ade93341172b077b74ce5ebcf5a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      $local_settings_path       \u003d \u0027/etc/openstack-dashboard/local_settings\u0027"},{"line_number":23,"context_line":"      # rabbitmq init params"},{"line_number":24,"context_line":"      $init_script_file          \u003d \u0027rabbitmq-init-centos.erb\u0027"},{"line_number":25,"context_line":"      $init_install_cmd          \u003d \"chkconfig --add \u0027/etc/init.d/${rabbit_service_name}\u0027\""},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"    \u0027Debian\u0027: {"},{"line_number":28,"context_line":"      # package names"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"da20952f_d51bcfc8","line":25,"updated":"2015-08-28 20:31:43.000000000","message":"init_{script_file,install_cmd} are not used anywhere, why you add this here (non atomic patch)","commit_id":"88b0a3cf3df0de60ce9044954e07a2b9ab3a13e2"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"18b53da64f0787fcfc8afd9ab21631384dd458e3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      $local_settings_path       \u003d \u0027/etc/openstack-dashboard/local_settings\u0027"},{"line_number":23,"context_line":"      # rabbitmq init params"},{"line_number":24,"context_line":"      $init_script_file          \u003d \u0027rabbitmq-init-centos.erb\u0027"},{"line_number":25,"context_line":"      $init_install_cmd          \u003d \"chkconfig --add \u0027/etc/init.d/${rabbit_service_name}\u0027\""},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"    \u0027Debian\u0027: {"},{"line_number":28,"context_line":"      # package names"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"da20952f_f1b83013","line":25,"in_reply_to":"da20952f_d51bcfc8","updated":"2015-08-31 12:12:55.000000000","message":"All patches in this chain are parts of one big patch, and those parameters are used by murano::rabbitmq class","commit_id":"88b0a3cf3df0de60ce9044954e07a2b9ab3a13e2"},{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"cf92aa99f1238ade93341172b077b74ce5ebcf5a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      $local_settings_path       \u003d \u0027/etc/openstack-dashboard/local_settings.py\u0027"},{"line_number":39,"context_line":"      # rabbitmq init params"},{"line_number":40,"context_line":"      $init_script_file          \u003d \u0027rabbitmq-init-ubuntu.erb\u0027"},{"line_number":41,"context_line":"      $init_install_cmd          \u003d \"update-rc.d \u0027${rabbit_service_name}\u0027 defaults\""},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":"    default: {"},{"line_number":44,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem: ${::operatingsystem}\""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"da20952f_9580f7c1","line":41,"updated":"2015-08-28 20:31:43.000000000","message":"init_{script_file,install_cmd} are not used anywhere, why you add this here (non atomic patch)","commit_id":"88b0a3cf3df0de60ce9044954e07a2b9ab3a13e2"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"18b53da64f0787fcfc8afd9ab21631384dd458e3","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      $local_settings_path       \u003d \u0027/etc/openstack-dashboard/local_settings.py\u0027"},{"line_number":39,"context_line":"      # rabbitmq init params"},{"line_number":40,"context_line":"      $init_script_file          \u003d \u0027rabbitmq-init-ubuntu.erb\u0027"},{"line_number":41,"context_line":"      $init_install_cmd          \u003d \"update-rc.d \u0027${rabbit_service_name}\u0027 defaults\""},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":"    default: {"},{"line_number":44,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem: ${::operatingsystem}\""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"da20952f_b13dd890","line":41,"in_reply_to":"da20952f_9580f7c1","updated":"2015-08-31 12:12:55.000000000","message":"ditto","commit_id":"88b0a3cf3df0de60ce9044954e07a2b9ab3a13e2"}],"spec/classes/murano_init_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8640fc93fcf4dde1925d91eeee7a4687f9bb6512","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    it { is_expected.to contain_class(\u0027mysql::bindings::python\u0027) }"},{"line_number":17,"context_line":"    it { is_expected.to contain_exec(\u0027murano-dbmanage\u0027) }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  shared_examples_for \u0027murano logging\u0027 do"},{"line_number":21,"context_line":"    context \u0027with syslog disabled\u0027 do"},{"line_number":22,"context_line":"      it { is_expected.to contain_murano_config(\u0027DEFAULT/use_syslog\u0027).with_value(false) }"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"da20952f_91e30bd8","line":19,"updated":"2015-09-04 16:08:10.000000000","message":"Add please tests for all cases and all basic params:\n- with defaults;\n- with passing;","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"79a58a142ebc8ba935f946ba4762327d4f41f46c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    it { is_expected.to contain_class(\u0027mysql::bindings::python\u0027) }"},{"line_number":17,"context_line":"    it { is_expected.to contain_exec(\u0027murano-dbmanage\u0027) }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  shared_examples_for \u0027murano logging\u0027 do"},{"line_number":21,"context_line":"    context \u0027with syslog disabled\u0027 do"},{"line_number":22,"context_line":"      it { is_expected.to contain_murano_config(\u0027DEFAULT/use_syslog\u0027).with_value(false) }"}],"source_content_type":"text/x-ruby","patch_set":17,"id":"ba15a1d1_34edc98b","line":19,"in_reply_to":"da20952f_91e30bd8","updated":"2015-09-14 16:50:51.000000000","message":"Done","commit_id":"bd1bfa7c6c703bae8072d811f8eb09cd3a844f41"}]}
