)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5e3a870221b0d92b9b738f8f6b63b74465503985","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-26 13:00:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6430544eda4fc6b1b16aa53ff9e6c127c62a2e5d"},{"line_number":10,"context_line":"Depends-On: If34c3b12afb2fe7a64b24a8660d6e8d1806bb8fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba15a1d1_fc5dba15","line":7,"updated":"2015-09-22 16:01:59.000000000","message":"typo","commit_id":"ffe565d35521f00361ad203b932f55a0a330dfac"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32f366eddd07abfd43af68f81d9e449c5ce30cd1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-16 12:56:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6430544eda4fc6b1b16aa53ff9e6c127c62a2e5d"},{"line_number":10,"context_line":"Depends-On: If34c3b12afb2fe7a64b24a8660d6e8d1806bb8fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"ba15a1d1_8886b8d9","line":7,"updated":"2015-09-22 17:16:53.000000000","message":"Also typo here per Emilien in patchset 7","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-16 12:56:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6430544eda4fc6b1b16aa53ff9e6c127c62a2e5d"},{"line_number":10,"context_line":"Depends-On: If34c3b12afb2fe7a64b24a8660d6e8d1806bb8fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"ba15a1d1_e09088ef","line":7,"in_reply_to":"ba15a1d1_8886b8d9","updated":"2015-09-23 13:34:01.000000000","message":"Done","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"845987242efc1ce244bf9ecff3a706aa11f14e16","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-16 12:56:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6430544eda4fc6b1b16aa53ff9e6c127c62a2e5d"},{"line_number":10,"context_line":"Depends-On: If34c3b12afb2fe7a64b24a8660d6e8d1806bb8fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"ba15a1d1_ef6e422e","line":8,"updated":"2015-09-23 08:52:49.000000000","message":"Add please more informative commit message","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-16 12:56:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6430544eda4fc6b1b16aa53ff9e6c127c62a2e5d"},{"line_number":10,"context_line":"Depends-On: If34c3b12afb2fe7a64b24a8660d6e8d1806bb8fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"ba15a1d1_60b3189b","line":8,"in_reply_to":"ba15a1d1_ef6e422e","updated":"2015-09-23 13:34:01.000000000","message":"Done","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8c92b1e46783ce6c94f29d359551bf97595b2f71","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-23 14:26:55 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds implementation of main murano service manifests:"},{"line_number":10,"context_line":"- murano-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"ba15a1d1_61cd5784","line":7,"updated":"2015-09-23 13:25:47.000000000","message":"typo s/Implementaion/Implementation\n\nPlease add more information about each class.","commit_id":"817e84753e6d73944ec3314e5a415ca92afe91ac"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e2d632574bac1f3e0bb65844bfc507c0499e137a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-23 14:26:55 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implementaion of api and engine classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds implementation of main murano service manifests:"},{"line_number":10,"context_line":"- murano-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":22,"id":"ba15a1d1_c4ea310f","line":7,"in_reply_to":"ba15a1d1_61cd5784","updated":"2015-09-23 13:45:21.000000000","message":"Done","commit_id":"817e84753e6d73944ec3314e5a415ca92afe91ac"}],"manifests/api.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"845987242efc1ce244bf9ecff3a706aa11f14e16","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  include ::murano::policy"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  Murano_config\u003c||\u003e ~\u003e Service[\u0027murano-api\u0027]"},{"line_number":44,"context_line":"  Package\u003c| title \u003d\u003d \u0027murano-common\u0027 |\u003e -\u003e Package[\u0027murano-api\u0027]"},{"line_number":45,"context_line":"  Exec[\u0027murano-dbmanage\u0027] -\u003e Service[\u0027murano-api\u0027]"},{"line_number":46,"context_line":"  Class[\u0027murano::policy\u0027] -\u003e Service[\u0027murano-api\u0027]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_ef55e24f","line":44,"updated":"2015-09-23 08:52:49.000000000","message":"Should be removed, no reason to keep this","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  include ::murano::policy"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  Murano_config\u003c||\u003e ~\u003e Service[\u0027murano-api\u0027]"},{"line_number":44,"context_line":"  Package\u003c| title \u003d\u003d \u0027murano-common\u0027 |\u003e -\u003e Package[\u0027murano-api\u0027]"},{"line_number":45,"context_line":"  Exec[\u0027murano-dbmanage\u0027] -\u003e Service[\u0027murano-api\u0027]"},{"line_number":46,"context_line":"  Class[\u0027murano::policy\u0027] -\u003e Service[\u0027murano-api\u0027]"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_00f7bc59","line":44,"in_reply_to":"ba15a1d1_ef55e24f","updated":"2015-09-23 13:34:01.000000000","message":"Done","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"32f366eddd07abfd43af68f81d9e449c5ce30cd1","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  murano_config {"},{"line_number":57,"context_line":"    \u0027DEFAULT/bind_host\u0027 : value \u003d\u003e $host;"},{"line_number":58,"context_line":"    \u0027DEFAULT/bind_port\u0027 : value \u003d\u003e $port;"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  package { \u0027murano-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_286e8c2f","line":58,"updated":"2015-09-22 17:16:53.000000000","message":"If you have to touch this again, can you remove the extra space before the : here?","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"  murano_config {"},{"line_number":57,"context_line":"    \u0027DEFAULT/bind_host\u0027 : value \u003d\u003e $host;"},{"line_number":58,"context_line":"    \u0027DEFAULT/bind_port\u0027 : value \u003d\u003e $port;"},{"line_number":59,"context_line":"  }"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  package { \u0027murano-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_c09b0417","line":58,"in_reply_to":"ba15a1d1_286e8c2f","updated":"2015-09-23 13:34:01.000000000","message":"Done","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3d2d7617204866c5ec09cb0390eb8802063a2a75","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":35,"context_line":"  $host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":36,"context_line":"  $port           \u003d 8082,"},{"line_number":37,"context_line":"  $sync_db        \u003d true,"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"9a1a9d01_51cedd82","line":37,"updated":"2015-09-29 13:02:40.000000000","message":"note for later - could be good to support workers, and also WSGI setups. See ::ceilometer::api as an example.","commit_id":"0860bc269dd36c1e49a2a125e4e3c77e8824981d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"27395bc44ceea7ef7a0eb2dc15e4e1556b0f373e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":35,"context_line":"  $host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":36,"context_line":"  $port           \u003d 8082,"},{"line_number":37,"context_line":"  $sync_db        \u003d true,"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":24,"id":"9a1a9d01_83c3ca88","line":37,"in_reply_to":"9a1a9d01_51cedd82","updated":"2015-09-29 13:51:41.000000000","message":"ok, i\u0027ll add this feature in separate patch","commit_id":"0860bc269dd36c1e49a2a125e4e3c77e8824981d"}],"manifests/engine.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"845987242efc1ce244bf9ecff3a706aa11f14e16","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_4feace75","line":59,"updated":"2015-09-23 08:52:49.000000000","message":"Already used in main init.pp class","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"ba15a1d1_e0e2c89f","line":59,"in_reply_to":"ba15a1d1_4feace75","updated":"2015-09-23 13:34:01.000000000","message":"I don\u0027t think it should be removed, we can install services separately, and if we need to add service to existing installation I think we shoul execute DB update","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"8c92b1e46783ce6c94f29d359551bf97595b2f71","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"ba15a1d1_414133a8","line":59,"updated":"2015-09-23 13:25:47.000000000","message":"If I have understood correctly Denis\u0027s review in patch 21, this can be removed because init.pp already have.","commit_id":"817e84753e6d73944ec3314e5a415ca92afe91ac"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e2d632574bac1f3e0bb65844bfc507c0499e137a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  Package[\u0027murano-engine\u0027] ~\u003e Service[\u0027murano-engine\u0027]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  if $sync_db {"},{"line_number":60,"context_line":"    include ::murano::db::sync"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":22,"id":"ba15a1d1_84799984","line":59,"in_reply_to":"ba15a1d1_414133a8","updated":"2015-09-23 13:45:21.000000000","message":"As I already mentioned in patch 21, it shouldn\u0027t be removed in case of ability to install services separately","commit_id":"817e84753e6d73944ec3314e5a415ca92afe91ac"}],"spec/shared_examples.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"94ec1d77d4dc61ab9bccfe9672b93759ffc29045","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        :notify \u003d\u003e [\"Service[#{service[:name]}]\"]"},{"line_number":35,"context_line":"      })"},{"line_number":36,"context_line":"      is_expected.to contain_service(service[:name]).with({"},{"line_number":37,"context_line":"        :name      \u003d\u003e service[:service_name],"},{"line_number":38,"context_line":"        :ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":39,"context_line":"        :enable    \u003d\u003e true"},{"line_number":40,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"ba15a1d1_2d45e244","line":37,"updated":"2015-09-17 15:52:38.000000000","message":"too much blank spaces?","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"b58dc4a44083bf0d5ff18b20e6ffe980c59a7cd5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        :notify \u003d\u003e [\"Service[#{service[:name]}]\"]"},{"line_number":35,"context_line":"      })"},{"line_number":36,"context_line":"      is_expected.to contain_service(service[:name]).with({"},{"line_number":37,"context_line":"        :name      \u003d\u003e service[:service_name],"},{"line_number":38,"context_line":"        :ensure    \u003d\u003e \u0027running\u0027,"},{"line_number":39,"context_line":"        :enable    \u003d\u003e true"},{"line_number":40,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"ba15a1d1_80b66cf7","line":37,"in_reply_to":"ba15a1d1_2d45e244","updated":"2015-09-23 13:34:01.000000000","message":"Done","commit_id":"f72a89ba11f29ad7656083d5829c04c9ce6c847d"}]}