)]}'
{"manifests/client.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b446f55904ad206b452d4872b68936275a76246c","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  package { \u0027python-muranoclient\u0027:"},{"line_number":18,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":19,"context_line":"    name   \u003d\u003e $::murano::params::pythonclient_package_name,"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a2ca52d_78091d31","line":19,"updated":"2015-10-13 10:00:24.000000000","message":"add please tag \u0027openstack\u0027","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"bc2e3abcdc4d0fbe648393613de330fb7b1a45e9","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  package { \u0027python-muranoclient\u0027:"},{"line_number":18,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":19,"context_line":"    name   \u003d\u003e $::murano::params::pythonclient_package_name,"},{"line_number":20,"context_line":"  }"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a2ca52d_6d8dd07a","line":19,"in_reply_to":"5a2ca52d_78091d31","updated":"2015-10-13 13:25:39.000000000","message":"Done","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"5be74f56a473ba82cfd4b0dd431ff66746acf2d8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  package { \u0027python-muranoclient\u0027:"},{"line_number":18,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":19,"context_line":"    name   \u003d\u003e $::murano::params::pythonclient_package_name,"},{"line_number":20,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"da85f559_d0d80856","line":20,"updated":"2015-11-09 14:52:17.000000000","message":"same? (for the tag)","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e8b4bc868426a85950ef6043064ceb31927450bd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  package { \u0027python-muranoclient\u0027:"},{"line_number":18,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":19,"context_line":"    name   \u003d\u003e $::murano::params::pythonclient_package_name,"},{"line_number":20,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"da85f559_a48f4522","line":20,"in_reply_to":"da85f559_d0d80856","updated":"2015-11-09 15:04:43.000000000","message":"Done","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"}],"manifests/dashboard.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":47,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_b1f80b4b","line":44,"updated":"2015-09-21 14:06:50.000000000","message":"It sounds very \"hackish\" to call a bash script here. Can you give the reason of such a thing?","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"d51126236fd06e1e0f87119c0333f67eebf1f364","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $settings_py           \u003d \u0027/usr/share/openstack-dashboard/openstack_dashboard/settings.py\u0027,"},{"line_number":44,"context_line":"  $modify_config         \u003d \u0027/usr/bin/modify-horizon-config.sh\u0027,"},{"line_number":45,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":46,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":47,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_7a348349","line":44,"in_reply_to":"ba15a1d1_b1f80b4b","updated":"2015-09-21 16:35:06.000000000","message":"This script is an old way murano change horizon config. It was included in murano-dashboard package and executed during package installation. So in this manifest we are cleaning out changes made by this script if it was executed.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  File_line {"},{"line_number":64,"context_line":"    ensure \u003d\u003e \u0027present\u0027,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  file_line { \u0027murano_url\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_51940fe7","line":64,"updated":"2015-09-21 14:06:50.000000000","message":"I\u0027m not sure it\u0027s safe to do it. Is it going to be applied in the whole Puppet catalog?","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"d51126236fd06e1e0f87119c0333f67eebf1f364","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  File_line {"},{"line_number":64,"context_line":"    ensure \u003d\u003e \u0027present\u0027,"},{"line_number":65,"context_line":"  }"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"  file_line { \u0027murano_url\u0027 :"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_5a517f61","line":64,"in_reply_to":"ba15a1d1_51940fe7","updated":"2015-09-21 16:35:06.000000000","message":"As far as I know it will affect only this class and classes that will include/require this one, so it should be secure.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    path \u003d\u003e $::murano::params::local_settings_path,"},{"line_number":99,"context_line":"    line \u003d\u003e \"LOGGING[\u0027loggers\u0027][\u0027muranoclient\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027ERROR\u0027}\","},{"line_number":100,"context_line":"    tag  \u003d\u003e \u0027patch-horizon-config\u0027,"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  exec { \u0027clean_horizon_config\u0027:"},{"line_number":104,"context_line":"    command \u003d\u003e \"${modify_config} uninstall\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_7199131f","line":101,"updated":"2015-09-21 14:06:50.000000000","message":"Instead of these file_line, I would rather use a template, to be consistent with puppet-horizon.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"d51126236fd06e1e0f87119c0333f67eebf1f364","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    path \u003d\u003e $::murano::params::local_settings_path,"},{"line_number":99,"context_line":"    line \u003d\u003e \"LOGGING[\u0027loggers\u0027][\u0027muranoclient\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027ERROR\u0027}\","},{"line_number":100,"context_line":"    tag  \u003d\u003e \u0027patch-horizon-config\u0027,"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  exec { \u0027clean_horizon_config\u0027:"},{"line_number":104,"context_line":"    command \u003d\u003e \"${modify_config} uninstall\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_5565d0de","line":101,"in_reply_to":"ba15a1d1_7199131f","updated":"2015-09-21 16:35:06.000000000","message":"As far as i know if we use template we should regenerate whole config. So I think it will be problematic.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    tag  \u003d\u003e \u0027patch-horizon-config\u0027,"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  exec { \u0027clean_horizon_config\u0027:"},{"line_number":104,"context_line":"    command \u003d\u003e \"${modify_config} uninstall\","},{"line_number":105,"context_line":"    onlyif  \u003d\u003e ["},{"line_number":106,"context_line":"      \"test -f ${modify_config}\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_119e9707","line":103,"updated":"2015-09-21 14:06:50.000000000","message":"what is the purpose of this exec? Purge any horizon thing? It\u0027s not really clear.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"d51126236fd06e1e0f87119c0333f67eebf1f364","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    tag  \u003d\u003e \u0027patch-horizon-config\u0027,"},{"line_number":101,"context_line":"  }"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"  exec { \u0027clean_horizon_config\u0027:"},{"line_number":104,"context_line":"    command \u003d\u003e \"${modify_config} uninstall\","},{"line_number":105,"context_line":"    onlyif  \u003d\u003e ["},{"line_number":106,"context_line":"      \"test -f ${modify_config}\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_75f25408","line":103,"in_reply_to":"ba15a1d1_119e9707","updated":"2015-09-21 16:35:06.000000000","message":"This exec is used to clean up all changes made by the modify-horizon-config.sh script. It was added for backward compatibility with early versions of murano-dashboard package","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":114,"context_line":"    environment \u003d\u003e ["},{"line_number":115,"context_line":"      \"APACHE_USER\u003d${apache_user}\","},{"line_number":116,"context_line":"      \"APACHE_GROUP\u003d${apache_user}\","},{"line_number":117,"context_line":"    ],"},{"line_number":118,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":119,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_31a39b51","line":116,"updated":"2015-09-21 14:06:50.000000000","message":"you could get the variable from puppetlabs-apache, by calling its scope.\napache::params::user\napache::params::group","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"d51126236fd06e1e0f87119c0333f67eebf1f364","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":114,"context_line":"    environment \u003d\u003e ["},{"line_number":115,"context_line":"      \"APACHE_USER\u003d${apache_user}\","},{"line_number":116,"context_line":"      \"APACHE_GROUP\u003d${apache_user}\","},{"line_number":117,"context_line":"    ],"},{"line_number":118,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":119,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_7525745a","line":116,"in_reply_to":"ba15a1d1_31a39b51","updated":"2015-09-21 16:35:06.000000000","message":"ok, i\u0027ll change it","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c98abadbb63a24c3b47511712182baba4e62861c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"  File_line \u003c| tag \u003d\u003d \u0027patch-horizon-config\u0027 |\u003e -\u003e Service \u003c| title \u003d\u003d \u0027httpd\u0027 |\u003e"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"  Package[\u0027murano-dashboard\u0027] -\u003e"},{"line_number":124,"context_line":"    Exec[\u0027clean_horizon_config\u0027] -\u003e"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_d1881fc9","line":121,"updated":"2015-09-21 14:06:50.000000000","message":"look, you\u0027re calling the right resource here, so it\u0027s a good reason to do the same with group/user.","commit_id":"fed3bd85a3f9cd688a919c220672f1cbd4ce443e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b446f55904ad206b452d4872b68936275a76246c","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  package { \u0027murano-dashboard\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":44,"context_line":"    name   \u003d\u003e $::murano::params::dashboard_package_name,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  concat { $::murano::params::local_settings_path: }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a2ca52d_db25cbae","line":44,"updated":"2015-10-13 10:00:24.000000000","message":"ditto","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"bc2e3abcdc4d0fbe648393613de330fb7b1a45e9","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  package { \u0027murano-dashboard\u0027:"},{"line_number":43,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":44,"context_line":"    name   \u003d\u003e $::murano::params::dashboard_package_name,"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  concat { $::murano::params::local_settings_path: }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"5a2ca52d_0de9bc1a","line":44,"in_reply_to":"5a2ca52d_db25cbae","updated":"2015-10-13 13:25:39.000000000","message":"Done","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"38c75c9fbfd6e04c2fd561aeaa0c52ad20d3ca51","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  exec { \u0027django_collectstatic\u0027:"},{"line_number":78,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":79,"context_line":"    environment \u003d\u003e ["},{"line_number":80,"context_line":"      \"APACHE_USER\u003d${::apache::params::user}\","},{"line_number":81,"context_line":"      \"APACHE_GROUP\u003d${::apache::params::group}\","}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5a2ca52d_66a05ca0","line":78,"updated":"2015-10-14 13:27:41.000000000","message":"The original collectstatic command uses \u0027--clear\u0027: https://github.com/openstack/puppet-horizon/blob/master/manifests/init.pp#L377; should it also be here? Do we need to compress after?","commit_id":"4b0b30c5ab5f533bd7f931ad2d7805e162bfaffc"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"a52b17c14f3587afda83a30150eb30010bf92262","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  exec { \u0027django_collectstatic\u0027:"},{"line_number":78,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":79,"context_line":"    environment \u003d\u003e ["},{"line_number":80,"context_line":"      \"APACHE_USER\u003d${::apache::params::user}\","},{"line_number":81,"context_line":"      \"APACHE_GROUP\u003d${::apache::params::group}\","}],"source_content_type":"text/x-puppet","patch_set":16,"id":"5a2ca52d_ce727049","line":78,"in_reply_to":"5a2ca52d_66a05ca0","updated":"2015-10-15 13:43:09.000000000","message":"\"--clear\" description from documentation: \"Clear the existing files before trying to copy or link the original file.\". I don\u0027t think, that comething like this should be done, during muranodashboard installation. It will affect horizon static files.\n\nI\u0027ll add compression and migration, but won\u0027t add \"--clear\" option.","commit_id":"4b0b30c5ab5f533bd7f931ad2d7805e162bfaffc"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"9b4e71a70a80b45bdf4c2e2d7869ff203ec2ef6c","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  exec { \u0027django_collectstatic\u0027:"},{"line_number":78,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":79,"context_line":"    environment \u003d\u003e ["},{"line_number":80,"context_line":"      \"APACHE_USER\u003d${::apache::params::user}\","},{"line_number":81,"context_line":"      \"APACHE_GROUP\u003d${::apache::params::group}\","}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a2ca52d_f1f95181","line":78,"updated":"2015-10-15 13:58:05.000000000","message":"Answering for previous patch: It should not affect static files, old files will be deleted and new will be copied and linked, at the end we will have the same state of static files. It work for horizon itself, and should work for Murano dashboard, isn\u0027t?. I think \u0027--clear\u0027 is required as it\u0027s done in horizon module","commit_id":"6a33f2a080f70bef36d471b99100a79fe2e2696e"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"4047a8106d0fc1d4a6e6deca7defce2cfd7bf317","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  }"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  exec { \u0027django_collectstatic\u0027:"},{"line_number":78,"context_line":"    command     \u003d\u003e \"${collect_static_script} collectstatic --noinput\","},{"line_number":79,"context_line":"    environment \u003d\u003e ["},{"line_number":80,"context_line":"      \"APACHE_USER\u003d${::apache::params::user}\","},{"line_number":81,"context_line":"      \"APACHE_GROUP\u003d${::apache::params::group}\","}],"source_content_type":"text/x-puppet","patch_set":17,"id":"5a2ca52d_9de82c12","line":78,"in_reply_to":"5a2ca52d_f1f95181","updated":"2015-10-15 14:51:50.000000000","message":"As murano team decided, we are not required to use \u0027--clear\u0027 option.","commit_id":"6a33f2a080f70bef36d471b99100a79fe2e2696e"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"ef9bdb99ff1b9e93c2aeef094f09b9c3770f7104","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class murano::dashboard("},{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a29b11f_c1f13ccf","line":42,"updated":"2015-10-19 10:57:56.000000000","message":"this should be storage.apps.openstack.org for kilo and http://apps.openstack.org/api/v1/murano_repo/liberty/ for liberty.\n\nI\u0027d rather not set it to any default here, but leave it for the dashboard to decide which default is correct.","commit_id":"47acbc0a133e904e6622a89222ac2941791ea841"},{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"908630c7051119039b386ec070216b880890b447","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class murano::dashboard("},{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a29b11f_423a0738","line":42,"in_reply_to":"3a29b11f_1fdd4842","updated":"2015-10-19 12:59:38.000000000","message":"I\u0027d prefer to not set it to anything by default and therefore use murano-dashboards default value.\nIt\u0027s definitely not worth to mark it as required, cause it\u0027s not \u003d)","commit_id":"47acbc0a133e904e6622a89222ac2941791ea841"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a512041d1ee0523f1e0ea30ba81883dc3055e07c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class murano::dashboard("},{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://storage.apps.openstack.org\u0027,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":19,"id":"3a29b11f_1fdd4842","line":42,"in_reply_to":"3a29b11f_c1f13ccf","updated":"2015-10-19 12:37:23.000000000","message":"Kirill,\n\nwe don\u0027t have Kilo branch for puppet-murano, so, i\u0027d like use here http://apps.openstack.org/api/v1/murano_repo/liberty/\n\nor\n\nwe can set this value as required and user should be set it himself.","commit_id":"47acbc0a133e904e6622a89222ac2941791ea841"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3181add1e6cb04fa9d5cac8d34d36c401179e38a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class murano::dashboard("},{"line_number":40,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":41,"context_line":"  $api_url               \u003d \u0027http://127.0.0.1:8082\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d \u0027http://apps.openstack.org/api/v1/murano_repo/liberty/\u0027,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/muranodashboard-cache\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"}],"source_content_type":"text/x-puppet","patch_set":21,"id":"3a29b11f_4e40f056","line":42,"updated":"2015-10-19 14:13:48.000000000","message":"According to Kiril comment in 19 patch set - should be undef by default.","commit_id":"fe57cbf621d3c8da5f436ca93095e411385b657f"},{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"5be74f56a473ba82cfd4b0dd431ff66746acf2d8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  package { \u0027murano-dashboard\u0027:"},{"line_number":53,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":54,"context_line":"    name   \u003d\u003e $::murano::params::dashboard_package_name,"},{"line_number":55,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  concat { $::murano::params::local_settings_path: }"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"da85f559_f0550cc6","line":55,"updated":"2015-11-09 14:52:17.000000000","message":"It\u0027s possible to tag packages like others projects, with \u0027openstack\u0027 and $project-package ? ([\u0027openstack\u0027,\u0027murano-package\u0027]). https://github.com/openstack/puppet-glance/blob/master/manifests/api.pp#L244","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e8b4bc868426a85950ef6043064ceb31927450bd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  package { \u0027murano-dashboard\u0027:"},{"line_number":53,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":54,"context_line":"    name   \u003d\u003e $::murano::params::dashboard_package_name,"},{"line_number":55,"context_line":"    tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  concat { $::murano::params::local_settings_path: }"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"da85f559_64995d6e","line":55,"in_reply_to":"da85f559_f0550cc6","updated":"2015-11-09 15:04:43.000000000","message":"Done","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"}],"spec/classes/murano_client_spec.rb":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"5be74f56a473ba82cfd4b0dd431ff66746acf2d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027murano::client\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    { :osfamily \u003d\u003e \u0027Debian\u0027 }"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  shared_examples_for \u0027murano-client\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":27,"id":"da85f559_f0c42c41","line":6,"updated":"2015-11-09 14:52:17.000000000","message":"Ok it\u0027s pretty straight forward, but no RedHat* tests?","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e8b4bc868426a85950ef6043064ceb31927450bd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027murano::client\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    { :osfamily \u003d\u003e \u0027Debian\u0027 }"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  shared_examples_for \u0027murano-client\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":27,"id":"da85f559_24a4b5a4","line":6,"in_reply_to":"da85f559_f0c42c41","updated":"2015-11-09 15:04:43.000000000","message":"Done","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"}],"spec/classes/murano_dashboard_spec.rb":[{"author":{"_account_id":7155,"name":"Sebastien Badia","email":"seb@sebian.fr","username":"sbadia"},"change_message_id":"5be74f56a473ba82cfd4b0dd431ff66746acf2d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027murano::dashboard\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do {"},{"line_number":6,"context_line":"    :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":7,"context_line":"    :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":8,"context_line":"  } end"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":27,"id":"da85f559_70e7dce4","line":6,"updated":"2015-11-09 14:52:17.000000000","message":"Ok it\u0027s pretty straight forward, but no RedHat* tests?","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e8b4bc868426a85950ef6043064ceb31927450bd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027murano::dashboard\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do {"},{"line_number":6,"context_line":"    :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":7,"context_line":"    :concat_basedir \u003d\u003e \u0027/var/lib/puppet/concat\u0027"},{"line_number":8,"context_line":"  } end"},{"line_number":9,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":27,"id":"da85f559_e4ad4d89","line":6,"in_reply_to":"da85f559_70e7dce4","updated":"2015-11-09 15:04:43.000000000","message":"Done","commit_id":"be6b020fab223433b62dbf03cfcd906ff74ffa3d"}],"templates/local_settings.py.erb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"d866d0bb7475e0b2284c6e6f288f908277f5ba70","unresolved":false,"context_lines":[{"line_number":3,"context_line":"MURANO_REPO_URL \u003d \u0027\u003c%\u003d @repo_url %\u003e\u0027"},{"line_number":4,"context_line":"MAX_FILE_SIZE_MB \u003d \u0027\u003c%\u003d @max_file_size %\u003e\u0027"},{"line_number":5,"context_line":"METADATA_CACHE_DIR \u003d \u0027\u003c%\u003d @metadata_dir %\u003e\u0027"},{"line_number":6,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranodashboard\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027DEBUG\u0027}"},{"line_number":7,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranoclient\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027ERROR\u0027}"},{"line_number":8,"context_line":"## MURANO_CONFIG_END ##"}],"source_content_type":"application/x-erb","patch_set":15,"id":"7a2fa921_496c7108","line":6,"updated":"2015-10-12 19:47:46.000000000","message":"Should we make this configurable? I\u0027m not sure of the chattiness of the dashboard logger but I wouldn\u0027t want to run debug in prod.","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"bc2e3abcdc4d0fbe648393613de330fb7b1a45e9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"MURANO_REPO_URL \u003d \u0027\u003c%\u003d @repo_url %\u003e\u0027"},{"line_number":4,"context_line":"MAX_FILE_SIZE_MB \u003d \u0027\u003c%\u003d @max_file_size %\u003e\u0027"},{"line_number":5,"context_line":"METADATA_CACHE_DIR \u003d \u0027\u003c%\u003d @metadata_dir %\u003e\u0027"},{"line_number":6,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranodashboard\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027DEBUG\u0027}"},{"line_number":7,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranoclient\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027ERROR\u0027}"},{"line_number":8,"context_line":"## MURANO_CONFIG_END ##"}],"source_content_type":"application/x-erb","patch_set":15,"id":"5a2ca52d_cdf2e406","line":6,"in_reply_to":"5a2ca52d_587781d4","updated":"2015-10-13 13:25:39.000000000","message":"Done","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b446f55904ad206b452d4872b68936275a76246c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"MURANO_REPO_URL \u003d \u0027\u003c%\u003d @repo_url %\u003e\u0027"},{"line_number":4,"context_line":"MAX_FILE_SIZE_MB \u003d \u0027\u003c%\u003d @max_file_size %\u003e\u0027"},{"line_number":5,"context_line":"METADATA_CACHE_DIR \u003d \u0027\u003c%\u003d @metadata_dir %\u003e\u0027"},{"line_number":6,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranodashboard\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027DEBUG\u0027}"},{"line_number":7,"context_line":"LOGGING[\u0027loggers\u0027][\u0027muranoclient\u0027] \u003d {\u0027handlers\u0027: [\u0027syslog\u0027], \u0027level\u0027: \u0027ERROR\u0027}"},{"line_number":8,"context_line":"## MURANO_CONFIG_END ##"}],"source_content_type":"application/x-erb","patch_set":15,"id":"5a2ca52d_587781d4","line":6,"in_reply_to":"7a2fa921_496c7108","updated":"2015-10-13 10:00:24.000000000","message":"Agree with Alex. Make it configurable, please","commit_id":"19dee6ff72351fbca396b8eb71b8ab1d5402a40a"}]}
