)]}'
{"lib/puppet/type/murano_application.rb":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"29f376c50f350045812246cdb54d54aee902cd49","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#    Required"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#  [*package_path*]"},{"line_number":9,"context_line":"#    Path to package file"},{"line_number":10,"context_line":"#    Required"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"#  [*category*]"}],"source_content_type":"text/x-ruby","patch_set":26,"id":"ba8a016a_90ca576d","line":9,"updated":"2015-11-17 18:11:14.000000000","message":"URL or filesystem path?","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"8d2e3d8b554016a2b0103b51a635f08fe37323a4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#    Required"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"#  [*package_path*]"},{"line_number":9,"context_line":"#    Path to package file"},{"line_number":10,"context_line":"#    Required"},{"line_number":11,"context_line":"#"},{"line_number":12,"context_line":"#  [*category*]"}],"source_content_type":"text/x-ruby","patch_set":26,"id":"ba8a016a_27546951","line":9,"in_reply_to":"ba8a016a_90ca576d","updated":"2015-11-18 12:55:48.000000000","message":"Filesystem path","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"}],"manifests/application.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"4a38034edfa5f86933c8da908c700380ac94cb42","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $os_password      \u003d \u0027ChangeMe\u0027,"},{"line_number":55,"context_line":"  $os_region        \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":57,"context_line":"  $mandatory        \u003d false,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a1a9d01_e35b3df5","line":57,"updated":"2015-10-01 14:41:53.000000000","message":"I don\u0027t see where this paramater is used.","commit_id":"8cc35d21d15189728989bf5a78d8ff0b4d224736"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"997b99d74846a651cb84bec13cfb12915984b435","unresolved":false,"context_lines":[{"line_number":54,"context_line":"  $os_password      \u003d \u0027ChangeMe\u0027,"},{"line_number":55,"context_line":"  $os_region        \u003d \u0027RegionOne\u0027,"},{"line_number":56,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":57,"context_line":"  $mandatory        \u003d false,"},{"line_number":58,"context_line":") {"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":13,"id":"9a1a9d01_6d38133e","line":57,"in_reply_to":"9a1a9d01_e35b3df5","updated":"2015-10-05 13:14:43.000000000","message":"Seems like I\u0027ve forgot to delete this parameter","commit_id":"8cc35d21d15189728989bf5a78d8ff0b4d224736"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d34ce750b356b6368df79e61af2b1aa304a0756d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $package_category {"},{"line_number":58,"context_line":"    $murano_cli_cmd \u003d \"${murano_cli} package-import \u0027${package_path}\u0027 -c \u0027${package_category}\u0027 --is-public --exists-action u\""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a2fa921_c87e26e4","line":55,"updated":"2015-10-06 16:55:33.000000000","message":"can this package be placed in other path? may be it should be moved to params?","commit_id":"22915a9b33f2ba9dd7e5ad59f60332b56f744f40"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"91d56d2b9017d73f0306a5d7eefe5dd561dd336a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  $os_auth_url      \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":53,"context_line":") {"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"  if $package_category {"},{"line_number":58,"context_line":"    $murano_cli_cmd \u003d \"${murano_cli} package-import \u0027${package_path}\u0027 -c \u0027${package_category}\u0027 --is-public --exists-action u\""}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a2fa921_3de81a10","line":55,"in_reply_to":"7a2fa921_c87e26e4","updated":"2015-10-07 10:46:09.000000000","message":"this package comes with murano-common package and now it\u0027s location is static","commit_id":"22915a9b33f2ba9dd7e5ad59f60332b56f744f40"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d34ce750b356b6368df79e61af2b1aa304a0756d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  $murano_cli_pkgcheck \u003d \"${murano_cli} package-list 2\u003e\u00261 | grep -q \u0027 ${package_name} \u0027\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  exec { \"murano_import_package_${package_name}\":"},{"line_number":66,"context_line":"    path        \u003d\u003e \u0027/sbin:/usr/sbin:/bin:/usr/bin\u0027,"},{"line_number":67,"context_line":"    environment \u003d\u003e ["},{"line_number":68,"context_line":"      \"OS_TENANT_NAME\u003d${os_tenant_name}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a2fa921_a8bc0a6d","line":65,"updated":"2015-10-06 16:55:33.000000000","message":"also may be will be better to create custom provider, which will take creds from murano.conf without explicit passing it? So, looks like:\n\nmurano_application { $name:\n  user \u003d\u003e $runas_user,\n  category \u003d\u003e $package_category,\n  package_path \u003d\u003e $package_path,\n}\n\nit\u0027ll be much more readable, i think","commit_id":"22915a9b33f2ba9dd7e5ad59f60332b56f744f40"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"91d56d2b9017d73f0306a5d7eefe5dd561dd336a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  $murano_cli_pkgcheck \u003d \"${murano_cli} package-list 2\u003e\u00261 | grep -q \u0027 ${package_name} \u0027\""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  exec { \"murano_import_package_${package_name}\":"},{"line_number":66,"context_line":"    path        \u003d\u003e \u0027/sbin:/usr/sbin:/bin:/usr/bin\u0027,"},{"line_number":67,"context_line":"    environment \u003d\u003e ["},{"line_number":68,"context_line":"      \"OS_TENANT_NAME\u003d${os_tenant_name}\","}],"source_content_type":"text/x-puppet","patch_set":15,"id":"7a2fa921_7dc5328c","line":65,"in_reply_to":"7a2fa921_a8bc0a6d","updated":"2015-10-07 10:46:09.000000000","message":"ok I\u0027ll take a look","commit_id":"22915a9b33f2ba9dd7e5ad59f60332b56f744f40"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"87f4459a6586282af7f959c0c8a101d571c99716","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a2ca52d_de4cd978","line":17,"updated":"2015-10-13 10:19:47.000000000","message":"I think, when we will try to create resource with \u0027package_category \u003d undef\u0027 we will see ArgumentError from type, because nil.is_a? String \u003d\u003e false. Did you checked this case?","commit_id":"8551d02e9dcd634111c1e06edafe974c06b106fd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0cdf30d92a0d583b7c398e8245cc0109f8a227e1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":18,"id":"5a2ca52d_b50725c9","line":17,"in_reply_to":"5a2ca52d_de4cd978","updated":"2015-10-16 02:12:39.000000000","message":"I\u0027ve asked in patch #19, he already tested and it\u0027s not a problem.","commit_id":"8551d02e9dcd634111c1e06edafe974c06b106fd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"f4973e39dd6cf77b6527a36c0586d5066ce6f92a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a2ca52d_580dca35","line":17,"updated":"2015-10-15 13:06:18.000000000","message":"Please take a look at Denis comment in patch #18.","commit_id":"fb8f003b8dc26ba91f8d37e9d980758bc1ef1dc1"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"5ac866d677ac14bfcb5f8297b13b0f61c0fded71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a2ca52d_d18c5581","line":17,"in_reply_to":"5a2ca52d_580dca35","updated":"2015-10-15 13:49:14.000000000","message":"I\u0027ve checked this case, and it shouldn\u0027t case any problem.","commit_id":"fb8f003b8dc26ba91f8d37e9d980758bc1ef1dc1"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1729cf61740539bde6d40d7704a266eab12f871f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""}],"source_content_type":"text/x-puppet","patch_set":19,"id":"5a2ca52d_5572517c","line":17,"in_reply_to":"5a2ca52d_d18c5581","updated":"2015-10-16 02:12:53.000000000","message":"ok ^^","commit_id":"fb8f003b8dc26ba91f8d37e9d980758bc1ef1dc1"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"29f376c50f350045812246cdb54d54aee902cd49","unresolved":false,"context_lines":[{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":26,"id":"ba8a016a_509b8f72","line":18,"updated":"2015-11-17 18:11:14.000000000","message":"how do I set the package_path?","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"8d2e3d8b554016a2b0103b51a635f08fe37323a4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"define murano::application ("},{"line_number":16,"context_line":"  $package_name     \u003d $title,"},{"line_number":17,"context_line":"  $package_category \u003d undef,"},{"line_number":18,"context_line":") {"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":26,"id":"ba8a016a_e77c21b7","line":18,"in_reply_to":"ba8a016a_509b8f72","updated":"2015-11-18 12:55:48.000000000","message":"murano has prepacked applications, and this class designed for it\u0027s installation. If you want to install different application you can use murano_application provider directly","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"29f376c50f350045812246cdb54d54aee902cd49","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  $package_path\u003d\"/var/cache/murano/meta/${package_name}.zip\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  murano_application { $package_name:"},{"line_number":23,"context_line":"    ensure       \u003d\u003e \u0027present\u0027,"},{"line_number":24,"context_line":"    package_path \u003d\u003e $package_path,"},{"line_number":25,"context_line":"    category     \u003d\u003e $package_category,"},{"line_number":26,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":26,"id":"ba8a016a_9091f754","line":23,"updated":"2015-11-17 18:11:14.000000000","message":"why is this not settable?","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"}],"spec/unit/provider/murano_spec.rb":[{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"29f376c50f350045812246cdb54d54aee902cd49","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      conf \u003d {\u0027keystone_authtoken\u0027 \u003d\u003e {\u0027invalid_value\u0027 \u003d\u003e \u0027foo\u0027}}"},{"line_number":49,"context_line":"      klass.expects(:murano_conf).returns(conf)"},{"line_number":50,"context_line":"      expect do"},{"line_number":51,"context_line":"       klass.murano_credentials"},{"line_number":52,"context_line":"      end.to raise_error(Puppet::Error, credential_error)"},{"line_number":53,"context_line":"    end"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":26,"id":"ba8a016a_3077eb3b","line":51,"updated":"2015-11-17 18:11:14.000000000","message":"indent 1 more space","commit_id":"08282d42587eb8ec9c89c7d4d03a8d66ebfa3aa3"}]}