)]}'
{"manifests/cfapi.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"183dd2031bf87fbcf9d24f25da9d03bdce05a3c1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  package { \u0027murano-cfapi\u0027:"},{"line_number":55,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":56,"context_line":"    name   \u003d\u003e $::murano::params::cfapi_package_name,"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_47aa2e87","line":55,"updated":"2015-11-13 13:07:34.000000000","message":"why not use ensure_packges?","commit_id":"229ef2924523363554d4b6c4f4056971243b66d0"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"212a29a6164091cec9843694ed59d048db1b89fe","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  package { \u0027murano-cfapi\u0027:"},{"line_number":55,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":56,"context_line":"    name   \u003d\u003e $::murano::params::cfapi_package_name,"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_a77d1ae9","line":55,"in_reply_to":"da85f559_47aa2e87","updated":"2015-11-13 13:11:49.000000000","message":"all classes in this module uses package_ensure variable name, it will be incosistent if it will be different","commit_id":"229ef2924523363554d4b6c4f4056971243b66d0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a15d789d0f0f9dabf26cc2ba8289630d724eee07","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  package { \u0027murano-cfapi\u0027:"},{"line_number":55,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":56,"context_line":"    name   \u003d\u003e $::murano::params::cfapi_package_name,"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_c7f13e97","line":55,"in_reply_to":"da85f559_47aa2e87","updated":"2015-11-13 13:10:27.000000000","message":"i don\u0027t think that it is important","commit_id":"229ef2924523363554d4b6c4f4056971243b66d0"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1d5db6f82393ba432c34838a9fbf43b9e2e6f44f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"  package { \u0027murano-cfapi\u0027:"},{"line_number":55,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":56,"context_line":"    name   \u003d\u003e $::murano::params::cfapi_package_name,"},{"line_number":57,"context_line":"  }"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_b9c45e5f","line":55,"in_reply_to":"da85f559_a77d1ae9","updated":"2015-11-13 14:00:04.000000000","message":"oh sorry, i\u0027m not talking about $package_ensure, but the ensure_packages\n\n ensure_packages([\u0027package_name\u0027], {\t\t\n    ensure \u003d\u003e present\t\t\n  })","commit_id":"229ef2924523363554d4b6c4f4056971243b66d0"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"86d84652e2d79f2e2f493ffa2dbdc86ab8eed54e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*manage_service*]"},{"line_number":8,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":9,"context_line":"#  Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Whether the service should be managed by Puppet"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_c6aabb85","line":9,"updated":"2015-11-16 13:38:00.000000000","message":"true, i guess","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"28f0a5ecfb9b8e5e998af859d4818ca5217d4035","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*manage_service*]"},{"line_number":8,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":9,"context_line":"#  Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Whether the service should be managed by Puppet"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_d1b58c7e","line":9,"in_reply_to":"ba8a016a_c6aabb85","updated":"2015-11-16 15:52:12.000000000","message":"Am I right and this parameter says if we want to enable/disable service by default? If so, I might say that we don\u0027t want service broker to be enabled by default.","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"a32bb30ba2bce42e36240513eba43b1c13bb7797","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*manage_service*]"},{"line_number":8,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":9,"context_line":"#  Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Whether the service should be managed by Puppet"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_fce187ff","line":9,"in_reply_to":"ba8a016a_d1b58c7e","updated":"2015-11-16 15:57:29.000000000","message":"Nikolay, it should be set to true by default. This parameters says if we want puppet to manage this service. Looks like description was shuffled with next parameter.","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2f0fb05676cc2d775fd0dd0a57c078458a6295ae","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*manage_service*]"},{"line_number":8,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":9,"context_line":"#  Defaults to false"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Whether the service should be managed by Puppet"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_fc3f47d4","line":9,"in_reply_to":"ba8a016a_fce187ff","updated":"2015-11-16 16:05:12.000000000","message":"Take a look on 41 line. This parameter means, should this service be managed by puppet or not. Also, please change description and parameters values to next:\n\n  # [*manage_service*]\n  #  (Optional) Whether the service should be managed by Puppet \n  #  Defaults to true\n\nand\n\n  # [*enabled*]\n  #  (Optional) Should the service be enabled\n  #  Defaults to false\n\nIn this case it means, that puppet will stop this service.","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"86d84652e2d79f2e2f493ffa2dbdc86ab8eed54e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*host*]"},{"line_number":20,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"},{"line_number":21,"context_line":"#  Defaults to host ip"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*port*]"},{"line_number":24,"context_line":"#  (Optional) Port on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_867cb321","line":21,"updated":"2015-11-16 13:38:00.000000000","message":"\u0027127.0.0.1\u0027","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"28f0a5ecfb9b8e5e998af859d4818ca5217d4035","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*host*]"},{"line_number":20,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"},{"line_number":21,"context_line":"#  Defaults to host ip"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*port*]"},{"line_number":24,"context_line":"#  (Optional) Port on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba8a016a_1c4d6b72","line":21,"in_reply_to":"ba8a016a_867cb321","updated":"2015-11-16 15:52:12.000000000","message":"Done","commit_id":"7fb5d37ee026c5083a1f1c82ad338e17a3de06ef"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"89de4048a32113d21bb7ecfd8910586e8cd86afa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":13,"context_line":"#  Defaults to false"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#  (Optional) Ensure state for package"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_77e34234","line":13,"updated":"2015-11-17 11:25:27.000000000","message":"Default value should be the same with variable value","commit_id":"8140066c134450567724f8aa43e7587f5c6187a2"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"b7ba60c064d0d5218c35499b494ffe669cfbe9b1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*enabled*]"},{"line_number":12,"context_line":"#  (Optional) Should the service be enabled"},{"line_number":13,"context_line":"#  Defaults to false"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*package_ensure*]"},{"line_number":16,"context_line":"#  (Optional) Ensure state for package"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_f53280f1","line":13,"in_reply_to":"ba8a016a_77e34234","updated":"2015-11-18 14:59:28.000000000","message":"sorry for collision","commit_id":"8140066c134450567724f8aa43e7587f5c6187a2"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"89de4048a32113d21bb7ecfd8910586e8cd86afa","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class murano::cfapi("},{"line_number":28,"context_line":"  $manage_service \u003d true,"},{"line_number":29,"context_line":"  $enabled        \u003d true,"},{"line_number":30,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":31,"context_line":"  $host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":32,"context_line":"  $port           \u003d 8083,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_571b9e1b","line":29,"updated":"2015-11-17 11:25:27.000000000","message":"It so to true, so it should be \u0027Defaults true\u0027, or you should change value to false","commit_id":"8140066c134450567724f8aa43e7587f5c6187a2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b324918a2f7e91ce44535fc7d0cec7d59b2de741","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"class murano::cfapi("},{"line_number":28,"context_line":"  $manage_service \u003d true,"},{"line_number":29,"context_line":"  $enabled        \u003d true,"},{"line_number":30,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":31,"context_line":"  $host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":32,"context_line":"  $port           \u003d 8083,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba8a016a_55682cb9","line":29,"updated":"2015-11-18 15:01:09.000000000","message":"service should be enable by default to be consistent with other services, update doc please above.","commit_id":"8140066c134450567724f8aa43e7587f5c6187a2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3691d8d11da2accd1a4886d719fe03f301e8bd81","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  $manage_service \u003d true,"},{"line_number":29,"context_line":"  $enabled        \u003d true,"},{"line_number":30,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":31,"context_line":"  $host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":32,"context_line":"  $port           \u003d 8083,"},{"line_number":33,"context_line":") {"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a8ffd7b_a55ffa0d","line":31,"updated":"2015-12-02 11:57:36.000000000","message":"Now we are using new scheme for parameters, which are the same for openstack project: use fact $::os_service_default. We already implemented such scheme for murano - https://review.openstack.org/#/c/247482/\n\nPlease change $host and $port to $::os_service_default as it done for murano (in patch above)","commit_id":"10bc95d67f5d20ce53748fb8d0e061119611764a"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ebea7247639a7cfd20f804e663aa47df28371866","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":244,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":245,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"},{"line_number":246,"context_line":"  $cfapi_auth_url          \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":247,"context_line":"  $cfapi_bind_port         \u003d \u00278083\u0027,"},{"line_number":248,"context_line":"  $cfapi_bind_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":249,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_d6549622","line":246,"updated":"2015-11-13 12:15:44.000000000","message":"this parameter is equal to auth_uri. is it ok?","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"7d4143738033e44d2d6aee2d50d3e0dc14cd74a7","unresolved":false,"context_lines":[{"line_number":243,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":244,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":245,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"},{"line_number":246,"context_line":"  $cfapi_auth_url          \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":247,"context_line":"  $cfapi_bind_port         \u003d \u00278083\u0027,"},{"line_number":248,"context_line":"  $cfapi_bind_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":249,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_819a46c4","line":246,"in_reply_to":"da85f559_d6549622","updated":"2015-11-13 12:22:21.000000000","message":"move this parameter to service_broker class","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ebea7247639a7cfd20f804e663aa47df28371866","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"},{"line_number":246,"context_line":"  $cfapi_auth_url          \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":247,"context_line":"  $cfapi_bind_port         \u003d \u00278083\u0027,"},{"line_number":248,"context_line":"  $cfapi_bind_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":249,"context_line":") {"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_b62eb2a3","line":248,"updated":"2015-11-13 12:15:44.000000000","message":"those parameters should not be here","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"7d4143738033e44d2d6aee2d50d3e0dc14cd74a7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"},{"line_number":246,"context_line":"  $cfapi_auth_url          \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":247,"context_line":"  $cfapi_bind_port         \u003d \u00278083\u0027,"},{"line_number":248,"context_line":"  $cfapi_bind_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":249,"context_line":") {"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_41a45e07","line":248,"in_reply_to":"da85f559_b62eb2a3","updated":"2015-11-13 12:22:21.000000000","message":"and those too","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"}],"manifests/service_broker.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ebea7247639a7cfd20f804e663aa47df28371866","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  $manage_service \u003d false,"},{"line_number":33,"context_line":"  $enabled        \u003d true,"},{"line_number":34,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":35,"context_line":"  $cfapi_host           \u003d \u0027127.0.0.1\u0027,"},{"line_number":36,"context_line":"  $cfapi_port           \u003d 8083,"},{"line_number":37,"context_line":"  $sync_db        \u003d true,"},{"line_number":38,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_16ad3e31","line":35,"updated":"2015-11-13 12:15:44.000000000","message":"aligment","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"7d4143738033e44d2d6aee2d50d3e0dc14cd74a7","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  package { \u0027murano-cfapi\u0027:"},{"line_number":61,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":62,"context_line":"    name   \u003d\u003e $::murano::params::api_package_name,"},{"line_number":63,"context_line":"  }"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  service { \u0027murano-cfapi\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_4140de07","line":62,"updated":"2015-11-13 12:22:21.000000000","message":"you should add cfapi_package_name parameter to params class and use it instead $::murano::params::api_package_name","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"7d4143738033e44d2d6aee2d50d3e0dc14cd74a7","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  service { \u0027murano-cfapi\u0027:"},{"line_number":66,"context_line":"    ensure  \u003d\u003e $service_ensure,"},{"line_number":67,"context_line":"    name    \u003d\u003e $::murano::params::api_service_name,"},{"line_number":68,"context_line":"    enable  \u003d\u003e $enabled,"},{"line_number":69,"context_line":"    require \u003d\u003e Package[\u0027murano-cfapi\u0027],"},{"line_number":70,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_e151d2d9","line":67,"updated":"2015-11-13 12:22:21.000000000","message":"ditto","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ebea7247639a7cfd20f804e663aa47df28371866","unresolved":false,"context_lines":[{"line_number":73,"context_line":"  Murano_paste_ini_config\u003c||\u003e ~\u003e Service[\u0027murano-cfapi\u0027]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  if $sync_db {"},{"line_number":76,"context_line":"    include ::murano::db::sync"},{"line_number":77,"context_line":"  }"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_16745ecd","line":76,"updated":"2015-11-13 12:15:44.000000000","message":"is this services requires db sync?","commit_id":"b96f4c2cf1e8dc179ef178b5bdbd10d221b686e7"}],"spec/acceptance/basic_murano_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"02046fd91ae3c7d6d8bb07144d92803977f84bc9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":114,"context_line":"          }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"          Class[\u0027::keystone\u0027] -\u003e Class[\u0027::murano::db::mysql\u0027]"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"      EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a8ffd7b_6159ab34","line":116,"updated":"2015-11-28 16:00:22.000000000","message":"why do you have this? ^\nI have never seen that before and we should not have this code.","commit_id":"a949026812579e53f6db536a768f8695eb3bcdcb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"04bc2cf5858e86775cedaa329e76b50a5b92174d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":114,"context_line":"          }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"          Class[\u0027::keystone\u0027] -\u003e Class[\u0027::murano::db::mysql\u0027]"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"      EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a8ffd7b_2506aa1c","line":116,"in_reply_to":"9a8ffd7b_02da7ce8","updated":"2015-12-02 11:55:00.000000000","message":"Agree with Nikolay, it is out of scope for this patch.","commit_id":"a949026812579e53f6db536a768f8695eb3bcdcb"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"13dd7fede405f542e53cabf4314c0c22aac0c46b","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":114,"context_line":"          }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"          Class[\u0027::keystone\u0027] -\u003e Class[\u0027::murano::db::mysql\u0027]"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"      EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a8ffd7b_92fc7f3f","line":116,"in_reply_to":"9a8ffd7b_6159ab34","updated":"2015-12-02 10:24:51.000000000","message":"Agree, ordering should not be defined for acceptance tests, AFAIK. Although this is out of the patch scope, could you please fix it as well?","commit_id":"a949026812579e53f6db536a768f8695eb3bcdcb"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"7e61f230f5c238ef97998ca35412cc92fdbc0018","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            password \u003d\u003e \u0027a_big_secret\u0027,"},{"line_number":114,"context_line":"          }"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"          Class[\u0027::keystone\u0027] -\u003e Class[\u0027::murano::db::mysql\u0027]"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"      }"},{"line_number":119,"context_line":"      EOS"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"9a8ffd7b_02da7ce8","line":116,"in_reply_to":"9a8ffd7b_92fc7f3f","updated":"2015-12-02 11:49:31.000000000","message":"I\u0027m always put \u0027-1\u0027 on review if somebody do smthg which is out of scope of the patch. So, I don\u0027t do it in this patch.","commit_id":"a949026812579e53f6db536a768f8695eb3bcdcb"}],"spec/classes/murano_cfapi_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b324918a2f7e91ce44535fc7d0cec7d59b2de741","unresolved":false,"context_lines":[{"line_number":3,"context_line":"describe \u0027murano::cfapi\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  shared_examples_for \u0027murano-cfapi\u0027 do"},{"line_number":6,"context_line":"    it { is_expected.to contain_class(\u0027murano::cfapi\u0027) }"},{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  context \u0027on a RedHat osfamily\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"ba8a016a_5202823e","line":6,"updated":"2015-11-18 15:01:09.000000000","message":"please add tests for config params, like here https://github.com/openstack/puppet-murano/blob/master/spec/classes/murano_init_spec.rb with defaults and when passed new.","commit_id":"8140066c134450567724f8aa43e7587f5c6187a2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3691d8d11da2accd1a4886d719fe03f301e8bd81","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    it { is_expected.to contain_class(\u0027murano::params\u0027) }"},{"line_number":11,"context_line":"    it { is_expected.to contain_class(\u0027murano::policy\u0027) }"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"    it { is_expected.to contain_murano_config(\u0027DEFAULT/cfapi_bind_host\u0027).with_value(\u0027127.0.0.1\u0027) }"},{"line_number":14,"context_line":"    it { is_expected.to contain_murano_config(\u0027DEFAULT/cfapi_bind_port\u0027).with_value(8083) }"},{"line_number":15,"context_line":"  end"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a8ffd7b_25a22afd","line":13,"updated":"2015-12-02 11:57:36.000000000","message":"should be \u003cSERVICE DEFAULT\u003e (https://review.openstack.org/#/c/247482/5/spec/classes/murano_api_spec.rb)","commit_id":"10bc95d67f5d20ce53748fb8d0e061119611764a"}]}