)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5d859df183dd9bc021db1464cafbc43960bbdab4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alexey Deryugin \u003caderyugin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 17:40:12 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect configuration for Murano Service Broker API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib0c9bcf44d8b125089e17856b2fdb49bf1adebf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_5b294c36","line":7,"updated":"2015-12-07 14:43:38.000000000","message":"Please add more information to the commit message","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bc548216a5c5530cf6a6fe2dfa49f3880b6e2716","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incorrect configuration for Murano Service Broker API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" - add missing config parameters and change section"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib0c9bcf44d8b125089e17856b2fdb49bf1adebf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a740942_be561e28","line":9,"updated":"2015-12-07 15:01:57.000000000","message":"add endpoint for cfapi service","commit_id":"20c91ea0d7f945a8e801b003fe9185634c9764df"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"41df439812ddb64acbc020c359d54cd386ab0c5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix incorrect configuration for Murano Service Broker API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":" - add missing config parameters and change section"},{"line_number":10,"context_line":" - update acceptance tests"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib0c9bcf44d8b125089e17856b2fdb49bf1adebf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_f4728510","line":10,"updated":"2015-12-07 15:34:36.000000000","message":"add new endpoint for cfapi","commit_id":"bdcb903d0e921fce5f71987807ea73af17ec95d5"}],"manifests/cfapi.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4efe4f687c7f4c7a9a5995286c10f75127deffc8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to $::os_service_default."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_93a8fe8e","line":21,"updated":"2015-12-07 14:03:35.000000000","message":"shouldn\u0027t be service default. It is required parameter.","commit_id":"140bcf8f72963ea113175d5c889b0a2914e2bc51"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"9ce9a5a27eb6d90069ad8897596476b92382341f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to $::os_service_default."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_689c7c5d","line":21,"in_reply_to":"7a740942_93a8fe8e","updated":"2015-12-07 14:31:39.000000000","message":"fixed","commit_id":"140bcf8f72963ea113175d5c889b0a2914e2bc51"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4efe4f687c7f4c7a9a5995286c10f75127deffc8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to $::os_service_default."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*auth_uri*]"},{"line_number":32,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":33,"context_line":"#  Defaults to $::os_service_default."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class murano::cfapi("}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_137c0e1e","line":32,"updated":"2015-12-07 14:03:35.000000000","message":"see init.pp class. Shouldn\u0027t be os_service_default","commit_id":"140bcf8f72963ea113175d5c889b0a2914e2bc51"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"9ce9a5a27eb6d90069ad8897596476b92382341f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#  Defaults to $::os_service_default."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*auth_uri*]"},{"line_number":32,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":33,"context_line":"#  Defaults to $::os_service_default."},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"class murano::cfapi("}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_68b31cea","line":32,"in_reply_to":"7a740942_137c0e1e","updated":"2015-12-07 14:31:39.000000000","message":"fixed","commit_id":"140bcf8f72963ea113175d5c889b0a2914e2bc51"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"44a884d125d9043ab6e16809b4e8e74c93d59781","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  $manage_service \u003d true,"},{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $tenant         \u003d \u0027admin\u0027,"},{"line_number":40,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":42,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_1b3ae4cc","line":39,"updated":"2015-12-07 14:37:53.000000000","message":"why tenant is admin? Endpoint created with \u0027services\u0027. AFAIK, you shoud use tenant, which was created for user.\n\nThe same problem in murano in init.pp. I\u0027m not sure, but it is not ok.","commit_id":"e80b79438a27998af2deb6b1684af72d24543aaf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fa8f4677ed4a05656d96b89de5a447fc301a2015","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027admin\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_dbec5cf5","line":21,"updated":"2015-12-07 14:43:54.000000000","message":"service","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5d859df183dd9bc021db1464cafbc43960bbdab4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#  (Optional) Port on which murano cloudfoundry api should listen"},{"line_number":29,"context_line":"#  Defaults to $::os_service_default."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*auth_uri*]"},{"line_number":32,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":33,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027."},{"line_number":34,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_fb97d845","line":31,"updated":"2015-12-07 14:43:38.000000000","message":"Is it auth_urI or auth_urL as it\u0027s in parameters?","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fa8f4677ed4a05656d96b89de5a447fc301a2015","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#  (Optional) Port on which murano cloudfoundry api should listen"},{"line_number":29,"context_line":"#  Defaults to $::os_service_default."},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*auth_uri*]"},{"line_number":32,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":33,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v2.0/\u0027."},{"line_number":34,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_7ba3e8b2","line":31,"updated":"2015-12-07 14:43:54.000000000","message":"auth_url","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"787d1975e0cd5f0358157db1ae91f92b4fc12bfc","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027service\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a740942_76899674","line":21,"updated":"2015-12-08 06:50:07.000000000","message":"better use \u0027admin\u0027 here.","commit_id":"178252465d1bca9a71d4eb6e4b7abba1373b714e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027admin\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_9ae0e097","line":21,"updated":"2015-12-08 09:41:33.000000000","message":"you shouldn\u0027t hardcode fuel specific parameters here.\n\ntenant should be set as required parameter, because we don\u0027t know, which tenant will be used by user.","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"4466d88988c766d8b05ace2b723983967eb2fb7e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027admin\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_8be2d02d","line":21,"in_reply_to":"7a740942_4d1f206c","updated":"2015-12-08 10:17:48.000000000","message":"Looks like good suggestion, thx, Denis.","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b67555bbaa10dea12f96d0f62dfeca1d3ecc8899","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027admin\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_4d1f206c","line":21,"in_reply_to":"7a740942_6dabfc75","updated":"2015-12-08 09:59:41.000000000","message":"It means, that some user which will use this class, should have \u0027admin\u0027 tenant by default. This is not correct. We can use \u0027service\u0027 tenant here, but cfapi needs tenant which will used exactly by user. So, will be better set this parameter as required.","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e03054e912fb680bf26e5fc470588f48070199d7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Optional) Tenant for admin_username"},{"line_number":21,"context_line":"#  Defaults to \u0027admin\u0027."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*bind_host*]"},{"line_number":24,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_6dabfc75","line":21,"in_reply_to":"7a740942_9ae0e097","updated":"2015-12-08 09:54:20.000000000","message":"it\u0027s not a fuel specific value, it\u0027s internal default of murano-cfapi","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"d4c69adeada257a6e4a43bc974dbf86cf44d3b89","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $tenant         \u003d \u0027admin\u0027,"},{"line_number":40,"context_line":"  $bind_host      \u003d \u0027127.0.0.1\u0027,"},{"line_number":41,"context_line":"  $bind_port      \u003d \u00278083\u0027,"},{"line_number":42,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_7a75f4f7","line":40,"updated":"2015-12-08 09:37:36.000000000","message":"Why do you switch defaults to hard-coded values?","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $tenant         \u003d \u0027admin\u0027,"},{"line_number":40,"context_line":"  $bind_host      \u003d \u0027127.0.0.1\u0027,"},{"line_number":41,"context_line":"  $bind_port      \u003d \u00278083\u0027,"},{"line_number":42,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_9a49c0b9","line":40,"in_reply_to":"7a740942_7a75f4f7","updated":"2015-12-08 09:41:33.000000000","message":"Agree.","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e03054e912fb680bf26e5fc470588f48070199d7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $tenant         \u003d \u0027admin\u0027,"},{"line_number":40,"context_line":"  $bind_host      \u003d \u0027127.0.0.1\u0027,"},{"line_number":41,"context_line":"  $bind_port      \u003d \u00278083\u0027,"},{"line_number":42,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_ad41e4aa","line":40,"in_reply_to":"7a740942_9a49c0b9","updated":"2015-12-08 09:54:20.000000000","message":"I\u0027ve switched to this values in case of problems with $::os_service_default - It doesn\u0027t works","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b67555bbaa10dea12f96d0f62dfeca1d3ecc8899","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $tenant         \u003d \u0027admin\u0027,"},{"line_number":40,"context_line":"  $bind_host      \u003d \u0027127.0.0.1\u0027,"},{"line_number":41,"context_line":"  $bind_port      \u003d \u00278083\u0027,"},{"line_number":42,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":43,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_ed6a8cec","line":40,"in_reply_to":"7a740942_ad41e4aa","updated":"2015-12-08 09:59:41.000000000","message":"What do you mean by \u0027It doesn\u0027t works\u0027? Murano-cfapi doesn\u0027t have default values for those parameters (host, port)? Or what?","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"01e37c479c008a0101c55d5ff1d97a78da6a7aef","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Required) Tenant for cloudfoundry api"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*bind_host*]"},{"line_number":23,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"},{"line_number":24,"context_line":"#  Defaults to $::os_service_default."},{"line_number":25,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a740942_f098956c","line":22,"updated":"2015-12-10 13:33:31.000000000","message":"because this parameter wasn\u0027t released - i think it can be renamed.","commit_id":"8f3cd128f4b6b6bbb5f16ec6aa7596815e18e25d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b8e2d0c33d88551101eef148b6cb61ffbe3856b9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# [*tenant*]"},{"line_number":20,"context_line":"#  (Required) Tenant for cloudfoundry api"},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*bind_host*]"},{"line_number":23,"context_line":"#  (Optional) Host on which murano cloudfoundry api should listen"},{"line_number":24,"context_line":"#  Defaults to $::os_service_default."},{"line_number":25,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a7e1126_7541a537","line":22,"updated":"2015-12-18 19:56:53.000000000","message":"Since this wasn\u0027t part of the liberty release I guess this rename is ok since there shouldn\u0027t be an official release with these variable names.  But this is totally not backwards compatible...","commit_id":"e20ac6e9742a5bd84ac67f3923430c769bac0ba7"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb395181da4ba64d548ff7855eac160108307e10","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_647b0c7c","line":40,"updated":"2016-01-14 19:49:57.000000000","message":"the last 2 lines are not backport compatible and will break the interface. Is it ok?","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e4e8d641126cdb97b796e463951d9d7d7b0bbe14","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $enabled        \u003d true,"},{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_e324b20d","line":40,"in_reply_to":"da6ed579_647b0c7c","updated":"2016-01-15 11:03:37.000000000","message":"These parameters were not released, so, i think that\u0027s ok.","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb395181da4ba64d548ff7855eac160108307e10","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_847e4068","line":41,"updated":"2016-01-14 19:49:57.000000000","message":"Is it possible to use versionless endpoint? We\u0027re currently try to use them everywhere we can.","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c4e512e8df554ef240a9c8e24c493e095d612596","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7a5de9d1_c2eb3c77","line":41,"in_reply_to":"7a5de9d1_2939de41","updated":"2016-01-28 16:18:26.000000000","message":"Can you post a link where it is written down? :)","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"f1aba75d18c826014b380ee62be0deae21f2e2ca","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7a5de9d1_70ab32d7","line":41,"in_reply_to":"7a5de9d1_c2eb3c77","updated":"2016-01-28 16:33:03.000000000","message":"http://murano.readthedocs.org/en/latest/install/manual.html","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e4e8d641126cdb97b796e463951d9d7d7b0bbe14","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da6ed579_c3708e0d","line":41,"in_reply_to":"da6ed579_847e4068","updated":"2016-01-15 11:03:37.000000000","message":"That\u0027s good question. Murano team, waiting for your answer.","commit_id":"93077d6308550f688f4304a8853177478dc8927f"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"f08f1b7539048e2ab13fb3d6853ec0b58c697839","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $bind_host      \u003d $::os_service_default,"},{"line_number":40,"context_line":"  $bind_port      \u003d $::os_service_default,"},{"line_number":41,"context_line":"  $auth_url       \u003d \u0027http://127.0.0.1:5000/v2.0/\u0027,"},{"line_number":42,"context_line":") {"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  include ::murano::params"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"7a5de9d1_2939de41","line":41,"in_reply_to":"da6ed579_c3708e0d","updated":"2016-01-28 14:55:21.000000000","message":"According to documentation, Murano doesn\u0027t support versionless endpoint.","commit_id":"93077d6308550f688f4304a8853177478dc8927f"}],"manifests/keystone/cfapi_auth.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"44a884d125d9043ab6e16809b4e8e74c93d59781","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $service_name        \u003d undef,"},{"line_number":66,"context_line":"  $auth_name           \u003d \u0027murano\u0027,"},{"line_number":67,"context_line":"  $email               \u003d \u0027murano@localhost\u0027,"},{"line_number":68,"context_line":"  $tenant              \u003d \u0027services\u0027,"},{"line_number":69,"context_line":"  $service_type        \u003d \u0027service_broker\u0027,"},{"line_number":70,"context_line":"  $service_description \u003d \u0027Murano Service Broker API\u0027,"},{"line_number":71,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_08613805","line":68,"updated":"2015-12-07 14:37:53.000000000","message":"service","commit_id":"e80b79438a27998af2deb6b1684af72d24543aaf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fa8f4677ed4a05656d96b89de5a447fc301a2015","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*auth_name*]"},{"line_number":15,"context_line":"#   (Optional) Username for murano service."},{"line_number":16,"context_line":"#   Defaults to \u0027murano\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*email*]"},{"line_number":19,"context_line":"#   (Optional) Email for murano user."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_7b8a081d","line":16,"updated":"2015-12-07 14:43:54.000000000","message":"ditto","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fa8f4677ed4a05656d96b89de5a447fc301a2015","unresolved":false,"context_lines":[{"line_number":63,"context_line":"class murano::keystone::cfapi_auth("},{"line_number":64,"context_line":"  $password,"},{"line_number":65,"context_line":"  $service_name        \u003d undef,"},{"line_number":66,"context_line":"  $auth_name           \u003d \u0027murano\u0027,"},{"line_number":67,"context_line":"  $email               \u003d \u0027murano@localhost\u0027,"},{"line_number":68,"context_line":"  $tenant              \u003d \u0027service\u0027,"},{"line_number":69,"context_line":"  $service_type        \u003d \u0027service_broker\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a740942_1b95043e","line":66,"updated":"2015-12-07 14:43:54.000000000","message":"murano-cfapi or whatever","commit_id":"60e2aec3ca90859799d7e51601508b0177d673dd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   Defaults to the value of auth_name."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*auth_name*]"},{"line_number":15,"context_line":"#   (Optional) Username for murano service."},{"line_number":16,"context_line":"#   Defaults to \u0027murano-cfapi\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*email*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_7a56542b","line":15,"updated":"2015-12-08 09:41:33.000000000","message":"murano cfapi","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e03054e912fb680bf26e5fc470588f48070199d7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   Defaults to the value of auth_name."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*auth_name*]"},{"line_number":15,"context_line":"#   (Optional) Username for murano service."},{"line_number":16,"context_line":"#   Defaults to \u0027murano-cfapi\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*email*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_ad6fa429","line":15,"in_reply_to":"7a740942_7a56542b","updated":"2015-12-08 09:54:20.000000000","message":"What does this comment means?","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"4466d88988c766d8b05ace2b723983967eb2fb7e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   Defaults to the value of auth_name."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"# [*auth_name*]"},{"line_number":15,"context_line":"#   (Optional) Username for murano service."},{"line_number":16,"context_line":"#   Defaults to \u0027murano-cfapi\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*email*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_0b44a018","line":15,"in_reply_to":"7a740942_ad6fa429","updated":"2015-12-08 10:17:48.000000000","message":"not \u0027murano service\u0027, but \u0027murano-cfapi service\u0027","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   Defaults to \u0027murano-cfapi\u0027."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# [*email*]"},{"line_number":19,"context_line":"#   (Optional) Email for murano user."},{"line_number":20,"context_line":"#   Defaults to \u0027murano@localhost\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*tenant*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_1a7070db","line":19,"updated":"2015-12-08 09:41:33.000000000","message":"ditto","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   Defaults to \u0027murano@localhost\u0027."},{"line_number":21,"context_line":"#"},{"line_number":22,"context_line":"# [*tenant*]"},{"line_number":23,"context_line":"#   (Optional) Tenant for murano user."},{"line_number":24,"context_line":"#   Defaults to \u0027service\u0027."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_endpoint*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_fa41e463","line":23,"updated":"2015-12-08 09:41:33.000000000","message":"ditto","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3950a538c0fa0f4a3f23a1bad0f8a537690426d9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to \u0027service\u0027."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_endpoint*]"},{"line_number":27,"context_line":"#   (Optional) Should murano endpoint be configured?"},{"line_number":28,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*service_type*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_9af78058","line":27,"updated":"2015-12-08 09:41:33.000000000","message":"murano-cfapi","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b67555bbaa10dea12f96d0f62dfeca1d3ecc8899","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to \u0027service\u0027."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_endpoint*]"},{"line_number":27,"context_line":"#   (Optional) Should murano endpoint be configured?"},{"line_number":28,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*service_type*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_d0408736","line":27,"in_reply_to":"7a740942_4d67204d","updated":"2015-12-08 09:59:41.000000000","message":"Should murano endpoint be configured? \n\nYou are configuring murano-cfapi endpoint, aren\u0027t you?","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":13752,"name":"Alexey Deryugin","email":"aderiugin@mirantis.com","username":"velovec"},"change_message_id":"e03054e912fb680bf26e5fc470588f48070199d7","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to \u0027service\u0027."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*configure_endpoint*]"},{"line_number":27,"context_line":"#   (Optional) Should murano endpoint be configured?"},{"line_number":28,"context_line":"#   Defaults to \u0027true\u0027."},{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*service_type*]"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_4d67204d","line":27,"in_reply_to":"7a740942_9af78058","updated":"2015-12-08 09:54:20.000000000","message":"And this one?","commit_id":"6263a3680a5735c8dbcdb230918ae7400141d87c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bdec55894ad3d338f057e40c1a835e2279415517","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $service_name        \u003d undef,"},{"line_number":66,"context_line":"  $auth_name           \u003d \u0027murano-cfapi\u0027,"},{"line_number":67,"context_line":"  $email               \u003d \u0027murano@localhost\u0027,"},{"line_number":68,"context_line":"  $tenant              \u003d \u0027service\u0027,"},{"line_number":69,"context_line":"  $service_type        \u003d \u0027service_broker\u0027,"},{"line_number":70,"context_line":"  $service_description \u003d \u0027Murano Service Broker API\u0027,"},{"line_number":71,"context_line":"  $configure_endpoint  \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"da6ed579_8209e797","line":68,"updated":"2016-01-12 15:30:34.000000000","message":"other modules have \u0027services\u0027, please be consistent.","commit_id":"e20ac6e9742a5bd84ac67f3923430c769bac0ba7"}],"spec/shared_examples.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"01e37c479c008a0101c55d5ff1d97a78da6a7aef","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  context \u0027with default parameters\u0027 do"},{"line_number":64,"context_line":"    it \u0027installs package and service\u0027 do"},{"line_number":65,"context_line":"      is_expected.to contain_package(service[:name]).with({"},{"line_number":66,"context_line":"        :name   \u003d\u003e service[:package_name],"},{"line_number":67,"context_line":"        :ensure \u003d\u003e \u0027present\u0027,"},{"line_number":68,"context_line":"        :notify \u003d\u003e [\"Service[#{service[:name]}]\"]"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"7a740942_1001a16a","line":65,"updated":"2015-12-10 13:33:31.000000000","message":"you should use existing shared_examples for service and package.","commit_id":"8f3cd128f4b6b6bbb5f16ec6aa7596815e18e25d"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"fc753aa7dc70978e58ebdc452fef3eb585707011","unresolved":false,"context_lines":[{"line_number":7,"context_line":"shared_examples \u0027generic murano service\u0027 do |service|"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  context \u0027with default parameters\u0027 do"},{"line_number":10,"context_line":"    let :context_params do "},{"line_number":11,"context_line":"      { }"},{"line_number":12,"context_line":"    end"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3a7e1126_5ca08990","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":27},"updated":"2015-12-18 00:16:52.000000000","message":"This whitespace is needed?","commit_id":"c280d069d1f85154225f3edff0f53cc0d8f19855"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"32d646fbb1916294e413c51a1aad34b11b488dcf","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        :package_ensure \u003d\u003e \u00272014.2-1\u0027 }"},{"line_number":32,"context_line":"    end"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    let :params do "},{"line_number":35,"context_line":"      context_params.merge(service[:extra_params].nil? ? {} : service[:extra_params])"},{"line_number":36,"context_line":"    end"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3a7e1126_e4b0a945","line":34,"range":{"start_line":34,"start_character":18,"end_line":34,"end_character":19},"updated":"2015-12-18 10:26:30.000000000","message":"same here, whitespace","commit_id":"c280d069d1f85154225f3edff0f53cc0d8f19855"},{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"fc753aa7dc70978e58ebdc452fef3eb585707011","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        :manage_service \u003d\u003e false }"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    let :params do "},{"line_number":59,"context_line":"      context_params.merge(service[:extra_params].nil? ? {} : service[:extra_params])"},{"line_number":60,"context_line":"    end"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3a7e1126_1caa0171","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":19},"updated":"2015-12-18 00:16:52.000000000","message":"same question","commit_id":"c280d069d1f85154225f3edff0f53cc0d8f19855"}]}