)]}'
{"manifests/dashboard.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1ca5821ac0565da86d0afc3a47f84e7e2e3e67e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*api_url*]"},{"line_number":12,"context_line":"#  (Optional) API url for murano-dashboard"},{"line_number":13,"context_line":"#  Defaults to \u0027undef\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*repo_url*]"},{"line_number":16,"context_line":"#  (Optional) Application repository URL for murano-dashboard"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_7e95483e","line":13,"updated":"2015-12-10 17:18:05.000000000","message":"you\u0027re breaking backward compatibility.","commit_id":"9ecb51e27bf0d2ddd501a07d19b1e440a41062b8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2bf1c6164205562d4194e5a0dad3c115d0f7e58d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*api_url*]"},{"line_number":12,"context_line":"#  (Optional) API url for murano-dashboard"},{"line_number":13,"context_line":"#  Defaults to \u0027undef\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*repo_url*]"},{"line_number":16,"context_line":"#  (Optional) Application repository URL for murano-dashboard"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_d459bb36","line":13,"in_reply_to":"7a740942_7e95483e","updated":"2015-12-10 17:42:37.000000000","message":"Agree, mark this parameter as deprecated then.","commit_id":"9ecb51e27bf0d2ddd501a07d19b1e440a41062b8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f1ca5821ac0565da86d0afc3a47f84e7e2e3e67e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d undef,"},{"line_number":42,"context_line":"  $repo_url              \u003d undef,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/murano-dashboard\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"},{"line_number":46,"context_line":"  $dashboard_debug_level \u003d \u0027DEBUG\u0027,"},{"line_number":47,"context_line":"  $client_debug_level    \u003d \u0027ERROR\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_9e903450","line":44,"updated":"2015-12-10 17:18:05.000000000","message":"you\u0027re also breaking backward compatibility and moreover you missed to update doc.","commit_id":"9ecb51e27bf0d2ddd501a07d19b1e440a41062b8"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2bf1c6164205562d4194e5a0dad3c115d0f7e58d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $api_url               \u003d undef,"},{"line_number":42,"context_line":"  $repo_url              \u003d undef,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/murano-dashboard\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"},{"line_number":46,"context_line":"  $dashboard_debug_level \u003d \u0027DEBUG\u0027,"},{"line_number":47,"context_line":"  $client_debug_level    \u003d \u0027ERROR\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a740942_946333dd","line":44,"in_reply_to":"7a740942_9e903450","updated":"2015-12-10 17:42:37.000000000","message":"Well, this path is not correct :( we can\u0027t catch it here in upstream untill we don\u0027t have dashboard in acceptance tests.","commit_id":"9ecb51e27bf0d2ddd501a07d19b1e440a41062b8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"332276d488d91a7f48851530b91d42def8429d81","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d undef,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/murano-dashboard\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"},{"line_number":46,"context_line":"  $dashboard_debug_level \u003d \u0027DEBUG\u0027,"},{"line_number":47,"context_line":"  $client_debug_level    \u003d \u0027ERROR\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a710552_1c422a3f","line":44,"updated":"2015-12-15 15:19:38.000000000","message":"you\u0027re breaking backward compatibility and you did not update the doc.","commit_id":"5f33cab8731de973e60907577074feac40661ecb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"95a985b5a4f5089877aa6a91f6d281e6ae002584","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  $package_ensure        \u003d \u0027present\u0027,"},{"line_number":42,"context_line":"  $repo_url              \u003d undef,"},{"line_number":43,"context_line":"  $collect_static_script \u003d \u0027/usr/share/openstack-dashboard/manage.py\u0027,"},{"line_number":44,"context_line":"  $metadata_dir          \u003d \u0027/var/cache/murano-dashboard\u0027,"},{"line_number":45,"context_line":"  $max_file_size         \u003d \u00275\u0027,"},{"line_number":46,"context_line":"  $dashboard_debug_level \u003d \u0027DEBUG\u0027,"},{"line_number":47,"context_line":"  $client_debug_level    \u003d \u0027ERROR\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5a710552_8699ae21","line":44,"in_reply_to":"5a710552_1c422a3f","updated":"2015-12-16 13:02:58.000000000","message":"Emilien, this is not break backward compatibility, because it is wrong path. We missed it before, because we don\u0027t have acceptance tests for murano-dashboard now. So, it also will be backported to stable/liberty.\n\nAlso i think we should finally prepare acceptance tests for this class. Alexey, is it possible?","commit_id":"5f33cab8731de973e60907577074feac40661ecb"}]}