)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ee8a57b5191f05c571976b4bf32cabf7270eafe6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-02-12 15:51:22 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Switch murano to use keystone API v3 by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I198f0388764605083e9272645d2b9cffd6fe5cfa"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a57f1b5_b927f5c8","line":8,"updated":"2016-02-12 14:56:15.000000000","message":"can you please provide more info about this switch? What\u0027s the reason for that, may be some bugs or blueprints to Murano code?","commit_id":"de565b09fee9c53402ead87081b5dee0a1666ba6"}],"lib/puppet/provider/murano.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"487ed34c61377d025340530ad058c4b2d882967f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  def self.get_murano_credentials"},{"line_number":39,"context_line":"    #needed keys for authentication"},{"line_number":40,"context_line":"    auth_keys \u003d [\u0027auth_uri\u0027, \u0027auth_url\u0027, \u0027auth_plugin\u0027, \u0027tenant_name\u0027, \u0027username\u0027,"},{"line_number":41,"context_line":"                 \u0027password\u0027, \u0027region_name\u0027, \u0027project_domain_id\u0027, \u0027project_name\u0027,"},{"line_number":42,"context_line":"                 \u0027user_domain_id\u0027]"},{"line_number":43,"context_line":"    obsolete_keys \u003d [\u0027auth_uri\u0027, \u0027admin_user\u0027, \u0027admin_tenant_name\u0027, \u0027identity_uri\u0027,"},{"line_number":44,"context_line":"                     \u0027admin_password\u0027]"}],"source_content_type":"text/x-ruby","patch_set":18,"id":"9aed3d3a_b395c2e5","line":41,"range":{"start_line":41,"start_character":30,"end_line":41,"end_character":41},"updated":"2016-02-26 11:13:43.000000000","message":"this is non-required value, it shouldn\u0027t be in this hash, please add additional check for this.\n\nlike here:\n\nhttps://github.com/openstack/puppet-nova/blob/master/lib/puppet/provider/nova.rb#L42-L50\n\nauth_keys must contain only required keys at all.","commit_id":"87e7803aef3fa4ee2afb1e57e01e3e42bb6264fd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d6eee0ed3cc9310f60f2e0f2cf7f39a635912e46","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if conf and conf[\u0027keystone_authtoken\u0027] and"},{"line_number":46,"context_line":"        auth_keys.all?{|k| !conf[\u0027keystone_authtoken\u0027][k].nil?}"},{"line_number":47,"context_line":"      creds \u003d Hash[ auth_keys.map { |k| [k, conf[\u0027keystone_authtoken\u0027][k].strip] } ]"},{"line_number":48,"context_line":"      if conf and conf[\u0027keystone_authtoken\u0027]:"},{"line_number":49,"context_line":"          creds[\u0027region_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027]"},{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    elsif conf and conf[\u0027keystone_authtoken\u0027] and"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9aed3d3a_13efaa1e","line":48,"range":{"start_line":48,"start_character":9,"end_line":48,"end_character":13},"updated":"2016-03-01 10:10:37.000000000","message":"no need to check it again","commit_id":"cb5df523a9d2e3502b1a8d5dd6dc7034835861ef"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d6eee0ed3cc9310f60f2e0f2cf7f39a635912e46","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    if conf and conf[\u0027keystone_authtoken\u0027] and"},{"line_number":46,"context_line":"        auth_keys.all?{|k| !conf[\u0027keystone_authtoken\u0027][k].nil?}"},{"line_number":47,"context_line":"      creds \u003d Hash[ auth_keys.map { |k| [k, conf[\u0027keystone_authtoken\u0027][k].strip] } ]"},{"line_number":48,"context_line":"      if conf and conf[\u0027keystone_authtoken\u0027]:"},{"line_number":49,"context_line":"          creds[\u0027region_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027]"},{"line_number":50,"context_line":"      end"},{"line_number":51,"context_line":"    elsif conf and conf[\u0027keystone_authtoken\u0027] and"}],"source_content_type":"text/x-ruby","patch_set":20,"id":"9aed3d3a_b3c7de94","line":48,"range":{"start_line":48,"start_character":44,"end_line":48,"end_character":45},"updated":"2016-03-01 10:10:37.000000000","message":"we don\u0027t use \u0027:\u0027 :)","commit_id":"cb5df523a9d2e3502b1a8d5dd6dc7034835861ef"}],"manifests/cfapi.pp":[{"author":{"_account_id":13962,"name":"Victor Ryzhenkin","email":"vryzhenkin@mirantis.com","username":"vryzhenkin"},"change_message_id":"ed028b51406aa46c30c6e0e917d778edcb7b6c0b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*auth_url*]"},{"line_number":31,"context_line":"#  (Optional) Public identity endpoint"},{"line_number":32,"context_line":"#  Defaults to \u0027http://127.0.0.1:5000/v3\u0027."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"class murano::cfapi("},{"line_number":35,"context_line":"  $tenant,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dae33548_34cfdc80","line":32,"range":{"start_line":32,"start_character":38,"end_line":32,"end_character":39},"updated":"2016-02-15 17:48:04.000000000","message":"let\u0027s be consistent with our patch in murano and remove versions.","commit_id":"6325e12ae6f649a616a32188f52d2924d5301ded"}],"manifests/init.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"c6b30355276fcdd84fcf526c6f3e11fd31d6db4e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  $database_retry_interval \u003d undef,"},{"line_number":226,"context_line":"  $database_max_overflow   \u003d undef,"},{"line_number":227,"context_line":"  $sync_db                 \u003d true,"},{"line_number":228,"context_line":"  $admin_user              \u003d \u0027murano\u0027,"},{"line_number":229,"context_line":"  $admin_tenant_name       \u003d \u0027service\u0027,"},{"line_number":230,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":231,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":232,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_981254b3","line":229,"range":{"start_line":228,"start_character":2,"end_line":229,"end_character":39},"updated":"2016-02-20 10:13:35.000000000","message":"AFAIK these options are deprecated, do you plan to add modern and v3-specific options also?","commit_id":"6f7f84e1ef188e9f83d47ac095e3b6273a1d0516"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3e7e6749a55a3b17a694f82e36c138069d0cfc5e","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  $database_retry_interval \u003d undef,"},{"line_number":226,"context_line":"  $database_max_overflow   \u003d undef,"},{"line_number":227,"context_line":"  $sync_db                 \u003d true,"},{"line_number":228,"context_line":"  $admin_user              \u003d \u0027murano\u0027,"},{"line_number":229,"context_line":"  $admin_tenant_name       \u003d \u0027service\u0027,"},{"line_number":230,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":231,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":232,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_5ccebcb4","line":229,"range":{"start_line":228,"start_character":2,"end_line":229,"end_character":39},"in_reply_to":"bae84128_4ba0f89f","updated":"2016-02-22 18:11:44.000000000","message":"I think you can use options similar to options which I added here https://github.com/openstack/puppet-neutron/commit/7f06f8794db4f88573cd0dfc918e003a191e0488 , but please set project_* and user_* to some default values as they are required now. You can also check the latest options in devstack. This commit seams appropriate","commit_id":"6f7f84e1ef188e9f83d47ac095e3b6273a1d0516"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"07dce3d6b291725189b51098f59ffe3bece26997","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  $database_retry_interval \u003d undef,"},{"line_number":226,"context_line":"  $database_max_overflow   \u003d undef,"},{"line_number":227,"context_line":"  $sync_db                 \u003d true,"},{"line_number":228,"context_line":"  $admin_user              \u003d \u0027murano\u0027,"},{"line_number":229,"context_line":"  $admin_tenant_name       \u003d \u0027service\u0027,"},{"line_number":230,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":231,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":232,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_41c2fbe9","line":229,"range":{"start_line":228,"start_character":2,"end_line":229,"end_character":39},"in_reply_to":"bae84128_5ccebcb4","updated":"2016-02-24 08:18:17.000000000","message":"In devstack commit for support keystone v3 was reverted, but I get the idea from the commit you\u0027ve done.","commit_id":"6f7f84e1ef188e9f83d47ac095e3b6273a1d0516"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"48e27e3dd17e678c93ee9bdf16dbf95b8bde3111","unresolved":false,"context_lines":[{"line_number":225,"context_line":"  $database_retry_interval \u003d undef,"},{"line_number":226,"context_line":"  $database_max_overflow   \u003d undef,"},{"line_number":227,"context_line":"  $sync_db                 \u003d true,"},{"line_number":228,"context_line":"  $admin_user              \u003d \u0027murano\u0027,"},{"line_number":229,"context_line":"  $admin_tenant_name       \u003d \u0027service\u0027,"},{"line_number":230,"context_line":"  $auth_uri                \u003d \u0027http://127.0.0.1:5000\u0027,"},{"line_number":231,"context_line":"  $identity_uri            \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":232,"context_line":"  $signing_dir             \u003d \u0027/tmp/keystone-signing-muranoapi\u0027,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_4ba0f89f","line":229,"range":{"start_line":228,"start_character":2,"end_line":229,"end_character":39},"in_reply_to":"bae84128_981254b3","updated":"2016-02-20 10:57:17.000000000","message":"Sergey, can you point me to example of new v3-specific options? And do you think I should do it in that commit or another one?","commit_id":"6f7f84e1ef188e9f83d47ac095e3b6273a1d0516"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9d44d6f6e8ec3b6ef37511fc9fb60c539f027d58","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    }"},{"line_number":381,"context_line":"  }"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"  murano_config {"},{"line_number":384,"context_line":"      \u0027networking/default_dns\u0027:                  value \u003d\u003e $default_nameservers;"},{"line_number":385,"context_line":"  }"},{"line_number":386,"context_line":"  if $sync_db {"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bae84128_09d1d8fb","line":383,"range":{"start_line":383,"start_character":2,"end_line":383,"end_character":15},"updated":"2016-02-25 14:48:09.000000000","message":"you can move this call above, to another common parameters.","commit_id":"7ad121bd71bc374a9995296751fef5d98ce6a52f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"487ed34c61377d025340530ad058c4b2d882967f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"  $auth_url                \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":271,"context_line":"  $username                \u003d \u0027murano\u0027,"},{"line_number":272,"context_line":"  $password                \u003d false,"},{"line_number":273,"context_line":"  $tenant_name             \u003d \u0027services\u0027,"},{"line_number":274,"context_line":"  $region_name             \u003d $::os_service_default,"},{"line_number":275,"context_line":"  $project_domain_id       \u003d \u0027Default\u0027,"},{"line_number":276,"context_line":"  $project_name            \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"9aed3d3a_937ebee2","line":273,"range":{"start_line":273,"start_character":3,"end_line":273,"end_character":14},"updated":"2016-02-26 11:13:43.000000000","message":"tenant_name and project_name are same values, or for murano they are have different logic?","commit_id":"87e7803aef3fa4ee2afb1e57e01e3e42bb6264fd"}],"spec/unit/provider/murano_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"1c3f54f302c052282e625bc35b168ad2489075a4","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    it \u0027should set obsolete auth credentials in the environment\u0027 do"},{"line_number":82,"context_line":"      authenv \u003d {"},{"line_number":83,"context_line":"        :OS_AUTH_URL      \u003d\u003e obsolete_credential_hash[\u0027identity_uri\u0027] "},{"line_number":84,"context_line":"        :OS_USERNAME      \u003d\u003e obsolete_credential_hash[\u0027admin_user\u0027]"},{"line_number":85,"context_line":"        :OS_TENANT_NAME   \u003d\u003e obsolete_credential_hash[\u0027admin_tenant_name\u0027]"},{"line_number":86,"context_line":"        :OS_PASSWORD      \u003d\u003e obsolete_credential_hash[\u0027admin_password\u0027]"}],"source_content_type":"text/x-ruby","patch_set":21,"id":"7af24918_41413439","line":83,"range":{"start_line":83,"start_character":69,"end_line":83,"end_character":70},"updated":"2016-03-01 10:53:09.000000000","message":"Whitespace","commit_id":"834305047cae1b984f2ad85d352b831c8e5db2a2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1daec77547720305c66229f5e0dd17c6ae698bcc","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    it \u0027should set obsolete auth credentials in the environment\u0027 do"},{"line_number":82,"context_line":"      authenv \u003d {"},{"line_number":83,"context_line":"        :OS_AUTH_URL      \u003d\u003e obsolete_credential_hash[\u0027identity_uri\u0027]"},{"line_number":84,"context_line":"        :OS_USERNAME      \u003d\u003e obsolete_credential_hash[\u0027admin_user\u0027]"},{"line_number":85,"context_line":"        :OS_TENANT_NAME   \u003d\u003e obsolete_credential_hash[\u0027admin_tenant_name\u0027]"},{"line_number":86,"context_line":"        :OS_PASSWORD      \u003d\u003e obsolete_credential_hash[\u0027admin_password\u0027]"}],"source_content_type":"text/x-ruby","patch_set":22,"id":"7af24918_feb456d2","line":83,"updated":"2016-03-01 13:32:41.000000000","message":"missed \u0027,\u0027 and below","commit_id":"2b394a9b1e102f694b726c9d391671cf24a55afa"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0b0c31d3bed003f4c3140fab49085f463dc39ad6","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        :OS_PASSWORD      \u003d\u003e obsolete_credential_hash[\u0027admin_password\u0027],"},{"line_number":87,"context_line":"        :OS_ENDPOINT_TYPE \u003d\u003e \u0027intenalURL\u0027,"},{"line_number":88,"context_line":"      }"},{"line_number":89,"context_line":"      klass.expects(:get_murano_credentials).with().returns(credential_hash)"},{"line_number":90,"context_line":"      klass.expects(:withenv).with(authenv)"},{"line_number":91,"context_line":"      klass.auth_murano(\u0027test_retries\u0027)"},{"line_number":92,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":23,"id":"7af24918_8aefc8af","line":89,"range":{"start_line":89,"start_character":60,"end_line":89,"end_character":75},"updated":"2016-03-01 14:24:16.000000000","message":"obsolete_credential_hash","commit_id":"2d5b677b2df2ded8330a87b5724bdb70d21f7b7b"}]}
