)]}'
{"manifests/db.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d54d631318a6770ba78223cf06f8f5f030b523de","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $database_retry_interval_real \u003d pick($::murano::database_retry_interval, $database_retry_interval)"},{"line_number":56,"context_line":"  $database_max_overflow_real   \u003d pick($::murano::database_max_overflow, $database_max_overflow)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  validate_re($database_connection_real, \u0027^(mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  case $database_connection_real {"},{"line_number":61,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a18252c_53360004","line":58,"range":{"start_line":58,"start_character":15,"end_line":58,"end_character":39},"updated":"2016-04-12 14:55:55.000000000","message":"you don\u0027t need this validation and case below. it\u0027s already in oslo module: https://github.com/openstack/puppet-oslo/blob/master/manifests/db.pp\n\nPlease keep in mind that now backend package has db_backend_package title, so you probably need to update unit tests","commit_id":"609b32d2ec390501dcdf679df3f5927617168390"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"5d7c61a3908e634cdd8e68a039b2b9d701057076","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $database_retry_interval_real \u003d pick($::murano::database_retry_interval, $database_retry_interval)"},{"line_number":56,"context_line":"  $database_max_overflow_real   \u003d pick($::murano::database_max_overflow, $database_max_overflow)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  validate_re($database_connection_real, \u0027^(mysql(\\+pymysql)?|postgresql):\\/\\/(\\S+:\\S+@\\S+\\/\\S+)?\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"  case $database_connection_real {"},{"line_number":61,"context_line":"    /^mysql(\\+pymysql)?:\\/\\//: {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"5a18252c_ee20ff4b","line":58,"range":{"start_line":58,"start_character":15,"end_line":58,"end_character":39},"in_reply_to":"5a18252c_53360004","updated":"2016-04-12 14:59:58.000000000","message":"I will prefer to keep this here, because puppet-oslo supports more backends: mongodb, sqlite.\n\nI\u0027m not sure, that murano can work with these backends.\n\nSo, probably will be better to keep validation here, but remove case below.","commit_id":"609b32d2ec390501dcdf679df3f5927617168390"}]}
