)]}'
{"manifests/api.pp":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"3173b75355fe23fa812bec561d9978166ad52494","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $package_ensure \u003d \u0027present\u0027,"},{"line_number":35,"context_line":"  $host           \u003d $::os_service_default,"},{"line_number":36,"context_line":"  $port           \u003d $::os_service_default,"},{"line_number":37,"context_line":"  $api_workers    \u003d $::os_workers,"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  include ::murano::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f2577a7_2db1cde2","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":34},"updated":"2017-09-08 14:06:59.000000000","message":"I was thinking switch this to $workers","commit_id":"8a9efbed478d11ea603641cf043a63fe7c845021"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"3173b75355fe23fa812bec561d9978166ad52494","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  murano_config {"},{"line_number":53,"context_line":"    \u0027DEFAULT/bind_host\u0027: value \u003d\u003e $host;"},{"line_number":54,"context_line":"    \u0027DEFAULT/bind_port\u0027: value \u003d\u003e $port;"},{"line_number":55,"context_line":"    \u0027murano/api_workers\u0027: value \u003d\u003e $api_workers;"},{"line_number":56,"context_line":"  }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  package { \u0027murano-api\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5f2577a7_0db611db","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":48},"updated":"2017-09-08 14:06:59.000000000","message":"But keep this as api_workers because we can\u0027t switch up the configs obviously!","commit_id":"8a9efbed478d11ea603641cf043a63fe7c845021"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"7fea3566585d6443bb653b945a00ca9f6ebbd8d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#"},{"line_number":27,"context_line":"# [*workers*]"},{"line_number":28,"context_line":"#  (Optional) Number of workers for Murano Api"},{"line_number":29,"context_line":"#  Defaults to $::os_works"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"class murano::api("},{"line_number":32,"context_line":"  $manage_service \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f2577a7_6649b42f","line":29,"range":{"start_line":29,"start_character":18,"end_line":29,"end_character":26},"updated":"2017-09-14 14:05:46.000000000","message":"os_workers","commit_id":"549a17e3c07e0cab7b2afbfaee2728c9c3a79b75"}],"manifests/engine.pp":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"7fea3566585d6443bb653b945a00ca9f6ebbd8d5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  murano_config {"},{"line_number":43,"context_line":"    \u0027engine/engine_workers\u0027: value \u003d\u003e $workers;"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  package { \u0027murano-engine\u0027:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5f2577a7_6672d47d","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":47},"updated":"2017-09-14 14:05:46.000000000","message":"For other reviewers, this change happened here:\n\nhttps://github.com/openstack/murano/commit/23fbee8dcd484fc46b320188b22ab6def0311679#diff-fe280ac9c4e6445db36c1fdb1e25d8b2","commit_id":"549a17e3c07e0cab7b2afbfaee2728c9c3a79b75"}],"spec/classes/murano_api_spec.rb":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"7fea3566585d6443bb653b945a00ca9f6ebbd8d5","unresolved":false,"context_lines":[{"line_number":15,"context_line":"      let :params do {"},{"line_number":16,"context_line":"         :host        \u003d\u003e \u0027localhost\u0027,"},{"line_number":17,"context_line":"         :port        \u003d\u003e \u00271111\u0027,"},{"line_number":18,"context_line":"         :workers \u003d\u003e \u00274\u0027,"},{"line_number":19,"context_line":"      } end"},{"line_number":20,"context_line":"      it { is_expected.to contain_murano_config(\u0027DEFAULT/bind_host\u0027).with_value(\u0027localhost\u0027) }"},{"line_number":21,"context_line":"      it { is_expected.to contain_murano_config(\u0027DEFAULT/bind_port\u0027).with_value(\u00271111\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f2577a7_e6348495","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":20},"updated":"2017-09-14 14:05:46.000000000","message":"Small nit but because we have some changes, might as well address it, could you line this up with the two items above?","commit_id":"549a17e3c07e0cab7b2afbfaee2728c9c3a79b75"}]}