)]}'
{"manifests/agents/dhcp.pp":[{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"ed5cb7a7a03abb232556bdc409101cbe0d057b63","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        # CPNR is currently supported only on Redhat/CentOS based OS"},{"line_number":143,"context_line":"        fail(\"Unsupported osfamily ${::osfamily} for CPNR Driver\")"},{"line_number":144,"context_line":"      }"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"      validate_re($cpnr_http_server,\u0027(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\u0027)"},{"line_number":147,"context_line":"      validate_string($cpnr_http_user)"},{"line_number":148,"context_line":"      validate_string($cpnr_http_password)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba7be1f8_bede830f","line":145,"updated":"2015-02-24 02:44:31.000000000","message":"put everything below here in a class eg neutron::agents::dhcp::cpnr","commit_id":"0cb42b472bcc9c7aa76cd246713b990aebeaef0c"},{"author":{"_account_id":7567,"name":"Wei Tie","email":"nuaafe@gmail.com","username":"nuaafe"},"change_message_id":"b300c89a3433ed82d55a89f9b795de9fd5cf5729","unresolved":false,"context_lines":[{"line_number":150,"context_line":"      validate_re($cpnr_dhcp_server_addr,\u0027(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\u0027)"},{"line_number":151,"context_line":"      validate_re($cpnr_dhcp_server_port,\u0027^\\d+$\u0027)"},{"line_number":152,"context_line":"      validate_re($cpnr_dns_server_addr,\u0027(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\u0027)"},{"line_number":153,"context_line":"      validate_re($cpnr_dns_server_port,\u0027^\\d+$\u0027)"},{"line_number":154,"context_line":"      ensure_packages([\u0027openstack-cisco-cpnrdhcp-driver\u0027])"},{"line_number":155,"context_line":"      $enable_cpnr \u003d true"},{"line_number":156,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba7be1f8_e18cde37","line":153,"updated":"2015-02-24 03:29:22.000000000","message":"there is \"is_integer\" and \"is_ipaddress\" in puppet stdlib","commit_id":"0cb42b472bcc9c7aa76cd246713b990aebeaef0c"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"ed5cb7a7a03abb232556bdc409101cbe0d057b63","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      validate_re($cpnr_dhcp_server_port,\u0027^\\d+$\u0027)"},{"line_number":152,"context_line":"      validate_re($cpnr_dns_server_addr,\u0027(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\u0027)"},{"line_number":153,"context_line":"      validate_re($cpnr_dns_server_port,\u0027^\\d+$\u0027)"},{"line_number":154,"context_line":"      ensure_packages([\u0027openstack-cisco-cpnrdhcp-driver\u0027])"},{"line_number":155,"context_line":"      $enable_cpnr \u003d true"},{"line_number":156,"context_line":"    }"},{"line_number":157,"context_line":"    default: {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba7be1f8_dee177d1","line":154,"updated":"2015-02-24 02:44:31.000000000","message":"Might want to make this configurable so it can be set to \u0027latest\u0027","commit_id":"0cb42b472bcc9c7aa76cd246713b990aebeaef0c"}],"manifests/agents/dhcp/cpnr.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"7301963a08c9b8b5cc1abf6e12cb5b942a2b1011","unresolved":false,"context_lines":[{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*cpnr_http_server*]"},{"line_number":9,"context_line":"#  (required)"},{"line_number":10,"context_line":"#  Specifies the ip and port that the CPNR host is listening on."},{"line_number":11,"context_line":"#  Defaults to 127.0.0.1:8080"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba7be1f8_97dc5c76","line":8,"updated":"2015-03-01 22:23:54.000000000","message":"I would prefer these parameter names to not be prefixed with \u0027cpnr_\u0027, since the \u0027cpnr\u0027 part is evident from the name of the class. Config parameter names are usually identical to the config file parameter they are setting.","commit_id":"e58fdfd1e264c773e2a4711fccc91aa48fcdd3db"}]}