)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7567,"name":"Wei Tie","email":"nuaafe@gmail.com","username":"nuaafe"},"change_message_id":"bf18067741341ed55308b51c84a590e22e48d1c3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync DB when enabling FWAAS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I the DB is has not been sync neutron is going to fail while"},{"line_number":10,"context_line":"managing the firewall."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3cb5080a2416e0d0109cf7328da57cd1f8bbef5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_d5d80556","line":9,"updated":"2015-06-30 04:37:49.000000000","message":"I think the \"I\" here is a typo","commit_id":"7c3de163e5ec6171ecbc74347ed3f00ba0e76afc"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"8a6d57dacb8fed74f1628a123ca94b502a1477fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync DB when enabling FWAAS"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I the DB is has not been sync neutron is going to fail while"},{"line_number":10,"context_line":"managing the firewall."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I3cb5080a2416e0d0109cf7328da57cd1f8bbef5c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba3cc151_df625ed8","line":9,"in_reply_to":"ba3cc151_d5d80556","updated":"2015-06-30 08:04:28.000000000","message":"thanks i\u0027ll fix that","commit_id":"7c3de163e5ec6171ecbc74347ed3f00ba0e76afc"}],"manifests/db/sync.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"39a12de9900530ece4ccf826948a0a96352c4fda","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Defined type to execute neutron dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"define neutron::db::sync ("},{"line_number":5,"context_line":"  $service \u003d \u0027\u0027,"},{"line_number":6,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_2c72ee49","line":3,"updated":"2015-07-01 18:05:16.000000000","message":"As specified in the other commend I\u0027d rather see that back the way it was and create a specific neutron::db::fwaas::sync","commit_id":"58ae33c77323a84053fc783162355a5ebe2d0920"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"24a9e30af416f0363774889f6504b78dd1b1490a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Defined type to execute neutron dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"define neutron::db::sync ("},{"line_number":5,"context_line":"  $service \u003d \u0027\u0027,"},{"line_number":6,"context_line":") {"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  include neutron::params"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_02b81129","line":5,"updated":"2015-07-01 18:39:31.000000000","message":"beurk :-)","commit_id":"58ae33c77323a84053fc783162355a5ebe2d0920"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"68e27b8d6d3ff2a812342cc6a21c6adcbd2c9de3","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Defined type to execute neutron dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"define neutron::db::sync ("},{"line_number":5,"context_line":"  $service \u003d nil,"},{"line_number":6,"context_line":") {"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  include neutron::params"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_28915a47","line":5,"updated":"2015-07-02 10:05:18.000000000","message":"I would prefer to see \u0027undef\u0027 instead of \u0027nil\u0027!","commit_id":"906f27034c10a67d94e8156ce2c75f723cfc8574"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"b50a22b7142ed63a56bf92bfc0f031a5554c957f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Defined type to execute neutron dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"define neutron::db::sync ("},{"line_number":5,"context_line":"  $service \u003d nil,"},{"line_number":6,"context_line":") {"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  include neutron::params"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_7550750b","line":5,"in_reply_to":"ba3cc151_28915a47","updated":"2015-07-02 21:40:02.000000000","message":"i can change this","commit_id":"906f27034c10a67d94e8156ce2c75f723cfc8574"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"68e27b8d6d3ff2a812342cc6a21c6adcbd2c9de3","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  include neutron::params"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  if ($service !\u003d nil) {"},{"line_number":11,"context_line":"    $service_arg \u003d \"--service ${service}\""},{"line_number":12,"context_line":"    $command_title \u003d \"neutron-db-sync-$service\""},{"line_number":13,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_48961e40","line":10,"updated":"2015-07-02 10:05:18.000000000","message":"same here!","commit_id":"906f27034c10a67d94e8156ce2c75f723cfc8574"},{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"68e27b8d6d3ff2a812342cc6a21c6adcbd2c9de3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  Exec[$command_title] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  exec { $command_title:"},{"line_number":31,"context_line":"    command     \u003d\u003e \"neutron-db-manage ${service_arg} --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\","},{"line_number":32,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":33,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":34,"context_line":"    logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_e896123d","line":31,"updated":"2015-07-02 10:05:18.000000000","message":"Shouldn\u0027t --service ${service_arg}?","commit_id":"906f27034c10a67d94e8156ce2c75f723cfc8574"},{"author":{"_account_id":7462,"name":"Ivan Chavero","email":"ichavero@redhat.com","username":"ichavero"},"change_message_id":"b50a22b7142ed63a56bf92bfc0f031a5554c957f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  Exec[$command_title] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  exec { $command_title:"},{"line_number":31,"context_line":"    command     \u003d\u003e \"neutron-db-manage ${service_arg} --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\","},{"line_number":32,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":33,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":34,"context_line":"    logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba3cc151_1539e9d6","line":31,"in_reply_to":"ba3cc151_e896123d","updated":"2015-07-02 21:40:02.000000000","message":"the command be run without the --service switch so it\u0027s only used if there\u0027s actually a service declared.","commit_id":"906f27034c10a67d94e8156ce2c75f723cfc8574"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"1d771a50fcb499244bf8aac131221eaaa50da617","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  Package\u003c| title \u003d\u003d \u0027neutron\u0027 |\u003e -\u003e Exec[$command_title]"},{"line_number":20,"context_line":"  Neutron_config\u003c||\u003e ~\u003e Exec[$command_title]"},{"line_number":21,"context_line":"  Neutron_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[$command_title]"},{"line_number":22,"context_line":"  Exec[$command_title] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  exec { $command_title:"},{"line_number":25,"context_line":"    command     \u003d\u003e \"neutron-db-manage ${service_arg} --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\","}],"source_content_type":"text/x-puppet","patch_set":12,"id":"9a41bdd9_b6de996b","line":22,"updated":"2015-07-13 14:51:29.000000000","message":"Should this be notifying the service that it\u0027s running the dbsync for?","commit_id":"fddfb2a7d1871208ffbd6ed49a366e44bb6a70fe"}],"manifests/server.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"39a12de9900530ece4ccf826948a0a96352c4fda","unresolved":false,"context_lines":[{"line_number":281,"context_line":"  }"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"  if $sync_db {"},{"line_number":284,"context_line":"    neutron::db::sync {\"neutron-server-db-sync\":}"},{"line_number":285,"context_line":"  }"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"  neutron_config {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_0cc7ea64","line":284,"updated":"2015-07-01 18:05:16.000000000","message":"I\u0027d rather switch back to the previous include shape and create its own neutron::db::fwaas::sync to match fwaas need.\n\nSomething similar is done for powerdns sync in designate: https://review.openstack.org/#/c/196622/2/manifests/db/powerdns/sync.pp,cm","commit_id":"58ae33c77323a84053fc783162355a5ebe2d0920"}],"manifests/services/fwaas.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"39a12de9900530ece4ccf826948a0a96352c4fda","unresolved":false,"context_lines":[{"line_number":35,"context_line":"#   RedHat platforms won\u0027t take care of this parameter"},{"line_number":36,"context_line":"#   true/false"},{"line_number":37,"context_line":"#   Defaults to false"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class neutron::services::fwaas ("},{"line_number":41,"context_line":"  $enabled              \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_cc8a621b","line":38,"updated":"2015-07-01 18:05:16.000000000","message":"missing param description","commit_id":"58ae33c77323a84053fc783162355a5ebe2d0920"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"39a12de9900530ece4ccf826948a0a96352c4fda","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  if $sync_db {"},{"line_number":81,"context_line":"    neutron::db::sync {\"neutron-fwaas-db-sync\":"},{"line_number":82,"context_line":"      service \u003d\u003e \u0027fwaas\u0027,"},{"line_number":83,"context_line":"    }"},{"line_number":84,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"ba3cc151_acaefe95","line":81,"updated":"2015-07-01 18:05:16.000000000","message":"I\u0027d rather create its own neutron::db::fwaas::sync class to match fwaas need.\n\nSomething similar is done for powerdns sync in designate: https://review.openstack.org/#/c/196622/2/manifests/db/powerdns/sync.pp,cm","commit_id":"58ae33c77323a84053fc783162355a5ebe2d0920"}],"spec/classes/neutron_db_sync_spec.rb":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"1d771a50fcb499244bf8aac131221eaaa50da617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9a41bdd9_36836958","updated":"2015-07-13 14:51:29.000000000","message":"This needs to be moved to the defines directory.","commit_id":"fddfb2a7d1871208ffbd6ed49a366e44bb6a70fe"}]}