)]}'
{"manifests/server.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"008e556fe37fd33fe20af91c5f8ca362b646e2e0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#   (where \u0027/keystone\u0027 is the admin prefix)"},{"line_number":53,"context_line":"#   Defaults to false for empty. If defined, should be a string with a leading \u0027/\u0027 and no trailing \u0027/\u0027."},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*auth_region*]"},{"line_number":56,"context_line":"#   (optional) The authentication region. Note this value is case-sensitive and"},{"line_number":57,"context_line":"#   must match the endpoint region defined in Keystone."},{"line_number":58,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_b16ef1fd","line":55,"updated":"2015-07-03 14:48:30.000000000","message":"this param is already in metadata agent config. I wonder if we should move it to ::neutron class and change neutron::agents::metadata to get the param from ::init too.","commit_id":"d9d6f2ae3860dd8353dec423d6717b51dcc7c37f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6892bc8a39ac56855a8761bf494a376e487a968b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#   (where \u0027/keystone\u0027 is the admin prefix)"},{"line_number":53,"context_line":"#   Defaults to false for empty. If defined, should be a string with a leading \u0027/\u0027 and no trailing \u0027/\u0027."},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*auth_region*]"},{"line_number":56,"context_line":"#   (optional) The authentication region. Note this value is case-sensitive and"},{"line_number":57,"context_line":"#   must match the endpoint region defined in Keystone."},{"line_number":58,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_b2546854","line":55,"in_reply_to":"ba3cc151_1e9525e3","updated":"2015-07-07 00:21:40.000000000","message":"To me that is something that should be dictated by neutron and not by the config management. Since according to the docs both can be specified, I should be allowed to specify each individually and possibly differently. If that does not make sense, neutron should address it and we should not make assumptions here in puppet around the way someone wants to populate their configs.","commit_id":"d9d6f2ae3860dd8353dec423d6717b51dcc7c37f"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"8bdf25ba9bef29a257ffd9df6a378e3a1067e751","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#   (where \u0027/keystone\u0027 is the admin prefix)"},{"line_number":53,"context_line":"#   Defaults to false for empty. If defined, should be a string with a leading \u0027/\u0027 and no trailing \u0027/\u0027."},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*auth_region*]"},{"line_number":56,"context_line":"#   (optional) The authentication region. Note this value is case-sensitive and"},{"line_number":57,"context_line":"#   must match the endpoint region defined in Keystone."},{"line_number":58,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_1e9525e3","line":55,"in_reply_to":"ba3cc151_b16ef1fd","updated":"2015-07-06 21:56:11.000000000","message":"+1. We also already have nova_region_name which serves the same purpose. Can we unify these?","commit_id":"d9d6f2ae3860dd8353dec423d6717b51dcc7c37f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ad0d0360a85b26973243224bb1f98ea8081d18e2","unresolved":false,"context_lines":[{"line_number":52,"context_line":"#   (where \u0027/keystone\u0027 is the admin prefix)"},{"line_number":53,"context_line":"#   Defaults to false for empty. If defined, should be a string with a leading \u0027/\u0027 and no trailing \u0027/\u0027."},{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# [*auth_region*]"},{"line_number":56,"context_line":"#   (optional) The authentication region. Note this value is case-sensitive and"},{"line_number":57,"context_line":"#   must match the endpoint region defined in Keystone."},{"line_number":58,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_7abc4b6c","line":55,"in_reply_to":"ba3cc151_b2546854","updated":"2015-07-07 18:50:58.000000000","message":"+1, other than we may want to standardize the names at some point, they can technical be placed in separate regions so we need the multiple options.","commit_id":"d9d6f2ae3860dd8353dec423d6717b51dcc7c37f"},{"author":{"_account_id":8797,"name":"Andrew Woodward","email":"xarses@gmail.com","username":"xarses"},"change_message_id":"ad0d0360a85b26973243224bb1f98ea8081d18e2","unresolved":false,"context_lines":[{"line_number":479,"context_line":""},{"line_number":480,"context_line":"      if $auth_region {"},{"line_number":481,"context_line":"        neutron_config {"},{"line_number":482,"context_line":"          \u0027keystone_authtoken/auth_region\u0027: value \u003d\u003e $auth_region;"},{"line_number":483,"context_line":"        }"},{"line_number":484,"context_line":"      }"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba3cc151_3a448372","line":482,"updated":"2015-07-07 18:50:58.000000000","message":"with the inifile provider, an undef will not be written in any form, so it\u0027s not necessary to \u0027if\u0027 it in.","commit_id":"d9d6f2ae3860dd8353dec423d6717b51dcc7c37f"}]}
