)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"38243192990da349f5703c40022aab1e327d990a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"mtu-selection-and-advertisement neutron feature."},{"line_number":11,"context_line":"Instances will receive DHCP and RA MTU options when"},{"line_number":12,"context_line":"the network\u0027s preferred MTU is known."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ic0db0ec7934522474f243224a42839bce13d16c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a50d1a3_0eebedb1","line":13,"updated":"2015-07-24 04:20:13.000000000","message":"DocImpact as some default config options are being changed","commit_id":"3e6529b16b2df410ded89fbe98b104031410c1c4"}],"manifests/init.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b105b76620e478416237cf6223d304367283c7d0","unresolved":false,"context_lines":[{"line_number":249,"context_line":"  $dhcp_agents_per_network            \u003d 1,"},{"line_number":250,"context_line":"  $network_device_mtu                 \u003d undef,"},{"line_number":251,"context_line":"  $dhcp_agent_notification            \u003d true,"},{"line_number":252,"context_line":"  $advertise_mtu                      \u003d true,"},{"line_number":253,"context_line":"  $allow_bulk                         \u003d true,"},{"line_number":254,"context_line":"  $allow_pagination                   \u003d false,"},{"line_number":255,"context_line":"  $allow_sorting                      \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_f871f10c","line":252,"updated":"2015-07-22 23:39:39.000000000","message":"The default in liberty is for this open to be false.  Should the default here be true?","commit_id":"3e6529b16b2df410ded89fbe98b104031410c1c4"}],"manifests/plugins/ml2.pp":[{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b105b76620e478416237cf6223d304367283c7d0","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#"},{"line_number":103,"context_line":"# [*physnet_mtus*]"},{"line_number":104,"context_line":"#   (optional) For L2 mechanism drivers, per-physical network MTU setting."},{"line_number":105,"context_line":"#   Defaults to 1500."},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*path_mtu*]"},{"line_number":108,"context_line":"#   (optional) For L3 mechanism drivers, determines the maximum permissible"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_18713d0f","line":105,"updated":"2015-07-22 23:39:39.000000000","message":"Does this really default to 1500?  You\u0027ve set it to undef below.  The parameter name here should probably match the actual neutron parameter name.  Should this be a list?","commit_id":"3e6529b16b2df410ded89fbe98b104031410c1c4"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b105b76620e478416237cf6223d304367283c7d0","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  $supported_pci_vendor_devs \u003d [\u002715b3:1004\u0027, \u00278086:10ca\u0027],"},{"line_number":126,"context_line":"  $sriov_agent_required      \u003d false,"},{"line_number":127,"context_line":"  $physnet_mtus              \u003d undef,"},{"line_number":128,"context_line":"  $path_mtu                  \u003d 1500,"},{"line_number":129,"context_line":") {"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_386c3934","line":128,"updated":"2015-07-22 23:39:39.000000000","message":"The default in liberty is 0 (or disabled).  Should the default here really be 1500?  I think it makes sense to use a similar pattern to what you have below with physnet_mtus","commit_id":"3e6529b16b2df410ded89fbe98b104031410c1c4"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b105b76620e478416237cf6223d304367283c7d0","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  } else {"},{"line_number":207,"context_line":"    neutron_plugin_ml2 {"},{"line_number":208,"context_line":"      \u0027ml2/physical_network_mtus\u0027: value \u003d\u003e $physnet_mtus;"},{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":"  }"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a50d1a3_d8767505","line":208,"updated":"2015-07-22 23:39:39.000000000","message":"If this is supposed to be a list, then you\u0027ll want to join it and add a validate_array() call on the value.","commit_id":"3e6529b16b2df410ded89fbe98b104031410c1c4"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"07045b097b28c3c040b1c9d41998f3015eff2e8c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"#"},{"line_number":103,"context_line":"# [*physnet_mtus*]"},{"line_number":104,"context_line":"#   (optional) For L2 mechanism drivers, per-physical network MTU setting."},{"line_number":105,"context_line":"#   Defaults to undef."},{"line_number":106,"context_line":"#"},{"line_number":107,"context_line":"# [*path_mtu*]"},{"line_number":108,"context_line":"#   (optional) For L3 mechanism drivers, determines the maximum permissible"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1a4dcd0f_ff535769","line":105,"updated":"2015-08-05 14:30:38.000000000","message":"Please describe the syntax - it\u0027s [ \u003cnetwork-name\u003e:\u003cmtu\u003e , ... ] right?\n\nAlso please rename to physical_network_mtus so it matches the config item.","commit_id":"7ebd294c4f361424ab35505372b50546dc6a632d"}]}
