)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2597bdfc400ed460494776864caecc7aa45041bc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FWaaS, VPNaaS and LBaaS need to be installed on neutron api node if"},{"line_number":10,"context_line":"it\u0027s standalone. During neutron db sync it is also needed to run for"},{"line_number":11,"context_line":"these services again."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I9b2c00309f3a72f76fffd22a6f3b802e5f78dad2"},{"line_number":14,"context_line":"Closes-Bug: rhbz#1233149, rhbz#1230199"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a41bdd9_dca98125","line":11,"updated":"2015-07-15 15:42:42.000000000","message":"The commit message does not really help to understand the real motivation of such changes.","commit_id":"1f5cb31dcdbef3cb6247ffe3f236162e9dfbe152"},{"author":{"_account_id":16282,"name":"YaZug","email":"jschluet@redhat.com","username":"yazug"},"change_message_id":"a5deec9a10c8bae466695bc16a56e35818f8fb7f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"FWaaS, VPNaaS and LBaaS packages need to be installed on neutron API"},{"line_number":10,"context_line":" node otherwise the neutron service won\u0027t start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also of these neutron modules are enabled one has to update DB for these"},{"line_number":13,"context_line":"modules in neutron::db::sync."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9b2c00309f3a72f76fffd22a6f3b802e5f78dad2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a41bdd9_32450342","line":12,"updated":"2015-07-16 13:28:01.000000000","message":"did you mean \"Also if these neutron modules are enabled\" instead of \"of\"","commit_id":"a8c56f04a75fa454f313fcbd21c959a7906be127"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3aabfeed9b72862df4cd2cdb381b25343d80fd0c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Run neutron db sync also for each neutron module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"FWaaS, VPNaaS and LBaaS packages need to be installed on neutron API"},{"line_number":10,"context_line":" node otherwise the neutron service won\u0027t start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also if these neutron modules are enabled one has to update DB for these"},{"line_number":13,"context_line":"modules in neutron::db::sync."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa1b9901_8a91bbf3","line":10,"updated":"2015-08-19 15:12:32.000000000","message":"Neutron doesn\u0027t have strong dependencies on *aaS packages. Why do we need to install them always?","commit_id":"6ec636938c200ed54a48df08fbefe2d22d9dc602"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fe7702ebfb73eee6ee17df820ddbf65c77a33b0","unresolved":false,"context_lines":[{"line_number":13,"context_line":"modules in neutron::db::sync."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I9b2c00309f3a72f76fffd22a6f3b802e5f78dad2"},{"line_number":16,"context_line":"Closes-Bug: rhbz#1233149, rhbz#1230199, #1474961"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a50d1a3_1791d5f0","line":16,"updated":"2015-07-29 20:39:22.000000000","message":"Please put this one line above and remove links to another bug trackers. Normally, only LP bugs in Puppet OpenStack project space should be mentioned.","commit_id":"6ec636938c200ed54a48df08fbefe2d22d9dc602"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8b4e811ecc18f61d3ea8a79dd326a75a8593e469","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Also if these neutron modules are enabled one has to update DB for these"},{"line_number":13,"context_line":"modules in neutron::db::sync."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1474961 rhbz#1233149 rhbz#1230199"},{"line_number":16,"context_line":"Change-Id: I9b2c00309f3a72f76fffd22a6f3b802e5f78dad2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa1b9901_d4dc0a75","line":15,"updated":"2015-08-20 11:34:40.000000000","message":"Nit: Seems like 1474961 must stand alone on the line otherwise launchpad is not updated.","commit_id":"9bf452e39c546549344f5a200bde680d77416b39"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"68cb4c47f7255dcae945259cf91d44bdeb3e84dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Install service packages on api nodes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As of Liberty FWaaS, VPNaaS and LBaaS packages need to be installed on"},{"line_number":10,"context_line":"neutron API node otherwise the neutron service won\u0027t start."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I9b2c00309f3a72f76fffd22a6f3b802e5f78dad2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa1b9901_a5c23e83","line":9,"updated":"2015-08-21 12:32:58.000000000","message":"As of Kilo","commit_id":"ea00a827fcc8e6f57f02f040ca6f7fa5ed18e841"}],"manifests/agents/l3.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  Neutron_config\u003c||\u003e          ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":139,"context_line":"  Neutron_l3_agent_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":140,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":141,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"  if $allow_automatic_l3agent_failover {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9a68dd71_c4c94fae","line":140,"updated":"2016-01-20 15:15:30.000000000","message":"This is not explained in the commit message, I think it\u0027s worth to mention it.","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"}],"manifests/agents/lbaas.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    name   \u003d\u003e $::neutron::params::lbaas_agent_package,"},{"line_number":94,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":95,"context_line":"  })"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  if $manage_service {"},{"line_number":98,"context_line":"    if $enabled {"},{"line_number":99,"context_line":"      $service_ensure \u003d \u0027running\u0027"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9a68dd71_e4ced3b3","line":96,"updated":"2016-01-20 15:15:30.000000000","message":"?","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"}],"manifests/agents/lbaas/package.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2597bdfc400ed460494776864caecc7aa45041bc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# [*package_ensure*]"},{"line_number":8,"context_line":"#   (optional) Ensure state for package. Defaults to \u0027present\u0027."},{"line_number":9,"context_line":"#"},{"line_number":10,"context_line":"class neutron::agents::lbaas::package ("},{"line_number":11,"context_line":"  $package_ensure \u003d present,"},{"line_number":12,"context_line":") {"},{"line_number":13,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a41bdd9_dc574124","line":10,"updated":"2015-07-15 15:42:42.000000000","message":"I don\u0027t understand at all (maybe I\u0027m blind here) why you need such a split. Creating a class for a resource package, I\u0027m sure we can do better here.","commit_id":"1f5cb31dcdbef3cb6247ffe3f236162e9dfbe152"}],"manifests/db/sync.pp":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    Exec[\u0027neutron-db-sync\u0027] ~\u003e Exec[\u0027neutron-db-sync-lbaas\u0027]"},{"line_number":26,"context_line":"    Exec[\u0027neutron-db-sync-lbaas\u0027] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":27,"context_line":"    exec { \u0027neutron-db-sync-lbaas\u0027:"},{"line_number":28,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage  --service lbaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":29,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":30,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":31,"context_line":"      logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a50d1a3_e07d8c6d","line":28,"updated":"2015-07-23 15:22:38.000000000","message":"there is now no need to pass any config files, it will automatically locate it.","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    Exec[\u0027neutron-db-sync\u0027] ~\u003e Exec[\u0027neutron-db-sync-fwaas\u0027]"},{"line_number":38,"context_line":"    Exec[\u0027neutron-db-sync-fwaas\u0027] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":39,"context_line":"    exec { \u0027neutron-db-sync-fwaas\u0027:"},{"line_number":40,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage  --service fwaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":41,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":42,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":43,"context_line":"      logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a50d1a3_20eff41e","line":40,"updated":"2015-07-23 15:22:38.000000000","message":"ditto","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    Exec[\u0027neutron-db-sync\u0027] ~\u003e Exec[\u0027neutron-db-sync-vpnaas\u0027]"},{"line_number":50,"context_line":"    Exec[\u0027neutron-db-sync-vpnaas\u0027] ~\u003e Service \u003c| title \u003d\u003d \u0027neutron-server\u0027 |\u003e"},{"line_number":51,"context_line":"    exec { \u0027neutron-db-sync-vpnaas\u0027:"},{"line_number":52,"context_line":"      command     \u003d\u003e \u0027neutron-db-manage  --service vpnaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":53,"context_line":"      path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":54,"context_line":"      refreshonly \u003d\u003e true,"},{"line_number":55,"context_line":"      logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a50d1a3_80e0482a","line":52,"updated":"2015-07-23 15:22:38.000000000","message":"ditto","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"2fe7702ebfb73eee6ee17df820ddbf65c77a33b0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# Class to execute neutron dbsync"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"class neutron::db::sync ("},{"line_number":5,"context_line":"  $service_plugins \u003d $::neutron::service_plugins"},{"line_number":6,"context_line":") {"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3a50d1a3_9a6bccb8","line":5,"updated":"2015-07-29 20:39:22.000000000","message":"Please add ths to the params docs","commit_id":"6ec636938c200ed54a48df08fbefe2d22d9dc602"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eafb4a9fad90d0f57490099acb4307d36fecce92","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":18,"context_line":"    logoutput   \u003d\u003e on_failure,"},{"line_number":19,"context_line":"  }"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa1b9901_99ec0591","line":20,"updated":"2015-08-24 08:43:47.000000000","message":"unneeded change","commit_id":"d5804d233c7c3b751abe122a51bfc49a240b0c48"}],"manifests/init.pp":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3aaaa9ca9d6f5cc2ec6321fc56adea1c450fe402","unresolved":false,"context_lines":[{"line_number":429,"context_line":"      neutron_config { \u0027DEFAULT/service_plugins\u0027: value \u003d\u003e join($service_plugins, \u0027,\u0027) }"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"      if (\u0027lbaas\u0027 in $service_plugins or"},{"line_number":432,"context_line":"          \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027 in $service_plugins) {"},{"line_number":433,"context_line":"        if ! defined(Class[\u0027::neutron::agents::lbaas::package\u0027]) {"},{"line_number":434,"context_line":"          class { \u0027::neutron::agents::lbaas::package\u0027:"},{"line_number":435,"context_line":"            package_ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"fa1b9901_17b364ea","line":432,"updated":"2015-08-20 11:38:22.000000000","message":"In new deployments, this will likely be \"neutron_lbaas\" and similarly below with this pattern: \"neutron_\u003cadv-service\u003e\"","commit_id":"9bf452e39c546549344f5a200bde680d77416b39"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b87e2a75404475cda8b6ad00e17481b0e0d3948a","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"      if (\u0027lbaas\u0027 in $service_plugins or"},{"line_number":432,"context_line":"          \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027 in $service_plugins or"},{"line_number":433,"context_line":"          \u0027neutron_lbaa.sservices.loadbalancer.plugin.LoadBalancerPlugin\u0027 in $service_plugins) {"},{"line_number":434,"context_line":"        if ! defined(Class[\u0027::neutron::agents::lbaas::package\u0027]) {"},{"line_number":435,"context_line":"          class { \u0027::neutron::agents::lbaas::package\u0027:"},{"line_number":436,"context_line":"            package_ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa1b9901_7ba15b45","line":433,"updated":"2015-08-20 16:38:09.000000000","message":"neutron_lbaa -\u003e neutron_lbaas","commit_id":"2901f24cd04844bf1390098d3dd4ca6ef7c42965"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b87e2a75404475cda8b6ad00e17481b0e0d3948a","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"      if (\u0027firewall\u0027 in $service_plugins or"},{"line_number":442,"context_line":"          \u0027neutron.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins or"},{"line_number":443,"context_line":"          \u0027neutron_firewall.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins) {"},{"line_number":444,"context_line":"        include ::neutron::services::fwaas"},{"line_number":445,"context_line":"      }"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa1b9901_db92e7f5","line":443,"updated":"2015-08-20 16:38:09.000000000","message":"neutron_firewall -\u003e neutron_fwaas","commit_id":"2901f24cd04844bf1390098d3dd4ca6ef7c42965"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b87e2a75404475cda8b6ad00e17481b0e0d3948a","unresolved":false,"context_lines":[{"line_number":446,"context_line":""},{"line_number":447,"context_line":"      if (\u0027vpnaas\u0027 in $service_plugins or"},{"line_number":448,"context_line":"          \u0027neutron_vpnaas.services.vpn.plugin:VPNDriverPlugin\u0027 in $service_plugins or"},{"line_number":449,"context_line":"          \u0027neutron.services.vpn.plugin:VPNDriverPlugin\u0027 in $service_plugins) {"},{"line_number":450,"context_line":"        if ! defined(Class[\u0027::neutron::agents::vpnaas::package\u0027]) {"},{"line_number":451,"context_line":"          class { \u0027::neutron::agents::vpnaas::package\u0027:"},{"line_number":452,"context_line":"            package_ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"fa1b9901_5bb5777b","line":449,"updated":"2015-08-20 16:38:09.000000000","message":"neutron -\u003e neutron_vpnaas","commit_id":"2901f24cd04844bf1390098d3dd4ca6ef7c42965"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"68cb4c47f7255dcae945259cf91d44bdeb3e84dd","unresolved":false,"context_lines":[{"line_number":430,"context_line":""},{"line_number":431,"context_line":"      if (\u0027lbaas\u0027 in $service_plugins or"},{"line_number":432,"context_line":"          \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027 in $service_plugins or"},{"line_number":433,"context_line":"          \u0027neutron_lbaas.sservices.loadbalancer.plugin.LoadBalancerPlugin\u0027 in $service_plugins) {"},{"line_number":434,"context_line":"        if ! defined(Class[\u0027::neutron::agents::lbaas::package\u0027]) {"},{"line_number":435,"context_line":"          class { \u0027::neutron::agents::lbaas::package\u0027:"},{"line_number":436,"context_line":"            package_ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"fa1b9901_30618ed3","line":433,"updated":"2015-08-21 12:32:58.000000000","message":"sservices -\u003e services","commit_id":"ea00a827fcc8e6f57f02f040ca6f7fa5ed18e841"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"68cb4c47f7255dcae945259cf91d44bdeb3e84dd","unresolved":false,"context_lines":[{"line_number":441,"context_line":"      if (\u0027firewall\u0027 in $service_plugins or"},{"line_number":442,"context_line":"          \u0027neutron.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins or"},{"line_number":443,"context_line":"          \u0027neutron_firewall.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins) {"},{"line_number":444,"context_line":"        include ::neutron::services::fwaas"},{"line_number":445,"context_line":"      }"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"      if (\u0027vpnaas\u0027 in $service_plugins or"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"fa1b9901_90f73ad2","line":444,"updated":"2015-08-21 12:32:58.000000000","message":"I have very limited (or none) puppet knowledge but I see similar pattern in vpnaas and lbaas that it asks whether class is not defined while in fwaas case, it does include. Is that correct?","commit_id":"ea00a827fcc8e6f57f02f040ca6f7fa5ed18e841"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eafb4a9fad90d0f57490099acb4307d36fecce92","unresolved":false,"context_lines":[{"line_number":440,"context_line":""},{"line_number":441,"context_line":"      if (\u0027firewall\u0027 in $service_plugins or"},{"line_number":442,"context_line":"          \u0027neutron.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins or"},{"line_number":443,"context_line":"          \u0027neutron_firewall.services.firewall.fwaas_plugin.FirewallPlugin\u0027 in $service_plugins) {"},{"line_number":444,"context_line":"        include ::neutron::services::fwaas"},{"line_number":445,"context_line":"      }"},{"line_number":446,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"fa1b9901_99a3a54f","line":443,"updated":"2015-08-24 08:43:47.000000000","message":"neutron_fwaas.services....?","commit_id":"d5804d233c7c3b751abe122a51bfc49a240b0c48"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"98b9c24495951c4ba9276c337695786746eb2245","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        \u0027neutron_lbaas.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":432,"context_line":"        \u0027neutron.services.firewall.fwaas_plugin.FirewallPlugin\u0027,"},{"line_number":433,"context_line":"        \u0027neutron_fwaas.services.firewall.fwaas_plugin.FirewallPlugin\u0027,"},{"line_number":434,"context_line":"        \u0027neutron_vpnaas.services.vpn.plugin:VPNDriverPlugin\u0027,"},{"line_number":435,"context_line":"        \u0027neutron.services.vpn.plugin:VPNDriverPlugin\u0027"},{"line_number":436,"context_line":"      ]"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da20952f_970a6020","line":434,"updated":"2015-08-28 08:23:47.000000000","message":"plugin:VPNDriverPlugin -\u003e plugin.VPNDriverPlugin\n\nThere is a colon instead of a dot","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"98b9c24495951c4ba9276c337695786746eb2245","unresolved":false,"context_lines":[{"line_number":432,"context_line":"        \u0027neutron.services.firewall.fwaas_plugin.FirewallPlugin\u0027,"},{"line_number":433,"context_line":"        \u0027neutron_fwaas.services.firewall.fwaas_plugin.FirewallPlugin\u0027,"},{"line_number":434,"context_line":"        \u0027neutron_vpnaas.services.vpn.plugin:VPNDriverPlugin\u0027,"},{"line_number":435,"context_line":"        \u0027neutron.services.vpn.plugin:VPNDriverPlugin\u0027"},{"line_number":436,"context_line":"      ]"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"      $deprecated_present \u003d intersection($deprecated, $service_plugins)"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da20952f_b70d2439","line":435,"updated":"2015-08-28 08:23:47.000000000","message":"Ditto","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"98b9c24495951c4ba9276c337695786746eb2245","unresolved":false,"context_lines":[{"line_number":453,"context_line":"      ]"},{"line_number":454,"context_line":"      $vpnaas \u003d ["},{"line_number":455,"context_line":"        \u0027vpnaas\u0027,"},{"line_number":456,"context_line":"        \u0027neutron_vpnaas.services.vpn.plugin:VPNDriverPlugin\u0027,"},{"line_number":457,"context_line":"        \u0027neutron.services.vpn.plugin:VPNDriverPlugin\u0027"},{"line_number":458,"context_line":"      ]"},{"line_number":459,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da20952f_171f3060","line":456,"updated":"2015-08-28 08:23:47.000000000","message":"Ditto","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"98b9c24495951c4ba9276c337695786746eb2245","unresolved":false,"context_lines":[{"line_number":454,"context_line":"      $vpnaas \u003d ["},{"line_number":455,"context_line":"        \u0027vpnaas\u0027,"},{"line_number":456,"context_line":"        \u0027neutron_vpnaas.services.vpn.plugin:VPNDriverPlugin\u0027,"},{"line_number":457,"context_line":"        \u0027neutron.services.vpn.plugin:VPNDriverPlugin\u0027"},{"line_number":458,"context_line":"      ]"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"      neutron_config { \u0027DEFAULT/service_plugins\u0027: value \u003d\u003e join($service_plugins, \u0027,\u0027) }"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"da20952f_371a746f","line":457,"updated":"2015-08-28 08:23:47.000000000","message":"Ditto","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":437,"context_line":"      $deprecated_present \u003d intersection($deprecated, $service_plugins)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"      if !empty($deprecated_present) {"},{"line_number":440,"context_line":"        warning(\"You should stop using full import paths: ${deprecated_present} please use router, firewall, lbaas, vpnaas, metering\")"},{"line_number":441,"context_line":"      }"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"      $lbaas \u003d ["}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9a68dd71_44031fb9","line":440,"updated":"2016-01-20 15:15:30.000000000","message":"That\u0027s completely out of context.\nIt should be done in a separated patchset and you should mention about it in commit message.","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":499,"context_line":"          tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":500,"context_line":"        })"},{"line_number":501,"context_line":"      }"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"    } else {"},{"line_number":504,"context_line":"      fail(\u0027service_plugins should be an array.\u0027)"},{"line_number":505,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9a68dd71_44ad5f87","line":502,"updated":"2016-01-20 15:15:30.000000000","message":"If you actually need the packages on API nodes (which are installed by neutron::server class by the way), but using init.pp ?","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"}],"manifests/params.pp":[{"author":{"_account_id":11491,"name":"Gael Chamoulaud","email":"gchamoul@redhat.com","username":"gchamoul"},"change_message_id":"4b8490541f9d36c543a703ab9fcdf717d220b5f0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    $metering_agent_package \u003d \u0027openstack-neutron-metering-agent\u0027"},{"line_number":57,"context_line":"    $metering_agent_service \u003d \u0027neutron-metering-agent\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    $vpnaas_agent_package \u003d \u0027openstack-neutron-vpnaas\u0027"},{"line_number":60,"context_line":"    $vpnaas_agent_service \u003d \u0027neutron-vpn-agent\u0027"},{"line_number":61,"context_line":"    if $::operatingsystemrelease \u003d~ /^7.*/ or $::operatingsystem \u003d\u003d \u0027Fedora\u0027 {"},{"line_number":62,"context_line":"      $openswan_package     \u003d \u0027libreswan\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9a41bdd9_33ef12b2","line":59,"updated":"2015-07-17 11:20:06.000000000","message":"This seems to fix https://bugs.launchpad.net/puppet-neutron/+bug/1474797 but no note in the commit message about it.\nMoreover, another fix for that has been proposed by Nick Jones, https://review.openstack.org/#/c/202065/","commit_id":"4d4d1dcc9b066d739b48d75686c7967a44d60395"}],"manifests/services/fwaas.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  include ::neutron::params"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":49,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if ($::osfamily \u003d\u003d \u0027Debian\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":29,"id":"9a68dd71_c4af0f7c","side":"PARENT","line":48,"updated":"2016-01-20 15:15:30.000000000","message":"Same comments, I don\u0027t understand why you\u0027re moving it and the commit message does not explain it.","commit_id":"66eee63420297a013fb57ee488c571350cf5052a"}],"spec/acceptance/basic_neutron_spec.rb":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eafb4a9fad90d0f57490099acb4307d36fecce92","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        debug                 \u003d\u003e true,"},{"line_number":104,"context_line":"        verbose               \u003d\u003e true,"},{"line_number":105,"context_line":"        service_plugins \u003d\u003e ["},{"line_number":106,"context_line":"          \u0027neutron.services.l3_router.l3_router_plugin.L3RouterPlugin\u0027,"},{"line_number":107,"context_line":"          \u0027neutron.services.loadbalancer.plugin.LoadBalancerPlugin\u0027,"},{"line_number":108,"context_line":"          \u0027neutron.services.metering.metering_plugin.MeteringPlugin\u0027,"},{"line_number":109,"context_line":"          \u0027firewall\u0027,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"fa1b9901_197eb5ae","line":106,"updated":"2015-08-24 08:43:47.000000000","message":"That is not for this patch, but I believe you should stop using full import paths here asap.","commit_id":"d5804d233c7c3b751abe122a51bfc49a240b0c48"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"98b9c24495951c4ba9276c337695786746eb2245","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          \u0027router\u0027,"},{"line_number":107,"context_line":"          \u0027lbaas\u0027,"},{"line_number":108,"context_line":"          \u0027metering\u0027,"},{"line_number":109,"context_line":"          \u0027firewall\u0027,"},{"line_number":110,"context_line":"        ],"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      class { \u0027::neutron::db::mysql\u0027:"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"da20952f_373114ed","line":109,"updated":"2015-08-28 08:23:47.000000000","message":"vpn?","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2ea8f095feddd58ad05afc166816a80bb59f1ba6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"          \u0027router\u0027,"},{"line_number":107,"context_line":"          \u0027lbaas\u0027,"},{"line_number":108,"context_line":"          \u0027metering\u0027,"},{"line_number":109,"context_line":"          \u0027firewall\u0027,"},{"line_number":110,"context_line":"        ],"},{"line_number":111,"context_line":"      }"},{"line_number":112,"context_line":"      class { \u0027::neutron::db::mysql\u0027:"}],"source_content_type":"text/x-ruby","patch_set":14,"id":"da20952f_576a88b4","line":109,"in_reply_to":"da20952f_373114ed","updated":"2015-08-28 08:24:32.000000000","message":"I meant vpnaas","commit_id":"ac3b27a43fe3847aa3c70b901d1bc87f291b0f31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"          \u0027router\u0027,"},{"line_number":41,"context_line":"          \u0027lbaas\u0027,"},{"line_number":42,"context_line":"          \u0027metering\u0027,"},{"line_number":43,"context_line":"          \u0027firewall\u0027,"},{"line_number":44,"context_line":"        ],"},{"line_number":45,"context_line":"      }"},{"line_number":46,"context_line":"      class { \u0027::neutron::db::mysql\u0027:"}],"source_content_type":"text/x-ruby","patch_set":29,"id":"9a68dd71_44c47f3f","line":43,"updated":"2016-01-20 15:15:30.000000000","message":"same comment as before, it should be done in a different patchset.","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"5a686bd5d72eeea2632ebc93b1ce4d57a4ddf2e4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"      class { \u0027::neutron::client\u0027: }"},{"line_number":59,"context_line":"      class { \u0027::neutron::quota\u0027: }"},{"line_number":60,"context_line":"      class { \u0027::neutron::agents::dhcp\u0027: debug \u003d\u003e true }"},{"line_number":61,"context_line":"      class { \u0027::neutron::services::fwaas\u0027:"},{"line_number":62,"context_line":"        enabled \u003d\u003e true,"},{"line_number":63,"context_line":"        driver  \u003d\u003e \u0027neutron.services.firewall.drivers.linux.iptables_fwaas.IptablesFwaasDriver\u0027,"},{"line_number":64,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":29,"id":"9a68dd71_24e2abd6","line":61,"updated":"2016-01-20 15:15:30.000000000","message":"same here. Another patch for that.","commit_id":"33f9627364efb5210b858aababb264c2fd00952c"}],"spec/classes/neutron_db_sync_spec.rb":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    it \u0027runs neutron-db-sync-lbaas\u0027 do"},{"line_number":59,"context_line":"      is_expected.to contain_exec(\u0027neutron-db-sync-lbaas\u0027).with("},{"line_number":60,"context_line":"        :command     \u003d\u003e \u0027neutron-db-manage  --service lbaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":61,"context_line":"        :path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":62,"context_line":"        :refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":63,"context_line":"        :logoutput   \u003d\u003e \u0027on_failure\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a50d1a3_e0cb4ca2","line":60,"updated":"2015-07-23 15:22:38.000000000","message":"no need for --config-file.","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    end"},{"line_number":66,"context_line":"    it \u0027runs neutron-db-sync-vpnaas\u0027 do"},{"line_number":67,"context_line":"      is_expected.to contain_exec(\u0027neutron-db-sync-vpnaas\u0027).with("},{"line_number":68,"context_line":"        :command     \u003d\u003e \u0027neutron-db-manage  --service vpnaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":69,"context_line":"        :path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":70,"context_line":"        :refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":71,"context_line":"        :logoutput   \u003d\u003e \u0027on_failure\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a50d1a3_a0c22483","line":68,"updated":"2015-07-23 15:22:38.000000000","message":"ditto","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        :logoutput   \u003d\u003e \u0027on_failure\u0027"},{"line_number":72,"context_line":"      )"},{"line_number":73,"context_line":"    end"},{"line_number":74,"context_line":"    it \u0027runs neutron-db-sync-fwaas\u0027 do"},{"line_number":75,"context_line":"      is_expected.to contain_exec(\u0027neutron-db-sync-fwaas\u0027).with("},{"line_number":76,"context_line":"        :command     \u003d\u003e \u0027neutron-db-manage  --service fwaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":77,"context_line":"        :path        \u003d\u003e \u0027/usr/bin\u0027,"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a50d1a3_c05650cd","line":74,"updated":"2015-07-23 15:22:38.000000000","message":"btw why do you even refer to the step as neutron-db-sync while the tool is neutron-db-manage?","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a84c276f85b3cf27cba0ecf74c1a87a0a6d11fc7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    end"},{"line_number":74,"context_line":"    it \u0027runs neutron-db-sync-fwaas\u0027 do"},{"line_number":75,"context_line":"      is_expected.to contain_exec(\u0027neutron-db-sync-fwaas\u0027).with("},{"line_number":76,"context_line":"        :command     \u003d\u003e \u0027neutron-db-manage  --service fwaas --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini upgrade head\u0027,"},{"line_number":77,"context_line":"        :path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":78,"context_line":"        :refreshonly \u003d\u003e \u0027true\u0027,"},{"line_number":79,"context_line":"        :logoutput   \u003d\u003e \u0027on_failure\u0027"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a50d1a3_003af898","line":76,"updated":"2015-07-23 15:22:38.000000000","message":"ditto","commit_id":"c23fa83f21b5ba00670c4b4e8ad0d4d8bef0d13a"}],"spec/classes/neutron_init_spec.rb":[{"author":{"_account_id":7984,"name":"Jason Guiditta","email":"jguiditt@redhat.com","username":"jayg"},"change_message_id":"e3aa30fa167f9cf578e3de589397bfa254bd3fe7","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    end"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    it do"},{"line_number":397,"context_line":"      is_expected.to contain_class(\u0027neutron::agents::lbaas::package\u0027)"},{"line_number":398,"context_line":"      is_expected.to contain_class(\u0027neutron::agents::vpnaas::package\u0027)"},{"line_number":399,"context_line":"      is_expected.to contain_class(\u0027neutron::services::fwaas::package\u0027)"},{"line_number":400,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/service_plugins\u0027).with_value(\u0027router,firewall,lbaas,vpnaas,metering,qos\u0027)"}],"source_content_type":"text/x-ruby","patch_set":27,"id":"ba63e191_10bbece6","line":397,"updated":"2016-01-19 16:17:15.000000000","message":"These need to be updated since you removed the ::package classes.","commit_id":"47f3ae5ddf3a5b3ff5bb7ad11817a4fe45c42575"}]}