)]}'
{"lib/puppet/provider/neutron_agent_mlnx_config/ini_setting.rb":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8c8af3ee20ca5ea37296d57f06b9ec4993d37492","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  def file_path"},{"line_number":19,"context_line":"    \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027"},{"line_number":20,"context_line":"  end"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"1ac06dbe_063bb39d","line":20,"updated":"2016-08-24 22:27:47.000000000","message":"You should consider adding:\n\n def self.file_path\n    \u0027etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027\n end\n\nand implementing the instance version in terms of it. See the some of the other providers for examples.","commit_id":"fcf3db3c560f2a4bb62e0a4d8ee27e253b3fcdc7"}],"lib/puppet/type/neutron_agent_mlnx_config.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from mlnx agent config.\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  newproperty(:value) do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_aa3e6f89","line":7,"updated":"2015-08-13 17:57:14.000000000","message":"would be nice to restrict with ^ and $","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from mlnx agent config.\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  newproperty(:value) do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_c256edcd","line":7,"in_reply_to":"1a4dcd0f_aa3e6f89","updated":"2015-08-16 12:53:32.000000000","message":"Done.\nSeems from 32 types I\u0027ll, exclude neutron_router_interface.rb, be alone nice. :)","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"}],"lib/puppet/type/neutron_mellanox_eswitchd_config.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from Mellanox eswitchd\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  newproperty(:value) do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_0a08c3d8","line":7,"updated":"2015-08-13 17:57:14.000000000","message":"ditto","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  newparam(:name, :namevar \u003d\u003e true) do"},{"line_number":6,"context_line":"    desc \u0027Section/setting name to manage from Mellanox eswitchd\u0027"},{"line_number":7,"context_line":"    newvalues(/\\S+\\/\\S+/)"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  newproperty(:value) do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_a2f3a1e6","line":7,"in_reply_to":"1a4dcd0f_0a08c3d8","updated":"2015-08-16 12:53:32.000000000","message":"Done","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"}],"manifests/agents/ml2/mlnx.pp":[{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"b852b1a5345094226b91104e3e5124ec2b1eb787","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $ensure                           \u003d \u0027present\u0027,"},{"line_number":34,"context_line":"  $enabled                          \u003d true,"},{"line_number":35,"context_line":"  $physical_device_mappings         \u003d [],"},{"line_number":36,"context_line":"  $packages_repository_provider     \u003d \u0027mellanox\u0027,"},{"line_number":37,"context_line":"  $openstack_release                \u003d \u0027kilo\u0027"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_4caf0b7d","line":36,"updated":"2015-08-06 16:11:01.000000000","message":"Why not using boolean of use_mellanox_repository \u003d true ?","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"2920bfe79252c423a8f8c6ff33fe90a952af6237","unresolved":false,"context_lines":[{"line_number":33,"context_line":"  $ensure                           \u003d \u0027present\u0027,"},{"line_number":34,"context_line":"  $enabled                          \u003d true,"},{"line_number":35,"context_line":"  $physical_device_mappings         \u003d [],"},{"line_number":36,"context_line":"  $packages_repository_provider     \u003d \u0027mellanox\u0027,"},{"line_number":37,"context_line":"  $openstack_release                \u003d \u0027kilo\u0027"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_6064f148","line":36,"in_reply_to":"1a4dcd0f_4caf0b7d","updated":"2015-08-13 08:46:32.000000000","message":"Who know may be tommorow will be also XYZ.","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"b852b1a5345094226b91104e3e5124ec2b1eb787","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $supported_os_ubuntu    \u003d \u0027Ubuntu\u0027"},{"line_number":41,"context_line":"  $supported_os_redhat    \u003d \u0027Redhat\u0027"},{"line_number":42,"context_line":"  $supported_os_centos    \u003d \u0027Centos\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if  $::operatingsystem !\u003d $supported_os_ubuntu and"},{"line_number":45,"context_line":"      $::operatingsystem !\u003d $supported_os_redhat and"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_4ca4eb06","line":42,"updated":"2015-08-06 16:11:01.000000000","message":"No need constants IMO\n+ Why not using osfamily\nhttps://docs.puppetlabs.com/facter/1.6/core_facts.html#osfamily ?","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"2920bfe79252c423a8f8c6ff33fe90a952af6237","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $supported_os_ubuntu    \u003d \u0027Ubuntu\u0027"},{"line_number":41,"context_line":"  $supported_os_redhat    \u003d \u0027Redhat\u0027"},{"line_number":42,"context_line":"  $supported_os_centos    \u003d \u0027Centos\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"  if  $::operatingsystem !\u003d $supported_os_ubuntu and"},{"line_number":45,"context_line":"      $::operatingsystem !\u003d $supported_os_redhat and"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_c053856b","line":42,"in_reply_to":"1a4dcd0f_4ca4eb06","updated":"2015-08-13 08:46:32.000000000","message":"Need constants, used in many places.\nWe are\u0027nt support OS families.\nWe are support specific OS.","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"b852b1a5345094226b91104e3e5124ec2b1eb787","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $mlnx_repository_base_url     \u003d \u0027http://www.mellanox.com/repository/solutions/openstack/data\u0027"},{"line_number":61,"context_line":"  $mlnx_repository_description  \u003d \u0027Mellanox Openstack Repository\u0027"},{"line_number":62,"context_line":"  $mlnx_repository_name         \u003d \u0027openstack-mellanox\u0027"},{"line_number":63,"context_line":"  $mlnx_repository_component    \u003d \u0027main\u0027  "},{"line_number":64,"context_line":"  $mlnx_package_tag             \u003d \u0027mlnx\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"  neutron_mellanox_eswitchd_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_6c59a734","line":63,"updated":"2015-08-06 16:11:01.000000000","message":"Please remove whitespaces","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"b852b1a5345094226b91104e3e5124ec2b1eb787","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    $allow_virtual \u003d false"},{"line_number":76,"context_line":"  } else {"},{"line_number":77,"context_line":"    $allow_virtual \u003d true"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"  "},{"line_number":80,"context_line":"  package { $mlnx_eswitchd_package :"},{"line_number":81,"context_line":"    allow_virtual   \u003d\u003e $allow_virtual,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_6cdf673a","line":78,"updated":"2015-08-06 16:11:01.000000000","message":"Do we need it in this scope?","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"2920bfe79252c423a8f8c6ff33fe90a952af6237","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    $allow_virtual \u003d false"},{"line_number":76,"context_line":"  } else {"},{"line_number":77,"context_line":"    $allow_virtual \u003d true"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":"  "},{"line_number":80,"context_line":"  package { $mlnx_eswitchd_package :"},{"line_number":81,"context_line":"    allow_virtual   \u003d\u003e $allow_virtual,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_e0500161","line":78,"in_reply_to":"1a4dcd0f_6cdf673a","updated":"2015-08-13 08:46:32.000000000","message":"Prevent deprecation messages.","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e6848180d66d501acb2e7ba04d14fac272210080","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $enabled                          \u003d true,"},{"line_number":35,"context_line":"  $physical_device_mappings         \u003d [],"},{"line_number":36,"context_line":"  $packages_repository_provider     \u003d \u0027mellanox\u0027,"},{"line_number":37,"context_line":"  $openstack_release                \u003d \u0027kilo\u0027"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $supported_os_ubuntu \u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_85ed8a90","line":37,"updated":"2015-08-09 16:21:27.000000000","message":"default should be liberty","commit_id":"ef74bcd9da3d5d30f047b155d23e863cf7e60543"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"0f1241d4050248135091fffb063cb23aba119ae1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"  $enabled                          \u003d true,"},{"line_number":35,"context_line":"  $physical_device_mappings         \u003d [],"},{"line_number":36,"context_line":"  $packages_repository_provider     \u003d \u0027mellanox\u0027,"},{"line_number":37,"context_line":"  $openstack_release                \u003d \u0027kilo\u0027"},{"line_number":38,"context_line":") {"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  $supported_os_ubuntu \u003d \u0027Ubuntu\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_a948d82d","line":37,"in_reply_to":"1a4dcd0f_85ed8a90","updated":"2015-08-13 09:33:30.000000000","message":"as I understand pushing this  manifests to master means that it will configure mlnx mechanism driver for liberty, right?\nso I think we should not use the parameter, but try to figure out in what version of openstack we are configuring  mlnx mechanism driver.","commit_id":"ef74bcd9da3d5d30f047b155d23e863cf7e60543"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e6848180d66d501acb2e7ba04d14fac272210080","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":58,"context_line":"  $mlnx_eswitchd_package       \u003d $::neutron::params::mlnx_eswitchd_packages"},{"line_number":59,"context_line":"  $mlnx_eswitchd_service       \u003d $::neutron::params::mlnx_eswitchd_service"},{"line_number":60,"context_line":"  $mlnx_repository_base_url    \u003d \u0027http://www.mellanox.com/repository/solutions/openstack/data\u0027"},{"line_number":61,"context_line":"  $mlnx_repository_description \u003d \u0027Mellanox Openstack Repository\u0027"},{"line_number":62,"context_line":"  $mlnx_repository_name        \u003d \u0027openstack-mellanox\u0027"},{"line_number":63,"context_line":"  $mlnx_repository_component   \u003d \u0027main\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_65ecfe8f","line":60,"updated":"2015-08-09 16:21:27.000000000","message":"is this the url why data and the end?","commit_id":"ef74bcd9da3d5d30f047b155d23e863cf7e60543"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"b46b9f8a14cf1ff541e949bf9982005117e1c2cb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":58,"context_line":"  $mlnx_eswitchd_package       \u003d $::neutron::params::mlnx_eswitchd_packages"},{"line_number":59,"context_line":"  $mlnx_eswitchd_service       \u003d $::neutron::params::mlnx_eswitchd_service"},{"line_number":60,"context_line":"  $mlnx_repository_base_url    \u003d \u0027http://www.mellanox.com/repository/solutions/openstack/data\u0027"},{"line_number":61,"context_line":"  $mlnx_repository_description \u003d \u0027Mellanox Openstack Repository\u0027"},{"line_number":62,"context_line":"  $mlnx_repository_name        \u003d \u0027openstack-mellanox\u0027"},{"line_number":63,"context_line":"  $mlnx_repository_component   \u003d \u0027main\u0027"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a4dcd0f_5c1d5571","line":60,"in_reply_to":"1a4dcd0f_65ecfe8f","updated":"2015-08-13 08:47:02.000000000","message":"Names conflict with already present parts in url.","commit_id":"ef74bcd9da3d5d30f047b155d23e863cf7e60543"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*ensure*]"},{"line_number":8,"context_line":"#   (optional) The state of the package"},{"line_number":9,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_0a2f633f","line":7,"updated":"2015-08-13 17:57:14.000000000","message":"in PO modules this one is used to be package_ensure or ensure_package","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*ensure*]"},{"line_number":8,"context_line":"#   (optional) The state of the package"},{"line_number":9,"context_line":"#   Defaults to \u0027present\u0027"},{"line_number":10,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_c2db4d4e","line":7,"in_reply_to":"1a4dcd0f_0a2f633f","updated":"2015-08-16 12:53:32.000000000","message":"Done.\nReplaced by package_ensure.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $supported_os_redhat        \u003d \u0027redhat\u0027"},{"line_number":43,"context_line":"  $supported_os_centos        \u003d \u0027centos\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if  $current_operatingsystem !\u003d $supported_os_ubuntu and"},{"line_number":46,"context_line":"      $current_operatingsystem !\u003d $supported_os_redhat and"},{"line_number":47,"context_line":"      $current_operatingsystem !\u003d $supported_os_centos {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_4ad6cbf2","line":45,"updated":"2015-08-13 17:57:14.000000000","message":"this section\u0027s logic duplicates params and should be moved there.\nif debian should raise an error here, one check for it would look more simple.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  $supported_os_redhat        \u003d \u0027redhat\u0027"},{"line_number":43,"context_line":"  $supported_os_centos        \u003d \u0027centos\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if  $current_operatingsystem !\u003d $supported_os_ubuntu and"},{"line_number":46,"context_line":"      $current_operatingsystem !\u003d $supported_os_redhat and"},{"line_number":47,"context_line":"      $current_operatingsystem !\u003d $supported_os_centos {"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_22b8f1c6","line":45,"in_reply_to":"1a4dcd0f_4ad6cbf2","updated":"2015-08-16 12:53:32.000000000","message":"Is not double logic. First check - whole module supported OS checks. Second check is supported by Mellanox repositories check. Also we\u0027ll not provide support for OS families - only for specific OS - this module not for all Debians for Ubuntu only. For example: we\u0027ll add in near future support for Fedora by module, but we\u0027ll not provide yum repositories for Fedora.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027 : value \u003d\u003e join($physical_device_mappings, \u0027,\u0027);"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $enabled {"},{"line_number":139,"context_line":"    $service_ensure \u003d \u0027running\u0027"},{"line_number":140,"context_line":"  } else {"},{"line_number":141,"context_line":"    $service_ensure \u003d \u0027stopped\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_8ae29300","line":138,"updated":"2015-08-13 17:57:14.000000000","message":"there is also common practice in PO modules to use manage_service param additionally.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    \u0027eswitch/physical_interface_mappings\u0027 : value \u003d\u003e join($physical_device_mappings, \u0027,\u0027);"},{"line_number":136,"context_line":"  }"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  if $enabled {"},{"line_number":139,"context_line":"    $service_ensure \u003d \u0027running\u0027"},{"line_number":140,"context_line":"  } else {"},{"line_number":141,"context_line":"    $service_ensure \u003d \u0027stopped\u0027"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a4dcd0f_e2e9a980","line":138,"in_reply_to":"1a4dcd0f_8ae29300","updated":"2015-08-16 12:53:32.000000000","message":"Done.\nAdded manage_service support.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"a706995929cd1972845f2d15a5aefa21e8ce8223","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $use_mellanox_repository {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if $current_operatingsystem \u003d\u003d $supported_os_ubuntu {"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"fa1b9901_222ce497","line":109,"updated":"2015-08-21 11:50:56.000000000","message":"Can you externalize that part. We do not manage external repo within our modules","commit_id":"6fe3866d8c27cc852d036ac984d19a325b264ead"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"cc70a5076ca6b3f8708b06698c7ec91f483c0edb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $use_mellanox_repository {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if $current_operatingsystem \u003d\u003d $supported_os_ubuntu {"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"fa1b9901_651074a9","line":109,"in_reply_to":"fa1b9901_058bea1f","updated":"2015-08-23 08:07:40.000000000","message":"Hi.\n\nFirst of all thanks for your review.\n\nCan you please check:\n\nmodule puppet-neutron/manifests/agents/n1kv_vem.pp\n...\n# [*n1kv_source*]\n#   (optional)\n#     n1kv_source \u003d\u003d\u003e VEM package location. One of below\n#       A)URL of yum repository that hosts VEM package.\n#       B)VEM RPM/DPKG file name, If present locally in \u0027files\u0027 folder\n#       C)If not specified, assumes that VEM image is available in\n#         default enabled repositories.\n...\n#from below repo.\n  yumrepo { \u0027cisco-vem-repo\u0027:\n   baseurl  \u003d\u003e $n1kv_source,\n   descr    \u003d\u003e \u0027Repo for VEM Image\u0027,\n   enabled  \u003d\u003e 1,\n   gpgcheck \u003d\u003e 1,\n   gpgkey   \u003d\u003e \"${n1kv_source}/RPM-GPG-KEY\"\n    #proxy   \u003d\u003e \u0027_none_\u0027,\n }\n...\n\nI was following this module. Parameter n1kv_source of class n1kv_vem already providing same manipulations with Cisco repositories like Mellanox agent module. Does our case is differnet than above ?\n\nOur repository contains Openstack related software only and by default it turned off, for actually prevent dependencies fails during Jenkins test/checks.\n\nThanks.","commit_id":"6fe3866d8c27cc852d036ac984d19a325b264ead"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"1b292171b88d25a44550a138bb7304db653397e6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    }"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $use_mellanox_repository {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if $current_operatingsystem \u003d\u003d $supported_os_ubuntu {"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"fa1b9901_058bea1f","line":109,"in_reply_to":"fa1b9901_222ce497","updated":"2015-08-21 12:21:02.000000000","message":"Let me give a little bit more context and explain why \"We do not manage extertnal repo(s) within our modules\".\n\nopenstack/puppet-* modules aim to configure, install and run OpenStack applications and their dependencies that are also part of OpenStack (libraries, tools, etc).\n\nHowever, we don\u0027t want to manage third-party software in our modules because:\n* they are not part of OpenStack.\n* they might conflict with OpenStack packaging (specific dependencies).\n* we don\u0027t have third-party CI, so we can\u0027t test it, so we don\u0027t want that code.\n* we think this code should be part an external module or the composition layer. Example in that case, a puppet-mlnx that would install repos and dependencies to deploy the right tools that Neutron needs.\n\nIn summary: pupet-neutron aims to configure neutron.conf and plugins.ini (whatever plugin that is supported by Neutron upstream), install any package needed by Neutron to run (agents, server, etc), manage Neutron services (agents, services, etc) but not external tools like: custom OVS, custom libraries, custom kernel versions, etc. which is something quite often required by recent SDN tools (which by the way makes sense!).\n\nI hope it\u0027s a bit more clear now, let me know if you need more discussion.","commit_id":"6fe3866d8c27cc852d036ac984d19a325b264ead"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"685e4ee4ee70afeb08611e5a204b7fe795d31ed2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if $use_mellanox_repository {"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    if $current_operatingsystem \u003d\u003d $supported_os_ubuntu {"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"      include ::apt"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"ba15a1d1_8099e870","line":110,"updated":"2015-09-14 21:29:31.000000000","message":"I\u0027m aware Cisco is implemented like this for now and honestly this class it not a good example to follow.\nPlease drop this code and use your own composition layer to configure repos.\n\nThanks","commit_id":"6fe3866d8c27cc852d036ac984d19a325b264ead"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8c8af3ee20ca5ea37296d57f06b9ec4993d37492","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   (optional) List of \u003cphysical_network\u003e:\u003cphysical device\u003e"},{"line_number":21,"context_line":"#   All physical networks listed in network_vlan_ranges"},{"line_number":22,"context_line":"#   on the server should have mappings to appropriate"},{"line_number":23,"context_line":"#   interfaces on each agent."},{"line_number":24,"context_line":"#   Defaults to empty list"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class neutron::agents::ml2::mlnx ("}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1ac06dbe_4613eb0d","line":23,"updated":"2016-08-24 22:27:47.000000000","message":"would $::os_service_default be better choice here?","commit_id":"fcf3db3c560f2a4bb62e0a4d8ee27e253b3fcdc7"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8c8af3ee20ca5ea37296d57f06b9ec4993d37492","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   All physical networks listed in network_vlan_ranges"},{"line_number":22,"context_line":"#   on the server should have mappings to appropriate"},{"line_number":23,"context_line":"#   interfaces on each agent."},{"line_number":24,"context_line":"#   Defaults to empty list"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"class neutron::agents::ml2::mlnx ("},{"line_number":27,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1ac06dbe_86ca036d","line":24,"updated":"2016-08-24 22:27:47.000000000","message":"We\u0027ve added purge_config to classes to support cleaning remnants out of config files. You might consider adding.","commit_id":"fcf3db3c560f2a4bb62e0a4d8ee27e253b3fcdc7"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8c8af3ee20ca5ea37296d57f06b9ec4993d37492","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  $mlnx_agent_package          \u003d $::neutron::params::mlnx_agent_packages"},{"line_number":38,"context_line":"  $mlnx_agent_service          \u003d $::neutron::params::mlnx_agent_service"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if versioncmp($::puppetversion, \u00273.6.1\u0027) \u003e\u003d 0 {"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    package { $mlnx_agent_package :"},{"line_number":43,"context_line":"      ensure        \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1ac06dbe_465e4b77","line":40,"updated":"2016-08-24 22:27:47.000000000","message":"Do you need this? I suspect you are trying to get around the deprecation warnings and the change in default value of allow_virtual. Why not just have allow_virtual always set to false?","commit_id":"fcf3db3c560f2a4bb62e0a4d8ee27e253b3fcdc7"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"8c8af3ee20ca5ea37296d57f06b9ec4993d37492","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      $service_ensure \u003d \u0027stopped\u0027"},{"line_number":64,"context_line":"    }"},{"line_number":65,"context_line":"  } else {"},{"line_number":66,"context_line":"    $service_ensure \u003d undef"},{"line_number":67,"context_line":"  }"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  service { $mlnx_agent_service :"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"1ac06dbe_2694efe6","line":66,"updated":"2016-08-24 22:27:47.000000000","message":"I don\u0027t think this else is necessary. if ! $manage_service, $service_ensure will be undef anyways.","commit_id":"fcf3db3c560f2a4bb62e0a4d8ee27e253b3fcdc7"}],"manifests/params.pp":[{"author":{"_account_id":11968,"name":"Aviram Bar-Haim","email":"avirambh@gmail.com","username":"aviramb"},"change_message_id":"b852b1a5345094226b91104e3e5124ec2b1eb787","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    $mlnx_eswitchd_config_file \u003d \u0027/etc/eswitchd/eswitchd.conf\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    $mlnx_agent_service        \u003d \u0027neutron-plugin-mlnx-agent\u0027"},{"line_number":122,"context_line":"    $mlnx_agent_packages       \u003d [\u0027neutron-plugin-mlnx\u0027,\u0027neutron-plugin-mlnx-agent\u0027,\u0027python-networking-mlnx\u0027]"},{"line_number":123,"context_line":"    $mlnx_agent_config_file    \u003d \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    $cisco_server_package  \u003d \u0027neutron-plugin-cisco\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_1724ac5b","line":122,"updated":"2015-08-06 16:11:01.000000000","message":"Do we need all these 3 packages?","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"2920bfe79252c423a8f8c6ff33fe90a952af6237","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    $mlnx_eswitchd_config_file \u003d \u0027/etc/eswitchd/eswitchd.conf\u0027"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    $mlnx_agent_service        \u003d \u0027neutron-plugin-mlnx-agent\u0027"},{"line_number":122,"context_line":"    $mlnx_agent_packages       \u003d [\u0027neutron-plugin-mlnx\u0027,\u0027neutron-plugin-mlnx-agent\u0027,\u0027python-networking-mlnx\u0027]"},{"line_number":123,"context_line":"    $mlnx_agent_config_file    \u003d \u0027/etc/neutron/plugins/mlnx/mlnx_conf.ini\u0027"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    $cisco_server_package  \u003d \u0027neutron-plugin-cisco\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a4dcd0f_a073d914","line":122,"in_reply_to":"1a4dcd0f_1724ac5b","updated":"2015-08-13 08:46:32.000000000","message":"Yes","commit_id":"7adc45a74d4d02446931897c59f8b42db0ce7fb1"}],"spec/classes/neutron_agents_ml2_mlnx_spec.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"fb690af295ee2b5875182ba80a219dcbccdd6778","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  let :default_params do"},{"line_number":10,"context_line":"    { :package_ensure             \u003d\u003e \u0027present\u0027,"},{"line_number":11,"context_line":"      :enabled                    \u003d\u003e true,"},{"line_number":12,"context_line":"      :physical_device_mappings   \u003d\u003e [],"},{"line_number":13,"context_line":"    }"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_ea60f70f","line":10,"updated":"2015-08-13 17:57:14.000000000","message":"please align the mlnx.pp params with this.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"},{"author":{"_account_id":16751,"name":"Andrey Yevsyukov","email":"andreyy@mellanox.com","username":"andreyyevsyukov"},"change_message_id":"1e735cad3db0053e8ba27de7bcd9c5ff7d94f3e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  end"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  let :default_params do"},{"line_number":10,"context_line":"    { :package_ensure             \u003d\u003e \u0027present\u0027,"},{"line_number":11,"context_line":"      :enabled                    \u003d\u003e true,"},{"line_number":12,"context_line":"      :physical_device_mappings   \u003d\u003e [],"},{"line_number":13,"context_line":"    }"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a4dcd0f_e26e89ff","line":10,"in_reply_to":"1a4dcd0f_ea60f70f","updated":"2015-08-16 12:53:32.000000000","message":"Done.\nAdded.","commit_id":"69bee3bbe295e5ad69f030d9b26598fb4b5f1f12"}]}