)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb683b9c74086013b7ac749aeed9d23332693a7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Configure Big Switch ML2 plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a class to install the Big Switch ML2 plugin and another one to"},{"line_number":10,"context_line":"configure the [restproxy] section of ml2_conf.ini."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If027762f70695c31dbca6151373a0ebe6e75d071"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_ebeb2711","line":10,"updated":"2015-08-21 12:47:20.000000000","message":"please indicate this is only supported on RH platforms.","commit_id":"d621f722770138ed9e65aa3f8d2f581039a9431c"}],"manifests/plugins/ml2/bigswitch.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2f7d5b13881d16ef7e568bcecb003f745651e54","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-bsnstacklib\u0027,"},{"line_number":24,"context_line":"    {"},{"line_number":25,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":26,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_f8525134","line":23,"updated":"2015-08-20 16:26:41.000000000","message":"you could also use ensure_packages: https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/lib/puppet/parser/functions/ensure_packages.rb but that\u0027s fine too.","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6cb618d05a22df049964d3631174e7946ae9d89d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    fail(\"Unsupported osfamily ${::osfamily}\")"},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-bsnstacklib\u0027,"},{"line_number":24,"context_line":"    {"},{"line_number":25,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":26,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_55051f11","line":23,"in_reply_to":"fa1b9901_f8525134","updated":"2015-08-21 09:33:48.000000000","message":"Done","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2f7d5b13881d16ef7e568bcecb003f745651e54","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-bsnstacklib\u0027,"},{"line_number":24,"context_line":"    {"},{"line_number":25,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":26,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":27,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_bb2cd399","line":24,"updated":"2015-08-20 16:26:41.000000000","message":"Also, I don\u0027t see the package available in trusty \u0026 centos. Could you point us the URL please?","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6cb618d05a22df049964d3631174e7946ae9d89d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  ensure_resource(\u0027package\u0027, \u0027python-bsnstacklib\u0027,"},{"line_number":24,"context_line":"    {"},{"line_number":25,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":26,"context_line":"      tag    \u003d\u003e \u0027openstack\u0027,"},{"line_number":27,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_18859e58","line":24,"in_reply_to":"fa1b9901_bb2cd399","updated":"2015-08-21 09:33:48.000000000","message":"Hehe you\u0027re right :) I used the name which they tested with, but they actually renamed it for package review. The name will be \u0027python-networking-bigswitch\u0027. I think it\u0027s currently being packaged only for RH platform (same as the Cisco ML2 plugin, so i used the same check). Big Switch didn\u0027t use packages for their plugin at all before i think, so it\u0027s all in progress.\n\nHere\u0027s the review request:\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id\u003d1254828\n\nAnd a koji build:\n\nhttp://koji.fedoraproject.org/koji/taskinfo?taskID\u003d10747075","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"}],"manifests/plugins/ml2/bigswitch/restproxy.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2f7d5b13881d16ef7e568bcecb003f745651e54","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*server_ssl*]"},{"line_number":29,"context_line":"# (optional) Whether Neutron should use SSL to talk to the Big Switch"},{"line_number":30,"context_line":"# controllers."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*ssl_cert_directory*]"},{"line_number":33,"context_line":"# (optional) Directory where Big Switch controller certificate will be"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_d82e6da4","line":30,"updated":"2015-08-20 16:26:41.000000000","message":"Defaults to... ?","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6cb618d05a22df049964d3631174e7946ae9d89d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"# [*server_ssl*]"},{"line_number":29,"context_line":"# (optional) Whether Neutron should use SSL to talk to the Big Switch"},{"line_number":30,"context_line":"# controllers."},{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*ssl_cert_directory*]"},{"line_number":33,"context_line":"# (optional) Directory where Big Switch controller certificate will be"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_588f9674","line":30,"in_reply_to":"fa1b9901_d82e6da4","updated":"2015-08-21 09:33:48.000000000","message":"Done","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e2f7d5b13881d16ef7e568bcecb003f745651e54","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*ssl_cert_directory*]"},{"line_number":33,"context_line":"# (optional) Directory where Big Switch controller certificate will be"},{"line_number":34,"context_line":"# stored."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class neutron::plugins::ml2::bigswitch::restproxy ("},{"line_number":37,"context_line":"  $servers,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_382449c3","line":34,"updated":"2015-08-20 16:26:41.000000000","message":"Defaults to... ?","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"6cb618d05a22df049964d3631174e7946ae9d89d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"#"},{"line_number":32,"context_line":"# [*ssl_cert_directory*]"},{"line_number":33,"context_line":"# (optional) Directory where Big Switch controller certificate will be"},{"line_number":34,"context_line":"# stored."},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class neutron::plugins::ml2::bigswitch::restproxy ("},{"line_number":37,"context_line":"  $servers,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa1b9901_788a9a65","line":34,"in_reply_to":"fa1b9901_382449c3","updated":"2015-08-21 09:33:48.000000000","message":"Done","commit_id":"0ac8bc6ffc96b71a4b62e25581967c901b69405c"}],"spec/classes/neutron_plugins_ml2_bigswitch_restproxy_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3e96413b16f662f65ec2b23e0e5390e5d0fb7c17","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        default_facts.merge({:osfamily \u003d\u003e \u0027Debian\u0027})"},{"line_number":83,"context_line":"      end"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"      it { is_expected.to raise_error(Puppet::Error, /Unsupported osfamily Debian/) }"},{"line_number":86,"context_line":"    end"},{"line_number":87,"context_line":"  end"},{"line_number":88,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"fa1b9901_a30d48ea","line":85,"updated":"2015-08-21 16:39:59.000000000","message":"sorry to nitpick but the fail is in fact in neutron::plugins::ml2::bigswitch - you might need to move this test, isn\u0027t?","commit_id":"32a247806ec216b6d80b1b44c8b143385c3da4e6"}],"spec/classes/neutron_plugins_ml2_bigswitch_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"cb683b9c74086013b7ac749aeed9d23332693a7c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        default_facts.merge({:osfamily \u003d\u003e \u0027RedHat\u0027})"},{"line_number":49,"context_line":"      end"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"      it_configures \u0027neutron plugin bigswitch ml2\u0027"},{"line_number":52,"context_line":"    end"},{"line_number":53,"context_line":"  end"},{"line_number":54,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa1b9901_6bb2b74d","line":51,"updated":"2015-08-21 12:47:20.000000000","message":"please add a context with Debian/Ubuntu that should fail.","commit_id":"d621f722770138ed9e65aa3f8d2f581039a9431c"}]}
