)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"eef4847a031953834f2bcdc421b9b4fa23441ad8","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For preventing parsing warning messages,"},{"line_number":14,"context_line":"I propose got response from Neutron CLI as JSON and parse"},{"line_number":15,"context_line":"it by generag ruby JSON parser."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iba1105bc119272715fa211ac129a366fe50cbf47"},{"line_number":18,"context_line":"Closes-bug: #1508511"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a29b11f_170a408a","line":15,"updated":"2015-10-23 10:16:23.000000000","message":"there is a typo - maybe should be - generating","commit_id":"7dcc9d06f85090d038144bf5c4c45568304b3625"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f56917dd1ce3c245abfe92bb385ad9475d2cf57d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use json output instead plain-text"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack CLI utilities can returns warning messages while"},{"line_number":10,"context_line":"run to stderr. It\u0027s a normal behavior for Openstack CLI."},{"line_number":11,"context_line":"But Puppet mixing stderr and stdout for commands."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa80f949_363b8ed3","line":9,"updated":"2015-11-04 11:54:49.000000000","message":"s/returns/return/","commit_id":"bb88977d06ddd7c00d2ea18e5222cf29c6d187c3"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"f56917dd1ce3c245abfe92bb385ad9475d2cf57d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Openstack CLI utilities can returns warning messages while"},{"line_number":10,"context_line":"run to stderr. It\u0027s a normal behavior for Openstack CLI."},{"line_number":11,"context_line":"But Puppet mixing stderr and stdout for commands."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For preventing parsing warning messages,"},{"line_number":14,"context_line":"I propose got response from Neutron CLI as JSON if it required"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa80f949_3642ae3f","line":11,"updated":"2015-11-04 11:54:49.000000000","message":"s/mixing/mixs/","commit_id":"bb88977d06ddd7c00d2ea18e5222cf29c6d187c3"}],"lib/puppet/provider/neutron.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"2794aa9d50658709fba7927b20464d67949a38cb","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    end"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # saparate json from any possible garbage"},{"line_number":144,"context_line":"    list \u003d list.scan(/\\[\\{.*\\}\\]/m).last"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if list.is_a? String"},{"line_number":147,"context_line":"      JSON.parse(list).each do |line|"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a29b11f_3d10a856","line":144,"updated":"2015-10-22 11:40:23.000000000","message":"Here we should also parse two additional cases - when dict is empty - [], and when json is in multi-string format - so we should probably remove \\n and spaces from output string","commit_id":"948c6bb580b81d19015a177f31237160929da1ee"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"0c23c0aa3063d8eb5339ac00e58d08aef843d925","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    end"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # saparate json from any possible garbage"},{"line_number":144,"context_line":"    list \u003d list.scan(/\\[\\{.*\\}\\]/m).last"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    if list.is_a? String"},{"line_number":147,"context_line":"      JSON.parse(list).each do |line|"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a29b11f_5e1b1b81","line":144,"in_reply_to":"3a29b11f_3d10a856","updated":"2015-10-22 12:29:34.000000000","message":"1. I use multi-line regex here. Multi-line case covered. Multi-line case  already used in the spec-tests. \n\n2. we don\u0027t cover [] case, because [] cace equal to \u0027json not found\u0027 case. result list will empty.","commit_id":"948c6bb580b81d19015a177f31237160929da1ee"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"eef4847a031953834f2bcdc421b9b4fa23441ad8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  end"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"  def self.find_and_parse_json(text)"},{"line_number":136,"context_line":"    # saparate json from any possible garbage around it and parse"},{"line_number":137,"context_line":"    unless text.is_a? Array"},{"line_number":138,"context_line":"      text \u003d text.split(\"\\n\")"},{"line_number":139,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a29b11f_77d4d4ea","line":136,"updated":"2015-10-23 10:16:23.000000000","message":"there is a typo - sEparate","commit_id":"7dcc9d06f85090d038144bf5c4c45568304b3625"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"aa6171d9fe960be0a7548cb5627dff97d4259c3c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    results \u003d []"},{"line_number":201,"context_line":"    cmd_output \u003d auth_neutron(\"router-port-list\","},{"line_number":202,"context_line":"                              \u0027--format\u003dcsv\u0027,"},{"line_number":203,"context_line":"                              router_name_or_id)"},{"line_number":204,"context_line":"    if ! cmd_output"},{"line_number":205,"context_line":"      return results"},{"line_number":206,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3a29b11f_308dca7b","line":203,"updated":"2015-10-26 14:46:02.000000000","message":"I don\u0027t see any parsing here.","commit_id":"7dcc9d06f85090d038144bf5c4c45568304b3625"},{"author":{"_account_id":7468,"name":"Sergey Vasilenko","email":"svasilenko@mirantis.com","username":"xenolog"},"change_message_id":"10dcff03791b62f7433c58e8bfc6ce9b689d5ba4","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    results \u003d []"},{"line_number":201,"context_line":"    cmd_output \u003d auth_neutron(\"router-port-list\","},{"line_number":202,"context_line":"                              \u0027--format\u003dcsv\u0027,"},{"line_number":203,"context_line":"                              router_name_or_id)"},{"line_number":204,"context_line":"    if ! cmd_output"},{"line_number":205,"context_line":"      return results"},{"line_number":206,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a26ad4f_32fab043","line":203,"in_reply_to":"3a29b11f_308dca7b","updated":"2015-10-28 16:09:12.000000000","message":"it\u0027s another story.\nThis story may be implemented after merge this patch.","commit_id":"7dcc9d06f85090d038144bf5c4c45568304b3625"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"7cb08b475504a1f3be2483e9b47a6366dc924d21","unresolved":false,"context_lines":[{"line_number":188,"context_line":"      k \u003d line[\u0027Field\u0027]"},{"line_number":189,"context_line":"      v \u003d line[\u0027Value\u0027]"},{"line_number":190,"context_line":"      if [\u0027True\u0027, \u0027False\u0027].include? v.to_s.capitalize"},{"line_number":191,"context_line":"        v \u003d \"#{v}\".capitalize"},{"line_number":192,"context_line":"      elsif v.is_a? String and v \u003d~ /\\n/"},{"line_number":193,"context_line":"        v \u003d v.split(/\\n/)"},{"line_number":194,"context_line":"      elsif v.is_a? Numeric"}],"source_content_type":"text/x-ruby","patch_set":15,"id":"da85f559_9cb3089a","line":191,"updated":"2015-11-11 14:36:43.000000000","message":"It would be cleaner to replace all these \"#{v}\" instances with v.to_s","commit_id":"79f0e636c07b80b2c6699d934b42641bfef4352b"}],"spec/unit/provider/neutron_router/neutron_spec.rb":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"5283f0ddcfebdab9a40d15e9e35ebfa216504dbd","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        bla-bla-bla"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        [{\"Field\": \"external_gateway_info\", \"Value\": \"{}\"}]"},{"line_number":107,"context_line":"      EOT"},{"line_number":108,"context_line":"      klass.stubs(:auth_neutron).returns(output)"},{"line_number":109,"context_line":"      result \u003d klass.get_neutron_resource_attrs \u0027foo\u0027, nil"},{"line_number":110,"context_line":"      expect(provider.parse_gateway_network_id(result[\u0027external_gateway_info\u0027])).to eql(\u0027\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"3a29b11f_1e8283c8","line":107,"updated":"2015-10-22 12:21:52.000000000","message":"please add cases for the cases suggested by Sergey K.","commit_id":"948c6bb580b81d19015a177f31237160929da1ee"}]}
