)]}'
{"spec/classes/neutron_agents_dhcp_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"de48c46dd2ac80652057d11e3deea77eaff5a003","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_09865813","line":185,"updated":"2015-11-25 13:40:56.000000000","message":"Can you try to run using\n\n@default_facts.merge( default_facts.merge( { \n  :osfamily...\n}))\n\n? I thinks this should work ^^","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"64584f2a0e47345e4683c2e7ceee385df7aaeccb","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_b54c3b43","line":185,"in_reply_to":"9a8ffd7b_09865813","updated":"2015-11-25 14:27:11.000000000","message":"Thanks for suggestion! But won\u0027t two separate calls be more readable?","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"69c6d2d5162140232e68c9cdc10acbffcdf80bdc","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_793b2d39","line":185,"in_reply_to":"9a8ffd7b_39e36535","updated":"2015-11-25 14:44:36.000000000","message":"So do you suggest to rename the local \"default_facts\" variable?","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"397fe17daa91bc9491bee531969bc4e9afd55b42","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_fc02ab08","line":185,"in_reply_to":"9a8ffd7b_793b2d39","updated":"2015-11-25 14:48:58.000000000","message":"I think this is a good approach, can you test and tell me, if this change requires too much work? ^^","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"bdc0be7acef4dcc581f9b14e32fa6c57983dff37","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_39e36535","line":185,"in_reply_to":"9a8ffd7b_b54c3b43","updated":"2015-11-25 14:38:35.000000000","message":"Yeah it will be, the problem i see here is \"default_facts\" in this file could have other name, this will be more readable i think. \nThis way i think we are repeating code...","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"68a7d7cf408553f2e90593fdd6d976f1d9a19cf9","unresolved":false,"context_lines":[{"line_number":182,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":183,"context_line":"    let :facts do"},{"line_number":184,"context_line":"      @default_facts.merge(default_facts)"},{"line_number":185,"context_line":"      @default_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a8ffd7b_43064bcf","line":185,"in_reply_to":"9a8ffd7b_fc02ab08","updated":"2015-11-26 09:33:32.000000000","message":"It\u0027s ok, I\u0027ll upload a new patchset today","commit_id":"83b0b4d1f3d003c653ae7425af8bd381ae0b30c2"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"7075962b39c13a2c6459f9dde73aa204499ed345","unresolved":false,"context_lines":[{"line_number":182,"context_line":""},{"line_number":183,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":184,"context_line":"    let :facts do"},{"line_number":185,"context_line":"      @default_facts.merge!(test_facts.merge({"},{"line_number":186,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":187,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":188,"context_line":"      }))"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"9a8ffd7b_21ca154f","line":185,"updated":"2015-11-26 12:49:24.000000000","message":"We should not use merge!\ntake a look at this commit message for puppet-cinder: https://review.openstack.org/#/c/240247/","commit_id":"69cbb1de33e20c30266f4e1f9d8d1f73e3a78049"}]}
