)]}'
{"manifests/db/sync.pp":[{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"66ff31032588eaead4bc00f5dec4f61382831e26","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  Neutron_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027neutron-db-sync\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  exec { \u0027neutron-db-sync\u0027:"},{"line_number":25,"context_line":"    command     \u003d\u003e \"neutron-db-manage ${extra_params} upgrade head\","},{"line_number":26,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":27,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":28,"context_line":"    logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a26ad4f_87cc1b6b","line":25,"updated":"2015-11-03 09:07:44.000000000","message":"If \"extra_params\" are empty, shouldn\u0027t it run the old command with \"--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini\".   Or you could put the default value of the \"extra_param\" rather than keeping it empty.","commit_id":"9a4fcaf30c32dfec447f3b3e930668bfc0971d5d"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"1acf29951e23d235b113ec7513374bfd5d1fbcc6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  Neutron_config\u003c| title \u003d\u003d \u0027database/connection\u0027 |\u003e ~\u003e Exec[\u0027neutron-db-sync\u0027]"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  exec { \u0027neutron-db-sync\u0027:"},{"line_number":25,"context_line":"    command     \u003d\u003e \"neutron-db-manage ${extra_params} upgrade head\","},{"line_number":26,"context_line":"    path        \u003d\u003e \u0027/usr/bin\u0027,"},{"line_number":27,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":28,"context_line":"    logoutput   \u003d\u003e on_failure,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa80f949_03d0b152","line":25,"in_reply_to":"1a26ad4f_87cc1b6b","updated":"2015-11-03 15:13:41.000000000","message":"Sure, making it the default is a good idea","commit_id":"9a4fcaf30c32dfec447f3b3e930668bfc0971d5d"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"6e9e45996dcaa86d2fd519532876ae6bb454e41f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   to the neutron-db-manage upgrade head command. These will be"},{"line_number":9,"context_line":"#   inserted in the command line between \u0027neutron-db-manage\u0027 and"},{"line_number":10,"context_line":"#   \u0027upgrade head\u0027."},{"line_number":11,"context_line":"#   Defaults to \u0027--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini\u0027"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::db::sync("},{"line_number":14,"context_line":"  $extra_params \u003d \u0027--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_5a1b60ca","line":11,"updated":"2015-11-11 14:56:46.000000000","message":"I think this should default to an empty string. Reading from the \"correct\" config file should be the default and this will just break distributions or deployers that choose to put the config file in a non-default location.","commit_id":"ae3fae27b1d50e0f3dd7917550b30ac70c597e64"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"991ca6053caa7c74d9ca7ed237b133580484e3fb","unresolved":false,"context_lines":[{"line_number":8,"context_line":"#   to the neutron-db-manage upgrade head command. These will be"},{"line_number":9,"context_line":"#   inserted in the command line between \u0027neutron-db-manage\u0027 and"},{"line_number":10,"context_line":"#   \u0027upgrade head\u0027."},{"line_number":11,"context_line":"#   Defaults to \u0027--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini\u0027"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::db::sync("},{"line_number":14,"context_line":"  $extra_params \u003d \u0027--config-file /etc/neutron/neutron.conf --config-file /etc/neutron/plugin.ini\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"da85f559_d07091a6","line":11,"in_reply_to":"da85f559_5a1b60ca","updated":"2015-11-11 15:19:32.000000000","message":"Done. I had it this way because the db sync command in params.pp included these files as the default, but I agree this provides more flexibility.","commit_id":"ae3fae27b1d50e0f3dd7917550b30ac70c597e64"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7fc2a3ca4727e6d2bf3e72a6c4b595406ce03c4f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to undef"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::db::sync("},{"line_number":14,"context_line":"  $extra_params \u003d undef,"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba8a016a_68add987","line":14,"updated":"2015-11-16 14:57:22.000000000","message":"This change doesn\u0027t look like backward compatible. And also we need to specify at least a path to neutron.conf to get database connection string","commit_id":"7a211400de64b9596c6ca1984744686360deb782"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"9b35d0ab98ea99b8dcfe7b72e53ce8dc2c0a4b72","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#   Defaults to undef"},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"class neutron::db::sync("},{"line_number":14,"context_line":"  $extra_params \u003d undef,"},{"line_number":15,"context_line":") {"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"ba8a016a_ab95fb40","line":14,"in_reply_to":"ba8a016a_68add987","updated":"2015-11-16 15:11:23.000000000","message":"In patch set 3 Clayton suggested making it default to undef because reading from the correct config file should be default behavior, and this will break deployments that have the config file in a non-default location.","commit_id":"7a211400de64b9596c6ca1984744686360deb782"}]}
