)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6d506336dafdc46043762c1e2b00f14639c65564","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-18 22:40:05 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add proper dependencies for Nuage plugin configuration steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ib524046be71623b2d4bce2c492a173904475fa75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba8a016a_bc80e6f8","line":8,"updated":"2015-11-20 14:52:55.000000000","message":"It would be great to write a good commit message.\nFeel free to read https://wiki.openstack.org/wiki/GitCommitMessages for more details.","commit_id":"9fcb28d1fdee85e7997cc1ee6bb005a02311a31d"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"64b55ab32cbcedd633c77d43bbd4b5c5f3e885ef","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-11-18 19:11:39 -0500"},{"line_number":4,"context_line":"Commit:     Vishal Patil \u003cvishpat@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-23 10:45:23 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add proper dependencies for Nuage plugin configuration steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Specify proper dependencies between the configuration steps"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_c78b441d","line":6,"updated":"2015-11-23 16:57:31.000000000","message":"The first line should be limited to 50 characters","commit_id":"2483fd03a0c9f9a7eeedda9356a0c27e8b300a65"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"64b55ab32cbcedd633c77d43bbd4b5c5f3e885ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add proper dependencies for Nuage plugin configuration steps"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Specify proper dependencies between the configuration steps"},{"line_number":10,"context_line":"requied to setup the Nuage Neutron Plugin. This ensures"},{"line_number":11,"context_line":"that the steps are executed in proper order and the plugin"},{"line_number":12,"context_line":"is setup correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_27cb3055","line":9,"updated":"2015-11-23 16:57:31.000000000","message":"required","commit_id":"2483fd03a0c9f9a7eeedda9356a0c27e8b300a65"}],"manifests/plugins/nuage.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6d506336dafdc46043762c1e2b00f14639c65564","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    fail(\u0027Nuage plugin should be the core_plugin in neutron.conf\u0027)"},{"line_number":96,"context_line":"  }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"  Neutron_plugin_nuage\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_bce546dd","side":"PARENT","line":98,"updated":"2015-11-20 14:52:55.000000000","message":"Not sure this is a good idea. AFIK Neutron DB sync use the plugin to populate the DB correctly.","commit_id":"b46efbbc153d67a89dd5d8eb68a7fc57c408f51b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6d506336dafdc46043762c1e2b00f14639c65564","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  Neutron_plugin_nuage\u003c||\u003e ~\u003e Service[\u0027neutron-server\u0027]"},{"line_number":53,"context_line":"  Neutron_plugin_nuage\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e"},{"line_number":54,"context_line":"  "},{"line_number":55,"context_line":"  file { \u0027/etc/neutron/plugins/nuage\u0027:"},{"line_number":56,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":57,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba8a016a_dc85aa07","line":54,"updated":"2015-11-20 14:52:55.000000000","message":"whitespace","commit_id":"9fcb28d1fdee85e7997cc1ee6bb005a02311a31d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7f35bbabe9b062f9561512c6e67abde6ca3c90e7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":72,"context_line":"    File[\u0027/etc/neutron/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e"},{"line_number":73,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":74,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":75,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a8ffd7b_1415c8e3","line":72,"updated":"2015-12-02 15:38:58.000000000","message":"i\u0027m not sure, why do you need this relation?\n\nIf you need to be sure, that config file exists, then you need use\n\n  File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e\n\nfor example","commit_id":"289e819b526c08e873d8b916ddb2dc7872c5aa52"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"b2781693009f2130c2f06b45f9631e0d7f65de0a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":72,"context_line":"    File[\u0027/etc/neutron/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e"},{"line_number":73,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":74,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":75,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a8ffd7b_feeed189","line":72,"in_reply_to":"9a8ffd7b_1415c8e3","updated":"2015-12-03 14:24:48.000000000","message":"Denis, this is needed to make sure that neutron-db-sync is executed after\n1) The plugin.ini is populated with correct values and \n2) The symlink /etc/neutron/plugin.ini has been created","commit_id":"289e819b526c08e873d8b916ddb2dc7872c5aa52"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"77f9226fd2cbe12ce333b370bbbe0b0e78bd4c95","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":72,"context_line":"    File[\u0027/etc/neutron/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e"},{"line_number":73,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":74,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":75,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"7a740942_6d771803","line":72,"in_reply_to":"9a8ffd7b_dd2881e4","updated":"2015-12-04 00:36:08.000000000","message":"Done","commit_id":"289e819b526c08e873d8b916ddb2dc7872c5aa52"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3107381d878de5ef8e50c5c58f839e42f0657812","unresolved":false,"context_lines":[{"line_number":69,"context_line":"  }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":72,"context_line":"    File[\u0027/etc/neutron/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e"},{"line_number":73,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":74,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":75,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9a8ffd7b_dd2881e4","line":72,"in_reply_to":"9a8ffd7b_feeed189","updated":"2015-12-03 14:55:37.000000000","message":"1) /etc/neutron/plugin.ini is a symlink to  /etc/neutron/plugins/nuage/plugin.ini . It also have require on  /etc/neutron/plugins/nuage/plugin.ini;\n\n2) You have \u0027Neutron_plugin_nuage\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e \u0027 - it tells that change in your config triggers db sync - not a strong relation.\n\nI got your point about created File[\u0027/etc/neutron/plugin.ini\u0027] before Neutron_plugin_nuage, because it also require main config file. But it will be valid in case of RedHat, we will have next chain:\n\nFile[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027] -\u003e File[\u0027/etc/neutron/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e\n\nBut for another OS that\u0027s not true. So, i suggest add File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e in common case. Then we will have config file every time before we executing Neutron_plugin_nuage\u003c||\u003e.\n\nActually, we don\u0027t need File[\u0027/etc/neutron/plugin.ini\u0027] for Neutron_plugin_nuage\u003c||\u003e, right? If you need execute db sync with this symlink (you probably can\u0027t do it BEFORE as is) you can just add notify File[\u0027/etc/neutron/plugin.ini\u0027] ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e like it done for  Neutron_plugin_nuage\u003c||\u003e.","commit_id":"289e819b526c08e873d8b916ddb2dc7872c5aa52"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e4ee3769d48bc8f0b83ec27c54184318f8b9ffff","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":71,"context_line":"#    File[\u0027/etc/neutron/plugin.ini\u0027] ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e"},{"line_number":72,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":73,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":74,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_74202e9c","line":71,"updated":"2015-12-04 11:15:02.000000000","message":"Comment in line beginning.\n\nAlso you didn\u0027t got my point for prev patchset.\n\n1) You shouldn\u0027t remove existing Neutron_plugin_nuage\u003c||\u003e ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e;\n\n2) I suggested to add File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027] -\u003e Neutron_plugin_nuage\u003c||\u003e for both systems, in common.","commit_id":"a6d6cf26a232f9647907e4a1d33c15e044fe8bf9"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"340e6fd5b879c816dd1dae23315eb6d989eae4ed","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  }"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $::osfamily \u003d\u003d \u0027Redhat\u0027 {"},{"line_number":71,"context_line":"#    File[\u0027/etc/neutron/plugin.ini\u0027] ~\u003e Exec\u003c| title \u003d\u003d \u0027neutron-db-sync\u0027 |\u003e"},{"line_number":72,"context_line":"    file { \u0027/etc/neutron/plugin.ini\u0027:"},{"line_number":73,"context_line":"      ensure  \u003d\u003e link,"},{"line_number":74,"context_line":"      require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage/plugin.ini\u0027],"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7a740942_75549a20","line":71,"in_reply_to":"7a740942_74202e9c","updated":"2015-12-04 16:36:18.000000000","message":"Done","commit_id":"a6d6cf26a232f9647907e4a1d33c15e044fe8bf9"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5c852dea855656a6272052af8171f137fd7d7b57","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270640\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a740942_dea8ca79","line":60,"updated":"2015-12-07 14:56:08.000000000","message":"Is it needed to set such mode here? You use 644 on a file","commit_id":"d19a7366741f6b67b3d310132c46d63f71d6f0df"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"314363a9f9177bde1a0c6184a88474579e6ac45f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270640\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7a740942_986796e8","line":60,"in_reply_to":"7a740942_dea8ca79","updated":"2015-12-08 03:51:10.000000000","message":"Sergey, this maps to existing code. Why do you want me to change it to 644 ?","commit_id":"d19a7366741f6b67b3d310132c46d63f71d6f0df"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"89a43c4efae3cb859a8fd836eb5a057f071d5801","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270640\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a740942_07e4b3a9","line":60,"updated":"2015-12-07 20:17:17.000000000","message":"this change has nothing to do with dependencies, which is what you try to achieve if I read your commit message.","commit_id":"5e561ea550960c2d90cd6f7e96d50bf2837d936c"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"c81869472c3675f821f9e961ab4b378960143d9c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270640\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a740942_ef3fb5b1","line":60,"in_reply_to":"7a740942_07e4b3a9","updated":"2015-12-08 23:23:14.000000000","message":"This was added to make sure that the /etc/neutron/plugins/nuage directory is present before ensuring the presence of /etc/neutron/plugins/nuage/plugin.ini file","commit_id":"5e561ea550960c2d90cd6f7e96d50bf2837d936c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"89a43c4efae3cb859a8fd836eb5a057f071d5801","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":84,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":85,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage\u0027],"},{"line_number":86,"context_line":"    mode    \u003d\u003e \u00270644\u0027"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  $nuage_base_uri_base \u003d \u0027/nuage/api\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a740942_6702573f","line":86,"updated":"2015-12-07 20:17:17.000000000","message":"Why are you changing permissions here? It\u0027s also out of context of the commit message.","commit_id":"5e561ea550960c2d90cd6f7e96d50bf2837d936c"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"c81869472c3675f821f9e961ab4b378960143d9c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    owner   \u003d\u003e \u0027root\u0027,"},{"line_number":84,"context_line":"    group   \u003d\u003e \u0027neutron\u0027,"},{"line_number":85,"context_line":"    require \u003d\u003e File[\u0027/etc/neutron/plugins/nuage\u0027],"},{"line_number":86,"context_line":"    mode    \u003d\u003e \u00270644\u0027"},{"line_number":87,"context_line":"  }"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"  $nuage_base_uri_base \u003d \u0027/nuage/api\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"7a740942_4f77e99f","line":86,"in_reply_to":"7a740942_6702573f","updated":"2015-12-08 23:23:14.000000000","message":"I will revert this change.","commit_id":"5e561ea550960c2d90cd6f7e96d50bf2837d936c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"345c55f35ac991d14acffd9009241b7f3ec0d3fe","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270644\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_c6bfdffa","line":60,"updated":"2015-12-10 14:00:05.000000000","message":"so in prev patch set you\u0027ve used here 0640, and now it is 0644, why?","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9e023ac905b21194f37cd76924c8e2215d7cfa4c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270644\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_9244b1b7","line":60,"in_reply_to":"7a740942_571b9b80","updated":"2015-12-10 15:02:26.000000000","message":"No, you\u0027re wrong. You\u0027ve had 0644 exactly on file[\u0027/etc/neutron/plugins/nuage\u0027] in prev patchset.","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"5a13bf4874d5b9ef74e7824e07300b0130659a69","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270644\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_aad04354","line":60,"in_reply_to":"7a740942_9244b1b7","updated":"2015-12-10 19:15:33.000000000","message":"Ok, I understand what you are saying.","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b8a5bf9a92a9d2e81791a536325c28e926255b5f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270644\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_32637d1c","line":60,"in_reply_to":"7a740942_9244b1b7","updated":"2015-12-10 15:03:30.000000000","message":"typo, 0640","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"},{"author":{"_account_id":19355,"name":"Vishal Patil","email":"vishpat@gmail.com","username":"vishpat"},"change_message_id":"e0199f9914c79a50d4892eda38ee38cfd8e94391","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ensure \u003d\u003e directory,"},{"line_number":58,"context_line":"    owner  \u003d\u003e \u0027root\u0027,"},{"line_number":59,"context_line":"    group  \u003d\u003e \u0027neutron\u0027,"},{"line_number":60,"context_line":"    mode   \u003d\u003e \u00270644\u0027"},{"line_number":61,"context_line":"  }"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  if $::osfamily \u003d\u003d \u0027Debian\u0027 {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7a740942_571b9b80","line":60,"in_reply_to":"7a740942_c6bfdffa","updated":"2015-12-10 14:50:09.000000000","message":"This is a  different resource. The mode is set on /etc/neutron/plugins/nuage while 640 is set on /etc/neutron/plugins/nuage/plugin.ini which has not changed. I think the diff is causing confusion here.","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"}],"spec/classes/neutron_plugins_nuage_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"70363ed9b2bf1a7c5807382a714a88f112601254","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    it { is_expected.to contain_class(\u0027neutron::params\u0027) }"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    it \u0027should have a nuage plugin folder\u0027 do"},{"line_number":34,"context_line":"      is_expected.to contain_file(\u0027/etc/neutron/plugins/nuage\u0027).with("},{"line_number":35,"context_line":"        :ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":36,"context_line":"        :owner  \u003d\u003e \u0027root\u0027,"},{"line_number":37,"context_line":"        :group  \u003d\u003e \u0027neutron\u0027,"}],"source_content_type":"text/x-ruby","patch_set":12,"id":"7a740942_400b8c2a","line":34,"updated":"2015-12-11 16:30:51.000000000","message":"you can add test for file - it will same","commit_id":"d6aa8e1db02bf667785809bf28157a0f4c5ad235"}]}