)]}'
{"manifests/agents/l3.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"de2cfd38af6c65fdbf55968ceb31f9cd18871be2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  Neutron_l3_agent_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":142,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $allow_automatic_l3agent_failover {"},{"line_number":145,"context_line":"    notice(\u0027parameter allow_automatic_l3agent_failover is deprecated, use parameter in neutron::server instead\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_b90dac3f","line":142,"updated":"2015-12-03 06:44:23.000000000","message":"Based on the comment/commit message don\u0027t you want -\u003e not ~\u003e?  That being said, this might work as it would cause a restart of the service but the comment/commit message needs to be updated to reflect which one is used","commit_id":"18a5045410d40eb7a9f5ab9c5998a286429664e2"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ad8b4371349104b1b3de16e722811bda53478148","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  Neutron_l3_agent_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":142,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $allow_automatic_l3agent_failover {"},{"line_number":145,"context_line":"    notice(\u0027parameter allow_automatic_l3agent_failover is deprecated, use parameter in neutron::server instead\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_27a30802","line":142,"in_reply_to":"9a8ffd7b_4fe06029","updated":"2015-12-07 12:47:23.000000000","message":"May be will be better add this here? \n\nhttps://github.com/openstack/puppet-neutron/blob/master/manifests/services/fwaas.pp\n\nlike:\n\n  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service\u003c|title \u003d\u003d \u0027neutron-l3\u0027 |\u003e","commit_id":"18a5045410d40eb7a9f5ab9c5998a286429664e2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0e3ab042a3570202dfa79f3ca577335343a02579","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  Neutron_l3_agent_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":142,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $allow_automatic_l3agent_failover {"},{"line_number":145,"context_line":"    notice(\u0027parameter allow_automatic_l3agent_failover is deprecated, use parameter in neutron::server instead\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a740942_936a3eed","line":142,"in_reply_to":"9a8ffd7b_4fe06029","updated":"2015-12-07 14:08:53.000000000","message":"That\u0027s fine, can you update the commit message to reflect this?  The commit message only mentions that the configs need to be laid down before the service but that is not what this change is doing","commit_id":"18a5045410d40eb7a9f5ab9c5998a286429664e2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9689f5fab9520f2b21eadff7d3029fafeb25b117","unresolved":false,"context_lines":[{"line_number":139,"context_line":"  Neutron_l3_agent_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"  # FWaaS needs to be enabled before starting Neutron L3 agent"},{"line_number":142,"context_line":"  Neutron_fwaas_service_config\u003c||\u003e ~\u003e Service[\u0027neutron-l3\u0027]"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"  if $allow_automatic_l3agent_failover {"},{"line_number":145,"context_line":"    notice(\u0027parameter allow_automatic_l3agent_failover is deprecated, use parameter in neutron::server instead\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a8ffd7b_4fe06029","line":142,"in_reply_to":"9a8ffd7b_b90dac3f","updated":"2015-12-03 12:48:07.000000000","message":"We also need the notify in case you disable fwaas and want to make sure l3 agent took it in account.","commit_id":"18a5045410d40eb7a9f5ab9c5998a286429664e2"}]}