)]}'
{"manifests/plugins/ml2/opendaylight.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fff60201b9600ff960029929bcafd4362c12a086","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class neutron::plugins::ml2::opendaylight ("},{"line_number":29,"context_line":"  $package_ensure    \u003d \u0027present\u0027,"},{"line_number":30,"context_line":"  $odl_username      \u003d $::os_service_default,"},{"line_number":31,"context_line":"  $odl_password      \u003d $::os_service_default,"},{"line_number":32,"context_line":"  $odl_url           \u003d $::os_service_default,"},{"line_number":33,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_176f25c6","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":44},"updated":"2015-12-18 10:41:19.000000000","message":"for Neutron stable/liberty we don\u0027t have os_service_default feature.","commit_id":"baa73e4fedcf80d6b3a0bc1d62a443826c5a3a42"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"11ff483b4e2327df8736b56beb025260dbf3a892","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"class neutron::plugins::ml2::opendaylight ("},{"line_number":29,"context_line":"  $package_ensure    \u003d \u0027present\u0027,"},{"line_number":30,"context_line":"  $odl_username      \u003d $::os_service_default,"},{"line_number":31,"context_line":"  $odl_password      \u003d $::os_service_default,"},{"line_number":32,"context_line":"  $odl_url           \u003d $::os_service_default,"},{"line_number":33,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a7e1126_4162923f","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":44},"in_reply_to":"3a7e1126_176f25c6","updated":"2015-12-21 01:45:09.000000000","message":"Totally forgot about this, thanks. Should be fixed now, using the old style.","commit_id":"baa73e4fedcf80d6b3a0bc1d62a443826c5a3a42"}],"manifests/plugins/ovs/opendaylight.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"fafb42b00940b6ab7d98f5c586318bdf7a3e25dd","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  # OVS manager"},{"line_number":58,"context_line":"  exec { \u0027Set OVS Manager to OpenDaylight\u0027:"},{"line_number":59,"context_line":"    command \u003d\u003e \"/usr/bin/ovs-vsctl set-manager ${odl_ovsdb_iface}\","},{"line_number":60,"context_line":"    unless  \u003d\u003e \"/usr/bin/ovs-vsctl show | /usr/bin/grep \u0027Manager \\\"${odl_ovsdb_iface}\\\"\u0027\","},{"line_number":61,"context_line":"  } -\u003e"},{"line_number":62,"context_line":"  # local ip"},{"line_number":63,"context_line":"  exec { \u0027Set local_ip Other Option\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_14011106","line":60,"range":{"start_line":60,"start_character":47,"end_line":60,"end_character":50},"updated":"2015-12-21 13:03:10.000000000","message":"/usr/bin/grep doesn\u0027t exist on ubuntu. Can you please use:\npath    \u003d\u003e \u0027/usr/sbin:/usr/bin:/sbin:/bin\u0027\n\ninstead of hard-coding paths?","commit_id":"e3ada8a858e9abc0535d615d04afed92edd93c4e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"100d8bdae128dcd0f4df6210648ff015ecf453d1","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  # OVS manager"},{"line_number":58,"context_line":"  exec { \u0027Set OVS Manager to OpenDaylight\u0027:"},{"line_number":59,"context_line":"    command \u003d\u003e \"/usr/bin/ovs-vsctl set-manager ${odl_ovsdb_iface}\","},{"line_number":60,"context_line":"    unless  \u003d\u003e \"/usr/bin/ovs-vsctl show | /usr/bin/grep \u0027Manager \\\"${odl_ovsdb_iface}\\\"\u0027\","},{"line_number":61,"context_line":"  } -\u003e"},{"line_number":62,"context_line":"  # local ip"},{"line_number":63,"context_line":"  exec { \u0027Set local_ip Other Option\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_e065711d","line":60,"range":{"start_line":60,"start_character":47,"end_line":60,"end_character":50},"in_reply_to":"3a7e1126_0c081327","updated":"2015-12-22 12:26:35.000000000","message":"Good catch, Sergey! Also curl is under /usr/bin.\n\nHere is patch that fixes this problem in master. We should merge it at first and then cherry pick it to liberty.\n\nhttps://review.openstack.org/#/c/260468/","commit_id":"e3ada8a858e9abc0535d615d04afed92edd93c4e"},{"author":{"_account_id":6994,"name":"Michael Chapman","email":"woppin@gmail.com","username":"michaeltchapman"},"change_message_id":"887c697539dadc79aeebb511f79e6806dc87098f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  # OVS manager"},{"line_number":58,"context_line":"  exec { \u0027Set OVS Manager to OpenDaylight\u0027:"},{"line_number":59,"context_line":"    command \u003d\u003e \"/usr/bin/ovs-vsctl set-manager ${odl_ovsdb_iface}\","},{"line_number":60,"context_line":"    unless  \u003d\u003e \"/usr/bin/ovs-vsctl show | /usr/bin/grep \u0027Manager \\\"${odl_ovsdb_iface}\\\"\u0027\","},{"line_number":61,"context_line":"  } -\u003e"},{"line_number":62,"context_line":"  # local ip"},{"line_number":63,"context_line":"  exec { \u0027Set local_ip Other Option\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a7e1126_0c081327","line":60,"range":{"start_line":60,"start_character":47,"end_line":60,"end_character":50},"in_reply_to":"3a7e1126_14011106","updated":"2015-12-21 22:16:04.000000000","message":"Since this is a backport I\u0027ll do this as a separate patch.","commit_id":"e3ada8a858e9abc0535d615d04afed92edd93c4e"}]}
