)]}'
{"manifests/agents/dhcp.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"24aa2f384954e2ff56e18682a2d28da35bbc7e92","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dnsmasq_config_file      \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dhcp_delete_namespaces   \u003d true,"},{"line_number":92,"context_line":"  $enable_isolated_metadata \u003d false,"},{"line_number":93,"context_line":"  $enable_force_metadata    \u003d false,"},{"line_number":94,"context_line":"  $enable_metadata_network  \u003d false,"},{"line_number":95,"context_line":"  $dhcp_broadcast_reply     \u003d $::os_service_default,"},{"line_number":96,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a7b0d38_65a80e78","line":93,"updated":"2015-12-28 18:58:55.000000000","message":"This should use $::os_service_default unless there\u0027s a reason to be defining it as true/false","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"493789026c2489b1b19cb632aee8fa028f53d7e2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dnsmasq_config_file      \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dhcp_delete_namespaces   \u003d true,"},{"line_number":92,"context_line":"  $enable_isolated_metadata \u003d false,"},{"line_number":93,"context_line":"  $enable_force_metadata    \u003d false,"},{"line_number":94,"context_line":"  $enable_metadata_network  \u003d false,"},{"line_number":95,"context_line":"  $dhcp_broadcast_reply     \u003d $::os_service_default,"},{"line_number":96,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_056e4f2f","line":93,"in_reply_to":"1a7b0d38_65a80e78","updated":"2015-12-31 14:37:42.000000000","message":"I was wondering if I should use os_service_default when I wrote the patch, but I noticed enable_isolated_metadata is true/false which I wanted to mirror.  Is this just because it has not been updated yet to use os_service_default?","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"16851e90c4fc95ccba6887d2e32b39b09a6bd4d9","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dnsmasq_config_file      \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dhcp_delete_namespaces   \u003d true,"},{"line_number":92,"context_line":"  $enable_isolated_metadata \u003d false,"},{"line_number":93,"context_line":"  $enable_force_metadata    \u003d false,"},{"line_number":94,"context_line":"  $enable_metadata_network  \u003d false,"},{"line_number":95,"context_line":"  $dhcp_broadcast_reply     \u003d $::os_service_default,"},{"line_number":96,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_65bb8b73","line":93,"in_reply_to":"fa69d971_056e4f2f","updated":"2015-12-31 14:48:37.000000000","message":"Most likely, i don\u0027t think we\u0027ve done a full conversion yet but for new things we\u0027re leveraging os_service_default.","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"8c98b562359ee56df8ffd276e2bad19cc6744340","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $dnsmasq_config_file      \u003d $::os_service_default,"},{"line_number":91,"context_line":"  $dhcp_delete_namespaces   \u003d true,"},{"line_number":92,"context_line":"  $enable_isolated_metadata \u003d false,"},{"line_number":93,"context_line":"  $enable_force_metadata    \u003d false,"},{"line_number":94,"context_line":"  $enable_metadata_network  \u003d false,"},{"line_number":95,"context_line":"  $dhcp_broadcast_reply     \u003d $::os_service_default,"},{"line_number":96,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_c01d8567","line":93,"in_reply_to":"fa69d971_65bb8b73","updated":"2015-12-31 14:55:53.000000000","message":"OK will fix.","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"16851e90c4fc95ccba6887d2e32b39b09a6bd4d9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  } else {"},{"line_number":121,"context_line":"    neutron_dhcp_agent_config {"},{"line_number":122,"context_line":"      \u0027DEFAULT/enable_isolated_metadata\u0027: value \u003d\u003e $enable_isolated_metadata;"},{"line_number":123,"context_line":"      \u0027DEFAULT/enable_force_metadata\u0027:    value \u003d\u003e $enable_force_metadata;"},{"line_number":124,"context_line":"      \u0027DEFAULT/enable_metadata_network\u0027:  value \u003d\u003e $enable_metadata_network;"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_85631f1a","line":123,"range":{"start_line":123,"start_character":15,"end_line":123,"end_character":36},"updated":"2015-12-31 14:48:37.000000000","message":"Also i thought I had commented on this but isn\u0027t the configuration value \u0027force_metadata\u0027 not \u0027enable_force_metadata\u0027 https://review.openstack.org/#/c/211963/11/neutron/agent/dhcp/config.py","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"8c98b562359ee56df8ffd276e2bad19cc6744340","unresolved":false,"context_lines":[{"line_number":120,"context_line":"  } else {"},{"line_number":121,"context_line":"    neutron_dhcp_agent_config {"},{"line_number":122,"context_line":"      \u0027DEFAULT/enable_isolated_metadata\u0027: value \u003d\u003e $enable_isolated_metadata;"},{"line_number":123,"context_line":"      \u0027DEFAULT/enable_force_metadata\u0027:    value \u003d\u003e $enable_force_metadata;"},{"line_number":124,"context_line":"      \u0027DEFAULT/enable_metadata_network\u0027:  value \u003d\u003e $enable_metadata_network;"},{"line_number":125,"context_line":"    }"},{"line_number":126,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_8026adb8","line":123,"range":{"start_line":123,"start_character":15,"end_line":123,"end_character":36},"in_reply_to":"fa69d971_85631f1a","updated":"2015-12-31 14:55:53.000000000","message":"Thanks will fix it.","commit_id":"1a866ce13a4b465122dce5c7350ac36e186a4237"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"2b792f764158c053345d06de908dd09fb419dd99","unresolved":false,"context_lines":[{"line_number":55,"context_line":"#"},{"line_number":56,"context_line":"# [*enable_force_metadata*]"},{"line_number":57,"context_line":"#   (optional) enable metadata support on all networks."},{"line_number":58,"context_line":"#   Defaults to false."},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*enable_metadata_network*]"},{"line_number":61,"context_line":"#   (optional) Allows for serving metadata requests coming from a dedicated metadata"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa69d971_13914ff1","line":58,"range":{"start_line":58,"start_character":21,"end_line":58,"end_character":22},"updated":"2016-01-05 17:26:19.000000000","message":"$os_service_default","commit_id":"564d800a323785fefb1d6ed7100efbed2875bc8a"}]}
