)]}'
{"manifests/params.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5b8e8e7e2df97f35e1ec2b99111ce03b3f389dd0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        $ovs_agent_service   \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":102,"context_line":"      }"},{"line_number":103,"context_line":"      default: {"},{"line_number":104,"context_line":"        $ovs_agent_package   \u003d \u0027neutron-plugin-openvswitch-agent\u0027"},{"line_number":105,"context_line":"        $ovs_agent_service   \u003d \u0027neutron-plugin-openvswitch-agent\u0027"},{"line_number":106,"context_line":"      }"},{"line_number":107,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a7b0d38_91fa0e42","line":104,"range":{"start_line":104,"start_character":39,"end_line":104,"end_character":40},"updated":"2015-12-29 10:58:07.000000000","message":"Could you please make the same for other packages? E.x, neutron-plugin-linuxbridge-agent or sriov-agent","commit_id":"b46ec23f96b18679806a1c261341f68c0a439709"},{"author":{"_account_id":9500,"name":"Matt Fischer","email":"matt@mattfischer.com","username":"mfisch"},"change_message_id":"35a5855f90fa091135290df3270e8416037897a8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    case $::os_package_type {"},{"line_number":99,"context_line":"      \u0027debian\u0027: {"},{"line_number":100,"context_line":"        $ovs_agent_package   \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":101,"context_line":"        $ovs_agent_service   \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":102,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa69d971_7bea99dc","line":99,"updated":"2016-01-07 04:16:28.000000000","message":"does this also affect Ubuntu? It still has the plugin name there.","commit_id":"db04bf3514fb38130df938fa4ab764c07a9992ba"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a74209772f36972f10d179828bf99fe1a49f33a4","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    case $::os_package_type {"},{"line_number":99,"context_line":"      \u0027debian\u0027: {"},{"line_number":100,"context_line":"        $ovs_agent_package   \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":101,"context_line":"        $ovs_agent_service   \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":102,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa69d971_c65648cd","line":99,"in_reply_to":"fa69d971_7bea99dc","updated":"2016-01-07 04:57:03.000000000","message":"No this is to do the debian/ubuntu name differences.  This is within the $::osfamily \u003d\u003d \u0027Debian\u0027 block so in this case it\u0027s specifying a different name for \u0027debian\u0027 rather than \u0027ubuntu\u0027.  I guess this could just be an if/else block since we\u0027re only really comparing two values","commit_id":"db04bf3514fb38130df938fa4ab764c07a9992ba"}],"spec/classes/neutron_agents_ml2_ovs_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"169f245395959d662c0b3530996ca742fd3baf10","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    let :platform_params do"},{"line_number":252,"context_line":"      if :os_package_type \u003d\u003d \u0027debian\u0027"},{"line_number":253,"context_line":"        {"},{"line_number":254,"context_line":"          :ovs_agent_package \u003d\u003e \u0027neutron-openvswitch-agent\u0027,"},{"line_number":255,"context_line":"          :ovs_agent_service \u003d\u003e \u0027neutron-openvswitch-agent\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"1a7b0d38_a2534c6a","line":252,"updated":"2015-12-28 18:20:31.000000000","message":"I think this needs to be facts[:os_package_type]","commit_id":"ce570ae8baf2afe79c64da203d1f6462894bf713"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f4131ab259cf551239b922a9ffb65fd5862a387b","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    let :platform_params do"},{"line_number":252,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":253,"context_line":"        {"},{"line_number":254,"context_line":"          :ovs_agent_package \u003d\u003e \u0027neutron-openvswitch-agent\u0027,"},{"line_number":255,"context_line":"          :ovs_agent_service \u003d\u003e \u0027neutron-openvswitch-agent\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_9c1f8807","line":252,"updated":"2015-12-29 08:36:11.000000000","message":"This is IMHO useless add a conditional because you never test the case when os_package_type \u003d\u003d \u0027debian\u0027.\n\nWhat I would love to see is a new context with this os_package_type fact on Debian so we can really test the ovs agent package name/service.","commit_id":"b46ec23f96b18679806a1c261341f68c0a439709"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d61ba7b571d12dcd5a550c33f1d1cf29120a4f0c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    let :platform_params do"},{"line_number":252,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":253,"context_line":"        {"},{"line_number":254,"context_line":"          :ovs_agent_package \u003d\u003e \u0027neutron-openvswitch-agent\u0027,"},{"line_number":255,"context_line":"          :ovs_agent_service \u003d\u003e \u0027neutron-openvswitch-agent\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_20eae2ac","line":252,"in_reply_to":"1a7b0d38_72220554","updated":"2015-12-29 14:07:04.000000000","message":"Agree with Emilien.\n\nThis fact will never cover os_package_type \u003d\u003d debian, because there is no place, where we set this fact to debian. You should add a new context, like it done here: https://review.openstack.org/#/c/241741/","commit_id":"b46ec23f96b18679806a1c261341f68c0a439709"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"2503692a68af45dfcef21eb4ac224ea64fb4bfff","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    let :platform_params do"},{"line_number":252,"context_line":"      if facts[:os_package_type] \u003d\u003d \u0027debian\u0027"},{"line_number":253,"context_line":"        {"},{"line_number":254,"context_line":"          :ovs_agent_package \u003d\u003e \u0027neutron-openvswitch-agent\u0027,"},{"line_number":255,"context_line":"          :ovs_agent_service \u003d\u003e \u0027neutron-openvswitch-agent\u0027 }"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a7b0d38_72220554","line":252,"in_reply_to":"1a7b0d38_9c1f8807","updated":"2015-12-29 09:47:22.000000000","message":"What is it that you propose I do in the shorter term for this patch to be in a good enough shape to be accepted then? I\u0027m a bit confused, as I still don\u0027t see anything wrong with what I wrote.","commit_id":"b46ec23f96b18679806a1c261341f68c0a439709"}]}