)]}'
{"manifests/agents/vpnaas.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":56,"context_line":") {"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  include ::neutron::params"},{"line_number":59,"context_line":"  if $::neutron::params::vpnaas_agent_package {"},{"line_number":60,"context_line":"    Package[\u0027neutron\u0027] -\u003e Package[\u0027neutron-vpnaas-agent\u0027]"},{"line_number":61,"context_line":"    ensure_resource( \u0027package\u0027, \u0027neutron-vpnaas-agent\u0027, {"},{"line_number":62,"context_line":"      ensure \u003d\u003e $package_ensure,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_13a002a5","line":59,"updated":"2016-01-26 14:07:21.000000000","message":"Why do you move the whole section?\nDoing this kind of move does not help when you use git blame to see the code history in a file.","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"}],"manifests/server.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":183,"context_line":"#   Defaults to $::os_service_default."},{"line_number":184,"context_line":"#"},{"line_number":185,"context_line":"# [*ensure_vpnaas_package*]"},{"line_number":186,"context_line":"#   (optional) Ensures installation of VPNaaS package before starting API service."},{"line_number":187,"context_line":"#   Defaults to false."},{"line_number":188,"context_line":"#"},{"line_number":189,"context_line":"# [*ensure_fwaas_package*]"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_132a42e8","line":186,"updated":"2016-01-26 14:07:21.000000000","message":"I like having the boolean, but it would be even better if you could explain why we would need to enable them.\n\"Set to True, it installs the package that is required if the service_plugin is enabled on neutron-server nodes\" or something like this.\n\nThanks","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":253,"context_line":"      if $vpnaas_agent_package {"},{"line_number":254,"context_line":"        ensure_resource( \u0027package\u0027, $::neutron::params::vpnaas_agent_package, {"},{"line_number":255,"context_line":"          \u0027ensure\u0027 \u003d\u003e $neutron::package_ensure,"},{"line_number":256,"context_line":"          \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":257,"context_line":"        })"},{"line_number":258,"context_line":"        Package[$::neutron::params::vpnaas_agent_package] -\u003e Neutron_fwaas_service_config\u003c||\u003e"},{"line_number":259,"context_line":"      } else {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_d3aeea80","line":256,"updated":"2016-01-26 14:07:21.000000000","message":"I think we miss \u0027neutron-package\u0027 in the tag list.","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":260,"context_line":"        ensure_resource( \u0027package\u0027, \u0027neutron-fwaas\u0027 , {"},{"line_number":261,"context_line":"          \u0027name\u0027   \u003d\u003e $::neutron::params::fwaas_package,"},{"line_number":262,"context_line":"          \u0027ensure\u0027 \u003d\u003e $neutron::package_ensure,"},{"line_number":263,"context_line":"          \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":264,"context_line":"        })"},{"line_number":265,"context_line":"      }"},{"line_number":266,"context_line":"    } elsif($::osfamily \u003d\u003d \u0027Redhat\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_53c3da38","line":263,"updated":"2016-01-26 14:07:21.000000000","message":"dito","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":268,"context_line":"      ensure_resource( \u0027package\u0027, \u0027neutron-fwaas\u0027, {"},{"line_number":269,"context_line":"        \u0027name\u0027   \u003d\u003e $::neutron::params::fwaas_package,"},{"line_number":270,"context_line":"        \u0027ensure\u0027 \u003d\u003e $neutron::package_ensure,"},{"line_number":271,"context_line":"        \u0027tag\u0027    \u003d\u003e \u0027openstack\u0027"},{"line_number":272,"context_line":"      })"},{"line_number":273,"context_line":"    }"},{"line_number":274,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_13dc8217","line":271,"updated":"2016-01-26 14:07:21.000000000","message":"dito","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":277,"context_line":"    ensure_resource( \u0027package\u0027, \u0027neutron-vpnaas-agent\u0027, {"},{"line_number":278,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":279,"context_line":"      name   \u003d\u003e $::neutron::params::vpnaas_agent_package,"},{"line_number":280,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":281,"context_line":"    })"},{"line_number":282,"context_line":"  }"},{"line_number":283,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_d3e58adc","line":280,"updated":"2016-01-26 14:07:21.000000000","message":"oh you have it here :-)","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"215b0e029cdaa00c9ddece91c54e026f92e20521","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    ensure_resource( \u0027package\u0027, \u0027neutron-lbaas-agent\u0027, {"},{"line_number":286,"context_line":"      ensure \u003d\u003e $package_ensure,"},{"line_number":287,"context_line":"      name   \u003d\u003e $::neutron::params::lbaas_agent_package,"},{"line_number":288,"context_line":"      tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":289,"context_line":"    })"},{"line_number":290,"context_line":"  }"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a68dd71_f3ea0eac","line":288,"updated":"2016-01-26 14:07:21.000000000","message":"and here too!","commit_id":"9c18dadb5a7d07770e9c275356aeffcde7cf0c83"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3e60a61f7719791d56f258647fd28dad952c18d4","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  require keystone::python"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  if $ensure_fwaas_package {"},{"line_number":254,"context_line":"    if ($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":255,"context_line":"      # Debian platforms"},{"line_number":256,"context_line":"      if $vpnaas_agent_package {"},{"line_number":257,"context_line":"        ensure_resource( \u0027package\u0027, $::neutron::params::vpnaas_agent_package, {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a68dd71_d15a5d50","line":254,"range":{"start_line":254,"start_character":4,"end_line":254,"end_character":32},"updated":"2016-01-26 15:46:00.000000000","message":"Can we move this to params.pp?","commit_id":"ff096ccfeb1b753547ca051932f772adf96cd558"},{"author":{"_account_id":11166,"name":"Lukas Bezdicka","email":"social@v3.sk","username":"xbezdick"},"change_message_id":"3a91f0e42cdb9b302674a1f85aae6a72681464ef","unresolved":false,"context_lines":[{"line_number":251,"context_line":"  require keystone::python"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"  if $ensure_fwaas_package {"},{"line_number":254,"context_line":"    if ($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":255,"context_line":"      # Debian platforms"},{"line_number":256,"context_line":"      if $vpnaas_agent_package {"},{"line_number":257,"context_line":"        ensure_resource( \u0027package\u0027, $::neutron::params::vpnaas_agent_package, {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a5de9d1_fa7d11e8","line":254,"range":{"start_line":254,"start_character":4,"end_line":254,"end_character":32},"in_reply_to":"9a68dd71_d15a5d50","updated":"2016-01-27 13:32:11.000000000","message":"This can\u0027t be moved to params as in this case we use class parameter $vpnaas_agent_package.","commit_id":"ff096ccfeb1b753547ca051932f772adf96cd558"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7cbf74daf23ec062e9185d375af44182a9298fe2","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if ($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":255,"context_line":"      # Debian platforms"},{"line_number":256,"context_line":"      if $vpnaas_agent_package {"},{"line_number":257,"context_line":"        ensure_resource( \u0027package\u0027, $::neutron::params::vpnaas_agent_package, {"},{"line_number":258,"context_line":"          \u0027ensure\u0027 \u003d\u003e $neutron::package_ensure,"},{"line_number":259,"context_line":"          \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":260,"context_line":"        })"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a68dd71_5b8c4c35","line":257,"range":{"start_line":257,"start_character":38,"end_line":257,"end_character":76},"updated":"2016-01-26 15:13:43.000000000","message":"As I understand, these packages are installed from appropriate classes (*aaS), why do you want to install them here? If smb wants to use them, he will include classes","commit_id":"ff096ccfeb1b753547ca051932f772adf96cd558"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"3e60a61f7719791d56f258647fd28dad952c18d4","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    if ($::osfamily \u003d\u003d \u0027Debian\u0027) {"},{"line_number":255,"context_line":"      # Debian platforms"},{"line_number":256,"context_line":"      if $vpnaas_agent_package {"},{"line_number":257,"context_line":"        ensure_resource( \u0027package\u0027, $::neutron::params::vpnaas_agent_package, {"},{"line_number":258,"context_line":"          \u0027ensure\u0027 \u003d\u003e $neutron::package_ensure,"},{"line_number":259,"context_line":"          \u0027tag\u0027    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":260,"context_line":"        })"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a68dd71_b16c8937","line":257,"range":{"start_line":257,"start_character":38,"end_line":257,"end_character":76},"in_reply_to":"9a68dd71_5b8c4c35","updated":"2016-01-26 15:46:00.000000000","message":"Got the point","commit_id":"ff096ccfeb1b753547ca051932f772adf96cd558"}],"spec/classes/neutron_server_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d578d3250f07680c0fb11b10c1173ad440a007e0","unresolved":false,"context_lines":[{"line_number":239,"context_line":"    before do"},{"line_number":240,"context_line":"      params.merge!("},{"line_number":241,"context_line":"        :ensure_vpnaas_package \u003d\u003e true,"},{"line_number":242,"context_line":"        :ensure_fwaas_package \u003d\u003e true,"},{"line_number":243,"context_line":"        :ensure_lbaas_package \u003d\u003e true"},{"line_number":244,"context_line":"      )"},{"line_number":245,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dae33548_cbf8907f","line":242,"updated":"2016-02-15 16:17:01.000000000","message":"if you could align the \"\u003d\u003e\" that would be awesome.","commit_id":"cc2c6ed464240526c1edaccc0f4a79b964d49249"}]}
