)]}'
{"manifests/agents/dhcp.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7bcefcad283f46682afee49be71b8c31501f7b4a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*dhcp_delete_namespaces*]"},{"line_number":66,"context_line":"#   (optional) Deprecated. Delete namespace after removing a dhcp server"},{"line_number":67,"context_line":"#   Defaults to true."},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*dhcp_domain*]"},{"line_number":70,"context_line":"#   (optional) Deprecated. Domain to use for building the hostnames"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_2255894f","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":21},"updated":"2016-01-28 09:48:04.000000000","message":"Please change to $::os_service_default as you did it below","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d31883d39ef99614589fac8161440c90e6cc4829","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) DHCP lease"},{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*dns_domain*]"},{"line_number":66,"context_line":"#   (optional) Domain to use for building the hostnames"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*dhcp_agents_per_network*]"},{"line_number":70,"context_line":"#   (optional) Number of DHCP agents scheduled to host a network."},{"line_number":71,"context_line":"#   This enables redundant DHCP agents for configured networks."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_f2176d52","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":1},"updated":"2016-01-27 14:25:14.000000000","message":"i believe, that it should be done in separate commit, if there no any reason to mix it with deprecation another parameters.","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"af487905e5b82ebbd179d5faade7dddf1973bb49","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) DHCP lease"},{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*dns_domain*]"},{"line_number":66,"context_line":"#   (optional) Domain to use for building the hostnames"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*dhcp_agents_per_network*]"},{"line_number":70,"context_line":"#   (optional) Number of DHCP agents scheduled to host a network."},{"line_number":71,"context_line":"#   This enables redundant DHCP agents for configured networks."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_987950ff","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":1},"in_reply_to":"7a5de9d1_226ee92f","updated":"2016-01-28 10:20:02.000000000","message":"Oh, yeah, i see it here:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/dhcp/config.py#L66-L71\n\nThen cover comments from Sergey.","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7bcefcad283f46682afee49be71b8c31501f7b4a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) DHCP lease"},{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*dns_domain*]"},{"line_number":66,"context_line":"#   (optional) Domain to use for building the hostnames"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*dhcp_agents_per_network*]"},{"line_number":70,"context_line":"#   (optional) Number of DHCP agents scheduled to host a network."},{"line_number":71,"context_line":"#   This enables redundant DHCP agents for configured networks."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_226ee92f","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":1},"in_reply_to":"7a5de9d1_87f812e7","updated":"2016-01-28 09:48:04.000000000","message":"Agree with Jerzy. I don\u0027t see a problem here","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"},{"author":{"_account_id":19561,"name":"Jerzy Mikolajczak","email":"jmikolajczak@mirantis.com","username":"jmikolajczak"},"change_message_id":"865f9c53338dd9fc54de2a96ea55c99de424502d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"#   (optional) DHCP lease"},{"line_number":63,"context_line":"#   Defaults to $::os_service_default"},{"line_number":64,"context_line":"#"},{"line_number":65,"context_line":"# [*dns_domain*]"},{"line_number":66,"context_line":"#   (optional) Domain to use for building the hostnames"},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*dhcp_agents_per_network*]"},{"line_number":70,"context_line":"#   (optional) Number of DHCP agents scheduled to host a network."},{"line_number":71,"context_line":"#   This enables redundant DHCP agents for configured networks."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a5de9d1_87f812e7","line":68,"range":{"start_line":65,"start_character":0,"end_line":68,"end_character":1},"in_reply_to":"7a5de9d1_f2176d52","updated":"2016-01-28 08:08:07.000000000","message":"I\u0027ve done it in a single commit because dns_domain is a replacement for dhcp_domain.","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"}],"spec/classes/neutron_init_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7bcefcad283f46682afee49be71b8c31501f7b4a","unresolved":false,"context_lines":[{"line_number":113,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/base_mac\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":114,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/mac_generation_retries\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":115,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/dhcp_lease_duration\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":116,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/dns_domain\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":117,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/dhcp_agents_per_network\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":118,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/network_device_mtu\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":119,"context_line":"      is_expected.to contain_neutron_config(\u0027DEFAULT/dhcp_agent_notification\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"7a5de9d1_353f05b6","line":116,"range":{"start_line":116,"start_character":53,"end_line":116,"end_character":63},"updated":"2016-01-28 09:48:04.000000000","message":"Please also add a test where you change the default value","commit_id":"95b46b3e1c103c67b8652e02ec42d8d6df432d66"}]}