)]}'
{"manifests/params.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"303cf0714ab18439f390b77462764317a0efb3be","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    $midonet_server_package \u003d \u0027python-neutron-plugin-midonet\u0027"},{"line_number":43,"context_line":"    $midonet_config_file    \u003d \u0027/etc/neutron/plugins/midonet/midonet.ini\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    $plumgrid_plugin_package    \u003d \u0027networking-plumgrid\u0027"},{"line_number":46,"context_line":"    $plumgrid_pythonlib_package \u003d \u0027plumgrid-pythonlib\u0027"},{"line_number":47,"context_line":"    $plumgrid_config_file       \u003d \u0027/etc/neutron/plugins/plumgrid/plumgrid.ini\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_a332895d","line":45,"range":{"start_line":45,"start_character":35,"end_line":45,"end_character":54},"updated":"2016-02-05 09:41:58.000000000","message":"This package seems to be not available from UCA","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"b71305551f6a9cd6900460005440d1ae9199d87b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    $midonet_server_package \u003d \u0027python-neutron-plugin-midonet\u0027"},{"line_number":43,"context_line":"    $midonet_config_file    \u003d \u0027/etc/neutron/plugins/midonet/midonet.ini\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    $plumgrid_plugin_package    \u003d \u0027networking-plumgrid\u0027"},{"line_number":46,"context_line":"    $plumgrid_pythonlib_package \u003d \u0027plumgrid-pythonlib\u0027"},{"line_number":47,"context_line":"    $plumgrid_config_file       \u003d \u0027/etc/neutron/plugins/plumgrid/plumgrid.ini\u0027"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_7fe973e5","line":45,"range":{"start_line":45,"start_character":35,"end_line":45,"end_character":54},"in_reply_to":"5a5ae5dd_a332895d","updated":"2016-02-05 16:41:10.000000000","message":"This package is managed by plumgrid itself and the plumgrid mirrors are configured during the install to get it from there.\nAnd the source code is managed at https://github.com/openstack/networking-plumgrid","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"}],"manifests/plugins/plumgrid.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b89e64054de6ad742889c799f6ad118b7940cf0e","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":68,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"},{"line_number":69,"context_line":"  $metadata_proxy_shared_secret \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $package_ensure               \u003d \u0027present\u0027"},{"line_number":71,"context_line":") {"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_83a3cdb1","side":"PARENT","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":17},"updated":"2016-02-05 09:36:57.000000000","message":"you shouldn\u0027t change this parameter - it\u0027s common for all modules.","commit_id":"ee9eb9d8d5c2f3e39cbeb9e85b351b593a750474"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9679083aecf959eb641d5d78b641eb5a076052b6","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":68,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"},{"line_number":69,"context_line":"  $metadata_proxy_shared_secret \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $package_ensure               \u003d \u0027present\u0027"},{"line_number":71,"context_line":") {"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_6a43b813","side":"PARENT","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":17},"in_reply_to":"5a5ae5dd_3f9d3b66","updated":"2016-02-08 10:56:38.000000000","message":"So, first of all, you can\u0027t simply remove some parameter. If you want to do this - you should go through deprecation cycle: make it deprecated, raise warning message, keep it with a new parameter with using suffix _real.","commit_id":"ee9eb9d8d5c2f3e39cbeb9e85b351b593a750474"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"e7dbb844409c2989e729d0ab4ce199f6980dc392","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":68,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"},{"line_number":69,"context_line":"  $metadata_proxy_shared_secret \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $package_ensure               \u003d \u0027present\u0027"},{"line_number":71,"context_line":") {"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_8045a743","side":"PARENT","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":17},"in_reply_to":"5a5ae5dd_6a43b813","updated":"2016-02-08 15:47:42.000000000","message":"I think its good to stick with the package_ensure parameter for main plugin package install to keep things common with other modules. Whereas introduce a new param for pglib package.","commit_id":"ee9eb9d8d5c2f3e39cbeb9e85b351b593a750474"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"b71305551f6a9cd6900460005440d1ae9199d87b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":68,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"},{"line_number":69,"context_line":"  $metadata_proxy_shared_secret \u003d $::os_service_default,"},{"line_number":70,"context_line":"  $package_ensure               \u003d \u0027present\u0027"},{"line_number":71,"context_line":") {"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_3f9d3b66","side":"PARENT","line":70,"range":{"start_line":70,"start_character":3,"end_line":70,"end_character":17},"in_reply_to":"5a5ae5dd_83a3cdb1","updated":"2016-02-05 16:41:10.000000000","message":"there are two different packages with different versions getting installed, not sure how can I handle it otherwise. I can keep $package_ensure to use it for plugin package and keep the pglib package to the \u0027present\u0027 only. What you say?","commit_id":"ee9eb9d8d5c2f3e39cbeb9e85b351b593a750474"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"303cf0714ab18439f390b77462764317a0efb3be","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_c3746537","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"updated":"2016-02-05 09:41:58.000000000","message":"Does it make sense to leave password field as optional?","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9679083aecf959eb641d5d78b641eb5a076052b6","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_8a85d45a","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"in_reply_to":"5a5ae5dd_3f753bf9","updated":"2016-02-08 10:56:38.000000000","message":"Sergey meant, that: is it good idea to set this parameter as optional? May be it should be required?","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"e7dbb844409c2989e729d0ab4ce199f6980dc392","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_cd23d8bb","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"in_reply_to":"5a5ae5dd_8a85d45a","updated":"2016-02-08 15:47:42.000000000","message":"l2gateway_* fields are optional for user to set for some extra features. What I can do here if l2gateway_username is provided then make l2gateway_password required below in manifest.","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"f5ceddbdc4cef896dfe31a07364aa3885bbeb34d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_52e460aa","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"in_reply_to":"5a5ae5dd_c36649ec","updated":"2016-02-08 17:32:21.000000000","message":"Ok, I will keep it optional. Thanks.","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"b71305551f6a9cd6900460005440d1ae9199d87b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_3f753bf9","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"in_reply_to":"5a5ae5dd_c3746537","updated":"2016-02-05 16:41:10.000000000","message":"I can put it to undef but I didn\u0027t actually understand your point here, can you please explain a bit.","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"f517f3ec4292ca08f4ad3754076cd36d439b86fc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*l2gateway_password*]"},{"line_number":70,"context_line":"#   L2 gateway password"},{"line_number":71,"context_line":"#   Defaults to $::os_service_default"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*plugin_package_ensure*]"},{"line_number":74,"context_line":"#   (optional) Ensure state for plugin package."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_c36649ec","line":71,"range":{"start_line":71,"start_character":4,"end_line":71,"end_character":37},"in_reply_to":"5a5ae5dd_cd23d8bb","updated":"2016-02-08 15:54:19.000000000","message":"I\u0027m ok with the current solution if these credentials are optional","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"303cf0714ab18439f390b77462764317a0efb3be","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :                value \u003d\u003e \u0027admin\u0027;"},{"line_number":165,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:             value \u003d\u003e $admin_password, secret \u003d\u003etrue;"},{"line_number":166,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:                   value \u003d\u003e \"${auth_protocol}://${controller_priv_host}:35357/${identity_version}\";"},{"line_number":167,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027:          value \u003d\u003e \u0027admin\u0027;"},{"line_number":168,"context_line":"    \u0027keystone_authtoken/identity_version\u0027:           value \u003d\u003e $identity_version;"},{"line_number":169,"context_line":"    \u0027PLUMgridMetadata/enable_pg_metadata\u0027 :          value \u003d\u003e \u0027True\u0027;"},{"line_number":170,"context_line":"    \u0027PLUMgridMetadata/metadata_mode\u0027:                value \u003d\u003e \u0027local\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_c3d9c523","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":43},"updated":"2016-02-05 09:41:58.000000000","message":"Is it enough to set existing parameters to switch to v3 auth version?","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"f517f3ec4292ca08f4ad3754076cd36d439b86fc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :                value \u003d\u003e \u0027admin\u0027;"},{"line_number":165,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:             value \u003d\u003e $admin_password, secret \u003d\u003etrue;"},{"line_number":166,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:                   value \u003d\u003e \"${auth_protocol}://${controller_priv_host}:35357/${identity_version}\";"},{"line_number":167,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027:          value \u003d\u003e \u0027admin\u0027;"},{"line_number":168,"context_line":"    \u0027keystone_authtoken/identity_version\u0027:           value \u003d\u003e $identity_version;"},{"line_number":169,"context_line":"    \u0027PLUMgridMetadata/enable_pg_metadata\u0027 :          value \u003d\u003e \u0027True\u0027;"},{"line_number":170,"context_line":"    \u0027PLUMgridMetadata/metadata_mode\u0027:                value \u003d\u003e \u0027local\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_c3f729d1","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":43},"in_reply_to":"5a5ae5dd_1f1f1f6d","updated":"2016-02-08 15:54:19.000000000","message":"I\u0027m asking because for v3 you normally need to specify *_domain parameters, for example, which are not available when you use old authentication scheme (without auth plugins). If current solution is enough, we can keep it","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"b71305551f6a9cd6900460005440d1ae9199d87b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :                value \u003d\u003e \u0027admin\u0027;"},{"line_number":165,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:             value \u003d\u003e $admin_password, secret \u003d\u003etrue;"},{"line_number":166,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:                   value \u003d\u003e \"${auth_protocol}://${controller_priv_host}:35357/${identity_version}\";"},{"line_number":167,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027:          value \u003d\u003e \u0027admin\u0027;"},{"line_number":168,"context_line":"    \u0027keystone_authtoken/identity_version\u0027:           value \u003d\u003e $identity_version;"},{"line_number":169,"context_line":"    \u0027PLUMgridMetadata/enable_pg_metadata\u0027 :          value \u003d\u003e \u0027True\u0027;"},{"line_number":170,"context_line":"    \u0027PLUMgridMetadata/metadata_mode\u0027:                value \u003d\u003e \u0027local\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_1f1f1f6d","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":43},"in_reply_to":"5a5ae5dd_c3d9c523","updated":"2016-02-05 16:41:10.000000000","message":"Not sure, I have to check with developers but current implementation needs this. I can remove it back once the support added to on the plugin side to reduce this parameter.","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"},{"author":{"_account_id":15675,"name":"Salman","email":"engrsalmankhan@gmail.com","username":"engrsalmankhan"},"change_message_id":"f5ceddbdc4cef896dfe31a07364aa3885bbeb34d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :                value \u003d\u003e \u0027admin\u0027;"},{"line_number":165,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:             value \u003d\u003e $admin_password, secret \u003d\u003etrue;"},{"line_number":166,"context_line":"    \u0027keystone_authtoken/auth_uri\u0027:                   value \u003d\u003e \"${auth_protocol}://${controller_priv_host}:35357/${identity_version}\";"},{"line_number":167,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027:          value \u003d\u003e \u0027admin\u0027;"},{"line_number":168,"context_line":"    \u0027keystone_authtoken/identity_version\u0027:           value \u003d\u003e $identity_version;"},{"line_number":169,"context_line":"    \u0027PLUMgridMetadata/enable_pg_metadata\u0027 :          value \u003d\u003e \u0027True\u0027;"},{"line_number":170,"context_line":"    \u0027PLUMgridMetadata/metadata_mode\u0027:                value \u003d\u003e \u0027local\u0027;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a5ae5dd_d258508c","line":167,"range":{"start_line":167,"start_character":4,"end_line":167,"end_character":43},"in_reply_to":"5a5ae5dd_c3f729d1","updated":"2016-02-08 17:32:21.000000000","message":"I could have added those v3 domain parameters here but with current implementation they are not needed but might be needed in future. I will add them later once they are needed.","commit_id":"456f4d114ea7f913421ce8a288cc6c2e224e9782"}]}