)]}'
{"manifests/plugins/ml2/midonet.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e26fdd9cdff92438131358aced36c411027b229","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class neutron::plugins::ml2::midonet ("},{"line_number":24,"context_line":"  $midonet_uri \u003d \u0027http://localhost:8080/midonet-api\u0027,"},{"line_number":25,"context_line":"  $username    \u003d \u0027admin\u0027,"},{"line_number":26,"context_line":"  $password    \u003d \u0027passw0rd\u0027,"},{"line_number":27,"context_line":"  $project_id  \u003d \u0027admin\u0027,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_62495dd0","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":25},"updated":"2016-02-10 08:09:22.000000000","message":"are these fields good to be optional? May be better make them as required?","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"739c64ae4b47894b800c2636d763fdd194e1993e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class neutron::plugins::ml2::midonet ("},{"line_number":24,"context_line":"  $midonet_uri \u003d \u0027http://localhost:8080/midonet-api\u0027,"},{"line_number":25,"context_line":"  $username    \u003d \u0027admin\u0027,"},{"line_number":26,"context_line":"  $password    \u003d \u0027passw0rd\u0027,"},{"line_number":27,"context_line":"  $project_id  \u003d \u0027admin\u0027,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_ebbf1ef9","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"3a57f1b5_5e6e4b30","updated":"2016-02-11 11:28:11.000000000","message":"If these parameters are really optional (it\u0027s possible to work without them), let\u0027s set them to $::os_service_default. Otherwise please change \"password\" to \"false\" and make it required, other parameters values are up to you (you can leave them set to \u0027admin\u0027 if it makes sense)","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"1a35d86fae3ff0cff07f4016323906027ce01801","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class neutron::plugins::ml2::midonet ("},{"line_number":24,"context_line":"  $midonet_uri \u003d \u0027http://localhost:8080/midonet-api\u0027,"},{"line_number":25,"context_line":"  $username    \u003d \u0027admin\u0027,"},{"line_number":26,"context_line":"  $password    \u003d \u0027passw0rd\u0027,"},{"line_number":27,"context_line":"  $project_id  \u003d \u0027admin\u0027,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_5e6e4b30","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"3a57f1b5_62495dd0","updated":"2016-02-10 22:43:46.000000000","message":"Sure can do, I was just following other examples which use defaults for all things","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"301dd9bc697cd1578773ef5904ca37616531c441","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class neutron::plugins::ml2::midonet ("},{"line_number":24,"context_line":"  $midonet_uri \u003d \u0027http://localhost:8080/midonet-api\u0027,"},{"line_number":25,"context_line":"  $username    \u003d \u0027admin\u0027,"},{"line_number":26,"context_line":"  $password    \u003d \u0027passw0rd\u0027,"},{"line_number":27,"context_line":"  $project_id  \u003d \u0027admin\u0027,"},{"line_number":28,"context_line":") {"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_20252fc0","line":27,"range":{"start_line":25,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"3a57f1b5_ebbf1ef9","updated":"2016-02-11 22:24:14.000000000","message":"OK will do","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"07b344332cac96ff24bcf606a1f604591b5b09fc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"class neutron::plugins::ml2::midonet ("},{"line_number":21,"context_line":"  $midonet_uri \u003d \u0027http://localhost:8080/midonet-api\u0027,"},{"line_number":22,"context_line":"  $username    \u003d \u0027admin\u0027,"},{"line_number":23,"context_line":"  $password    \u003d false,"},{"line_number":24,"context_line":"  $project_id  \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a57f1b5_728be468","line":24,"range":{"start_line":22,"start_character":0,"end_line":24,"end_character":24},"updated":"2016-02-12 10:22:22.000000000","message":"if these fields are required, they shouldn\u0027t have default values.","commit_id":"b573e95c5a5acde799cee55994e81042a6eb43f3"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"aa1930e43bf0c6217b607cdd33d359ea7ba342ac","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# [*midonet_uri*]"},{"line_number":8,"context_line":"#   (required) MidoNet API server URI."},{"line_number":9,"context_line":"#   Defaults to \u0027http://localhost:8080/midonet-api\u0027"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*username*]"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bae84128_2c160e4c","line":8,"range":{"start_line":8,"start_character":5,"end_line":8,"end_character":13},"updated":"2016-02-23 08:22:54.000000000","message":"As you provide a default value, this option is not required. So either remove the default value, or mark this parameter as optional","commit_id":"6cd1624df25d94cfdfa1c7346e2794dcdf5cd094"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"f2bda5b1a0939592cf8d4e0d793b4d1338770fc6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  $midonet_uri,"},{"line_number":22,"context_line":"  $username,"},{"line_number":23,"context_line":"  $password,"},{"line_number":24,"context_line":"  $project_id,"},{"line_number":25,"context_line":") {"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"bae84128_a1474a4a","line":24,"updated":"2016-02-24 23:57:30.000000000","message":"Across the rest of the Puppet OpenStack module set, this is often defaulted to \u0027services\u0027.  In Class[*::keytone::auth] the parameter to used is called \"tenant\".  There is one ml2 related class in the neutron module Class[neutron:plugins::ml2::bigswitch::restproxy] that set a precedence here for using \"auth_tenant\" as the parameter name and setting it to \"services\".\n\nIn my opinion that parameter name makes at least decent sense and to stay congruent with the rest of the modules, the default should be \"services\".","commit_id":"c2663fe729e6ee20b01891ff09b1b3566fb594c2"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"fd40e3e8550dd160246a3cdb7b905312c06130ea","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $midonet_uri,"},{"line_number":23,"context_line":"  $username,"},{"line_number":24,"context_line":"  $password,"},{"line_number":25,"context_line":"  $project_id \u003d \u0027service\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_f91c666c","line":25,"updated":"2016-02-25 01:17:35.000000000","message":"Likely a typo, \"services\" is the common usage.","commit_id":"b94b28653739383d223cf8f11634cb4930288c3f"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"eb056c6d0863f0216ecd24d2b170ecbd23c82b10","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $midonet_uri,"},{"line_number":23,"context_line":"  $username,"},{"line_number":24,"context_line":"  $password,"},{"line_number":25,"context_line":"  $project_id \u003d \u0027service\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"bae84128_79fdf66d","line":25,"in_reply_to":"bae84128_f91c666c","updated":"2016-02-25 01:32:09.000000000","message":"I want by the provided example at https://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2/bigswitch/restproxy.pp which is \"service\"","commit_id":"b94b28653739383d223cf8f11634cb4930288c3f"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"3e7a263c76249a3f380e867857ca23582da90526","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  $midonet_uri,"},{"line_number":23,"context_line":"  $username,"},{"line_number":24,"context_line":"  $password,"},{"line_number":25,"context_line":"  $project_id \u003d \u0027service\u0027,"},{"line_number":26,"context_line":") {"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  neutron_plugin_ml2 {"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"9aed3d3a_57d8c7ef","line":25,"updated":"2016-02-25 20:39:35.000000000","message":"Even though this matches the other example for bigswitch, this default will literally just fail if people are relying on defaults in other part of the code base.  Because of this it is going to be best to default to services and put in a patch to fix the other one.","commit_id":"986d6746194f16f10f1746aa75e9812fc96c63a6"}],"manifests/plugins/ml2/type_driver.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4e26fdd9cdff92438131358aced36c411027b229","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # Nexus_vxlan type driver has its own class separate from this one"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  elsif ($name \u003d\u003d \u0027midonet\u0027) or ($name \u003d\u003d \u0027uplink\u0027) {"},{"line_number":111,"context_line":"    # midonet type driver has its own class separate from this one"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"  else {"},{"line_number":114,"context_line":"    # detect an invalid type_drivers value"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_e2e6ade7","line":111,"updated":"2016-02-10 08:09:22.000000000","message":"it\u0027s better to spawn warning message here","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"301dd9bc697cd1578773ef5904ca37616531c441","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # Nexus_vxlan type driver has its own class separate from this one"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  elsif ($name \u003d\u003d \u0027midonet\u0027) or ($name \u003d\u003d \u0027uplink\u0027) {"},{"line_number":111,"context_line":"    # midonet type driver has its own class separate from this one"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"  else {"},{"line_number":114,"context_line":"    # detect an invalid type_drivers value"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_c0569b29","line":111,"in_reply_to":"3a57f1b5_4b6f5292","updated":"2016-02-11 22:24:14.000000000","message":"This block is needed as it will get to the else and fail","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":3031,"name":"Sam Morrison","email":"sorrison@gmail.com","username":"sorrison"},"change_message_id":"1a35d86fae3ff0cff07f4016323906027ce01801","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # Nexus_vxlan type driver has its own class separate from this one"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  elsif ($name \u003d\u003d \u0027midonet\u0027) or ($name \u003d\u003d \u0027uplink\u0027) {"},{"line_number":111,"context_line":"    # midonet type driver has its own class separate from this one"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"  else {"},{"line_number":114,"context_line":"    # detect an invalid type_drivers value"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_fe15b79a","line":111,"in_reply_to":"3a57f1b5_e2e6ade7","updated":"2016-02-10 22:43:46.000000000","message":"I just copied how the cisco driver did it. \nI don\u0027t think you want a warning here what would it say?","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"739c64ae4b47894b800c2636d763fdd194e1993e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    # Nexus_vxlan type driver has its own class separate from this one"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":"  elsif ($name \u003d\u003d \u0027midonet\u0027) or ($name \u003d\u003d \u0027uplink\u0027) {"},{"line_number":111,"context_line":"    # midonet type driver has its own class separate from this one"},{"line_number":112,"context_line":"  }"},{"line_number":113,"context_line":"  else {"},{"line_number":114,"context_line":"    # detect an invalid type_drivers value"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a57f1b5_4b6f5292","line":111,"in_reply_to":"3a57f1b5_fe15b79a","updated":"2016-02-11 11:28:11.000000000","message":"Let\u0027s remove this block at all, if it doesn\u0027t make sense to raise a warning here","commit_id":"bb74581c31532d8bdbcf1102c2fabb6a290a3ebd"}]}
