)]}'
{"manifests/agents/metadata.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0722726b5d9f106bae93cb66cac1b40b70570faa","unresolved":false,"context_lines":[{"line_number":113,"context_line":"  if $auth_password {"},{"line_number":114,"context_line":"    warning(\u0027The auth_password parameter is deprecated and was removed in Mitaka release.\u0027)"},{"line_number":115,"context_line":"    neutron_metadata_agent_config {"},{"line_number":116,"context_line":"      \u0027DEFAULT/admin_password\u0027:               value \u003d\u003e $auth_password, secret \u003d\u003e true;"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":"  }"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_5cadcb99","line":116,"range":{"start_line":116,"start_character":6,"end_line":116,"end_character":86},"updated":"2016-03-10 12:03:22.000000000","message":"not sure that we should set all of them to config, because they are ALREADY removed. You should just only raise warning message.","commit_id":"eb0e56483451c432042b3862f203c109ffb7f920"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"abaebde328f5c53ad63710453d741326f36cfee2","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    warning(\u0027The auth_url parameter is deprecated and was removed in Mitaka release.\u0027)"},{"line_number":122,"context_line":"  }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  if $auth_insecure !\u003d undef {"},{"line_number":125,"context_line":"    warning(\u0027The auth_insecure parameter is deprecated and was removed in Mitaka release.\u0027)"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5aef4532_2d07e782","line":124,"updated":"2016-03-10 13:00:16.000000000","message":"why this if statement is different from others?","commit_id":"72d4b2dcb46be3f8f67dd48437538d0362014384"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1cacc86a11ae8ce18c79cf421434cc833dfbe12b","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    warning(\u0027The auth_url parameter is deprecated and was removed in Mitaka release.\u0027)"},{"line_number":122,"context_line":"  }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"  if $auth_insecure !\u003d undef {"},{"line_number":125,"context_line":"    warning(\u0027The auth_insecure parameter is deprecated and was removed in Mitaka release.\u0027)"},{"line_number":126,"context_line":"  }"},{"line_number":127,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"5aef4532_08bc99b9","line":124,"in_reply_to":"5aef4532_2d07e782","updated":"2016-03-10 13:17:11.000000000","message":"can be false, all another - strings","commit_id":"72d4b2dcb46be3f8f67dd48437538d0362014384"}],"spec/classes/neutron_agents_metadata_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"1cacc86a11ae8ce18c79cf421434cc833dfbe12b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"      is_expected.to contain_neutron_metadata_agent_config(\u0027DEFAULT/metadata_backlog\u0027).with(:value \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":58,"context_line":"      is_expected.to contain_neutron_metadata_agent_config(\u0027DEFAULT/metadata_proxy_shared_secret\u0027).with(:value \u003d\u003e params[:shared_secret])"},{"line_number":59,"context_line":"      is_expected.to contain_neutron_metadata_agent_config(\u0027DEFAULT/cache_url\u0027).with(:ensure \u003d\u003e \u0027absent\u0027)"},{"line_number":60,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/auth_url\u0027)"},{"line_number":61,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/auth_insecure\u0027)"},{"line_number":62,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/auth_region\u0027)"},{"line_number":63,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/admin_tenant_name\u0027)"},{"line_number":64,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/admin_user\u0027)"},{"line_number":65,"context_line":"      is_expected.not_to contain_neutron_metadata_agent_config(\u0027DEFAULT/admin_password\u0027)"},{"line_number":66,"context_line":"    end"},{"line_number":67,"context_line":"  end"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"5aef4532_48e981b6","line":65,"range":{"start_line":60,"start_character":0,"end_line":65,"end_character":88},"updated":"2016-03-10 13:17:11.000000000","message":"that\u0027s not needed actually :) because we always don\u0027t have these parameters, not in some particular case.","commit_id":"72d4b2dcb46be3f8f67dd48437538d0362014384"}]}
