)]}'
{"manifests/plugins/ml2/cisco/nexus.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b1d75e4c5267073c66f273ad57125dc46c6cacdb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $provider_vlan_name_prefix \u003d \u0027p-\u0027,"},{"line_number":106,"context_line":"  $persistent_switch_config  \u003d false,"},{"line_number":107,"context_line":"  $switch_heartbeat_time     \u003d 0,"},{"line_number":108,"context_line":"  $switch_replay_count       \u003d 3,"},{"line_number":109,"context_line":"  $provider_vlan_auto_create \u003d true,"},{"line_number":110,"context_line":"  $provider_vlan_auto_trunk  \u003d true,"},{"line_number":111,"context_line":"  $vxlan_global_config       \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_d300a204","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":32},"updated":"2016-03-01 10:29:06.000000000","message":"move default value to $::os_service_default then","commit_id":"543704346b31d7c2052feafeb8111eb9609c7990"},{"author":{"_account_id":13697,"name":"Leon Zachery","email":"lzachery@cisco.com","username":"lzachery"},"change_message_id":"278d6b5832cb2832e8c5bb0832008abcfaae6e56","unresolved":false,"context_lines":[{"line_number":105,"context_line":"  $provider_vlan_name_prefix \u003d \u0027p-\u0027,"},{"line_number":106,"context_line":"  $persistent_switch_config  \u003d false,"},{"line_number":107,"context_line":"  $switch_heartbeat_time     \u003d 0,"},{"line_number":108,"context_line":"  $switch_replay_count       \u003d 3,"},{"line_number":109,"context_line":"  $provider_vlan_auto_create \u003d true,"},{"line_number":110,"context_line":"  $provider_vlan_auto_trunk  \u003d true,"},{"line_number":111,"context_line":"  $vxlan_global_config       \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7af24918_425e2bea","line":108,"range":{"start_line":108,"start_character":31,"end_line":108,"end_character":32},"in_reply_to":"9aed3d3a_d300a204","updated":"2016-03-01 20:42:44.000000000","message":"Done","commit_id":"543704346b31d7c2052feafeb8111eb9609c7990"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b1d75e4c5267073c66f273ad57125dc46c6cacdb","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  $host_key_checks           \u003d false"},{"line_number":113,"context_line":") {"},{"line_number":114,"context_line":"  include ::neutron::plugins::ml2::cisco"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  neutron_plugin_ml2 {"},{"line_number":117,"context_line":"    \u0027ml2_cisco/managed_physical_network\u0027  : value \u003d\u003e $managed_physical_network;"},{"line_number":118,"context_line":"    \u0027ml2_cisco/vlan_name_prefix\u0027          : value \u003d\u003e $vlan_name_prefix;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9aed3d3a_d3a4224c","line":115,"updated":"2016-03-01 10:29:06.000000000","message":"better to raise warning message, that this parameter is deprecated/obsolete now:\n\nif ! is_service_default($switch_replay_count) {\n  warning(..)\n}","commit_id":"543704346b31d7c2052feafeb8111eb9609c7990"},{"author":{"_account_id":13697,"name":"Leon Zachery","email":"lzachery@cisco.com","username":"lzachery"},"change_message_id":"278d6b5832cb2832e8c5bb0832008abcfaae6e56","unresolved":false,"context_lines":[{"line_number":112,"context_line":"  $host_key_checks           \u003d false"},{"line_number":113,"context_line":") {"},{"line_number":114,"context_line":"  include ::neutron::plugins::ml2::cisco"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"  neutron_plugin_ml2 {"},{"line_number":117,"context_line":"    \u0027ml2_cisco/managed_physical_network\u0027  : value \u003d\u003e $managed_physical_network;"},{"line_number":118,"context_line":"    \u0027ml2_cisco/vlan_name_prefix\u0027          : value \u003d\u003e $vlan_name_prefix;"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7af24918_a26f2f91","line":115,"in_reply_to":"9aed3d3a_d3a4224c","updated":"2016-03-01 20:42:44.000000000","message":"Thanks for this info!\n\nFixed","commit_id":"543704346b31d7c2052feafeb8111eb9609c7990"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f88bf463e8489929d1130a1bc8ebb8454feeca92","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   with a period equal to the heartbeat time interval. This was previously:"},{"line_number":65,"context_line":"#      Number of times to attempt config replay with switch."},{"line_number":66,"context_line":"#      This variable depends on switch_heartbeat_time being enabled."},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*provider_vlan_auto_create*]"},{"line_number":70,"context_line":"#   (optional) A flag indicating whether OpenStack networking should manage the"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7af24918_39e871e2","line":67,"updated":"2016-03-01 23:23:25.000000000","message":"I think the point was to update the default to match this and add a case for when it\u0027s specified.  It\u0027s ok for now but it would be nice to improve the test coverage by checking for both cases.","commit_id":"f0801dc4c01adaf64f8ed83b6fc100f18acabd13"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"a818e5ddaebe5fed78b10a80752e9ede59f28078","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   with a period equal to the heartbeat time interval. This was previously:"},{"line_number":65,"context_line":"#      Number of times to attempt config replay with switch."},{"line_number":66,"context_line":"#      This variable depends on switch_heartbeat_time being enabled."},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*provider_vlan_auto_create*]"},{"line_number":70,"context_line":"#   (optional) A flag indicating whether OpenStack networking should manage the"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7af24918_186db698","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":37},"updated":"2016-03-01 21:19:31.000000000","message":"We still have old value in tests, so probably it should be updated aslo https://github.com/openstack/puppet-neutron/blob/master/spec/classes/neutron_plugins_ml2_cisco_nexus_spec.rb#L38","commit_id":"f0801dc4c01adaf64f8ed83b6fc100f18acabd13"},{"author":{"_account_id":14757,"name":"Timothy Swanson","email":"tiswanso@cisco.com","username":"tiswanso"},"change_message_id":"ad31d81144891b312891c53742ab8a42a7b3a951","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   with a period equal to the heartbeat time interval. This was previously:"},{"line_number":65,"context_line":"#      Number of times to attempt config replay with switch."},{"line_number":66,"context_line":"#      This variable depends on switch_heartbeat_time being enabled."},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*provider_vlan_auto_create*]"},{"line_number":70,"context_line":"#   (optional) A flag indicating whether OpenStack networking should manage the"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7af24918_f3746bfe","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":37},"in_reply_to":"7af24918_186db698","updated":"2016-03-01 21:45:54.000000000","message":"Hmm... I\u0027m thinking we\u0027d want to leave the test to setting a real value until the capability is removed entirely.  --Since the test is checking that an explicit setting got given to the ml2 resource.","commit_id":"f0801dc4c01adaf64f8ed83b6fc100f18acabd13"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f859e482027231d4360de3ae51a164b73b646ffd","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   with a period equal to the heartbeat time interval. This was previously:"},{"line_number":65,"context_line":"#      Number of times to attempt config replay with switch."},{"line_number":66,"context_line":"#      This variable depends on switch_heartbeat_time being enabled."},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*provider_vlan_auto_create*]"},{"line_number":70,"context_line":"#   (optional) A flag indicating whether OpenStack networking should manage the"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7af24918_a7d6fa24","line":67,"in_reply_to":"7af24918_39e871e2","updated":"2016-03-02 11:08:49.000000000","message":"Agree with Alex. Otherwise lgtm.","commit_id":"f0801dc4c01adaf64f8ed83b6fc100f18acabd13"},{"author":{"_account_id":14757,"name":"Timothy Swanson","email":"tiswanso@cisco.com","username":"tiswanso"},"change_message_id":"04c4ac79178f21590e1ddb4d7ef454e9e2e3db21","unresolved":false,"context_lines":[{"line_number":64,"context_line":"#   with a period equal to the heartbeat time interval. This was previously:"},{"line_number":65,"context_line":"#      Number of times to attempt config replay with switch."},{"line_number":66,"context_line":"#      This variable depends on switch_heartbeat_time being enabled."},{"line_number":67,"context_line":"#   Defaults to $::os_service_default"},{"line_number":68,"context_line":"#"},{"line_number":69,"context_line":"# [*provider_vlan_auto_create*]"},{"line_number":70,"context_line":"#   (optional) A flag indicating whether OpenStack networking should manage the"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7af24918_15b70d87","line":67,"in_reply_to":"7af24918_a7d6fa24","updated":"2016-03-02 14:25:27.000000000","message":"Cool... I think we (Cisco) should add more use of $::os_service_default in this class so I\u0027ll work up a wider scope patch for that.  I\u0027m not sure I totally understand the rspec test comment here so I\u0027ll hit the IRC with any Q\u0027s for that.\n\nLeon just caught this mismatch with support for this config value and our tripleo templates and puppet-neutron manifests so he went ahead for the change.\n\nThank you all for the review comments!","commit_id":"f0801dc4c01adaf64f8ed83b6fc100f18acabd13"}]}