)]}'
{"lib/puppet/provider/neutron.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7c802b6e7e866fdd1da5329b18c20c4cf9d21539","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  def self.get_neutron_credentials"},{"line_number":29,"context_line":"    deprecated_auth_keys \u003d [\u0027admin_tenant_name\u0027, \u0027admin_user\u0027, \u0027admin_password\u0027, \u0027identity_uri\u0027, \u0027tenant_name\u0027]"},{"line_number":30,"context_line":"    auth_keys \u003d [\u0027project_name\u0027, \u0027username\u0027, \u0027password\u0027, \u0027auth_url\u0027]"},{"line_number":31,"context_line":"    conf \u003d neutron_conf"},{"line_number":32,"context_line":"    if conf and conf[\u0027keystone_authtoken\u0027] and"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa0719c6_a923fbbb","line":29,"range":{"start_line":29,"start_character":97,"end_line":29,"end_character":110},"updated":"2016-03-24 11:49:35.000000000","message":"These keys are related to an old auth scheme, let\u0027s don\u0027t add this key here","commit_id":"114123e3dda9f797380e6ac86df60ed6f9771a18"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"f72bc170200cc144fead83c7fc957e4f86cbec8e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      if !conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027].nil?"},{"line_number":38,"context_line":"        creds[\u0027region_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027].strip"},{"line_number":39,"context_line":"      end"},{"line_number":40,"context_line":"      if !conf[\u0027keystone_authtoken\u0027][\u0027tenant_name\u0027].nil?"},{"line_number":41,"context_line":"        creds[\u0027project_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027tenant_name\u0027].strip"},{"line_number":42,"context_line":"      end"},{"line_number":43,"context_line":"      return creds"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa0719c6_4cf1826a","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":56},"updated":"2016-03-24 14:23:21.000000000","message":"Looks like we don\u0027t have a case when tenant_name is used, as you always set project_name in the config file.","commit_id":"7c3732ad7317112c447bcab2a1539cd6415bcd4d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"634f1d51384a28b93324a9d4cb888d6476edc63a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      if !conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027].nil?"},{"line_number":38,"context_line":"        creds[\u0027region_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027region_name\u0027].strip"},{"line_number":39,"context_line":"      end"},{"line_number":40,"context_line":"      if !conf[\u0027keystone_authtoken\u0027][\u0027tenant_name\u0027].nil?"},{"line_number":41,"context_line":"        creds[\u0027project_name\u0027] \u003d conf[\u0027keystone_authtoken\u0027][\u0027tenant_name\u0027].strip"},{"line_number":42,"context_line":"      end"},{"line_number":43,"context_line":"      return creds"},{"line_number":44,"context_line":"    elsif conf and conf[\u0027keystone_authtoken\u0027] and"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa0719c6_ac6bfe1c","line":41,"range":{"start_line":40,"start_character":6,"end_line":41,"end_character":79},"updated":"2016-03-24 14:24:02.000000000","message":"we don\u0027t need that, we don\u0027t have now in puppet tenant_name.","commit_id":"7c3732ad7317112c447bcab2a1539cd6415bcd4d"}],"manifests/server.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7c802b6e7e866fdd1da5329b18c20c4cf9d21539","unresolved":false,"context_lines":[{"line_number":250,"context_line":"#"},{"line_number":251,"context_line":"# [*tenant_name*]"},{"line_number":252,"context_line":"#   Deprecated. The tenant of the auth user"},{"line_number":253,"context_line":"#   Defaults to undef"},{"line_number":254,"context_line":"#"},{"line_number":255,"context_line":"class neutron::server ("},{"line_number":256,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa0719c6_297febe0","line":253,"range":{"start_line":253,"start_character":16,"end_line":253,"end_character":21},"updated":"2016-03-24 11:49:35.000000000","message":"Please change to $::os_service_default","commit_id":"114123e3dda9f797380e6ac86df60ed6f9771a18"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"634f1d51384a28b93324a9d4cb888d6476edc63a","unresolved":false,"context_lines":[{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    } else {"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"      if $tenant_name !\u003d $::os_service_default {"},{"line_number":474,"context_line":"        warning(\u0027tenant_name configuration option is deprecated in favor of project_name\u0027)"},{"line_number":475,"context_line":"        neutron_config {"},{"line_number":476,"context_line":"          \u0027keystone_authtoken/project_name\u0027:      value \u003d\u003e $tenant_name;"},{"line_number":477,"context_line":"        }"},{"line_number":478,"context_line":"      } else {"},{"line_number":479,"context_line":"        neutron_config {"},{"line_number":480,"context_line":"          \u0027keystone_authtoken/project_name\u0027:      value \u003d\u003e $project_name;"},{"line_number":481,"context_line":"        }"},{"line_number":482,"context_line":"      }"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"      neutron_config {"},{"line_number":485,"context_line":"        \u0027keystone_authtoken/auth_url\u0027:          value \u003d\u003e $auth_url;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa0719c6_ec99767a","line":482,"range":{"start_line":473,"start_character":0,"end_line":482,"end_character":7},"updated":"2016-03-24 14:24:02.000000000","message":"not sure about that.\n\nso, we have $tenant_name \u003d $::os_service_default it will have ensure \u003d\u003e absent by default.\n\nlet\u0027s just use next:\n\nif !is_service_default($tenant_name) {\n  warning(\u0027tenant_name configuration option is deprecated in favor of project_name\u0027)\n  $project_name_real \u003d $tenant_name\n} else {\n  $project_name_real \u003d $project_name\n}\n\nremove line 475 (done) and in 480 use:\n\n\u0027keystone_authtoken/project_name\u0027:      value \u003d\u003e $project_name_real;","commit_id":"7c3732ad7317112c447bcab2a1539cd6415bcd4d"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5968a218fa38257cbf1590d03fba014dace11805","unresolved":false,"context_lines":[{"line_number":250,"context_line":"#"},{"line_number":251,"context_line":"# [*tenant_name*]"},{"line_number":252,"context_line":"#   Deprecated. The tenant of the auth user"},{"line_number":253,"context_line":"#   Defaults to undef"},{"line_number":254,"context_line":"#"},{"line_number":255,"context_line":"class neutron::server ("},{"line_number":256,"context_line":"  $package_ensure                   \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa0719c6_a8b3e396","line":253,"range":{"start_line":253,"start_character":16,"end_line":253,"end_character":21},"updated":"2016-03-24 15:56:34.000000000","message":"Please update to $::os_service_default and mention that project_name should be used instead","commit_id":"3f02de459db0476e8b61b0dbf7f9061f3e330cbc"}],"spec/unit/provider/neutron_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7c802b6e7e866fdd1da5329b18c20c4cf9d21539","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"  let :credential_hash do"},{"line_number":13,"context_line":"    {"},{"line_number":14,"context_line":"      \u0027project_name\u0027 \u003d\u003e \u0027admin_tenant\u0027,"},{"line_number":15,"context_line":"      \u0027username\u0027    \u003d\u003e \u0027admin\u0027,"},{"line_number":16,"context_line":"      \u0027password\u0027    \u003d\u003e \u0027password\u0027,"},{"line_number":17,"context_line":"      \u0027auth_url\u0027    \u003d\u003e \u0027https://192.168.56.210:35357\u0027"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa0719c6_cf458f43","line":14,"range":{"start_line":14,"start_character":21,"end_line":14,"end_character":23},"updated":"2016-03-24 11:49:35.000000000","message":"Please align","commit_id":"114123e3dda9f797380e6ac86df60ed6f9771a18"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"7c802b6e7e866fdd1da5329b18c20c4cf9d21539","unresolved":false,"context_lines":[{"line_number":83,"context_line":"      authenv \u003d {"},{"line_number":84,"context_line":"        :OS_AUTH_URL    \u003d\u003e credential_hash[\u0027auth_url\u0027],"},{"line_number":85,"context_line":"        :OS_USERNAME    \u003d\u003e credential_hash[\u0027username\u0027],"},{"line_number":86,"context_line":"        :OS_TENANT_NAME \u003d\u003e credential_hash[\u0027tenant_name\u0027],"},{"line_number":87,"context_line":"        :OS_PASSWORD    \u003d\u003e credential_hash[\u0027password\u0027],"},{"line_number":88,"context_line":"      }"},{"line_number":89,"context_line":"      klass.expects(:get_neutron_credentials).with().returns(credential_hash)"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa0719c6_4ff5ffea","line":86,"range":{"start_line":86,"start_character":9,"end_line":86,"end_character":23},"updated":"2016-03-24 11:49:35.000000000","message":"Please also check if these tests work","commit_id":"114123e3dda9f797380e6ac86df60ed6f9771a18"}]}
