)]}'
{"manifests/agents/dhcp.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"38e437267797442c3fc0c158d069531821353aff","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      neutron_dhcp_agent_config {"},{"line_number":152,"context_line":"        \u0027DEFAULT/dnsmasq_dns_servers\u0027: value \u003d\u003e join($dnsmasq_dns_servers, \u0027,\u0027);"},{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if ! is_service_default ($dhcp_delete_namespaces) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_d59b8764","line":154,"updated":"2016-03-31 11:57:17.000000000","message":"else ensure \u003d\u003e absent","commit_id":"0423d7f04ca55a63aabbc845df10c3c9abcf1a81"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7d8504b5ac98d909daf405d639a9cc95e375314f","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      neutron_dhcp_agent_config {"},{"line_number":152,"context_line":"        \u0027DEFAULT/dnsmasq_dns_servers\u0027: value \u003d\u003e join($dnsmasq_dns_servers, \u0027,\u0027);"},{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if ! is_service_default ($dhcp_delete_namespaces) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_d6538ee0","line":154,"in_reply_to":"ba0121b8_306f712c","updated":"2016-03-31 12:22:22.000000000","message":"No, you set this if ! is_service_default\n\nAs another way:\n\n  neutron_dhcp_agent_config {\n    \u0027DEFAULT/dnsmasq_dns_servers\u0027: value \u003d\u003e join(any2array($dnsmasq_dns_servers), \u0027,\u0027);\n  }\n\nIt will be always present as resource and will be handled with validate_array too, if it is not default.","commit_id":"0423d7f04ca55a63aabbc845df10c3c9abcf1a81"},{"author":{"_account_id":19561,"name":"Jerzy Mikolajczak","email":"jmikolajczak@mirantis.com","username":"jmikolajczak"},"change_message_id":"26628debd4b653238240f46c52ceb13ccd36ddbb","unresolved":false,"context_lines":[{"line_number":151,"context_line":"      neutron_dhcp_agent_config {"},{"line_number":152,"context_line":"        \u0027DEFAULT/dnsmasq_dns_servers\u0027: value \u003d\u003e join($dnsmasq_dns_servers, \u0027,\u0027);"},{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  }"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if ! is_service_default ($dhcp_delete_namespaces) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba0121b8_306f712c","line":154,"in_reply_to":"ba0121b8_d59b8764","updated":"2016-03-31 12:13:35.000000000","message":"why? ensure \u003d\u003e absent is already set by os_service_default in this case, is it not? if $dnsmasq_dns_servers is not passed from user/opertator it will remain absent.","commit_id":"0423d7f04ca55a63aabbc845df10c3c9abcf1a81"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"777d521a897b6de7e597e6370cb05be67b28c6a3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    validate_array($dnsmasq_dns_servers)"},{"line_number":150,"context_line":"    if size($dnsmasq_dns_servers) \u003e 0 {"},{"line_number":151,"context_line":"      neutron_dhcp_agent_config {"},{"line_number":152,"context_line":"        \u0027DEFAULT/dnsmasq_dns_servers\u0027: value \u003d\u003e join($dnsmasq_dns_servers, \u0027,\u0027);"},{"line_number":153,"context_line":"      }"},{"line_number":154,"context_line":"    }"},{"line_number":155,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_ed6b4a1c","line":152,"updated":"2016-03-31 19:22:42.000000000","message":"We should probably just use any2array() here to support people who want to just provide a specific list.  We do this all over the place in other modules, for example https://github.com/openstack/puppet-keystone/blob/master/manifests/init.pp#L745","commit_id":"2d5cdfbf885626f73def7aed4fe0d7616156708f"}]}
