)]}'
{"lib/puppet/type/neutron_plugin_ovn.rb":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f00ce8569edbde965d903ad40375db9e47d0f209","unresolved":false,"context_lines":[{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  autorequire(:package) do"},{"line_number":25,"context_line":"    \u0027networking-ovn\u0027"},{"line_number":26,"context_line":"  end"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"9a061dce_bc210050","line":25,"updated":"2016-04-05 12:47:40.000000000","message":"Isn\u0027t the package python-networking-ovn?","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    end"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  autorequire(:file) do"},{"line_number":21,"context_line":"    [\u0027/etc/neutron/plugins/networking-ovn\u0027]"},{"line_number":22,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a1b2928_1d82db94","line":19,"updated":"2016-04-11 14:05:19.000000000","message":"you\u0027re missing ensure_absent_val, secret, etc... Please take reference from lib/puppet/type/neutron_plugin_ml2.rb as a good example.","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  autorequire(:file) do"},{"line_number":21,"context_line":"    [\u0027/etc/neutron/plugins/networking-ovn\u0027]"},{"line_number":22,"context_line":"  end"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"  autorequire(:package) do"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"7a1b2928_fd7effac","line":21,"updated":"2016-04-11 14:05:19.000000000","message":"why this autorequire?","commit_id":"a689039fe9893936c86657e8a84d38230716e918"}],"manifests/params.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"ab28577109678bd3ca43dc74abed078b70802321","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    $midonet_server_package \u003d \u0027python-neutron-plugin-midonet\u0027"},{"line_number":43,"context_line":"    $midonet_config_file    \u003d \u0027/etc/neutron/plugins/midonet/midonet.ini\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    $ovn_plugin_package \u003d \u0027python-networking-ovn\u0027"},{"line_number":46,"context_line":"    $ovn_config_file    \u003d \u0027/etc/neutron/plugins/networking-ovn/networking-ovn.ini\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    $plumgrid_plugin_package    \u003d \u0027networking-plumgrid\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_d99fe1b2","line":45,"range":{"start_line":45,"start_character":27,"end_line":45,"end_character":48},"updated":"2016-04-15 15:50:17.000000000","message":"What about neutron-plugin-ovn package? Does it contain configuration file?","commit_id":"1fb8dd50e9da530bdf1f923af6e1a20ed76ce261"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"0efcad3aa2e51e5c1e37f212124eaebddaad02d1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    $midonet_server_package \u003d \u0027python-neutron-plugin-midonet\u0027"},{"line_number":43,"context_line":"    $midonet_config_file    \u003d \u0027/etc/neutron/plugins/midonet/midonet.ini\u0027"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    $ovn_plugin_package \u003d \u0027python-networking-ovn\u0027"},{"line_number":46,"context_line":"    $ovn_config_file    \u003d \u0027/etc/neutron/plugins/networking-ovn/networking-ovn.ini\u0027"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    $plumgrid_plugin_package    \u003d \u0027networking-plumgrid\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a122d0e_d9ed2127","line":45,"range":{"start_line":45,"start_character":27,"end_line":45,"end_character":48},"in_reply_to":"1a122d0e_d99fe1b2","updated":"2016-04-15 15:51:52.000000000","message":"python-networking-ovn is the neutron plugin.","commit_id":"1fb8dd50e9da530bdf1f923af6e1a20ed76ce261"}],"manifests/plugins/ovn.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#    The connection string for the native OVSDB backend"},{"line_number":7,"context_line":"# [*ovsdb_connection_timeout*]"},{"line_number":8,"context_line":"#    Timeout in seconds for the OVSDB connection transaction"},{"line_number":9,"context_line":"# [*neutron_sync_mode*]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_2d001c01","line":6,"updated":"2016-04-05 13:40:17.000000000","message":"for each doc section add please \u0027Defaults to ...\u0027","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# [*vhost_sock_dir*]"},{"line_number":25,"context_line":"#    The directory in which vhost virtio socket is created by all the"},{"line_number":26,"context_line":"#    vswitch daemons"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class neutron::plugins::ovn("},{"line_number":29,"context_line":"  $ovsdb_connection  \u003d undef,"},{"line_number":30,"context_line":"  $ovsdb_connection_timeout \u003d \u002760\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_4d0d9036","line":27,"updated":"2016-04-05 13:40:17.000000000","message":"empty line","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#    vswitch daemons"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class neutron::plugins::ovn("},{"line_number":29,"context_line":"  $ovsdb_connection  \u003d undef,"},{"line_number":30,"context_line":"  $ovsdb_connection_timeout \u003d \u002760\u0027,"},{"line_number":31,"context_line":"  $neutron_sync_mode \u003d \u0027log\u0027,"},{"line_number":32,"context_line":"  $ovn_l3_mode \u003d true,"},{"line_number":33,"context_line":"  $vif_type \u003d \u0027ovs\u0027,"},{"line_number":34,"context_line":"  $vhost_sock_dir \u003d \u0027/var/run/openvswitch\u0027"},{"line_number":35,"context_line":"  ) {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  include ::neutron::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_8d0fa82d","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":42},"updated":"2016-04-05 13:40:17.000000000","message":"should be aligned","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  validate_string($ovsdb_connection)"},{"line_number":40,"context_line":"  validate_bool($ovn_l3_mode)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  # timeout should be an integer"},{"line_number":43,"context_line":"  validate_re($ovsdb_connection_timeout, \u0027^\\d+$\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  $approved_vif_types \u003d [\u0027ovs\u0027, \u0027vhostuser\u0027]"},{"line_number":46,"context_line":"  validate_re($vif_type, $approved_vif_types)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_6d585433","line":43,"range":{"start_line":42,"start_character":0,"end_line":43,"end_character":49},"updated":"2016-04-05 13:40:17.000000000","message":"validate_integer ?","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  validate_re($ovsdb_connection_timeout, \u0027^\\d+$\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  $approved_vif_types \u003d [\u0027ovs\u0027, \u0027vhostuser\u0027]"},{"line_number":46,"context_line":"  validate_re($vif_type, $approved_vif_types)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  $approved_sync_modes \u003d [\u0027off\u0027, \u0027log\u0027, \u0027repair\u0027]"},{"line_number":49,"context_line":"  validate_re($neutron_sync_mode, $approved_sync_modes)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_ad40aca6","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":45},"updated":"2016-04-05 13:40:17.000000000","message":"if ! $vif_type in $approved_vif_types {\n  fail(..)\n}","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"  validate_re($vif_type, $approved_vif_types)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  $approved_sync_modes \u003d [\u0027off\u0027, \u0027log\u0027, \u0027repair\u0027]"},{"line_number":49,"context_line":"  validate_re($neutron_sync_mode, $approved_sync_modes)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  package {\u0027neutron-plugin-ovn\u0027:"},{"line_number":52,"context_line":"    ensure \u003d\u003e present,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_ed4aa4c4","line":49,"updated":"2016-04-05 13:40:17.000000000","message":"same","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"  # Ensure the neutron package is installed before config is set"},{"line_number":59,"context_line":"  # under both RHEL and Ubuntu"},{"line_number":60,"context_line":"  if ($::neutron::params::server_package) {"},{"line_number":61,"context_line":"    Package[\u0027neutron-server\u0027] -\u003e Neutron_plugin_ovn\u003c||\u003e"},{"line_number":62,"context_line":"  } else {"},{"line_number":63,"context_line":"    Package[\u0027neutron\u0027] -\u003e Neutron_plugin_ovn\u003c||\u003e"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_8d504860","line":60,"updated":"2016-04-05 13:40:17.000000000","message":"no need ()","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"eea090fab3f6c061b5c5357f638b88cd9aa0416d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"  neutron_plugin_ovn {"},{"line_number":86,"context_line":"    \u0027ovn/ovsdb_connection\u0027: value \u003d\u003e $ovsdb_connection;"},{"line_number":87,"context_line":"    \u0027ovn/ovsdb_connection_timeout\u0027: value \u003d\u003e$ovsdb_connection_timeout;"},{"line_number":88,"context_line":"    \u0027ovn/neutron_sync_mode\u0027: value \u003d\u003e $neutron_sync_mode;"},{"line_number":89,"context_line":"    \u0027ovn/ovn_l3_mode\u0027: value \u003d\u003e $ovn_l3_mode;"},{"line_number":90,"context_line":"    \u0027ovn/vif_type\u0027: value \u003d\u003e $vif_type;"},{"line_number":91,"context_line":"    \u0027ovn/vhost_sock_dir\u0027: value \u003d\u003e $vhost_sock_dir;"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_0d99d81f","line":91,"range":{"start_line":86,"start_character":0,"end_line":91,"end_character":51},"updated":"2016-04-05 13:40:17.000000000","message":"should be aligned \u0027value\u0027","commit_id":"cf7a538239378644837100bd843087706f942774"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7cc09f3ffee85c6f73120c2ae5dd2d41d501225b","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#    The connection string for the native OVSDB backend"},{"line_number":7,"context_line":"#    Defaults to undef"},{"line_number":8,"context_line":"# [*ovsdb_connection_timeout*]"},{"line_number":9,"context_line":"#    Timeout in seconds for the OVSDB connection transaction"},{"line_number":10,"context_line":"#    Defaults to \u002760\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a061dce_bbcc2f6b","line":7,"range":{"start_line":5,"start_character":0,"end_line":7,"end_character":22},"updated":"2016-04-06 10:45:51.000000000","message":"doc section style:\n\n# [*parameter*]\n#    Description\n#    Defaults to ..\n#\n\nexample: https://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2.pp#L25-L36","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7cc09f3ffee85c6f73120c2ae5dd2d41d501225b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      match   \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":75,"context_line":"      line    \u003d\u003e \"NEUTRON_PLUGIN_CONFIG\u003d${::neutron::params::ovn_config_file}\","},{"line_number":76,"context_line":"      require \u003d\u003e [ Package[\u0027neutron-server\u0027],"},{"line_number":77,"context_line":"  Package[$::neutron::params::ovn_plugin_package] ],"},{"line_number":78,"context_line":"      notify  \u003d\u003e Service[\u0027neutron-server\u0027],"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a061dce_9ba20b98","line":77,"updated":"2016-04-06 10:45:51.000000000","message":"align please:\n\nrequire \u003d\u003e [ Package[\u0027neutron-server\u0027],\n             Package[$::neutron::params::ovn_plugin_package] ]","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fe5bfdc5a29222508c1909c9edc11f619d1dfdb8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      match   \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":75,"context_line":"      line    \u003d\u003e \"NEUTRON_PLUGIN_CONFIG\u003d${::neutron::params::ovn_config_file}\","},{"line_number":76,"context_line":"      require \u003d\u003e [ Package[\u0027neutron-server\u0027],"},{"line_number":77,"context_line":"  Package[$::neutron::params::ovn_plugin_package] ],"},{"line_number":78,"context_line":"      notify  \u003d\u003e Service[\u0027neutron-server\u0027],"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a061dce_9f102e5b","line":77,"in_reply_to":"9a061dce_66b79bf5","updated":"2016-04-06 13:19:08.000000000","message":"Oh, i misread this dependency, you can simply use:\n\nrequire \u003d\u003e [ Package[\u0027neutron-server\u0027], Package[\u0027neutron-plugin-ovn\u0027 ] ]\n\nIn this case you will rely on resource title (which is \u0027neutron-plugin-ovn\u0027), not on a real package name.","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"2d31c8966d0236c750df58e06a04df5bc0cce364","unresolved":false,"context_lines":[{"line_number":74,"context_line":"      match   \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":75,"context_line":"      line    \u003d\u003e \"NEUTRON_PLUGIN_CONFIG\u003d${::neutron::params::ovn_config_file}\","},{"line_number":76,"context_line":"      require \u003d\u003e [ Package[\u0027neutron-server\u0027],"},{"line_number":77,"context_line":"  Package[$::neutron::params::ovn_plugin_package] ],"},{"line_number":78,"context_line":"      notify  \u003d\u003e Service[\u0027neutron-server\u0027],"},{"line_number":79,"context_line":"    }"},{"line_number":80,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a061dce_66b79bf5","line":77,"in_reply_to":"9a061dce_9ba20b98","updated":"2016-04-06 12:26:08.000000000","message":"When I wrote this way, there was a lint failure \n\u0027manifests/plugins/ovn.pp:77:ERROR: two-space soft tabs not used\u0027\n\nI will better put these two in the same line, but it will exceed 80 characters. What do you think?","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0779903e685b978fef82eaabc089f4d1f34f1690","unresolved":false,"context_lines":[{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#   The connection string for the native OVSDB backend"},{"line_number":7,"context_line":"#   Defaults to undef"},{"line_number":8,"context_line":"# [*ovsdb_connection_timeout*]"},{"line_number":9,"context_line":"#   (optional) Timeout in seconds for the OVSDB connection transaction"},{"line_number":10,"context_line":"#   Defaults to \u002760\u0027"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_aaadadea","line":7,"updated":"2016-04-07 13:40:03.000000000","message":"please improve readability:\n\n# [*foo*]\n#   Bar\n#\n# [*foo2*]\n#   Bar2\n#\n...","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0779903e685b978fef82eaabc089f4d1f34f1690","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#   Defaults to undef"},{"line_number":8,"context_line":"# [*ovsdb_connection_timeout*]"},{"line_number":9,"context_line":"#   (optional) Timeout in seconds for the OVSDB connection transaction"},{"line_number":10,"context_line":"#   Defaults to \u002760\u0027"},{"line_number":11,"context_line":"# [*neutron_sync_mode*]"},{"line_number":12,"context_line":"#   (optional) The synchronization mode of OVN with Neutron DB."},{"line_number":13,"context_line":"#   Valid values are - [\u0027log\u0027, \u0027off\u0027, \u0027repair\u0027]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_0ab9392e","line":10,"updated":"2016-04-07 13:40:03.000000000","message":"For more context, please look https://wiki.openstack.org/wiki/Puppet/Coding_style#Config_file_defaults_and_parameters and ask us if you need help about default parameters.","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"211200e87b948ef745165d895b93c64323ac81bf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#   Defaults to undef"},{"line_number":8,"context_line":"# [*ovsdb_connection_timeout*]"},{"line_number":9,"context_line":"#   (optional) Timeout in seconds for the OVSDB connection transaction"},{"line_number":10,"context_line":"#   Defaults to \u002760\u0027"},{"line_number":11,"context_line":"# [*neutron_sync_mode*]"},{"line_number":12,"context_line":"#   (optional) The synchronization mode of OVN with Neutron DB."},{"line_number":13,"context_line":"#   Valid values are - [\u0027log\u0027, \u0027off\u0027, \u0027repair\u0027]"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_67c4753f","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":19},"updated":"2016-04-07 12:23:07.000000000","message":"Is there a reason to avoid using $::os_service_default?","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0779903e685b978fef82eaabc089f4d1f34f1690","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   (optional) Type of VIF to be used for ports."},{"line_number":28,"context_line":"#   Valid values are [\u0027ovs\u0027, \u0027vhostuser\u0027]"},{"line_number":29,"context_line":"#   Defaults to \u0027ovs\u0027"},{"line_number":30,"context_line":"class neutron::plugins::ovn("},{"line_number":31,"context_line":"  $ovsdb_connection         \u003d undef,"},{"line_number":32,"context_line":"  $ovsdb_connection_timeout \u003d \u002760\u0027,"},{"line_number":33,"context_line":"  $neutron_sync_mode        \u003d \u0027log\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_eab3254b","line":30,"updated":"2016-04-07 13:40:03.000000000","message":"is it a ML2 plugin?","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"185bea2573911d3524f033bb5f789daed19d6833","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#   (optional) Type of VIF to be used for ports."},{"line_number":28,"context_line":"#   Valid values are [\u0027ovs\u0027, \u0027vhostuser\u0027]"},{"line_number":29,"context_line":"#   Defaults to \u0027ovs\u0027"},{"line_number":30,"context_line":"class neutron::plugins::ovn("},{"line_number":31,"context_line":"  $ovsdb_connection         \u003d undef,"},{"line_number":32,"context_line":"  $ovsdb_connection_timeout \u003d \u002760\u0027,"},{"line_number":33,"context_line":"  $neutron_sync_mode        \u003d \u0027log\u0027,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_ca574156","line":30,"in_reply_to":"9a061dce_eab3254b","updated":"2016-04-07 13:46:56.000000000","message":"No, it is a core plugin.","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"211200e87b948ef745165d895b93c64323ac81bf","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include ::neutron::params"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $ovsdb_connection \u003d\u003d undef {"},{"line_number":41,"context_line":"    fail( \u0027ovsdb_connection is not defined\u0027 )"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_e798856c","line":40,"range":{"start_line":40,"start_character":5,"end_line":40,"end_character":31},"updated":"2016-04-07 12:23:07.000000000","message":"If it\u0027s impossible to proceed without this parameter, it should be required for the class","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0779903e685b978fef82eaabc089f4d1f34f1690","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include ::neutron::params"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $ovsdb_connection \u003d\u003d undef {"},{"line_number":41,"context_line":"    fail( \u0027ovsdb_connection is not defined\u0027 )"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_4a85f157","line":40,"updated":"2016-04-07 13:40:03.000000000","message":"right, so please drop the default value, and update doc.","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"185bea2573911d3524f033bb5f789daed19d6833","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  include ::neutron::params"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $ovsdb_connection \u003d\u003d undef {"},{"line_number":41,"context_line":"    fail( \u0027ovsdb_connection is not defined\u0027 )"},{"line_number":42,"context_line":"  }"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_ea4845b5","line":40,"in_reply_to":"9a061dce_4a85f157","updated":"2016-04-07 13:46:56.000000000","message":"it is indeed required","commit_id":"98165377fba31235dbd7cfd742cfe341d1086df8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#   The connection string for the native OVSDB backend."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*ovsdb_connection_timeout*]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a1b2928_5d4a9384","line":5,"updated":"2016-04-11 14:05:19.000000000","message":"Please add (required), it helps people who use the module.","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# [*vif_type*]"},{"line_number":30,"context_line":"#   (optional) Type of VIF to be used for ports."},{"line_number":31,"context_line":"#   Valid values are [\u0027ovs\u0027, \u0027vhostuser\u0027]"},{"line_number":32,"context_line":"#   Defaults to $::os_service_default"},{"line_number":33,"context_line":"class neutron::plugins::ovn("},{"line_number":34,"context_line":"  $ovsdb_connection,"},{"line_number":35,"context_line":"  $ovsdb_connection_timeout \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a1b2928_3d4fd793","line":32,"updated":"2016-04-11 14:05:19.000000000","message":"add an empty line here for readability.","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":41,"context_line":"  include ::neutron::params"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if $ovn_l3_mode !\u003d $::os_service_default {"},{"line_number":44,"context_line":"    validate_bool($ovn_l3_mode)"},{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $ovsdb_connection_timeout !\u003d $::os_service_default {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a1b2928_9d442b75","line":44,"updated":"2016-04-11 14:05:19.000000000","message":"if you want to validate that\u0027s a bool, please add it in the doc: type: boolean.","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":45,"context_line":"  }"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"  if $ovsdb_connection_timeout !\u003d $::os_service_default {"},{"line_number":48,"context_line":"    validate_integer($ovsdb_connection_timeout)"},{"line_number":49,"context_line":"  }"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if ! ( $vif_type in [\u0027ovs\u0027, \u0027vhostuser\u0027, $::os_service_default] ) {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a1b2928_7d494f8b","line":48,"updated":"2016-04-11 14:05:19.000000000","message":"this validation is not needed I think we usually allow strings, like:\n\novsdb_connection_timeout \u003d \u00273\u0027\novsdb_connection_timeout \u003d 3\n\nthey work the same way, at the end you\u0027ll have a value like 3.","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"94eaab5114e8e6576281ba05ccb18370f2b73654","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  package {\u0027neutron-plugin-ovn\u0027:"},{"line_number":60,"context_line":"    ensure \u003d\u003e present,"},{"line_number":61,"context_line":"    name   \u003d\u003e $::neutron::params::ovn_plugin_package"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"  Neutron_plugin_ovn\u003c||\u003e ~\u003e Service[\u0027neutron-server\u0027]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"7a1b2928_dd5ea344","line":61,"updated":"2016-04-11 14:05:19.000000000","message":"please add tag","commit_id":"a689039fe9893936c86657e8a84d38230716e918"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"15960588a6f24c8031d256c9c52a73b450c73767","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  include ::neutron::params"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"  if $ovn_l3_mode !\u003d $::os_service_default {"},{"line_number":46,"context_line":"    validate_bool($ovn_l3_mode)"},{"line_number":47,"context_line":"  }"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"5a18252c_2848bdcb","line":45,"range":{"start_line":45,"start_character":5,"end_line":45,"end_character":42},"updated":"2016-04-14 11:14:28.000000000","message":"! is_service_default($ovn_l3_mode)","commit_id":"092520242ec75198ac527d3a6652c9798950fe4b"}],"spec/classes/neutron_plugins_ovn_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7cc09f3ffee85c6f73120c2ae5dd2d41d501225b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      is_expected.to contain_neutron_plugin_ovn(\u0027ovn/vif_type\u0027).with_value(params[:vif_type])"},{"line_number":43,"context_line":"      is_expected.to contain_neutron_plugin_ovn(\u0027ovn/vhost_sock_dir\u0027).with_value(params[:vhost_sock_dir])"},{"line_number":44,"context_line":"    end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  end"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a061dce_fb47c7b9","line":45,"updated":"2016-04-06 10:45:51.000000000","message":"add please tests for passed parameters","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"2d31c8966d0236c750df58e06a04df5bc0cce364","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      is_expected.to contain_neutron_plugin_ovn(\u0027ovn/vif_type\u0027).with_value(params[:vif_type])"},{"line_number":43,"context_line":"      is_expected.to contain_neutron_plugin_ovn(\u0027ovn/vhost_sock_dir\u0027).with_value(params[:vhost_sock_dir])"},{"line_number":44,"context_line":"    end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  end"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"9a061dce_d360e703","line":45,"in_reply_to":"9a061dce_fb47c7b9","updated":"2016-04-06 12:26:08.000000000","message":"Sure. Thanks","commit_id":"636bf423bfd815ee1ba76a36b9f8dc6f50fab051"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"5e9b98c8ef01c4e40cde52d6fd9a3e90777ee061","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        :notify  \u003d\u003e \u0027Service[neutron-server]\u0027"},{"line_number":96,"context_line":"      )"},{"line_number":97,"context_line":"    end"},{"line_number":98,"context_line":"    it_configures \"neutron ovn plugin\""},{"line_number":99,"context_line":"    it_configures \u0027Validating parameters\u0027"},{"line_number":100,"context_line":"  end"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a061dce_0db7aaf5","line":98,"updated":"2016-04-07 08:13:51.000000000","message":"lets use single quotes here","commit_id":"f364c30698dd2d3e1a46723d7c05160ad93d91ea"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"15960588a6f24c8031d256c9c52a73b450c73767","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    end"},{"line_number":72,"context_line":"  end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":75,"context_line":"    let :facts do"},{"line_number":76,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":77,"context_line":"         :osfamily \u003d\u003e \u0027Debian\u0027"},{"line_number":78,"context_line":"      }))"},{"line_number":79,"context_line":"    end"},{"line_number":80,"context_line":"    let :params do"},{"line_number":81,"context_line":"      default_params"},{"line_number":82,"context_line":"    end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    it \u0027configures /etc/default/neutron-server\u0027 do"},{"line_number":85,"context_line":"      is_expected.to contain_file_line(\u0027/etc/default/neutron-server:NEUTRON_PLUGIN_CONFIG\u0027).with("},{"line_number":86,"context_line":"        :path    \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":87,"context_line":"        :match   \u003d\u003e \u0027^NEUTRON_PLUGIN_CONFIG\u003d(.*)$\u0027,"},{"line_number":88,"context_line":"        :line    \u003d\u003e \u0027NEUTRON_PLUGIN_CONFIG\u003d/etc/neutron/plugins/networking-ovn/networking-ovn.ini\u0027,"},{"line_number":89,"context_line":"        :require \u003d\u003e [\u0027Package[neutron-server]\u0027, \u0027Package[neutron-plugin-ovn]\u0027],"},{"line_number":90,"context_line":"        :notify  \u003d\u003e \u0027Service[neutron-server]\u0027"},{"line_number":91,"context_line":"      )"},{"line_number":92,"context_line":"    end"},{"line_number":93,"context_line":"    it_configures \u0027neutron ovn plugin\u0027"},{"line_number":94,"context_line":"    it_configures \u0027Validating parameters\u0027"},{"line_number":95,"context_line":"  end"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":98,"context_line":"    let :facts do"},{"line_number":99,"context_line":"      @default_facts.merge(test_facts.merge({"},{"line_number":100,"context_line":"         :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":101,"context_line":"         :operatingsystemrelease \u003d\u003e \u00277\u0027"},{"line_number":102,"context_line":"      }))"},{"line_number":103,"context_line":"    end"},{"line_number":104,"context_line":"    let :params do"},{"line_number":105,"context_line":"      default_params"},{"line_number":106,"context_line":"    end"},{"line_number":107,"context_line":"    it \u0027should create plugin symbolic link\u0027 do"},{"line_number":108,"context_line":"      is_expected.to contain_file(\u0027/etc/neutron/plugin.ini\u0027).with("},{"line_number":109,"context_line":"        :ensure  \u003d\u003e \u0027link\u0027,"},{"line_number":110,"context_line":"        :target  \u003d\u003e \u0027/etc/neutron/plugins/networking-ovn/networking-ovn.ini\u0027,"},{"line_number":111,"context_line":"        :require \u003d\u003e \u0027Package[python-networking-ovn]\u0027)"},{"line_number":112,"context_line":"    end"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    it_configures \u0027neutron ovn plugin\u0027"},{"line_number":115,"context_line":"    it_configures \u0027Validating parameters\u0027"},{"line_number":116,"context_line":"  end"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"5a18252c_28fb9d48","line":116,"range":{"start_line":74,"start_character":0,"end_line":116,"end_character":5},"updated":"2016-04-14 11:14:28.000000000","message":"can you please rewrite it with on_supported_os function?\n\nexample: https://github.com/openstack/puppet-cinder/blob/master/spec/classes/cinder_api_spec.rb#L308\n\nfor platform specific checks, you can use case inside context in example above.","commit_id":"092520242ec75198ac527d3a6652c9798950fe4b"}]}