)]}'
{"lib/puppet/provider/neutron_lbaas_service_config/openstackconfig.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5a6781f6f30ef4a6227ab8d89b9be8da31b17cc0","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/neutron.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9a061dce_e225135c","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":30},"updated":"2016-04-07 12:33:58.000000000","message":"This change doesn\u0027t look reasonable. Can\u0027t we just use the existing provider for neutron.conf instead of changing this?","commit_id":"93fdbdb355e0a619b1c3e58562ec2ec4d7187e07"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"09f1a0c29f148c23b77afcb61e1ffe367d0a9d07","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/neutron.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a061dce_1c2015f7","line":7,"updated":"2016-04-08 16:56:39.000000000","message":"are we sure about that? I remember we changed that recently.","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"1f752338ce0bf86c9e8310bb47f60a881c3e51b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/neutron.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"9a061dce_282033f7","line":7,"in_reply_to":"9a061dce_1c2015f7","updated":"2016-04-08 18:22:40.000000000","message":"neutron_lbaas.conf isnt loaded by the services endpoint, it is loaded by the neutron agent. The configuration for the services needs to be on the neutron server side.","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"efe0d15b93176c9ae9610515606a6e54ad3889ab","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/neutron.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":19,"id":"1a122d0e_7c5f7275","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":30},"updated":"2016-04-22 14:37:33.000000000","message":"Do we really need this provider then? Looks like we can just use neutron_config","commit_id":"2fec5ca7f617ac38bfc6d306830c9be563f14789"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"f5d1edcdce85a15797aa82e5ea80e19637d4f45b","unresolved":false,"context_lines":[{"line_number":4,"context_line":") do"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  def self.file_path"},{"line_number":7,"context_line":"    \u0027/etc/neutron/neutron.conf\u0027"},{"line_number":8,"context_line":"  end"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"  # added for backwards compatibility with older versions of inifile"}],"source_content_type":"text/x-ruby","patch_set":19,"id":"1a122d0e_ea060f84","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":30},"in_reply_to":"1a122d0e_7c5f7275","updated":"2016-04-22 16:41:08.000000000","message":"because service_provider section of neutron conf has multiple values.\n\nhttps://github.com/openstack/neutron-lbaas/blob/stable/liberty/etc/neutron_lbaas.conf#L57-L78\n\nthey added it in a separate file for neutron server but nothing loads that file so we\u0027re stuffing it into neutron.conf.","commit_id":"2fec5ca7f617ac38bfc6d306830c9be563f14789"}],"manifests/params.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"09f1a0c29f148c23b77afcb61e1ffe367d0a9d07","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    $lbaas_agent_package \u003d \u0027openstack-neutron-lbaas\u0027"},{"line_number":59,"context_line":"    $lbaas_agent_service \u003d \u0027neutron-lbaas-agent\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    $lbaasv2_agent_package \u003d \u0027openstack-neutron-lbaas\u0027"},{"line_number":62,"context_line":"    $lbaasv2_agent_service \u003d \u0027neutron-lbaasv2-agent\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    $haproxy_package   \u003d \u0027haproxy\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_7c395141","line":61,"updated":"2016-04-08 16:56:39.000000000","message":"This one is not needed I think.\nMaybe you can set it to false and try to use $lbaas_agent_package in the manifest if lbaasv2_agent_package is not defined (we do that for some other packages, like ml2 plugin, etc).","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"1f752338ce0bf86c9e8310bb47f60a881c3e51b6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    $lbaas_agent_package \u003d \u0027openstack-neutron-lbaas\u0027"},{"line_number":59,"context_line":"    $lbaas_agent_service \u003d \u0027neutron-lbaas-agent\u0027"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    $lbaasv2_agent_package \u003d \u0027openstack-neutron-lbaas\u0027"},{"line_number":62,"context_line":"    $lbaasv2_agent_service \u003d \u0027neutron-lbaasv2-agent\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    $haproxy_package   \u003d \u0027haproxy\u0027"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_284e73c1","line":61,"in_reply_to":"9a061dce_7c395141","updated":"2016-04-08 18:22:40.000000000","message":"I can do that too since the params is using $::osfamily to determine if it needs to install the package.","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"}],"manifests/services/lbaas.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"433bacc3cf543a41e43727223e4b2de700718c3e","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# \u003d\u003d Class: neutron::services::lbaas"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# Configure the Loadbalancer as a Service Neutron Plugin"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_f61b5e71","side":"PARENT","line":22,"updated":"2016-04-06 10:52:29.000000000","message":"you can not just remove some file.\n\nGoing through backward compatibility cycle you should raise warning message, that this file is deprecated and should be used a new file instead.\n\nAlso you can use include for new file here. For parameters which are same for both classes, you need to use pick() function (like it done for most db.pp and logging.pp classes for debug/verbose parameters).","commit_id":"98dce78cd799fe7b66c59739d78ea4207f438d91"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"3b6701b9c1a4fa61b0a035361ef2911dbc75fb98","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# \u003d\u003d Class: neutron::services::lbaas"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# Configure the Loadbalancer as a Service Neutron Plugin"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9a061dce_f02fe185","side":"PARENT","line":22,"in_reply_to":"9a061dce_f61b5e71","updated":"2016-04-06 11:48:57.000000000","message":"I will fix that. I havent pushed out a new patch yet as it seems that documentation for lbaas v2 is lacking a bit and we might not need a whole new agent class to enable lbaas v2.","commit_id":"98dce78cd799fe7b66c59739d78ea4207f438d91"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7de15638f309bce6451c5797cb031ff1ff0fe7f1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":48,"context_line":"    name   \u003d\u003e $::neutron::params::lbaas_agent_package,"},{"line_number":49,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":50,"context_line":"  })"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if !is_service_default($service_providers) {"},{"line_number":53,"context_line":"    # default value is uncommented setting, so we should not touch it at all"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_c7e64faf","side":"PARENT","line":50,"updated":"2016-04-06 17:12:17.000000000","message":"why you removing this?","commit_id":"d301833c2c379db706a52a582f502bb14cd4d34f"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"44fd071f1b5f9ba86e9667d70b48dbfcdc6e5241","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    ensure \u003d\u003e $package_ensure,"},{"line_number":48,"context_line":"    name   \u003d\u003e $::neutron::params::lbaas_agent_package,"},{"line_number":49,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027neutron-package\u0027],"},{"line_number":50,"context_line":"  })"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"  if !is_service_default($service_providers) {"},{"line_number":53,"context_line":"    # default value is uncommented setting, so we should not touch it at all"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_c683f054","side":"PARENT","line":50,"in_reply_to":"9a061dce_c7e64faf","updated":"2016-04-06 17:36:38.000000000","message":"The agent package should be under neutron::agents::lbaas. The services, what is configured on the neutron server (as far as I know) does not get the lbaas agent installed.","commit_id":"d301833c2c379db706a52a582f502bb14cd4d34f"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5a6781f6f30ef4a6227ab8d89b9be8da31b17cc0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# \u003d\u003d\u003d Parameters:"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*package_ensure*]"},{"line_number":26,"context_line":"#   (required) Whether or not to install the LBaaS Neutron plugin package"},{"line_number":27,"context_line":"#   present"},{"line_number":28,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_828ed72b","side":"PARENT","line":25,"range":{"start_line":25,"start_character":4,"end_line":25,"end_character":18},"updated":"2016-04-07 12:33:58.000000000","message":"This is not required anymore, as you\u0027re removing package installation. But please keep the option for backward compatibility","commit_id":"d301833c2c379db706a52a582f502bb14cd4d34f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"09f1a0c29f148c23b77afcb61e1ffe367d0a9d07","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::neutron::params"},{"line_number":51,"context_line":"  if $package_ensure {"},{"line_number":52,"context_line":"    warning(\u0027The package_ensure parameter no longer does anything and may be removed in future releases. For installing the lbaas v2 agent, see neutron::agents::lbaas\u0027)"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"  if !is_service_default($service_providers) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_dc769dd7","line":51,"updated":"2016-04-08 16:56:39.000000000","message":"You\u0027ll have to find a better way to deprecate it, because right now we won\u0027t accept it.\nYou need to keep previous behavior working, send a warning and if possible support new behavior.","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"1f752338ce0bf86c9e8310bb47f60a881c3e51b6","unresolved":false,"context_lines":[{"line_number":48,"context_line":") {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::neutron::params"},{"line_number":51,"context_line":"  if $package_ensure {"},{"line_number":52,"context_line":"    warning(\u0027The package_ensure parameter no longer does anything and may be removed in future releases. For installing the lbaas v2 agent, see neutron::agents::lbaas\u0027)"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"  if !is_service_default($service_providers) {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a061dce_68034b77","line":51,"in_reply_to":"9a061dce_dc769dd7","updated":"2016-04-08 18:22:40.000000000","message":"Ok next patch will contain conditional to send warning but will keep the ensure_resource there.","commit_id":"93a94b5f58f1648e9c3aa04ef792aa6646f08c5d"}],"manifests/services/lbaas/octavia.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"51a0517c1cfda2615fcc7f289df3f2c68b34eabf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"#   Defaults to $::os_service_default"},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class neutron::services::lbaas::octavia("},{"line_number":28,"context_line":"  $base_url              \u003d \u0027http://127.0.0.1:9876\u0027,"},{"line_number":29,"context_line":"  $request_poll_interval \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $request_poll_timeout  \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_defc1aba","line":27,"updated":"2016-04-07 15:31:25.000000000","message":"I think we should use openstack/puppet-octavia for that. The repo is new, and we have a basic structure. You might want to contribute to it.","commit_id":"93fdbdb355e0a619b1c3e58562ec2ec4d7187e07"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5a6781f6f30ef4a6227ab8d89b9be8da31b17cc0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class neutron::services::lbaas::octavia("},{"line_number":28,"context_line":"  $base_url              \u003d \u0027http://127.0.0.1:9876\u0027,"},{"line_number":29,"context_line":"  $request_poll_interval \u003d $::os_service_default,"},{"line_number":30,"context_line":"  $request_poll_timeout  \u003d $::os_service_default,"},{"line_number":31,"context_line":"  $allocates_vip         \u003d $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_c29baf64","line":28,"range":{"start_line":28,"start_character":3,"end_line":28,"end_character":11},"updated":"2016-04-07 12:33:58.000000000","message":"Please add unit tests for this class","commit_id":"93fdbdb355e0a619b1c3e58562ec2ec4d7187e07"}],"spec/acceptance/basic_neutron_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7de15638f309bce6451c5797cb031ff1ff0fe7f1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        mechanism_drivers    \u003d\u003e [\u0027openvswitch\u0027, \u0027sriovnicswitch\u0027]"},{"line_number":74,"context_line":"      }"},{"line_number":75,"context_line":"      class { \u0027::neutron::agents::ml2::sriov\u0027: }"},{"line_number":76,"context_line":"      class { \u0027::neutron::agents::lbaasv2\u0027:"},{"line_number":77,"context_line":"        service_providers \u003d\u003e [\u0027LOADBALANCER:Haproxy:neutron_lbaas.services.loadbalancer.drivers.haproxy.plugin_driver.HaproxyOnHostPluginDriver:default\u0027],"},{"line_number":78,"context_line":"      }"},{"line_number":79,"context_line":"      EOS"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a061dce_471fdfb6","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":42},"updated":"2016-04-06 17:12:17.000000000","message":"we don\u0027t have such manifest","commit_id":"67f2030228cfa098e1e9214df8708ac5fbe2e980"}],"spec/acceptance/neutron_config_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7de15638f309bce6451c5797cb031ff1ff0fe7f1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        ensure_absent_val \u003d\u003e \u0027toto\u0027,"},{"line_number":182,"context_line":"      }"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"      neutron_lbaasv2_agent_config { \u0027DEFAULT/thisshouldexist2\u0027 :"},{"line_number":185,"context_line":"        value             \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027,"},{"line_number":186,"context_line":"        ensure_absent_val \u003d\u003e \u0027toto\u0027,"},{"line_number":187,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9a061dce_07b32799","line":184,"updated":"2016-04-06 17:12:17.000000000","message":"we don\u0027t have such config","commit_id":"67f2030228cfa098e1e9214df8708ac5fbe2e980"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6b90f94be7b11d301c29e2b79687e13d2df90a48","unresolved":false,"context_lines":[{"line_number":570,"context_line":"      end"},{"line_number":571,"context_line":"    end"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"    describe file(\u0027/etc/neutron/neutron.conf\u0027) do"},{"line_number":574,"context_line":"      it { is_expected.to contain(\u0027thisshouldexist3\u003dvalue1\u0027) }"},{"line_number":575,"context_line":"      it { is_expected.to contain(\u0027thisshouldexist3\u003dvalue2\u0027) }"},{"line_number":576,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"9a061dce_01e545a7","line":573,"updated":"2016-04-08 22:11:04.000000000","message":"I would like to see acceptance tests when deploying this new service. Thanks","commit_id":"3829b34b45d7cba0c4dfcba2697b9b2573645b56"}],"spec/classes/neutron_services_lbaas_haproxy_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"af01c6f41c5d70bda5fd45ce1ee42591f95f11e9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"describe \u0027neutron::services::lbaas::haproxy\u0027 do"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  let :default_params do"},{"line_number":26,"context_line":"    { :interface_driver        \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"      :periodic_interval       \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :loadbalancer_state_path \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :user_group              \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1a122d0e_fdd3725d","line":26,"updated":"2016-04-18 11:53:35.000000000","message":"do we really need this? I guess we can leave params empty.","commit_id":"0a11e33c6c415ea32e124156c4860e96ae295cb7"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"fffb58a4bb7fa464b37debf262407ba135d13c40","unresolved":false,"context_lines":[{"line_number":23,"context_line":"describe \u0027neutron::services::lbaas::haproxy\u0027 do"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  let :default_params do"},{"line_number":26,"context_line":"    { :interface_driver        \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":27,"context_line":"      :periodic_interval       \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :loadbalancer_state_path \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :user_group              \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1a122d0e_d8732414","line":26,"in_reply_to":"1a122d0e_fdd3725d","updated":"2016-04-18 12:23:01.000000000","message":"It is what is in the configuration reference documentation.  https://github.com/openstack/neutron-lbaas/blob/stable/liberty/etc/services_lbaas.conf#L68-L74\n\nWe\u0027re stuffing it into neutron.conf because startup scripts arent using the created files for lbaas and it also works from the neutron.conf too.","commit_id":"0a11e33c6c415ea32e124156c4860e96ae295cb7"}],"spec/classes/neutron_services_lbaas_octavia_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"af01c6f41c5d70bda5fd45ce1ee42591f95f11e9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    { :base_url              \u003d\u003e \u0027http://127.0.0.1:9876\u0027,"},{"line_number":27,"context_line":"      :request_poll_interval \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :request_poll_timeout  \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :allocates_vip         \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027}"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  context \u0027with default params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1a122d0e_7dc0027d","line":29,"updated":"2016-04-18 11:53:35.000000000","message":"same here","commit_id":"0a11e33c6c415ea32e124156c4860e96ae295cb7"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"fffb58a4bb7fa464b37debf262407ba135d13c40","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    { :base_url              \u003d\u003e \u0027http://127.0.0.1:9876\u0027,"},{"line_number":27,"context_line":"      :request_poll_interval \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":28,"context_line":"      :request_poll_timeout  \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027,"},{"line_number":29,"context_line":"      :allocates_vip         \u003d\u003e \u0027\u003cSERVICE_DEFAULT\u003e\u0027}"},{"line_number":30,"context_line":"  end"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  context \u0027with default params\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"1a122d0e_98fecc36","line":29,"in_reply_to":"1a122d0e_7dc0027d","updated":"2016-04-18 12:23:01.000000000","message":"We leave the three with service default because they\u0027re not required for Octavia plugin. The baseurl needs to be set though.","commit_id":"0a11e33c6c415ea32e124156c4860e96ae295cb7"}]}