)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"85a9d1dd136ad1e62c5a7a6aa13b1dab0d349267","unresolved":false,"context_lines":[{"line_number":416,"context_line":""},{"line_number":417,"context_line":"  oslo::concurrency { \u0027neutron_config\u0027: lock_path \u003d\u003e $lock_path }"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"  oslo::messaging::notifications { \u0027neutron_config\u0027:"},{"line_number":420,"context_line":"    driver \u003d\u003e $notification_driver,"},{"line_number":421,"context_line":"    topics \u003d\u003e $notification_topics,"},{"line_number":422,"context_line":"  }"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"  if ! is_service_default ($service_plugins) and ($service_plugins) {"},{"line_number":425,"context_line":"    if is_array($service_plugins) {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_b5b6cfd9","line":422,"range":{"start_line":419,"start_character":0,"end_line":422,"end_character":3},"updated":"2016-04-27 14:42:44.000000000","message":"it was not existed before, why you add these parameter in patch for switching?","commit_id":"b0c72a64fb036931c3e83a7da3a0579eedd19a8d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"59e6ffdccd952c317f7aac7f30e8f3c2e234a514","unresolved":false,"context_lines":[{"line_number":293,"context_line":"  $rabbit_ha_queues                   \u003d undef,"},{"line_number":294,"context_line":"  $rabbit_user                        \u003d \u0027guest\u0027,"},{"line_number":295,"context_line":"  $rabbit_virtual_host                \u003d $::os_service_default,"},{"line_number":296,"context_line":"  $rabbit_heartbeat_timeout_threshold \u003d 0,"},{"line_number":297,"context_line":"  $rabbit_heartbeat_rate              \u003d 2,"},{"line_number":298,"context_line":"  $rabbit_use_ssl                     \u003d $::os_service_default,"},{"line_number":299,"context_line":"  $amqp_durable_queues                \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a122d0e_91cbc271","side":"PARENT","line":296,"updated":"2016-04-28 16:06:57.000000000","message":"we may want to document the fact that this gets changed with the switch to os_service_default (oslo docs say the default is 60).","commit_id":"75df018ac06d59f2abd45239dcf86594f274eac9"}],"manifests/policy.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5962cc438c41b2634ed05c07dfc11cdf9d62bb52","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  create_resources(\u0027openstacklib::policy::base\u0027, $policies)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  oslo::policy { [\u0027neutron_config\u0027]: policy_file \u003d\u003e $policy_path }"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_75b6f73e","line":39,"updated":"2016-04-27 14:36:24.000000000","message":"do we need an array here?","commit_id":"b0c72a64fb036931c3e83a7da3a0579eedd19a8d"}],"spec/classes/neutron_db_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5962cc438c41b2634ed05c07dfc11cdf9d62bb52","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        { :database_connection     \u003d\u003e \u0027mysql+pymysql://neutron:neutron@localhost/neutron\u0027 }"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"      it { is_expected.to contain_package(\u0027neutron-backend-package\u0027).with({ :ensure \u003d\u003e \u0027present\u0027, :name \u003d\u003e \u0027python-pymysql\u0027 }) }"},{"line_number":88,"context_line":"    end"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_d5f42bf2","side":"PARENT","line":87,"updated":"2016-04-27 14:36:24.000000000","message":"why are you removing this test? you should change \u0027neutron-backend-package\u0027 to db_backend_packange and that\u0027s it","commit_id":"75df018ac06d59f2abd45239dcf86594f274eac9"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"85a9d1dd136ad1e62c5a7a6aa13b1dab0d349267","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        { :database_connection     \u003d\u003e \u0027mysql+pymysql://neutron:neutron@localhost/neutron\u0027 }"},{"line_number":85,"context_line":"      end"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"      it { is_expected.to contain_package(\u0027neutron-backend-package\u0027).with({ :ensure \u003d\u003e \u0027present\u0027, :name \u003d\u003e \u0027python-pymysql\u0027 }) }"},{"line_number":88,"context_line":"    end"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_15cfc356","side":"PARENT","line":87,"in_reply_to":"1a122d0e_d5f42bf2","updated":"2016-04-27 14:42:44.000000000","message":"Agree","commit_id":"75df018ac06d59f2abd45239dcf86594f274eac9"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5962cc438c41b2634ed05c07dfc11cdf9d62bb52","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        { :database_connection     \u003d\u003e \u0027mysql+pymysql://neutron:neutron@localhost/neutron\u0027 }"},{"line_number":105,"context_line":"      end"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"      it { is_expected.not_to contain_package(\u0027neutron-backend-package\u0027) }"},{"line_number":108,"context_line":"    end"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_75e4373b","side":"PARENT","line":107,"updated":"2016-04-27 14:36:24.000000000","message":"same here","commit_id":"75df018ac06d59f2abd45239dcf86594f274eac9"}],"spec/classes/neutron_init_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"5962cc438c41b2634ed05c07dfc11cdf9d62bb52","unresolved":false,"context_lines":[{"line_number":34,"context_line":"      end"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"      context \u0027with one server\u0027 do"},{"line_number":37,"context_line":"        before { params.merge!( :rabbit_hosts     \u003d\u003e [\u0027127.0.0.1:5672\u0027] ) }"},{"line_number":38,"context_line":"        it_configures \u0027a neutron base installation\u0027"},{"line_number":39,"context_line":"        it_configures \u0027rabbit HA with a single virtual host\u0027"},{"line_number":40,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_35c59f8d","line":37,"updated":"2016-04-27 14:36:24.000000000","message":"not needed","commit_id":"b0c72a64fb036931c3e83a7da3a0579eedd19a8d"}]}