)]}'
{"lib/puppet/provider/neutron_router/neutron.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f18aa408eeb46366daa848052c8380ac74ec4161","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    end"},{"line_number":201,"context_line":"    results \u003d auth_neutron(\"router-show\", \u0027--format\u003dshell\u0027, resource[:name])"},{"line_number":202,"context_line":"    attrs \u003d self.class.parse_creation_output(results)"},{"line_number":203,"context_line":"    set_admin_state_up(false)"},{"line_number":204,"context_line":"    auth_neutron(\u0027router-update\u0027, \"--availability-zone-hint\u003d#{value}\", name)"},{"line_number":205,"context_line":"    if attrs[\u0027admin_state_up\u0027] \u003d\u003d \u0027True\u0027"},{"line_number":206,"context_line":"      set_admin_state_up(true)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a122d0e_f987a15e","line":203,"updated":"2016-04-27 14:59:12.000000000","message":"so, actually, attrs[\u0027admin_state_up\u0027] should come in @property_hash after instances method and you don\u0027t need to execute router-show here. But in current case, you just following current scheme. I guess it can be rewritten, but in separate patch.","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0dce66352536d7942ff83718f95e3035782c9d63","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    end"},{"line_number":201,"context_line":"    results \u003d auth_neutron(\"router-show\", \u0027--format\u003dshell\u0027, resource[:name])"},{"line_number":202,"context_line":"    attrs \u003d self.class.parse_creation_output(results)"},{"line_number":203,"context_line":"    set_admin_state_up(false)"},{"line_number":204,"context_line":"    auth_neutron(\u0027router-update\u0027, \"--availability-zone-hint\u003d#{value}\", name)"},{"line_number":205,"context_line":"    if attrs[\u0027admin_state_up\u0027] \u003d\u003d \u0027True\u0027"},{"line_number":206,"context_line":"      set_admin_state_up(true)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a122d0e_74eee122","line":203,"in_reply_to":"1a122d0e_b97b69bd","updated":"2016-04-28 11:01:28.000000000","message":"Agree, let\u0027s follow existing scheme for now","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8e8f431f27df19ea3a7912dfe384897b8624e96d","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    end"},{"line_number":201,"context_line":"    results \u003d auth_neutron(\"router-show\", \u0027--format\u003dshell\u0027, resource[:name])"},{"line_number":202,"context_line":"    attrs \u003d self.class.parse_creation_output(results)"},{"line_number":203,"context_line":"    set_admin_state_up(false)"},{"line_number":204,"context_line":"    auth_neutron(\u0027router-update\u0027, \"--availability-zone-hint\u003d#{value}\", name)"},{"line_number":205,"context_line":"    if attrs[\u0027admin_state_up\u0027] \u003d\u003d \u0027True\u0027"},{"line_number":206,"context_line":"      set_admin_state_up(true)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a122d0e_b97b69bd","line":203,"in_reply_to":"1a122d0e_d9ee25ec","updated":"2016-04-27 15:12:29.000000000","message":"so, yeah, in common case we shouldn\u0027t have these calls, it should come with self.instance in property hash. But for this patch, having such thing is ok, just question to discuss.","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"115e1a6c03662ed1e38781822135911bcc44c94c","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    end"},{"line_number":201,"context_line":"    results \u003d auth_neutron(\"router-show\", \u0027--format\u003dshell\u0027, resource[:name])"},{"line_number":202,"context_line":"    attrs \u003d self.class.parse_creation_output(results)"},{"line_number":203,"context_line":"    set_admin_state_up(false)"},{"line_number":204,"context_line":"    auth_neutron(\u0027router-update\u0027, \"--availability-zone-hint\u003d#{value}\", name)"},{"line_number":205,"context_line":"    if attrs[\u0027admin_state_up\u0027] \u003d\u003d \u0027True\u0027"},{"line_number":206,"context_line":"      set_admin_state_up(true)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"1a122d0e_d9ee25ec","line":203,"in_reply_to":"1a122d0e_f987a15e","updated":"2016-04-27 15:02:45.000000000","message":"so for this instance, are you suggesting that I remove lines 201,202?","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7c828a3f87edab93529d98fa2c2a736f92f8f8e8","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    end"},{"line_number":201,"context_line":"    set_admin_state_up(false)"},{"line_number":202,"context_line":"    auth_neutron(\u0027router-update\u0027, \"--availability-zone-hint\u003d#{value}\", name)"},{"line_number":203,"context_line":"    if attrs[\u0027admin_state_up\u0027] \u003d\u003d \u0027True\u0027"},{"line_number":204,"context_line":"      set_admin_state_up(true)"},{"line_number":205,"context_line":"    end"},{"line_number":206,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_55973647","line":203,"range":{"start_line":203,"start_character":7,"end_line":203,"end_character":30},"updated":"2016-04-29 15:36:19.000000000","message":"i guess you missed call:\n\n    results \u003d auth_neutron(\"router-show\", \u0027--format\u003dshell\u0027, resource[:name])\n    attrs \u003d self.class.parse_creation_output(results)\n\nit\u0027s still needed.\n\nFor prev patch set my point was in refactoring provider and switching to use @property_hash var across whole neutron providers, not in this certain case.\n\nSo, please back this call :)","commit_id":"f6c0741126b905f84c7e26aeee8ed0b64bae5922"}],"manifests/server.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0dce66352536d7942ff83718f95e3035782c9d63","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  $router_scheduler_driver          \u003d \u0027neutron.scheduler.l3_agent_scheduler.ChanceScheduler\u0027,"},{"line_number":316,"context_line":"  $router_distributed               \u003d $::os_service_default,"},{"line_number":317,"context_line":"  $network_scheduler_driver         \u003d $::os_service_default,"},{"line_number":318,"context_line":"  $dhcp_load_type                   \u003d $::os_service_default,"},{"line_number":319,"context_line":"  $default_availability_zones       \u003d $::os_service_default,"},{"line_number":320,"context_line":"  $allow_automatic_l3agent_failover \u003d $::os_service_default,"},{"line_number":321,"context_line":"  $l3_ha                            \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_f46f918f","line":318,"range":{"start_line":318,"start_character":3,"end_line":318,"end_character":17},"updated":"2016-04-28 11:01:28.000000000","message":"If there\u0027re only 3 available values, can we validate this parameter then?","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c0b49d262a933b35b3227986c2236730427f7ffd","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  $router_scheduler_driver          \u003d \u0027neutron.scheduler.l3_agent_scheduler.ChanceScheduler\u0027,"},{"line_number":316,"context_line":"  $router_distributed               \u003d $::os_service_default,"},{"line_number":317,"context_line":"  $network_scheduler_driver         \u003d $::os_service_default,"},{"line_number":318,"context_line":"  $dhcp_load_type                   \u003d $::os_service_default,"},{"line_number":319,"context_line":"  $default_availability_zones       \u003d $::os_service_default,"},{"line_number":320,"context_line":"  $allow_automatic_l3agent_failover \u003d $::os_service_default,"},{"line_number":321,"context_line":"  $l3_ha                            \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_f48671b7","line":318,"range":{"start_line":318,"start_character":3,"end_line":318,"end_character":17},"in_reply_to":"1a122d0e_f46f918f","updated":"2016-04-28 11:13:28.000000000","message":"Sure I can put in something to validate the values.","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a430f8c750b92785131a65d33dd6837b13a948b2","unresolved":false,"context_lines":[{"line_number":315,"context_line":"  $router_scheduler_driver          \u003d \u0027neutron.scheduler.l3_agent_scheduler.ChanceScheduler\u0027,"},{"line_number":316,"context_line":"  $router_distributed               \u003d $::os_service_default,"},{"line_number":317,"context_line":"  $network_scheduler_driver         \u003d $::os_service_default,"},{"line_number":318,"context_line":"  $dhcp_load_type                   \u003d $::os_service_default,"},{"line_number":319,"context_line":"  $default_availability_zones       \u003d $::os_service_default,"},{"line_number":320,"context_line":"  $allow_automatic_l3agent_failover \u003d $::os_service_default,"},{"line_number":321,"context_line":"  $l3_ha                            \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_c0dd6ae1","line":318,"range":{"start_line":318,"start_character":3,"end_line":318,"end_character":17},"in_reply_to":"1a122d0e_f48671b7","updated":"2016-04-28 15:08:16.000000000","message":"Yep, agree, can be verified like:\n\nif ! $dhcp_load_type in [\u0027networks\u0027, \u0027subnets\u0027, \u0027ports\u0027] {\n  fail(..)\n}","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"0dce66352536d7942ff83718f95e3035782c9d63","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    include ::neutron::db::sync"},{"line_number":425,"context_line":"  }"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"  if is_array($default_availability_zones) {"},{"line_number":428,"context_line":"    $real_default_availability_zones \u003d join($default_availability_zones, \u0027,\u0027)"},{"line_number":429,"context_line":"  } else {"},{"line_number":430,"context_line":"    $real_default_availability_zones \u003d $default_availability_zones"},{"line_number":431,"context_line":"  }"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"  neutron_config {"},{"line_number":434,"context_line":"    \u0027DEFAULT/api_workers\u0027:                      value \u003d\u003e $api_workers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_344f4935","line":431,"range":{"start_line":427,"start_character":0,"end_line":431,"end_character":3},"updated":"2016-04-28 11:01:28.000000000","message":"Probably this can be replaced with:\n\njoin(any2array($default_availability_zones), \u0027,\u0027);","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"c0b49d262a933b35b3227986c2236730427f7ffd","unresolved":false,"context_lines":[{"line_number":424,"context_line":"    include ::neutron::db::sync"},{"line_number":425,"context_line":"  }"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"  if is_array($default_availability_zones) {"},{"line_number":428,"context_line":"    $real_default_availability_zones \u003d join($default_availability_zones, \u0027,\u0027)"},{"line_number":429,"context_line":"  } else {"},{"line_number":430,"context_line":"    $real_default_availability_zones \u003d $default_availability_zones"},{"line_number":431,"context_line":"  }"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"  neutron_config {"},{"line_number":434,"context_line":"    \u0027DEFAULT/api_workers\u0027:                      value \u003d\u003e $api_workers;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_74c1c1e3","line":431,"range":{"start_line":427,"start_character":0,"end_line":431,"end_character":3},"in_reply_to":"1a122d0e_344f4935","updated":"2016-04-28 11:13:28.000000000","message":"Next patch will have that, thanks.","commit_id":"bbf1f797209a6637b53c354fc16dd4f2d5f66754"}],"spec/classes/neutron_server_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"7c828a3f87edab93529d98fa2c2a736f92f8f8e8","unresolved":false,"context_lines":[{"line_number":207,"context_line":"      end"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"      it \u0027fails when dhcp_load_type value is incorrect\u0027 do"},{"line_number":210,"context_line":"        is_expected.not_to compile"},{"line_number":211,"context_line":"      end"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a122d0e_35c71a46","line":210,"updated":"2016-04-29 15:36:19.000000000","message":"that\u0027s not best practice to have not_to compile.\n\nYou need to catch error exactly, which will be raised in manifests.","commit_id":"f6c0741126b905f84c7e26aeee8ed0b64bae5922"}]}
