)]}'
{"manifests/server.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bc3826aa2c8bea9d138a0468d5d5a269b7036a32","unresolved":false,"context_lines":[{"line_number":245,"context_line":"#   true/false"},{"line_number":246,"context_line":"#   Defaults to false"},{"line_number":247,"context_line":"#"},{"line_number":248,"context_line":"# [*service_provider*]"},{"line_number":249,"context_line":"#   (optional) (Array) Configures the service providers for neutron server."},{"line_number":250,"context_line":"#   This needs to be set for lbaas, vpnaas, and fwaas."},{"line_number":251,"context_line":"#   Defaults to $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_b6d12dfe","line":248,"updated":"2016-05-06 16:19:34.000000000","message":"I don\u0027t see unit tests regarding this change.","commit_id":"ff2ac533be7d7ce63337a9617fbfe2816b8583d3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bc3826aa2c8bea9d138a0468d5d5a269b7036a32","unresolved":false,"context_lines":[{"line_number":463,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e $service_provider;"},{"line_number":464,"context_line":"  }"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"  if $state_path {"},{"line_number":468,"context_line":"    # If we got state_path here, display deprecation warning and override the value from"},{"line_number":469,"context_line":"    # the base class.  This preserves the behavior of before state_path was deprecated."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_96922956","line":466,"updated":"2016-05-06 16:19:34.000000000","message":"this line is useless, please revert this change.","commit_id":"ff2ac533be7d7ce63337a9617fbfe2816b8583d3"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3f8ed0ffba115890b1da6da5d1bbdd8121ec8ece","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e $service_providers;"},{"line_number":458,"context_line":"  }"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  if $state_path {"},{"line_number":462,"context_line":"    # If we got state_path here, display deprecation warning and override the value from"},{"line_number":463,"context_line":"    # the base class.  This preserves the behavior of before state_path was deprecated."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_2c368cb4","line":460,"updated":"2016-05-24 13:36:08.000000000","message":"nit: extra line","commit_id":"31659e63c1025291c975dc0553c6e365fe431aed"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"53ee84e68d50b672bc989609e3594a318a287fd7","unresolved":false,"context_lines":[{"line_number":457,"context_line":"    \u0027service_providers/service_provider\u0027:       value \u003d\u003e $service_providers;"},{"line_number":458,"context_line":"  }"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"  if $state_path {"},{"line_number":462,"context_line":"    # If we got state_path here, display deprecation warning and override the value from"},{"line_number":463,"context_line":"    # the base class.  This preserves the behavior of before state_path was deprecated."}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_7e679325","line":460,"in_reply_to":"bab6814e_2c368cb4","updated":"2016-05-24 14:47:11.000000000","message":"removed extra line","commit_id":"31659e63c1025291c975dc0553c6e365fe431aed"}],"manifests/services/lbaas.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bc3826aa2c8bea9d138a0468d5d5a269b7036a32","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  include ::neutron::params"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  if !is_service_default($service_providers) {"},{"line_number":50,"context_line":"    warning(\u0027service_providers in neutron::services::lbaas is deprecated, please use service provider in neutron::server class\u0027)"},{"line_number":51,"context_line":"  }"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  if $package_ensure {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_d6aaf16f","line":50,"updated":"2016-05-06 16:19:34.000000000","message":"we need a release note about that.","commit_id":"ff2ac533be7d7ce63337a9617fbfe2816b8583d3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a534392a086ef700071fb6407418a4ac3489e396","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# \u003d\u003d Class: neutron::services::lbaas"},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":"# Configure the Loadbalancer as a Service Neutron Plugin"},{"line_number":22,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_49571326","line":19,"updated":"2016-05-10 11:56:17.000000000","message":"i guess you can mention also that whole class is deprecated now.","commit_id":"a5597a0e1545f0180003a8a73ce23a065244d3a0"}],"manifests/services/vpnaas.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"bc3826aa2c8bea9d138a0468d5d5a269b7036a32","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  include ::neutron::params"},{"line_number":44,"context_line":"  if !is_service_default($service_providers) {"},{"line_number":45,"context_line":"    warning(\u0027service_providers in neutron::services::vpnaas is deprecated, please use service provider in neutron::server class\u0027)"},{"line_number":46,"context_line":"  }"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"  # agent package contains both agent and service resources"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_96c7c944","line":45,"updated":"2016-05-06 16:19:34.000000000","message":"need release note","commit_id":"ff2ac533be7d7ce63337a9617fbfe2816b8583d3"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"a534392a086ef700071fb6407418a4ac3489e396","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# [*package_ensure*]"},{"line_number":26,"context_line":"#   (required) Whether or not to install the VPNaas Neutron plugin package"},{"line_number":27,"context_line":"#   Defaults to present"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"# [*service_providers*]"},{"line_number":30,"context_line":"#   (optional) Array of allowed service types or \u0027\u003cSERVICE DEFAULT\u003e\u0027."},{"line_number":31,"context_line":"#   Note: The default upstream value is empty."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dab17558_292baf95","line":28,"updated":"2016-05-10 11:56:17.000000000","message":"deprecated parameters?","commit_id":"a5597a0e1545f0180003a8a73ce23a065244d3a0"}]}