)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1ac10a497ead7e85e8ac1995bf2fc43817a771de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New config parameters for PLUMgrid Neutron plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PLUMgrid Neutron plugin has a new parameter to"},{"line_number":10,"context_line":"support latest keystone version."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Doc-ref: https://wiki.openstack.org/wiki/PLUMgrid-Neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_8c4891b4","line":9,"updated":"2016-05-23 15:13:34.000000000","message":"please mention, that you are actually switching to v3","commit_id":"257a328ea96e886ebc5fdcf3b83812568317730f"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"65a255809727ebf9a29ee0901a9aa4010c3b3d96","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"New config parameters for PLUMgrid Neutron plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"PLUMgrid Neutron plugin has a new parameter to"},{"line_number":10,"context_line":"support latest keystone version."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Doc-ref: https://wiki.openstack.org/wiki/PLUMgrid-Neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_c0041816","line":9,"in_reply_to":"bab6814e_8c4891b4","updated":"2016-05-23 16:05:22.000000000","message":"Done","commit_id":"257a328ea96e886ebc5fdcf3b83812568317730f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1ac10a497ead7e85e8ac1995bf2fc43817a771de","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Doc-ref: https://wiki.openstack.org/wiki/PLUMgrid-Neutron"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The change needs to be back-ported to stable/mitaka as well."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibf5b5f7430035291d7bb89fe6ec744746c909903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_ace475ab","line":14,"updated":"2016-05-23 15:13:34.000000000","message":"no need to mention this here","commit_id":"257a328ea96e886ebc5fdcf3b83812568317730f"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"65a255809727ebf9a29ee0901a9aa4010c3b3d96","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Doc-ref: https://wiki.openstack.org/wiki/PLUMgrid-Neutron"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The change needs to be back-ported to stable/mitaka as well."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ibf5b5f7430035291d7bb89fe6ec744746c909903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_000bc024","line":14,"in_reply_to":"bab6814e_ace475ab","updated":"2016-05-23 16:05:22.000000000","message":"Done","commit_id":"257a328ea96e886ebc5fdcf3b83812568317730f"}],"manifests/plugins/plumgrid.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6d5e083f65f66f40e4a4c14c23092475bdc13c4e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3.0"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_66f6215e","line":43,"updated":"2016-05-23 17:45:30.000000000","message":"should be just v3 i guess","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"94f702fe469e8d4d2cbdf7cd9daf12710d3ea06f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3.0"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_65fe023a","line":43,"in_reply_to":"bab6814e_16649ce3","updated":"2016-05-24 05:49:18.000000000","message":"Thanks dennis for pointing this out. I have updated the patch-set accordingly. Making it v3 makes more sense.","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"8265eefd6e23d1c4f073397a1fe5cde3d30ebd49","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3.0"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_16649ce3","line":43,"in_reply_to":"bab6814e_66f6215e","updated":"2016-05-23 19:50:07.000000000","message":"Denis, PLUMgrid Library expects the identity version to be configured in this format. For sample configurations see, https://wiki.openstack.org/wiki/PLUMgrid-Neutron. \n\nHope this clarifies.","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6d5e083f65f66f40e4a4c14c23092475bdc13c4e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $admin_password               \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $controller_priv_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":103,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":104,"context_line":"  $identity_version             \u003d \u0027v3.0\u0027,"},{"line_number":105,"context_line":"  $user_domain_name             \u003d \u0027Default\u0027,"},{"line_number":106,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":107,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_c6970dea","line":104,"updated":"2016-05-23 17:45:30.000000000","message":"same","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"94f702fe469e8d4d2cbdf7cd9daf12710d3ea06f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $admin_password               \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $controller_priv_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":103,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":104,"context_line":"  $identity_version             \u003d \u0027v3.0\u0027,"},{"line_number":105,"context_line":"  $user_domain_name             \u003d \u0027Default\u0027,"},{"line_number":106,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":107,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_e598321e","line":104,"in_reply_to":"bab6814e_b69950d3","updated":"2016-05-24 05:49:18.000000000","message":"Done","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"8265eefd6e23d1c4f073397a1fe5cde3d30ebd49","unresolved":false,"context_lines":[{"line_number":101,"context_line":"  $admin_password               \u003d $::os_service_default,"},{"line_number":102,"context_line":"  $controller_priv_host         \u003d \u0027127.0.0.1\u0027,"},{"line_number":103,"context_line":"  $auth_protocol                \u003d \u0027http\u0027,"},{"line_number":104,"context_line":"  $identity_version             \u003d \u0027v3.0\u0027,"},{"line_number":105,"context_line":"  $user_domain_name             \u003d \u0027Default\u0027,"},{"line_number":106,"context_line":"  $nova_metadata_ip             \u003d \u0027127.0.0.1\u0027,"},{"line_number":107,"context_line":"  $nova_metadata_port           \u003d \u00278775\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_b69950d3","line":104,"in_reply_to":"bab6814e_c6970dea","updated":"2016-05-23 19:50:07.000000000","message":"See the above comment.","commit_id":"cd2ab512badc586a0030fc13cb3118cd1b1d16fb"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8c9e439d46f657ccd25bede8e46cf3d734348bca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_b8e1249d","line":43,"updated":"2016-05-24 10:07:08.000000000","message":"also, make since (if possible) don\u0027t use identity version at all, and use version-less endpoint. Is it possible for your plugin? Or identity version must be specified?\n\nIn case of 1) option - you can deprecate identity_version parameter and remove it from config and url.\n\nIn case of 2) - i\u0027m ok and i\u0027ll +2 after your answer.","commit_id":"a8b631e0972de6f965e43a02d64dba377e58490f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f40b47051ed203cbe23ca8e758814ffc12defdf","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_b59f664f","line":43,"in_reply_to":"bab6814e_8e0b3a2b","updated":"2016-05-24 11:42:16.000000000","message":"Just fyi, main neutron keystone_authtoken configuration already contains version-less endpoint. So, for keeping backward compatibility we can switch this plugin to version-less uri and keep old parameter identity_version - but do not put it to config.","commit_id":"a8b631e0972de6f965e43a02d64dba377e58490f"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"901d960877a96badc84d07a75fe21bd397eb3448","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_7beb2fb1","line":43,"in_reply_to":"bab6814e_b59f664f","updated":"2016-05-24 12:12:48.000000000","message":"Makes sense. Actually we have this limitation (in PLUMgird Library) to have the keystone version in auth_uri and identity version.\n\nWe are working on adding support for version-less endpoint in the plugin. Once supported I will deprecate the config here.","commit_id":"a8b631e0972de6f965e43a02d64dba377e58490f"},{"author":{"_account_id":18438,"name":"Qasim Sarfraz","email":"qasims@plumgrid.com","username":"qasims"},"change_message_id":"6c3160ca5033af1e9830c089a8495e6e27e23089","unresolved":false,"context_lines":[{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*identity_version*]"},{"line_number":42,"context_line":"#   Keystone identity version"},{"line_number":43,"context_line":"#   Defaults to v3"},{"line_number":44,"context_line":"#"},{"line_number":45,"context_line":"# [*user_domain_name*]"},{"line_number":46,"context_line":"#   Keystone user domain name"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_8e0b3a2b","line":43,"in_reply_to":"bab6814e_b8e1249d","updated":"2016-05-24 10:41:11.000000000","message":"Thanks Denis.\n\nWith the current plugin implementation it isn\u0027t possible to deprecate the identity version parameter. So. we have to include this config parameter.","commit_id":"a8b631e0972de6f965e43a02d64dba377e58490f"}]}