)]}'
{"manifests/agents/lbaas.pp":[{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"40656450e34c5b2d5e1edc5e1a94953182407877","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $user_group             \u003d $::neutron::params::nobody_user_group,"},{"line_number":56,"context_line":"  $manage_haproxy_package \u003d true,"},{"line_number":57,"context_line":"  $purge_config           \u003d false,"},{"line_number":58,"context_line":"  $enable_v1              \u003d true,"},{"line_number":59,"context_line":"  $enable_v2              \u003d false,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_560516c0","line":58,"updated":"2016-05-25 14:37:50.000000000","message":"If we\u0027re making v2 default, we should change the enable_v1 to false and enable_v2 to true.","commit_id":"cdf37836b03355e8365f4d0ce72b87df36dfe33a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ac2139515d07501de47df11deee86544d96bf7a4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $user_group             \u003d $::neutron::params::nobody_user_group,"},{"line_number":56,"context_line":"  $manage_haproxy_package \u003d true,"},{"line_number":57,"context_line":"  $purge_config           \u003d false,"},{"line_number":58,"context_line":"  $enable_v1              \u003d true,"},{"line_number":59,"context_line":"  $enable_v2              \u003d false,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_99ab3189","line":58,"in_reply_to":"bab6814e_560516c0","updated":"2016-05-25 14:50:54.000000000","message":"Agree, also you need to add a release note for this. We are using reno.","commit_id":"cdf37836b03355e8365f4d0ce72b87df36dfe33a"},{"author":{"_account_id":20316,"name":"Marcellin Fom Tchassem","email":"mf6510@att.com","username":"ciello89"},"change_message_id":"f82e1830bb9a144a80e4b80f9574dbacfb26c8ef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $user_group             \u003d $::neutron::params::nobody_user_group,"},{"line_number":56,"context_line":"  $manage_haproxy_package \u003d true,"},{"line_number":57,"context_line":"  $purge_config           \u003d false,"},{"line_number":58,"context_line":"  $enable_v1              \u003d true,"},{"line_number":59,"context_line":"  $enable_v2              \u003d false,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_e57c4eb7","line":58,"in_reply_to":"bab6814e_560516c0","updated":"2016-05-25 15:53:04.000000000","message":"Done","commit_id":"cdf37836b03355e8365f4d0ce72b87df36dfe33a"},{"author":{"_account_id":20316,"name":"Marcellin Fom Tchassem","email":"mf6510@att.com","username":"ciello89"},"change_message_id":"f82e1830bb9a144a80e4b80f9574dbacfb26c8ef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $user_group             \u003d $::neutron::params::nobody_user_group,"},{"line_number":56,"context_line":"  $manage_haproxy_package \u003d true,"},{"line_number":57,"context_line":"  $purge_config           \u003d false,"},{"line_number":58,"context_line":"  $enable_v1              \u003d true,"},{"line_number":59,"context_line":"  $enable_v2              \u003d false,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_454a7a84","line":58,"in_reply_to":"bab6814e_99ab3189","updated":"2016-05-25 15:53:04.000000000","message":"Done","commit_id":"cdf37836b03355e8365f4d0ce72b87df36dfe33a"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"397085ebb331555546c96c7ef009ca9b60d6e70f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"  $user_group             \u003d $::neutron::params::nobody_user_group,"},{"line_number":56,"context_line":"  $manage_haproxy_package \u003d true,"},{"line_number":57,"context_line":"  $purge_config           \u003d false,"},{"line_number":58,"context_line":"  $enable_v1              \u003d false,"},{"line_number":59,"context_line":"  $enable_v2              \u003d true,"},{"line_number":60,"context_line":") {"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7aa08908_da24f2b3","line":58,"range":{"start_line":58,"start_character":2,"end_line":58,"end_character":34},"updated":"2016-06-09 13:56:52.000000000","message":"As I understand, lbaasv1 is deprecated, could you please also add a warning regarding it?","commit_id":"29168c957ee13c76bc9bbfdbcc70d9d3f3ff2cb0"}],"spec/classes/neutron_agents_lbaas_spec.rb":[{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"844fb05362135419a0e8d2cf250fbafba76e9301","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    { :package_ensure   \u003d\u003e \u0027present\u0027,"},{"line_number":15,"context_line":"      :enabled          \u003d\u003e true,"},{"line_number":16,"context_line":"      :interface_driver \u003d\u003e \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027,"},{"line_number":17,"context_line":"      :device_driver    \u003d\u003e \u0027neutron_lbaas.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver\u0027,"},{"line_number":18,"context_line":"      :manage_haproxy_package  \u003d\u003e true,"},{"line_number":19,"context_line":"      :purge_config            \u003d\u003e false"},{"line_number":20,"context_line":"    }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_d6546655","side":"PARENT","line":17,"updated":"2016-05-25 14:42:09.000000000","message":"you will need to add the enable_v1 false and enable_v2 true options here too.","commit_id":"8e99353ef6838cde31f979c9e6683997f3ee369d"},{"author":{"_account_id":20316,"name":"Marcellin Fom Tchassem","email":"mf6510@att.com","username":"ciello89"},"change_message_id":"f82e1830bb9a144a80e4b80f9574dbacfb26c8ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    { :package_ensure   \u003d\u003e \u0027present\u0027,"},{"line_number":15,"context_line":"      :enabled          \u003d\u003e true,"},{"line_number":16,"context_line":"      :interface_driver \u003d\u003e \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027,"},{"line_number":17,"context_line":"      :device_driver    \u003d\u003e \u0027neutron_lbaas.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver\u0027,"},{"line_number":18,"context_line":"      :manage_haproxy_package  \u003d\u003e true,"},{"line_number":19,"context_line":"      :purge_config            \u003d\u003e false"},{"line_number":20,"context_line":"    }"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"bab6814e_a559a65d","side":"PARENT","line":17,"in_reply_to":"bab6814e_d6546655","updated":"2016-05-25 15:53:04.000000000","message":"Done","commit_id":"8e99353ef6838cde31f979c9e6683997f3ee369d"}]}