)]}'
{"manifests/plugins/opencontrail.pp":[{"author":{"_account_id":16339,"name":"Cyril Lopez","email":"cylopez@redhat.com","username":"cylopez"},"change_message_id":"7761387f0f5d03c299e3ede25149c6716182ed50","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :       value \u003d\u003e $keystone_admin_user;"},{"line_number":116,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_admin_tenant_name;"},{"line_number":117,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $keystone_admin_password, secret \u003d\u003etrue;"},{"line_number":118,"context_line":"    \u0027keystone_authtoken/admin_token\u0027:       value \u003d\u003e $keystone_admin_token, secret \u003d\u003etrue;"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_e4deb0d8","line":119,"range":{"start_line":118,"start_character":90,"end_line":119,"end_character":3},"updated":"2016-06-14 12:15:06.000000000","message":"Is missing this following in keystone_authtoken section :\nauth_host\u003d[VIP keystone]\nidentity_uri \u003d http://[VIP keystone admin]:35357\nauth_protocol \u003d http or https","commit_id":"e1f441cf251a6cd98cbefe4907bd6fa29ad76847"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2d90affa75c20d6173e248919863d66e7392ac44","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    \u0027keystone_authtoken/admin_user\u0027 :       value \u003d\u003e $keystone_admin_user;"},{"line_number":116,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_admin_tenant_name;"},{"line_number":117,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $keystone_admin_password, secret \u003d\u003etrue;"},{"line_number":118,"context_line":"    \u0027keystone_authtoken/admin_token\u0027:       value \u003d\u003e $keystone_admin_token, secret \u003d\u003etrue;"},{"line_number":119,"context_line":"  }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_b8cccb6a","line":119,"range":{"start_line":118,"start_character":90,"end_line":119,"end_character":3},"in_reply_to":"7aa08908_e4deb0d8","updated":"2016-06-14 13:09:45.000000000","message":"the 3 parameters that you mentioned are deprecated in OpenStack, look the doc: http://docs.openstack.org/developer/keystonemiddleware/middlewarearchitecture.html","commit_id":"e1f441cf251a6cd98cbefe4907bd6fa29ad76847"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"52f6dc2eddb9db45829e21f573b164721341c9d5","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#"},{"line_number":30,"context_line":"# [*keystone_auth_protocol*]"},{"line_number":31,"context_line":"#   HTTP or HTTPS protocol for keystone"},{"line_number":32,"context_line":"#   Defaults to http"},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"# [*keystone_auth_url*]"},{"line_number":35,"context_line":"#   Url of the keystone auth server"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_0400a300","line":32,"range":{"start_line":32,"start_character":16,"end_line":32,"end_character":20},"updated":"2016-06-22 17:28:41.000000000","message":"Is there a reason to set the exact value here? Probably it makes sense to leave $::os_service_default here and validate the value (http or https)","commit_id":"7cd3464adf0cd11a1bd5679e1cbffec5ec0ab017"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"a0d5c55568bc56530586871ace9854f684a1676a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_admin_tenant_name;"},{"line_number":134,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $keystone_admin_password, secret \u003d\u003etrue;"},{"line_number":135,"context_line":"    \u0027keystone_authtoken/admin_token\u0027:       value \u003d\u003e $keystone_admin_token, secret \u003d\u003etrue;"},{"line_number":136,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $keystone_admin_url;"},{"line_number":137,"context_line":"  }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_b6bcafdc","line":136,"range":{"start_line":136,"start_character":54,"end_line":136,"end_character":72},"updated":"2016-06-27 11:47:16.000000000","message":"Such variable name is confusing, can it be renamed to $keystone_identity_uri? Also AFAIK identity_uri is replaced by auth_url, auth_uri can be used additionally","commit_id":"776ff29d771806e312b78d60551d4e0e053e4a7d"},{"author":{"_account_id":16339,"name":"Cyril Lopez","email":"cylopez@redhat.com","username":"cylopez"},"change_message_id":"7b4980548377ba253395f24d96397c972bf8ee7d","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $keystone_admin_tenant_name;"},{"line_number":134,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $keystone_admin_password, secret \u003d\u003etrue;"},{"line_number":135,"context_line":"    \u0027keystone_authtoken/admin_token\u0027:       value \u003d\u003e $keystone_admin_token, secret \u003d\u003etrue;"},{"line_number":136,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $keystone_admin_url;"},{"line_number":137,"context_line":"  }"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_6c2efba6","line":136,"range":{"start_line":136,"start_character":54,"end_line":136,"end_character":72},"in_reply_to":"3aaa91ec_b6bcafdc","updated":"2016-06-27 12:10:01.000000000","message":"Thank for your remark and help, i have less skill...\nwe are expecting the keystone admin uri here. What can i use ?","commit_id":"776ff29d771806e312b78d60551d4e0e053e4a7d"}]}