)]}'
{"manifests/plugins/ml2.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fc8ffe0f0fd87c18d0e1086f5339bb4f65d45a2c","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  $firewall_driver           \u003d $::os_service_default,"},{"line_number":145,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":146,"context_line":"  $supported_pci_vendor_devs \u003d [\u002715b3:1004\u0027, \u00278086:10ca\u0027],"},{"line_number":147,"context_line":"  $sriov_agent_required      \u003d false,"},{"line_number":148,"context_line":"  $physical_network_mtus     \u003d $::os_service_default,"},{"line_number":149,"context_line":"  $path_mtu                  \u003d 0,"},{"line_number":150,"context_line":"  $purge_config              \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_4a4aa228","side":"PARENT","line":147,"updated":"2016-06-16 16:45:54.000000000","message":"This parameter was not deprecated. You need deprecate it at least on one cycle and raise warning message that parameter is deprecated.\n\nBut you can remove parameter from config.","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"79938c24173aff4a84c6753c2f0811ad46fea627","unresolved":false,"context_lines":[{"line_number":144,"context_line":"  $firewall_driver           \u003d $::os_service_default,"},{"line_number":145,"context_line":"  $package_ensure            \u003d \u0027present\u0027,"},{"line_number":146,"context_line":"  $supported_pci_vendor_devs \u003d [\u002715b3:1004\u0027, \u00278086:10ca\u0027],"},{"line_number":147,"context_line":"  $sriov_agent_required      \u003d false,"},{"line_number":148,"context_line":"  $physical_network_mtus     \u003d $::os_service_default,"},{"line_number":149,"context_line":"  $path_mtu                  \u003d 0,"},{"line_number":150,"context_line":"  $purge_config              \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a9d85d2_319d235a","side":"PARENT","line":147,"in_reply_to":"7aa08908_4a4aa228","updated":"2016-06-21 09:58:21.000000000","message":"Done, we will issue a warning.","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"b3950e9f6a089e4ff60aea5e713f43503f833130","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#   Repository. Should be an array of devices."},{"line_number":108,"context_line":"#   Defaults to [\u002715b3:1004\u0027, \u00278086:10ca\u0027] (Intel \u0026 Mellanox SR-IOV capable NICs)"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*sriov_agent_required*]"},{"line_number":111,"context_line":"#   (optional) SRIOV neutron agent is required for port binding."},{"line_number":112,"context_line":"#   Only set to true if SRIOV network adapters support VF link state setting"},{"line_number":113,"context_line":"#   and if admin state management is desired."},{"line_number":114,"context_line":"#   Defaults to false."},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*physical_network_mtus*]"},{"line_number":117,"context_line":"#   (optional) For L2 mechanism drivers, per-physical network MTU setting."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_5c8c3b7f","side":"PARENT","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":22},"updated":"2016-06-21 10:17:02.000000000","message":"please follow next pattern:\n\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/init.pp#L399-L404\n\nand\n\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/init.pp#L496-L497","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"0114ca6471e63754bc3c7f7bcee1d0c146f67cc3","unresolved":false,"context_lines":[{"line_number":107,"context_line":"#   Repository. Should be an array of devices."},{"line_number":108,"context_line":"#   Defaults to [\u002715b3:1004\u0027, \u00278086:10ca\u0027] (Intel \u0026 Mellanox SR-IOV capable NICs)"},{"line_number":109,"context_line":"#"},{"line_number":110,"context_line":"# [*sriov_agent_required*]"},{"line_number":111,"context_line":"#   (optional) SRIOV neutron agent is required for port binding."},{"line_number":112,"context_line":"#   Only set to true if SRIOV network adapters support VF link state setting"},{"line_number":113,"context_line":"#   and if admin state management is desired."},{"line_number":114,"context_line":"#   Defaults to false."},{"line_number":115,"context_line":"#"},{"line_number":116,"context_line":"# [*physical_network_mtus*]"},{"line_number":117,"context_line":"#   (optional) For L2 mechanism drivers, per-physical network MTU setting."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5a9d85d2_488f51cc","side":"PARENT","line":114,"range":{"start_line":110,"start_character":0,"end_line":114,"end_character":22},"in_reply_to":"5a9d85d2_5c8c3b7f","updated":"2016-06-21 11:48:19.000000000","message":"Done, thanks!","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"eb25b4388ffbae6b79241c62a674c5893b82f876","unresolved":false,"context_lines":[{"line_number":147,"context_line":"  $path_mtu                  \u003d 0,"},{"line_number":148,"context_line":"  $purge_config              \u003d false,"},{"line_number":149,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":150,"context_line":"  $sriov_agent_required      \u003d false,"},{"line_number":151,"context_line":") {"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a9d85d2_5f970890","line":150,"updated":"2016-06-21 12:16:43.000000000","message":"undef","commit_id":"35bc00a940d0200298bd8f6b8f4a9b028c259044"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"7b7b0f08f5074d90397a04477314c5ec97da74dd","unresolved":false,"context_lines":[{"line_number":147,"context_line":"  $path_mtu                  \u003d 0,"},{"line_number":148,"context_line":"  $purge_config              \u003d false,"},{"line_number":149,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":150,"context_line":"  $sriov_agent_required      \u003d false,"},{"line_number":151,"context_line":") {"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_718cae35","line":150,"in_reply_to":"5a9d85d2_5f970890","updated":"2016-06-23 08:31:50.000000000","message":"Done","commit_id":"35bc00a940d0200298bd8f6b8f4a9b028c259044"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"99508abcf3a0b134f42887d4edf04d053ee7f863","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  if $sriov_agent_required {"},{"line_number":217,"context_line":"    warning (\u0027Warning: Scope(Class[neutron::plugins::ml2]): sriov_agent_required is deprecated, has no effect and will be removed in a future release.\u0027)"},{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  neutron::plugins::ml2::mech_driver { $mechanism_drivers:"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_6c66182b","line":217,"updated":"2016-07-21 14:40:17.000000000","message":"no need to say \"Warning: Scope ...\", it\u0027s redondant with what Puppet already warn.","commit_id":"aa7f31942647a9e2f54d90cdc76d1eb4ba830a8e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8e3319205dd06de243e37d7ac5f855ff38c12c90","unresolved":false,"context_lines":[{"line_number":131,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":132,"context_line":"#"},{"line_number":133,"context_line":"# [*sriov_agent_required*]"},{"line_number":134,"context_line":"#   (optional) Warning!! sriov_agent_required is deprecated and will be removed"},{"line_number":135,"context_line":"#   in the next release. By Default this is enabled, sriovnicswitch is enabled."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class neutron::plugins::ml2 ("}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_196deccc","line":134,"updated":"2016-08-02 15:16:24.000000000","message":"This is not the usual format.\nShould be something like:\n\n(optional) Deprecated.\nDefaults to undef.","commit_id":"51166c1be29036e146e43c695d3681d5c86df4a6"}],"manifests/plugins/ml2/mech_driver.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"fc8ffe0f0fd87c18d0e1086f5339bb4f65d45a2c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# [*sriov_agent_required*]"},{"line_number":27,"context_line":"#   (optional) SRIOV neutron agent is always required for port binding"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":30,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":31,"context_line":"  $sriov_agent_required \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_aa5fc6e2","side":"PARENT","line":28,"updated":"2016-06-16 16:45:54.000000000","message":"same","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"eb25b4388ffbae6b79241c62a674c5893b82f876","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":30,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":31,"context_line":"  $sriov_agent_required \u003d true,"},{"line_number":32,"context_line":"){"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"5a9d85d2_3f783c2b","side":"PARENT","line":31,"updated":"2016-06-21 12:16:43.000000000","message":"please deprecate it here as well. Someone can use this define in top orchestration.\n\nP.S. I don\u0027t understand why this is implemented as define, because it used only for one option set. Let\u0027s deprecate it at all and move 32-35 lines to other class","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"7b7b0f08f5074d90397a04477314c5ec97da74dd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":30,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":31,"context_line":"  $sriov_agent_required \u003d true,"},{"line_number":32,"context_line":"){"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_d19ac262","side":"PARENT","line":31,"in_reply_to":"5a9d85d2_3f783c2b","updated":"2016-06-23 08:31:50.000000000","message":"Done, however moving the lines into the ml2.pp can be done as a separate patch say \u0027cleanup\u0027?","commit_id":"c8c790cd8b699e35816f5e46de41d8f77c1f7f5f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"99508abcf3a0b134f42887d4edf04d053ee7f863","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  include ::neutron::deps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $sriov_agent_required {"},{"line_number":40,"context_line":"    warning (\u0027Warning: Scope(Class[neutron::plugins::ml2]): sriov_agent_required is deprecated, has no effect and will be removed in a future release.\u0027)"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if ($name \u003d\u003d \u0027sriovnicswitch\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_4c6994f8","line":40,"updated":"2016-07-21 14:40:17.000000000","message":"dito","commit_id":"aa7f31942647a9e2f54d90cdc76d1eb4ba830a8e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"c0aec0c94d02bf4b140050cd8936dc5a47575d45","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  include ::neutron::deps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $sriov_agent_required {"},{"line_number":40,"context_line":"    warning (\u0027sriov_agent_required is deprecated, has no effect and will be removed in a future release.\u0027)"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if ($name \u003d\u003d \u0027sriovnicswitch\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dada55a8_d2c23652","line":40,"updated":"2016-07-21 17:32:26.000000000","message":"in fact this warning is useless because nobody calls this Define manually, we already have the warning from the class, so you can safely remove the parameter here and the warning without deprecation. Keep deprecation in the class though.","commit_id":"2e7831e8ebfdb53a4902f403dbfb59e004f912f6"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"48518d42449bee556a57d0bf9e6030a8ceb9e8cd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"  include ::neutron::deps"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"  if $sriov_agent_required {"},{"line_number":40,"context_line":"    warning (\u0027sriov_agent_required is deprecated, has no effect and will be removed in a future release.\u0027)"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  if ($name \u003d\u003d \u0027sriovnicswitch\u0027) {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dada55a8_cc3effd9","line":40,"in_reply_to":"dada55a8_d2c23652","updated":"2016-07-22 07:30:12.000000000","message":"Done","commit_id":"2e7831e8ebfdb53a4902f403dbfb59e004f912f6"}]}
