)]}'
{"manifests/agents/ml2/sriov.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"ba38571af772479828813e92a6d13bd8825a2e3d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_49d714ed","line":68,"updated":"2016-06-23 23:40:49.000000000","message":"Rather than using an empty array, would it be better to just use $::os_service_default which will prevent the error condition currently there since it\u0027ll just remove the config options","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"38120eaf574984043c4437ab8770e1f6ff3b23c4","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_3695b186","line":68,"in_reply_to":"3aaa91ec_49d714ed","updated":"2016-06-24 08:40:53.000000000","message":"+1","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"1bef4d4cb9641aea1439d0df46e0b0541ec2273d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_55b310e9","line":68,"in_reply_to":"3aaa91ec_49d714ed","updated":"2016-06-24 10:15:03.000000000","message":"Alex, we had checked, if we put --\n$physical_device_mappings   \u003d $::os_service_default,\nWe are still getting a bad line with empty option\nphysical_device_mappings\u003d\nthe above is not ok to have. What we understand, is that since this a array, passed down from Hiera (comma separated list) it gets a empty array [], which does not match the condition. Please advice.","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c926011d748e6e065cfdc6317a29925745019064","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_4fc898a8","line":68,"in_reply_to":"3aaa91ec_55b310e9","updated":"2016-06-24 13:24:25.000000000","message":"If you put $::os_service_default you should not get the empty mapping because os_service_default should cause the provider to remove the line from the configuration file.","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"665748ac054950bc3afc1d835dc024eef5735820","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3aaa91ec_96c1b3e6","line":68,"in_reply_to":"3aaa91ec_55b310e9","updated":"2016-06-27 11:54:35.000000000","message":"Then probably you should validate the value on a higher value:\n\n    if ! hiera(\u0027physical_device_mappings\u0027, \u0027\u0027) {\n       $physical_device_mappings \u003d $::os_service_default\n     } else {\n       $physical_device_mappings \u003d hiera(\u0027physical_device_mappings\u0027)\n     }\n\n     class { \u0027neutron::agents::ml2::sriov\u0027 :\n        physical_device_mappings \u003d\u003e $physical_device_mappings,\n     }\n\nAnd in this file it makes sense to set $::os_service_default as a default value","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"49057f0b9b4cc925390ecdaa17ee0218a14a89e6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"  $package_ensure             \u003d \u0027present\u0027,"},{"line_number":66,"context_line":"  $enabled                    \u003d true,"},{"line_number":67,"context_line":"  $manage_service             \u003d true,"},{"line_number":68,"context_line":"  $physical_device_mappings   \u003d [],"},{"line_number":69,"context_line":"  $polling_interval           \u003d 2,"},{"line_number":70,"context_line":"  $exclude_devices            \u003d [],"},{"line_number":71,"context_line":"  $extensions                 \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_8d894129","line":68,"in_reply_to":"3aaa91ec_96c1b3e6","updated":"2016-07-05 13:00:02.000000000","message":"Please look https://review.openstack.org/#/c/337653/\nI had to use a mix of os_service_default and empty because I also wanted to check if the list was empty or not.","commit_id":"8c78ec6341eb0924e538e4682fa08796080d351c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"277b48987d025ef550065826f0dcc253671a0e30","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  # The following values are following this rule:"},{"line_number":84,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":85,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":86,"context_line":"  # - Otherwise, fallback to default."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_314a0b56","line":83,"updated":"2016-07-20 10:09:59.000000000","message":"The next values should follow this rule...\n\nAnd probably you should add it to release note. Let\u0027s do not leave this text in the code.","commit_id":"d55d78af8c706a75d6356dea003a4e418414db59"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"33d5514ac6bbadbd62e40b7801796b35df47854a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    purge \u003d\u003e $purge_config,"},{"line_number":81,"context_line":"  }"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  # The following values are following this rule:"},{"line_number":84,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":85,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":86,"context_line":"  # - Otherwise, fallback to default."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_87e0d5fb","line":83,"in_reply_to":"dada55a8_314a0b56","updated":"2016-07-20 11:04:01.000000000","message":"Done","commit_id":"d55d78af8c706a75d6356dea003a4e418414db59"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f961e4991fdc9c7c7a81df1053a46e323a433534","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  if !is_service_default($exclude_devices) and !empty($exclude_devices) {"},{"line_number":88,"context_line":"    validate_array($exclude_devices)"},{"line_number":89,"context_line":"    neutron_sriov_agent_config {"},{"line_number":90,"context_line":"      \u0027sriov_nic/exclude_devices\u0027:          value \u003d\u003e join($exclude_devices, \u0027,\u0027);"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_faaf9a27","line":90,"updated":"2016-07-20 14:51:37.000000000","message":"you can remove useless extra space in the middle.","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"b8c2881ca1a08c9ddd123f4b9aaf7345bc2610cc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"  if !is_service_default($exclude_devices) and !empty($exclude_devices) {"},{"line_number":88,"context_line":"    validate_array($exclude_devices)"},{"line_number":89,"context_line":"    neutron_sriov_agent_config {"},{"line_number":90,"context_line":"      \u0027sriov_nic/exclude_devices\u0027:          value \u003d\u003e join($exclude_devices, \u0027,\u0027);"},{"line_number":91,"context_line":"    }"},{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dada55a8_d6dc0a48","line":90,"in_reply_to":"dada55a8_faaf9a27","updated":"2016-07-21 09:02:39.000000000","message":"Done","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3dd25183cabebe01551bafaea65540d92fa8ff37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":86,"context_line":"  # - Otherwise, fallback to default."},{"line_number":87,"context_line":"  if !is_service_default($exclude_devices) and !empty($exclude_devices) {"},{"line_number":88,"context_line":"    validate_array($exclude_devices)"},{"line_number":89,"context_line":"    neutron_sriov_agent_config {"},{"line_number":90,"context_line":"      \u0027sriov_nic/exclude_devices\u0027: value \u003d\u003e join($exclude_devices, \u0027,\u0027);"},{"line_number":91,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_61acf1a0","line":88,"updated":"2016-07-28 18:07:37.000000000","message":"why not just any2array($excluded_devices)? If this has to be an array please add this requirement into the parameter documentation.  My preference is just any2array to allow for strings.","commit_id":"c6b1ccf97e64f912574d18e8b9389b5ad6089df6"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"e5230d114b6db76789fa895ce6b40fe3d7acc698","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":86,"context_line":"  # - Otherwise, fallback to default."},{"line_number":87,"context_line":"  if !is_service_default($exclude_devices) and !empty($exclude_devices) {"},{"line_number":88,"context_line":"    validate_array($exclude_devices)"},{"line_number":89,"context_line":"    neutron_sriov_agent_config {"},{"line_number":90,"context_line":"      \u0027sriov_nic/exclude_devices\u0027: value \u003d\u003e join($exclude_devices, \u0027,\u0027);"},{"line_number":91,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_33dd130f","line":88,"in_reply_to":"bacf61ea_61acf1a0","updated":"2016-07-29 07:19:02.000000000","message":"we dont want to change the existing varabiles type,, we will keep as it is and add the format in the doc","commit_id":"c6b1ccf97e64f912574d18e8b9389b5ad6089df6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3dd25183cabebe01551bafaea65540d92fa8ff37","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if !is_service_default($physical_device_mappings) and !empty($physical_device_mappings) {"},{"line_number":95,"context_line":"    validate_array($physical_device_mappings)"},{"line_number":96,"context_line":"    neutron_sriov_agent_config {"},{"line_number":97,"context_line":"      \u0027sriov_nic/physical_device_mappings\u0027: value \u003d\u003e join($physical_device_mappings, \u0027,\u0027);"},{"line_number":98,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_41af2d94","line":95,"updated":"2016-07-28 18:07:37.000000000","message":"same","commit_id":"c6b1ccf97e64f912574d18e8b9389b5ad6089df6"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"e5230d114b6db76789fa895ce6b40fe3d7acc698","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  }"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"  if !is_service_default($physical_device_mappings) and !empty($physical_device_mappings) {"},{"line_number":95,"context_line":"    validate_array($physical_device_mappings)"},{"line_number":96,"context_line":"    neutron_sriov_agent_config {"},{"line_number":97,"context_line":"      \u0027sriov_nic/physical_device_mappings\u0027: value \u003d\u003e join($physical_device_mappings, \u0027,\u0027);"},{"line_number":98,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bacf61ea_13d8cf1c","line":95,"in_reply_to":"bacf61ea_41af2d94","updated":"2016-07-29 07:19:02.000000000","message":"Done","commit_id":"c6b1ccf97e64f912574d18e8b9389b5ad6089df6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90e10c89258a76974284e8c0e2fce4d499207b14","unresolved":false,"context_lines":[{"line_number":83,"context_line":"  if !is_service_default($exclude_devices) and !empty($exclude_devices) {"},{"line_number":84,"context_line":"    validate_array($exclude_devices)"},{"line_number":85,"context_line":"    neutron_sriov_agent_config {"},{"line_number":86,"context_line":"      \u0027sriov_nic/exclude_devices\u0027: value \u003d\u003e join($exclude_devices, \u0027,\u0027);"},{"line_number":87,"context_line":"    }"},{"line_number":88,"context_line":"  }"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_9bf4745b","line":86,"updated":"2016-08-01 14:31:55.000000000","message":"This should just always be set otherwise you have no way to remove it if $exclude_devices \u003d $::os_service_default. It would be better to move this out and use join(any2array($exclude_devices), \u0027,\u0027)","commit_id":"04d018ea52058069c169da419d89ba8dda054206"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90e10c89258a76974284e8c0e2fce4d499207b14","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  if !is_service_default($physical_device_mappings) and !empty($physical_device_mappings) {"},{"line_number":91,"context_line":"    validate_array($physical_device_mappings)"},{"line_number":92,"context_line":"    neutron_sriov_agent_config {"},{"line_number":93,"context_line":"      \u0027sriov_nic/physical_device_mappings\u0027: value \u003d\u003e join($physical_device_mappings, \u0027,\u0027);"},{"line_number":94,"context_line":"    }"},{"line_number":95,"context_line":"  }"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"bacf61ea_fbe770a9","line":93,"updated":"2016-08-01 14:31:55.000000000","message":"same","commit_id":"04d018ea52058069c169da419d89ba8dda054206"}],"releasenotes/notes/ml2-sriov-9369b66bb3d50d6a.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f961e4991fdc9c7c7a81df1053a46e323a433534","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  adds ml2  sriov functionality"},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  empty arrays - The following values are following this rule:"},{"line_number":6,"context_line":"    - default is $::os_service_default so Puppet won\u0027t try to configure it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_bab9a27b","line":3,"updated":"2016-07-20 14:51:37.000000000","message":"the format of the node is not good.\n\nEx:\n\nfeatures:\n  - Add ML2 SR-IOV support.","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"b8c2881ca1a08c9ddd123f4b9aaf7345bc2610cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  adds ml2  sriov functionality"},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  empty arrays - The following values are following this rule:"},{"line_number":6,"context_line":"    - default is $::os_service_default so Puppet won\u0027t try to configure it."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_f6ccae8a","line":3,"in_reply_to":"dada55a8_bab9a27b","updated":"2016-07-21 09:02:39.000000000","message":"Done","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f961e4991fdc9c7c7a81df1053a46e323a433534","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  empty arrays - The following values are following this rule:"},{"line_number":6,"context_line":"    - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":7,"context_line":"    - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":8,"context_line":"    - Otherwise, fallback to default."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_1ab38e99","line":8,"updated":"2016-07-20 14:51:37.000000000","message":"Those are not needed in the release note, you can drop it.","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"b8c2881ca1a08c9ddd123f4b9aaf7345bc2610cc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  empty arrays - The following values are following this rule:"},{"line_number":6,"context_line":"    - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":7,"context_line":"    - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":8,"context_line":"    - Otherwise, fallback to default."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_76a71ebd","line":8,"in_reply_to":"dada55a8_1ab38e99","updated":"2016-07-21 09:02:39.000000000","message":"Done","commit_id":"95a0e0ac8884c4491f5c211575de0ad3aff57eab"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"91acadcff73c9d11444d657abf84be977f118779","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - adds ml2  sriov functionality"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_0a519e0e","line":3,"updated":"2016-07-29 14:58:42.000000000","message":"1) you have an extra space\n2) this release note is wrong. The functionality was already here before the patch, so I\u0027m not sure you need a release note.","commit_id":"9f9f417e44a363162ded8dc9949fb019a5dba9b8"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"f688f45be935d29d22abfa5c83e66c3eb5006979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - adds ml2  sriov functionality"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_8327ffc8","line":3,"in_reply_to":"bacf61ea_0a519e0e","updated":"2016-08-01 09:18:31.000000000","message":"Done, removed release note.","commit_id":"9f9f417e44a363162ded8dc9949fb019a5dba9b8"}],"spec/classes/neutron_agents_ml2_sriov_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"277b48987d025ef550065826f0dcc253671a0e30","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    it \u0027configures /etc/neutron/plugins/ml2/sriov_agent.ini\u0027 do"},{"line_number":43,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027sriov_nic/polling_interval\u0027).with_value(p[:polling_interval])"},{"line_number":44,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/exclude_devices\u0027)"},{"line_number":45,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/physical_device_mappings\u0027)"},{"line_number":46,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027agent/extensions\u0027).with_value([\u0027\u003cSERVICE DEFAULT\u003e\u0027])"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"dada55a8_b1c8bba9","line":45,"updated":"2016-07-20 10:09:59.000000000","message":"please also add a test, when these values aren\u0027t service_default","commit_id":"d55d78af8c706a75d6356dea003a4e418414db59"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"33d5514ac6bbadbd62e40b7801796b35df47854a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    it \u0027configures /etc/neutron/plugins/ml2/sriov_agent.ini\u0027 do"},{"line_number":43,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027sriov_nic/polling_interval\u0027).with_value(p[:polling_interval])"},{"line_number":44,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/exclude_devices\u0027)"},{"line_number":45,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/physical_device_mappings\u0027)"},{"line_number":46,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027agent/extensions\u0027).with_value([\u0027\u003cSERVICE DEFAULT\u003e\u0027])"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"dada55a8_e7e6f013","line":45,"in_reply_to":"dada55a8_b1c8bba9","updated":"2016-07-20 11:04:01.000000000","message":"Thanks Ivan for reviewing, The test cases for concrete values are there in line nos. 81-84. Can you please suggest if we still need any more test cases?","commit_id":"d55d78af8c706a75d6356dea003a4e418414db59"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"24b3a4ff6cf92a0a5457eff2db04573232d5d123","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    it \u0027configures /etc/neutron/plugins/ml2/sriov_agent.ini\u0027 do"},{"line_number":43,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027sriov_nic/polling_interval\u0027).with_value(p[:polling_interval])"},{"line_number":44,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/exclude_devices\u0027)"},{"line_number":45,"context_line":"      is_expected.not_to contain_neutron_sriov_agent_config(\u0027sriov_nic/physical_device_mappings\u0027)"},{"line_number":46,"context_line":"      is_expected.to contain_neutron_sriov_agent_config(\u0027agent/extensions\u0027).with_value([\u0027\u003cSERVICE DEFAULT\u003e\u0027])"},{"line_number":47,"context_line":"    end"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":4,"id":"dada55a8_2a5e0d12","line":45,"in_reply_to":"dada55a8_e7e6f013","updated":"2016-07-20 11:15:50.000000000","message":"ah, I see. it\u0027s enough. thanks for pointing out","commit_id":"d55d78af8c706a75d6356dea003a4e418414db59"}]}