)]}'
{"manifests/plugins/ml2.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e0dfa5ad262093e581eac4903069a7256a440255","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    file { \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"},{"line_number":212,"context_line":"      target \u003d\u003e \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027,"},{"line_number":213,"context_line":"    }"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  neutron::plugins::ml2::mech_driver { $mechanism_drivers:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_72945742","line":213,"updated":"2016-06-24 13:47:03.000000000","message":"AFAIU, you need create symlink /etc/neutron/conf.d/neutron-server/ml2_conf.ini to /etc/neutron/plugins/ml2/ml2_conf.ini , so you need to swap target and source.","commit_id":"19fc7ae51816a2d80464c005d9d39446659f5bbf"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"8b4b983e66ea9b2d0f488962f51bc74b01b51419","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    file { \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"},{"line_number":212,"context_line":"      target \u003d\u003e \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027,"},{"line_number":213,"context_line":"    }"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  neutron::plugins::ml2::mech_driver { $mechanism_drivers:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3aaa91ec_84986f79","line":213,"in_reply_to":"3aaa91ec_72945742","updated":"2016-06-27 05:41:51.000000000","message":"Done, thanks for pointing out :)","commit_id":"19fc7ae51816a2d80464c005d9d39446659f5bbf"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"d55a6df42b1a6f6079dca4ec0b37d28a551ad487","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    vni_ranges          \u003d\u003e $vni_ranges,"},{"line_number":206,"context_line":"    vxlan_group         \u003d\u003e $vxlan_group,"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if \u0027sriovnicswitch\u0027 in $mechanism_drivers  {"},{"line_number":210,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_fba90291","line":208,"updated":"2016-06-27 11:29:48.000000000","message":"Not sure that this file is a right place for such check, please take a look at https://github.com/openstack/puppet-neutron/blob/master/manifests/plugins/ml2/mech_driver.pp#L36","commit_id":"60549ed6c6ffd2420bb72cf0faf2f3928c1a7b0a"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"32f095ef1e656ba95ce5f73a2579a26aca2b3c93","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    vni_ranges          \u003d\u003e $vni_ranges,"},{"line_number":206,"context_line":"    vxlan_group         \u003d\u003e $vxlan_group,"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if \u0027sriovnicswitch\u0027 in $mechanism_drivers  {"},{"line_number":210,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_03e35234","line":208,"in_reply_to":"3aaa91ec_fba90291","updated":"2016-06-29 08:26:22.000000000","message":"Done, moving this particular change to mech_driver.pp","commit_id":"60549ed6c6ffd2420bb72cf0faf2f3928c1a7b0a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"536df388c08309c62f4297409c2275cc742141f9","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"},{"line_number":212,"context_line":"      target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027,"},{"line_number":213,"context_line":"    }"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  neutron::plugins::ml2::mech_driver { $mechanism_drivers:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_f46f57c1","line":213,"updated":"2016-06-27 09:53:29.000000000","message":"looks like packages don\u0027t have directory \u0027/etc/neutron/conf.d/neutron-server\u0027 by default, so you need to create it here","commit_id":"60549ed6c6ffd2420bb72cf0faf2f3928c1a7b0a"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"32f095ef1e656ba95ce5f73a2579a26aca2b3c93","unresolved":false,"context_lines":[{"line_number":210,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"},{"line_number":211,"context_line":"      ensure \u003d\u003e link,"},{"line_number":212,"context_line":"      target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027,"},{"line_number":213,"context_line":"    }"},{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  neutron::plugins::ml2::mech_driver { $mechanism_drivers:"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3aaa91ec_e372867b","line":213,"in_reply_to":"3aaa91ec_f46f57c1","updated":"2016-06-29 08:26:22.000000000","message":"Thanks for pointing out. Done. moving this to mech_driver.pp as per Sergey\u0027s comment above.","commit_id":"60549ed6c6ffd2420bb72cf0faf2f3928c1a7b0a"}],"manifests/plugins/ml2/mech_driver.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"aff0f2e53f1ceddfc8b003f825168d4cde418775","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_0e8b5dc4","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":31},"updated":"2016-06-29 16:13:02.000000000","message":"Probably this directory should be created by packages. I\u0027m not sure that it should be created by Puppet if it\u0027s used by Neutron","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"3e49cda04c36a194cdf9821c502d7a4582d80d75","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_ae4fc5bc","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":46},"updated":"2016-06-29 08:50:59.000000000","message":"This will fail w/ error \"parent directory doesn\u0027t exist\"","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"796470b75c83c5a4bcdb9c2b488f15cf282410a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_75c5ce3a","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":31},"in_reply_to":"3aaa91ec_0e8b5dc4","updated":"2016-07-05 07:21:53.000000000","message":"package is creating /etc/neutron/conf.d","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"796470b75c83c5a4bcdb9c2b488f15cf282410a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_f5589efc","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":46},"in_reply_to":"3aaa91ec_ae4fc5bc","updated":"2016-07-05 07:21:53.000000000","message":"Done, added parent directory","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"f7c5f8f8d656a0a2cf16c95f311a9659ba645c8f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3aaa91ec_c40cad44","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":46},"in_reply_to":"3aaa91ec_ae4fc5bc","updated":"2016-06-29 10:17:48.000000000","message":"Exactly, that\u0027s why ubuntu job is red.","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"796470b75c83c5a4bcdb9c2b488f15cf282410a7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":42,"context_line":"      ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":43,"context_line":"    }"},{"line_number":44,"context_line":"    file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf.ini\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_9592fa49","line":41,"range":{"start_line":41,"start_character":12,"end_line":41,"end_character":46},"in_reply_to":"3aaa91ec_c40cad44","updated":"2016-07-05 07:21:53.000000000","message":"Done","commit_id":"65441f5958ba536b8d01acb82fd51684afcc9c8f"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"420189be2f42844e39e1014a7a4bea6a14edee6f","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    if($::osfamily \u003d\u003d \u0027Redhat\u0027) {"},{"line_number":42,"context_line":"      file { \u0027/etc/neutron/conf.d/\u0027, \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":43,"context_line":"        ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":44,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_38697bbf","line":41,"range":{"start_line":41,"start_character":23,"end_line":41,"end_character":29},"updated":"2016-07-05 07:38:58.000000000","message":"RedHat (s/h/H/)","commit_id":"a7c9c83151123ac0a8440310e5667afebfe6766b"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"1ffeb1b744e28f097fa27d71b4ec735f85f3f61b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    if($::osfamily \u003d\u003d \u0027Redhat\u0027) {"},{"line_number":42,"context_line":"      file { \u0027/etc/neutron/conf.d/\u0027, \u0027/etc/neutron/conf.d/neutron-server\u0027:"},{"line_number":43,"context_line":"        ensure \u003d\u003e \u0027directory\u0027,"},{"line_number":44,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_b13306f6","line":41,"range":{"start_line":41,"start_character":23,"end_line":41,"end_character":29},"in_reply_to":"1aa78d24_38697bbf","updated":"2016-07-08 10:02:36.000000000","message":"Done, thanks","commit_id":"a7c9c83151123ac0a8440310e5667afebfe6766b"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"420189be2f42844e39e1014a7a4bea6a14edee6f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        require \u003d\u003e File[\u0027/etc/neutron/conf.d/neutron-server\u0027],"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    } else {"},{"line_number":51,"context_line":"      warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_18e3df06","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":13},"updated":"2016-07-05 07:38:58.000000000","message":"on other platforms it\u0027ll always show warning ... is it Ok?","commit_id":"a7c9c83151123ac0a8440310e5667afebfe6766b"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"1ffeb1b744e28f097fa27d71b4ec735f85f3f61b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        require \u003d\u003e File[\u0027/etc/neutron/conf.d/neutron-server\u0027],"},{"line_number":49,"context_line":"      }"},{"line_number":50,"context_line":"    } else {"},{"line_number":51,"context_line":"      warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"1aa78d24_316d56cd","line":51,"range":{"start_line":51,"start_character":6,"end_line":51,"end_character":13},"in_reply_to":"1aa78d24_18e3df06","updated":"2016-07-08 10:02:36.000000000","message":"I am not sure of the ubuntu paths.","commit_id":"a7c9c83151123ac0a8440310e5667afebfe6766b"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"1d3f35495635b9b591f24e1840d5d30a30cf2ebe","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"        file { \u0027/etc/default/neutron-server/ml2_conf.ini\u0027:"},{"line_number":50,"context_line":"          ensure \u003d\u003e link,"},{"line_number":51,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027,"},{"line_number":52,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dada55a8_946d1735","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":56},"updated":"2016-07-18 12:34:16.000000000","message":"On Ubuntu/Debian /etc/default/neutron-server is a file and it\u0027s sourced by init script:\n\n. /etc/default/neutron-server\n\nSo I think we need to add to /etc/default/neutron-server smth like\n\n\"$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\"","commit_id":"5f7ebf26fb7de97f42c81520912efc91cf8678fd"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"20a6f7ff9ca964993c7c6b98edd10fe1523589e9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"        file { \u0027/etc/default/neutron-server/ml2_conf.ini\u0027:"},{"line_number":50,"context_line":"          ensure \u003d\u003e link,"},{"line_number":51,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf.ini\u0027,"},{"line_number":52,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"dada55a8_2ea2abfd","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":56},"in_reply_to":"dada55a8_946d1735","updated":"2016-07-20 08:31:09.000000000","message":"Thanks sergey, done","commit_id":"5f7ebf26fb7de97f42c81520912efc91cf8678fd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"811c610b6c9f7d13cd5dbbaa6a0231d2b24d227e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file { \u0027/etc/default/neutron-server\u0027:"},{"line_number":50,"context_line":"            ensure \u003d\u003e present,"},{"line_number":51,"context_line":"          }-\u003e"},{"line_number":52,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"dada55a8_0c2b6a95","line":49,"updated":"2016-07-20 10:39:43.000000000","message":"duplicated declaration\n\nyou can use ensure_resource function from stdlib.","commit_id":"8dbcbf9910c7ae359421da24e884010ad6f566f6"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"e5e3e04e0cb63f544b79f2ea76e4b31d7c194c8b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file { \u0027/etc/default/neutron-server\u0027:"},{"line_number":50,"context_line":"            ensure \u003d\u003e present,"},{"line_number":51,"context_line":"          }-\u003e"},{"line_number":52,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"dada55a8_67f040ff","line":49,"in_reply_to":"dada55a8_0c2b6a95","updated":"2016-07-20 12:15:44.000000000","message":"thanks for the help, done.","commit_id":"8dbcbf9910c7ae359421da24e884010ad6f566f6"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"ce459e001d17b4e8a019d3b8e94aa3db65438ca2","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":51,"context_line":"            line \u003d\u003e \u0027$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_3a1c92c0","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":33},"updated":"2016-07-20 14:48:25.000000000","message":"Isn\u0027t it better to use augeas here?\n\ncontext \u003d\u003e \u0027/files/etc/default/neutron-server\u0027,                         \nchanges \u003d\u003e set DAEMON_ARGS \\\u0027\"$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\"\\\u0027,","commit_id":"4a0e9a24ce17cffdd8c1059fba8c8772ede43d93"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"8120847970babf3ab251b43cd53fee961b9bef26","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":51,"context_line":"            line \u003d\u003e \u0027$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_c384450c","line":51,"range":{"start_line":51,"start_character":22,"end_line":51,"end_character":33},"in_reply_to":"dada55a8_3a1c92c0","updated":"2016-07-21 10:12:31.000000000","message":"Done","commit_id":"4a0e9a24ce17cffdd8c1059fba8c8772ede43d93"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"22475124be7ec200af72cbf8ec1a3de69ed7bf8f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":51,"context_line":"            line \u003d\u003e \u0027$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_ff12ec55","line":52,"updated":"2016-07-20 14:44:03.000000000","message":"this is not idempotent. At least you need add match parameter.","commit_id":"4a0e9a24ce17cffdd8c1059fba8c8772ede43d93"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"8120847970babf3ab251b43cd53fee961b9bef26","unresolved":false,"context_lines":[{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"},{"line_number":51,"context_line":"            line \u003d\u003e \u0027$DAEMON_ARGS --config-file /etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"dada55a8_23ce0163","line":52,"in_reply_to":"dada55a8_ff12ec55","updated":"2016-07-21 10:12:31.000000000","message":"I guess the default way file_line works is, if the line is missing it would add. so it should be in idempotent way.","commit_id":"4a0e9a24ce17cffdd8c1059fba8c8772ede43d93"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"baffd7c282cdaecfac09d03a543f165a33302fcf","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":56,"context_line":"      }"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"dada55a8_2c4ee0c0","line":57,"updated":"2016-07-21 14:38:18.000000000","message":"I am really not sure about this change, we already create a symlink in /etc/neutron/plugin.ini, not sure we need another symlink... It sounds like something to be fixed in packaging, isn\u0027t?","commit_id":"f0f1b87a4f1aba850f1e1f67c1d82a6ee73c119d"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"b85b82b20e412c98bb65e3b21077af16b4572b82","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":56,"context_line":"      }"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"},{"line_number":59,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"bacf61ea_216f802c","line":57,"in_reply_to":"dada55a8_2c4ee0c0","updated":"2016-07-29 06:52:18.000000000","message":"Changing the path on redhat, as that was wrong. Further we are discussing with package owners on your comment.","commit_id":"f0f1b87a4f1aba850f1e1f67c1d82a6ee73c119d"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"85507f1fc1c1f6fc76c4a54c5e4c9ec89b165677","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":30,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":31,"context_line":"  $sriov_agent_required \u003d true,"},{"line_number":32,"context_line":"){"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_2f32b410","line":31,"updated":"2016-07-29 15:51:32.000000000","message":"Is this required? AFAICT, this configuration option was removed in mitaka.","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"9613445a2292a591c6273ef047d8897a66d338a5","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"define neutron::plugins::ml2::mech_driver ("},{"line_number":30,"context_line":"  $supported_pci_vendor_devs,"},{"line_number":31,"context_line":"  $sriov_agent_required \u003d true,"},{"line_number":32,"context_line":"){"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  include ::neutron::deps"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_6325ab07","line":31,"in_reply_to":"bacf61ea_2f32b410","updated":"2016-08-01 09:12:52.000000000","message":"This is being removed with other\u0027s as deprecated in a separate patch https://review.openstack.org/#/c/330544/7/manifests/plugins/ml2/mech_driver.pp","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"85507f1fc1c1f6fc76c4a54c5e4c9ec89b165677","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.ini\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_4aec368f","line":43,"updated":"2016-07-29 15:51:32.000000000","message":"IIUC, oslo.config only picks up files with the extension .conf in paths specified with --config-dir. Feel free to double check, but I think this needs to be changed.","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"9613445a2292a591c6273ef047d8897a66d338a5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.ini\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_c31e17ba","line":43,"in_reply_to":"bacf61ea_4aec368f","updated":"2016-08-01 09:12:52.000000000","message":"Done","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"85507f1fc1c1f6fc76c4a54c5e4c9ec89b165677","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_fb569b28","line":47,"updated":"2016-07-29 15:51:32.000000000","message":"With respect to Emilien\u0027s earlier question on the symbolic link business: at the time, the patchset was flawed in that the file being referred to (ml2_conf.ini) was already being linked to in neutron::plugins::ml2. I don\u0027t think it was a general objection to creating additional links in the path specified in a service\u0027s --config-dir option.","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"9613445a2292a591c6273ef047d8897a66d338a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"},{"line_number":48,"context_line":"      /^(Debian|Ubuntu)$/: {"},{"line_number":49,"context_line":"          file_line { \u0027DAEMON_ARGS\u0027:"},{"line_number":50,"context_line":"            path \u003d\u003e \u0027/etc/default/neutron-server\u0027,"}],"source_content_type":"text/x-puppet","patch_set":14,"id":"bacf61ea_e37fdbdd","line":47,"in_reply_to":"bacf61ea_fb569b28","updated":"2016-08-01 09:12:52.000000000","message":"Done","commit_id":"c5042e7ecae92ab9141795df29e77b128f3f7d09"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ca98ce1aeb02ebb30d31bd85699f846c92b2de2b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":56,"context_line":"      }"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_f205df79","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":15},"updated":"2016-08-01 10:47:11.000000000","message":"i guess we need to fail here, as we have fails for all unsupported os","commit_id":"cc4a9e3446832b6272ddc506f640929a78214384"},{"author":{"_account_id":10034,"name":"Sanjay Upadhyay","email":"supadhya@redhat.com","username":"saneax"},"change_message_id":"2afb525c7337f1f03920d300e6bcdd831abe47af","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          }"},{"line_number":53,"context_line":"      }"},{"line_number":54,"context_line":"      default: {"},{"line_number":55,"context_line":"        warning (\"Warning: Scope(Class[neutron::plugins::ml2::mech_driver]): Unsupported osfamily ${::osfamily}\")"},{"line_number":56,"context_line":"      }"},{"line_number":57,"context_line":"    }"},{"line_number":58,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":15,"id":"bacf61ea_e6f6c28d","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":15},"in_reply_to":"bacf61ea_f205df79","updated":"2016-08-01 11:45:48.000000000","message":"Done","commit_id":"cc4a9e3446832b6272ddc506f640929a78214384"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6212459bc51d90f878c0fe3a13cbf540403bbdd5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_5b531c39","line":44,"updated":"2016-08-01 14:34:57.000000000","message":"Not sure using a link for one OS and updating the arguments for the other is a consistent configuration. I think it\u0027s better to use the same method for both systems. Personally I think it\u0027s also better in terms of being able to understand what configurations are being used via cmd line options","commit_id":"8f5993c020691d0446481fbff5f97ae3b88181c5"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"36113e246fb2a2d3d01ecf13d7dde265656f9fd5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_764ef5c1","line":44,"in_reply_to":"bacf61ea_5b531c39","updated":"2016-08-01 14:48:47.000000000","message":"Hmm.. I think it\u0027s a good point that the command line option --config-dir should probably be applied to the Debian case and the two can then be consistent. Using the command line option for each individual file is not the recommended way to go (for neutron at least) because of the very modular nature of the component. FWIW, we got very specific push back on the question of modifying the service when enabling/disabling features like SR-IOV. \n\nPersonally, I prefer leaving the service files alone because they are effectively packaged entities and if we can keep them as \"read only\" as possible it is just one less thing to worry about.","commit_id":"8f5993c020691d0446481fbff5f97ae3b88181c5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"4c4eea5a0317c1a9c959683acab513522b83a507","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_a752f264","line":44,"in_reply_to":"bacf61ea_764ef5c1","updated":"2016-08-01 17:33:41.000000000","message":"But /etc/default/neutron-server is the equivalent of /etc/sysconfig/neutron-server which is a configuration file. I don\u0027t believe you should touch the service file itself but it\u0027s a common practice to adjust these to enable the lookup of different services.  I agree that we shouldn\u0027t have to do this to enable this stuff and there really should just be a conf.d method for neutron but that\u0027s an upstream issue.  My personal preference until both of the distros have such a conf.d configuration is to just update /etc/{default,sysconfig}/neutron-server to add the lookup for the --config-file in puppet to make them consistent","commit_id":"8f5993c020691d0446481fbff5f97ae3b88181c5"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"1a3821fb081f1d7353effc02a8ed8783e7652a1a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"bacf61ea_e39a3b13","line":44,"in_reply_to":"bacf61ea_a752f264","updated":"2016-08-05 12:14:35.000000000","message":"IIUC, Redhat family does not have the config file  /etc/sysconfig/neutron-server.\n\nWith this discussion, I can see 2 options:\n(1) As in the current patch, fix it for RedHat and Debian separately. And raise this issue in debian upstream to create conf.d directory \n(2) Create link only for RedHat and raise upstream debian issue for conf.d, wait for it to be solved and then fix for debian\n\nI feel, for now option 1 is best, please feel free to suggest your opinion.","commit_id":"8f5993c020691d0446481fbff5f97ae3b88181c5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b2715e2f55b1aa94f7584bca77d50a9eca07f098","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"},{"line_number":45,"context_line":"          target \u003d\u003e \u0027/etc/neutron/plugins/ml2/ml2_conf_sriov.ini\u0027,"},{"line_number":46,"context_line":"        }"},{"line_number":47,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":16,"id":"9ad45d7e_9ec72d95","line":44,"in_reply_to":"bacf61ea_e39a3b13","updated":"2016-08-11 18:47:05.000000000","message":"You\u0027re right there is no /etc/sysconfig/neutron-server. There is an /etc/default/neutron-server but it doesn\u0027t appear to be used.  Sounds like this should get addressed in packaging at some point.","commit_id":"8f5993c020691d0446481fbff5f97ae3b88181c5"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"b803d653e1e37ecce45aaef6162e547ecc768628","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"9ad45d7e_adaed282","line":41,"updated":"2016-08-09 16:24:50.000000000","message":"could we have unit tests for this thing?","commit_id":"b993ccaa8cb78c7bf7b7db8eaf672f975a14aefd"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"3d9db11f923bda51b7c5909efba4a13058656d97","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027ml2_sriov/supported_pci_vendor_devs\u0027: value \u003d\u003e join(any2array($supported_pci_vendor_devs), \u0027,\u0027);"},{"line_number":39,"context_line":"      \u0027ml2_sriov/agent_required\u0027:            value \u003d\u003e $sriov_agent_required;"},{"line_number":40,"context_line":"    }"},{"line_number":41,"context_line":"    case $::osfamily {"},{"line_number":42,"context_line":"      \u0027RedHat\u0027: {"},{"line_number":43,"context_line":"        file { \u0027/etc/neutron/conf.d/neutron-server/ml2_conf_sriov.conf\u0027:"},{"line_number":44,"context_line":"          ensure \u003d\u003e link,"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"9ad45d7e_b78b98c2","line":41,"in_reply_to":"9ad45d7e_adaed282","updated":"2016-08-10 09:49:57.000000000","message":"Done","commit_id":"b993ccaa8cb78c7bf7b7db8eaf672f975a14aefd"}],"spec/defines/neutron_plugins_ml2_mechdriver_spec.rb":[{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"50f2e9559b34ae189f88c96a52203bd0a8669341","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"  let :params do {"},{"line_number":10,"context_line":"    :name \u003d\u003e \u0027sriovnicswitch\u0027,"},{"line_number":11,"context_line":"    :supported_pci_vendor_devs \u003d\u003e \u00278086:10ed\u0027,"},{"line_number":12,"context_line":"  }"},{"line_number":13,"context_line":"  end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":19,"id":"9ad45d7e_1d6563b4","line":11,"updated":"2016-08-10 10:15:16.000000000","message":"I did not add testcase for \u0027sriov_agent_required\u0027 since it is deprecated in neutron and will be deprecated from puppet-neutron as well (https://review.openstack.org/#/c/330544/)","commit_id":"6b00f0eb1961a13d9670c511f73b1001da466e0a"}]}
