)]}'
{"manifests/plugins/ml2/ovn.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"173fe811a765d8d6cd4ed580f416b00cabeae817","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  ) {"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  include ::neutron::deps"},{"line_number":51,"context_line":"  class {\u0027::neutron::plugins::ml2\u0027:"},{"line_number":52,"context_line":"    mechanism_drivers \u003d\u003e [\u0027ovn\u0027]"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"  if ! is_service_default($ovn_l3_mode) {"},{"line_number":56,"context_line":"    validate_bool($ovn_l3_mode)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1aa78d24_885abd81","line":53,"range":{"start_line":51,"start_character":0,"end_line":53,"end_character":3},"updated":"2016-07-11 14:19:59.000000000","message":"I think mechanism drivers should be managed on higher orchestration level","commit_id":"fc9b38b5ca37aee4226490b10f53cd91e870d9cb"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"52d1d7864dcd47aecff34b85a5de18abb9b704f5","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#   (required) The connection string for the native OVSDB backend."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_347e5d19","line":5,"updated":"2016-07-20 18:00:58.000000000","message":"This is deprecated in favor of ovn_nb_connection and ovn_sb_connection.","commit_id":"57c3ab2f605ed15727d407d75667a9c8b40bc73f"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"0c2de05ec5221b52aab2c92944d7902713ee8a9e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# [*ovsdb_connection*]"},{"line_number":6,"context_line":"#   (required) The connection string for the native OVSDB backend."},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# [*package_ensure*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_f605d779","line":5,"in_reply_to":"dada55a8_347e5d19","updated":"2016-07-21 05:05:29.000000000","message":"Thanks for pointing it out. I will make this change","commit_id":"57c3ab2f605ed15727d407d75667a9c8b40bc73f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"52d1d7864dcd47aecff34b85a5de18abb9b704f5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  neutron_plugin_ml2 {"},{"line_number":73,"context_line":"    \u0027ml2_ovn/ovsdb_connection\u0027         : value \u003d\u003e $ovsdb_connection;"},{"line_number":74,"context_line":"    \u0027ml2_ovn/ovsdb_connection_timeout\u0027 : value \u003d\u003e $ovsdb_connection_timeout;"},{"line_number":75,"context_line":"    \u0027ml2_ovn/neutron_sync_mode\u0027        : value \u003d\u003e $neutron_sync_mode;"},{"line_number":76,"context_line":"    \u0027ml2_ovn/ovn_l3_mode\u0027              : value \u003d\u003e $ovn_l3_mode;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_94e3c9d8","line":73,"range":{"start_line":73,"start_character":5,"end_line":73,"end_character":12},"updated":"2016-07-20 18:00:58.000000000","message":"The section is \"ovn\" in the ML2 configuration file.","commit_id":"57c3ab2f605ed15727d407d75667a9c8b40bc73f"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"0c2de05ec5221b52aab2c92944d7902713ee8a9e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"  )"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"  neutron_plugin_ml2 {"},{"line_number":73,"context_line":"    \u0027ml2_ovn/ovsdb_connection\u0027         : value \u003d\u003e $ovsdb_connection;"},{"line_number":74,"context_line":"    \u0027ml2_ovn/ovsdb_connection_timeout\u0027 : value \u003d\u003e $ovsdb_connection_timeout;"},{"line_number":75,"context_line":"    \u0027ml2_ovn/neutron_sync_mode\u0027        : value \u003d\u003e $neutron_sync_mode;"},{"line_number":76,"context_line":"    \u0027ml2_ovn/ovn_l3_mode\u0027              : value \u003d\u003e $ovn_l3_mode;"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"dada55a8_56c94358","line":73,"range":{"start_line":73,"start_character":5,"end_line":73,"end_character":12},"in_reply_to":"dada55a8_94e3c9d8","updated":"2016-07-21 05:05:29.000000000","message":"Hi Richard, ml2_ovn will interpreted by the neutron_plugin_ml2 provider, such that ml2_ovn/variable will put the variable in [ovn] section in ml2 config file.","commit_id":"57c3ab2f605ed15727d407d75667a9c8b40bc73f"}],"manifests/plugins/ovn.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"593ca37b589ef0950932abb9d5d8a92777ff7bd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# This class installs and configures the OVN Neutron plugin"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# \u003d\u003d\u003d Parameters"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_958c23db","side":"PARENT","line":1,"updated":"2016-07-21 19:53:43.000000000","message":"Instead of removing the whole class, you should deprecate it first, with a nice warning explaining the change and also a release note.","commit_id":"d591774c5409d59f3b4d9dd1989225585fe27392"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"879da9ae896b950f591434f9b34f7b781c15cf90","unresolved":false,"context_lines":[{"line_number":47,"context_line":"  include ::neutron::params"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"  warning(\u0027neutron::plugins::ovn is deprecated in favor of neutron::plugins::ml2::ovn\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"  if ! is_service_default($ovn_l3_mode) {"},{"line_number":52,"context_line":"    validate_bool($ovn_l3_mode)"},{"line_number":53,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_c3c0772d","line":50,"updated":"2016-07-22 14:33:22.000000000","message":"the warning is good, but you could also remove all the code bellow and declare the new class, so people will have the new plugin automatically !\n\nclass { ::neutron::plugins::ml2::ovn\u0027: ... } using the same params","commit_id":"ba27b214d4cf0f91b6af2f24d4249f64ac23687f"}],"releasenotes/notes/ovn_ml2_upgrade-9bc64f0da70ca670.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"593ca37b589ef0950932abb9d5d8a92777ff7bd2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - OVN is now an ml2 mechanism driver."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_75aecf2e","line":3,"updated":"2016-07-21 19:53:43.000000000","message":"can we have more details? Our users are reading it, please explain what is changing and what to do.","commit_id":"954393d32a0ad91fc32ab969c317a0f8d7325f0f"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"879da9ae896b950f591434f9b34f7b781c15cf90","unresolved":false,"context_lines":[{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - neutron::plugins::ovn is deprecated as it was managing OVN as a "},{"line_number":9,"context_line":"    core-plugin. This is deprecated in favor of its ml2 equivalent"},{"line_number":10,"context_line":"    neutron::plugins::ml2::ovn"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"dada55a8_e3c3fb36","line":10,"updated":"2016-07-22 14:33:22.000000000","message":"good.","commit_id":"ba27b214d4cf0f91b6af2f24d4249f64ac23687f"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"78ca1f85246be4a3e03da21dd814565ec0ea0b4d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    neutron as an ml2 mechanism driver."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"deprecations:"},{"line_number":8,"context_line":"  - neutron::plugins::ovn is deprecated as it was managing OVN as a "},{"line_number":9,"context_line":"    core-plugin. This is deprecated in favor of its ml2 equivalent"},{"line_number":10,"context_line":"    neutron::plugins::ml2::ovn"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"dada55a8_02219cb4","line":8,"range":{"start_line":8,"start_character":67,"end_line":8,"end_character":68},"updated":"2016-07-25 16:28:09.000000000","message":"whitespace","commit_id":"8b8ed37b543c7fe1f3d1508751052b9e0c7d27e1"}]}
